App\Jobs\ParseVocabulary

Complexity

Total Complexity

2

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	handle()	0	17	1

<?php

namespace App\Jobs;

use App\Events\ImportParseFinished;
use App\Models\Import;
use App\Services\Import\DataImporter;
use App\Services\Import\GoogleSpreadsheet;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use const EXTR_OVERWRITE;
use function collect;
use function extract;

class ParseVocabulary implements ShouldQueue
{
    use InteractsWithQueue, Queueable, SerializesModels, Dispatchable;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by App\Jobs\ParseVocabulary: $id, $class

    /**
     * @var Import
     */
    private $import;
    /**
     * @var string
     */
    private $worksheet_id;
    /**
     * @var array
     */
    private $spreadsheet;

    public function __construct(Import $import, string $worksheet_id, array $spreadsheet)
    {
        $this->import       = $import;
        $this->worksheet_id = $worksheet_id;
        $this->spreadsheet  = $spreadsheet;
    }

    /**
     * Execute the job.
     */
    public function handle()
    {
        $source_file_name = '';
        $import_type      = 0;

The assignment to $import_type is dead and can be removed.

        extract($this->spreadsheet, EXTR_OVERWRITE);
        $sheet    = new GoogleSpreadsheet($source_file_name);
        $data     = collect($sheet->getWorksheetData($this->worksheet_id)->toArray());
        //TODO: Handle $import_type in the importer
        $importer = new DataImporter($data, $this->import->export);
        //then we pass them to the importer
        $changeSet                  = $importer->getChangeset();
        $this->import->instructions = $changeSet;

It seems like $changeSet of type Illuminate\Support\Collection is incompatible with the declared type array of property $instructions.

        $this->import->preprocess   = $importer->getStats();

It seems like $importer->getStats() of type Illuminate\Support\Collection is incompatible with the declared type array of property $preprocess.

        $this->import->errors       = $importer->getErrors()->toJson();
        $this->import->save();

        event(new ImportParseFinished($this->import));
    }
}