ViewportSize - Code Metrics - Inspection of "Broken commit" - jonnnnyw/php-phantomjs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 5.0 ( c6890e...9916e2 )

by Jonny

created 2017-04-22 20:52 UTC

ViewportSize A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	0
dl	0
loc	41
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	jsonSerialize()	0	7	1

<?php

/*
 * This file is part of the php-phantomjs.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace JonnyW\PhantomJs\Page;

/**
 * PHP PhantomJs.
 *
 * @author Jon Wenmoth <[email protected]>
 */
class ViewportSize implements \JsonSerializable
{
    /**
     * Width.
     *
     * @var int
     */
    private $width;

    /**
     * Height.
     *
     * @var int
     */
    private $height;

    /**
     * Internal constructor.
     *
     * @param int $width
     * @param int $height
     */
    public function __construct($width, $height)
    {
        $this->width = (int) $width;
        $this->height = (int) $height;
    }

    /**
     * Format data for JSON serialization.
     *
     * @return array
     */
    public function jsonSerialize()
    {
        return array(
            'top' => $this->top,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'left' => $this->left,
class MyClass { }

$x = new MyClass();
$x->foo = true;
        );
    }
}


1			<?php
2
3			/*
4			* This file is part of the php-phantomjs.
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace JonnyW\PhantomJs\Page;
11
12			/**
13			* PHP PhantomJs.
14			*
15			* @author Jon Wenmoth <[email protected]>
16			*/
17			class ViewportSize implements \JsonSerializable
18			{
19			/**
20			* Width.
21			*
22			* @var int
23			*/
24			private $width;
25
26			/**
27			* Height.
28			*
29			* @var int
30			*/
31			private $height;
32
33			/**
34			* Internal constructor.
35			*
36			* @param int $width
37			* @param int $height
38			*/
39			public function __construct($width, $height)
40			{
41			$this->width = (int) $width;
42			$this->height = (int) $height;
43			}
44
45			/**
46			* Format data for JSON serialization.
47			*
48			* @return array
49			*/
50			public function jsonSerialize()
51			{
52			return array(
53			'top' => $this->top,
			0 ignored issues – show Bug introduced 2017-04-22 21:16 UTC by Report Bug Copy Issue Report The property `top` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
54			'left' => $this->left,
			0 ignored issues – show Bug introduced 2017-04-22 21:16 UTC by Report Bug Copy Issue Report The property `left` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
55			);
56			}
57			}
58

jonnnnyw / php-phantomjs

GitHub Access Token became invalid

Push — 5.0 ( c6890e...9916e2 )

ViewportSize A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like