Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class ParameterMapper |
||
| 16 | { |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var Request |
||
| 20 | */ |
||
| 21 | private $request; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var ViewModel |
||
| 25 | */ |
||
| 26 | private $viewModel; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var Map |
||
| 30 | */ |
||
| 31 | private $routerMap; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var ParameterMap |
||
| 35 | */ |
||
| 36 | private $parameterMap; |
||
| 37 | |||
| 38 | |||
| 39 | public function setRequest(Request $request) |
||
| 43 | |||
| 44 | public function setViewModel(ViewModel $viewModel) |
||
| 48 | |||
| 49 | public function setRouterMap(Map $routerMap) |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @return ParameterMap |
||
| 56 | */ |
||
| 57 | public function getParameterMap() |
||
| 71 | |||
| 72 | private function bindRequest() |
||
| 76 | |||
| 77 | View Code Duplication | private function bindPatternedUrl() |
|
| 84 | |||
| 85 | private function bindNamedUrl() |
||
| 94 | |||
| 95 | View Code Duplication | private function bindProc() |
|
| 102 | |||
| 103 | private function bindViewModel() |
||
| 107 | |||
| 108 | |||
| 109 | private function resolveUrl() |
||
| 114 | } |
||
| 115 |
This check marks calls to methods that do not seem to exist on an object.
This is most likely the result of a method being renamed without all references to it being renamed likewise.