create_column_items() - Code Metrics - Inspection of "New Website 2017" - jonge-democraten/website - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#155)

unknown

created 2017-08-24 09:34 UTC

create_column_items() B

↳ Parent: get_page_header()

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
dl	0
loc	15
rs	8.5454
c	0
b	0
f	0

import logging
logger = logging.getLogger(__name__)

from website.jdpages.models import HomePage
from website.jdpages.models import PageHeaderImage


def get_page_header(page):
    """
    :returns: the page header for a given page.
    Uses parent page image when none is defined.
    Top parent is the HomePage.
    None when there is no Hompage or when the HomePage has no header.
    """

    # Get a random page header, or the first one if there is only one
    image = PageHeaderImage.objects.filter(page=page).order_by('?').first()
    if image is not None:
        return image

    # No image found! If we received an integer, then do not search further
    if isinstance(page, int):
        return None

    # Try from parent
    if page.parent:
        return get_page_header(page.parent)

    # Try from first homepage
    homepage = HomePage.objects.values_list('id').first()
    if len(homepage) != 0:
        # Since we give get_page_header an integer, there is no infinite recursion here...
        return get_page_header(homepage[0])

    return None


def get_homepage_header():
    """ Returns the page header image of the homepage """
    homepage = HomePage.objects.values_list('id').first()
    if not homepage:
        return None
    return get_page_header(homepage[0])


1			import logging
2			logger = logging.getLogger(__name__)
3
4			from website.jdpages.models import HomePage
5			from website.jdpages.models import PageHeaderImage
6
7
8			def get_page_header(page):
9			"""
10			:returns: the page header for a given page.
11			Uses parent page image when none is defined.
12			Top parent is the HomePage.
13			None when there is no Hompage or when the HomePage has no header.
14			"""
15
16			# Get a random page header, or the first one if there is only one
17			image = PageHeaderImage.objects.filter(page=page).order_by('?').first()
18			if image is not None:
19			return image
20
21			# No image found! If we received an integer, then do not search further
22			if isinstance(page, int):
23			return None
24
25			# Try from parent
26			if page.parent:
27			return get_page_header(page.parent)
28
29			# Try from first homepage
30			homepage = HomePage.objects.values_list('id').first()
31			if len(homepage) != 0:
32			# Since we give get_page_header an integer, there is no infinite recursion here...
33			return get_page_header(homepage[0])
34
35			return None
36
37
38			def get_homepage_header():
39			""" Returns the page header image of the homepage """
40			homepage = HomePage.objects.values_list('id').first()
41			if not homepage:
42			return None
43			return get_page_header(homepage[0])
44

jonge-democraten / website

Pull Request — master (#155)

create_column_items() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like