Completed
Push — feature/code-analysis ( 110b5c...ddc57d )
by Jonathan
03:27
created
src/Webtrees/Module/Sosa/Schema/Migration0.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@
 block discarded – undo
22 22
 	public function upgrade() {
23 23
 
24 24
 		Database::exec(
25
-		    'CREATE TABLE IF NOT EXISTS `##maj_sosa` (' .
26
-	        ' majs_gedcom_id      INTEGER 	        NOT NULL,' .
27
-		    ' majs_user_id        INTEGER           NOT NULL DEFAULT -1,' . 
28
-		    ' majs_sosa           BIGINT UNSIGNED 	NOT NULL,' . // Allow to calculate sosa on 64 generations
29
-            ' majs_i_id           VARCHAR(20)	    NOT NULL,' .	
30
-            ' majs_gen            TINYINT			NULL,' .
31
-            ' majs_birth_year	  SMALLINT			NULL,' .
32
-            ' majs_death_year	  SMALLINT			NULL,' .
33
-            ' PRIMARY KEY (majs_gedcom_id, majs_user_id, majs_sosa),' .
34
-		    ' FOREIGN KEY `##gedcom_id_fk1` (majs_gedcom_id) REFERENCES `##gedcom` (gedcom_id) ON DELETE CASCADE,' .
35
-		    ' FOREIGN KEY `##user_id_fk1` (majs_user_id) REFERENCES `##user` (user_id) ON DELETE CASCADE' .			
25
+		    'CREATE TABLE IF NOT EXISTS `##maj_sosa` ('.
26
+	        ' majs_gedcom_id      INTEGER 	        NOT NULL,'.
27
+		    ' majs_user_id        INTEGER           NOT NULL DEFAULT -1,'. 
28
+		    ' majs_sosa           BIGINT UNSIGNED 	NOT NULL,'.// Allow to calculate sosa on 64 generations
29
+            ' majs_i_id           VARCHAR(20)	    NOT NULL,'.	
30
+            ' majs_gen            TINYINT			NULL,'.
31
+            ' majs_birth_year	  SMALLINT			NULL,'.
32
+            ' majs_death_year	  SMALLINT			NULL,'.
33
+            ' PRIMARY KEY (majs_gedcom_id, majs_user_id, majs_sosa),'.
34
+		    ' FOREIGN KEY `##gedcom_id_fk1` (majs_gedcom_id) REFERENCES `##gedcom` (gedcom_id) ON DELETE CASCADE,'.
35
+		    ' FOREIGN KEY `##user_id_fk1` (majs_user_id) REFERENCES `##user` (user_id) ON DELETE CASCADE'.			
36 36
 		    ') COLLATE utf8_unicode_ci ENGINE=InnoDB'
37 37
 		);
38 38
 	}
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListView.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
         <div id="maj-sosa-list-page" class="center">
29 29
 			<h2><?php echo $this->data->get('title'); ?></h2>
30 30
 			
31
-			<?php  if($this->data->get('is_setup')) { 
31
+			<?php  if ($this->data->get('is_setup')) { 
32 32
 			    $selectedgen = $this->data->get('generation');
33 33
 			    $this->renderSosaHeader();
34
-			    if($this->data->get('has_sosa') ) {
35
-			         if($selectedgen > 0) {
34
+			    if ($this->data->get('has_sosa')) {
35
+			         if ($selectedgen > 0) {
36 36
 			        ?>
37 37
 			<div id="sosalist-tabs">
38 38
 				<ul>
@@ -75,9 +75,9 @@  discard block
 block discarded – undo
75 75
         ?>
76 76
         
77 77
     	<form method="get" name="setgen" action="module.php">
78
-			<input type="hidden" name="mod" value="<?php echo $this->data->get('url_module');?>">
79
-			<input type="hidden" name="mod_action" value="<?php echo $this->data->get('url_action');?>">
80
-			<input type="hidden" name="ged" value="<?php echo $this->data->get('url_ged');?>">
78
+			<input type="hidden" name="mod" value="<?php echo $this->data->get('url_module'); ?>">
79
+			<input type="hidden" name="mod_action" value="<?php echo $this->data->get('url_action'); ?>">
80
+			<input type="hidden" name="ged" value="<?php echo $this->data->get('url_ged'); ?>">
81 81
 			<div class="maj-table">
82 82
 				<div class="maj-row">
83 83
 					<div class="label"><?php echo I18N::translate('Choose generation') ?></div>
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 				<div class="maj-row">
86 86
 					<div class="value">
87 87
 						<select name="gen">							
88
-						<?php for($i=$this->data->get('min_gen'); $i <= $max_gen;$i++) {?>
88
+						<?php for ($i = $this->data->get('min_gen'); $i <= $max_gen; $i++) {?>
89 89
 							<option value="<?php echo $i; ?>"
90
-							<?php if($selectedgen && $selectedgen==$i) { ?> selected="true" <?php } ?>
90
+							<?php if ($selectedgen && $selectedgen == $i) { ?> selected="true" <?php } ?>
91 91
                 			><?php echo I18N::translate('Generation %d', $i); ?>
92 92
                 			</option>
93 93
                 		<?php } ?>
@@ -95,21 +95,21 @@  discard block
 block discarded – undo
95 95
                 	</div>
96 96
                 </div>
97 97
       		</div>
98
-      		<input type="submit" value="<?php echo I18N::translate('Show');?>" />
98
+      		<input type="submit" value="<?php echo I18N::translate('Show'); ?>" />
99 99
       		<br />
100 100
       	</form>
101
-      	<?php if($selectedgen > 0) { ?>
101
+      	<?php if ($selectedgen > 0) { ?>
102 102
 		<h4>
103
-			<?php if($selectedgen > $this->data->get('min_gen')) { ?>
104
-			<a href="module.php?mod=<?php echo $this->data->get('url_module');?>&mod_action=<?php echo $this->data->get('url_action');?>&ged=<?php echo $this->data->get('url_ged');?>&gen=<?php echo $selectedgen-1; ?>">
103
+			<?php if ($selectedgen > $this->data->get('min_gen')) { ?>
104
+			<a href="module.php?mod=<?php echo $this->data->get('url_module'); ?>&mod_action=<?php echo $this->data->get('url_action'); ?>&ged=<?php echo $this->data->get('url_ged'); ?>&gen=<?php echo $selectedgen - 1; ?>">
105 105
 				<i class="icon-ldarrow" title="<?php echo I18N::translate('Previous generation'); ?>" ></i>
106 106
 			</a>
107 107
 			&nbsp;&nbsp;
108 108
 			<?php } ?>
109 109
 			<?php echo I18N::translate('Generation %d', $selectedgen); ?>
110
-			<?php if($selectedgen < $max_gen) { ?>
110
+			<?php if ($selectedgen < $max_gen) { ?>
111 111
 			&nbsp;&nbsp;
112
-			<a href="module.php?mod=<?php echo $this->data->get('url_module');?>&mod_action=<?php echo $this->data->get('url_action');?>&ged=<?php echo $this->data->get('url_ged');?>&gen=<?php echo $selectedgen+1; ?>">
112
+			<a href="module.php?mod=<?php echo $this->data->get('url_module'); ?>&mod_action=<?php echo $this->data->get('url_action'); ?>&ged=<?php echo $this->data->get('url_ged'); ?>&gen=<?php echo $selectedgen + 1; ?>">
113 113
 				<i class="icon-rdarrow" title="<?php echo I18N::translate('Next generation'); ?>" ></i>
114 114
 			</a>
115 115
 			<?php } ?>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaConfigView.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,13 +48,13 @@
 block discarded – undo
48 48
         			<div class="value">
49 49
         				<?php 
50 50
         				    $users = $this->data->get('users_settings');
51
-        				    if(count($users) == 1) {
51
+        				    if (count($users) == 1) {
52 52
         				?>
53 53
         					<label>
54 54
         						<input id="maj_sosa_input_userid" type="hidden" name="userid" value="<?php echo $users[0]['user']->getUserId(); ?>" />
55 55
         						<?php echo $users[0]['user']->getRealNameHtml() ?>
56 56
         					</label>
57
-        				<?php  } else if(count($users) > 1) { ?>
57
+        				<?php  } else if (count($users) > 1) { ?>
58 58
         					<select id='maj-sosa-config-select' name="userid">
59 59
         					<?php 
60 60
         					$root_indi = $users[0]['rootid'];
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListIndiView.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -33,12 +33,12 @@  discard block
 block discarded – undo
33 33
 	 */
34 34
     protected function renderContent() { 
35 35
         
36
-        if($this->data->get('has_sosa', false)) {
36
+        if ($this->data->get('has_sosa', false)) {
37 37
             $table_id = $this->data->get('table_id');            
38 38
         ?>   
39 39
         
40 40
         <div id="sosa-indi-list" class="sosa-list">
41
-        	<table id="<?php echo $table_id;?>">
41
+        	<table id="<?php echo $table_id; ?>">
42 42
 				<thead>
43 43
     				<tr>
44 44
     					<th colspan="22">
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 				</thead>
186 186
 			<tbody>
187 187
 			
188
-			<?php foreach($this->data->get('sosa_list') as $sosa => $person) {
188
+			<?php foreach ($this->data->get('sosa_list') as $sosa => $person) {
189 189
 			    /** @var \Fisharebest\Webtrees\Individual $person */
190 190
 			    if ($person->isPendingAddtion()) {
191 191
 			        $class = ' class="new"';
@@ -201,18 +201,18 @@  discard block
 block discarded – undo
201 201
         			<td class="transparent"><?php echo $person->getXref(); ?></td>
202 202
         			<td colspan="2">
203 203
         			<?php foreach ($person->getAllNames() as $num=>$name) {
204
-        				if ($name['type']=='NAME') {
205
-        					$title='';
204
+        				if ($name['type'] == 'NAME') {
205
+        					$title = '';
206 206
         				} else {
207
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
207
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
208 208
         				}
209
-        				if ($num==$person->getPrimaryName()) {
210
-        					$class=' class="name2"';
211
-        					$sex_image=$person->getSexImage();
212
-        					list($surn, $givn)=explode(',', $name['sort']);
209
+        				if ($num == $person->getPrimaryName()) {
210
+        					$class = ' class="name2"';
211
+        					$sex_image = $person->getSexImage();
212
+        					list($surn, $givn) = explode(',', $name['sort']);
213 213
         				} else {
214
-        					$class='';
215
-        					$sex_image='';
214
+        					$class = '';
215
+        					$sex_image = '';
216 216
         				} ?>
217 217
         				<a <?php echo $title.' '.$class; ?> href="<?php echo $person->getHtmlUrl(); ?>">
218 218
         					<?php echo \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']); ?>
@@ -225,20 +225,20 @@  discard block
 block discarded – undo
225 225
             		</td>
226 226
             		<td style="display:none;"></td>
227 227
             		<td>
228
-            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)) . 'AAAA' . Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
228
+            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)).'AAAA'.Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
229 229
             		</td>
230 230
             		<td>
231
-            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)) . 'AAAA' . Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
231
+            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)).'AAAA'.Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
232 232
             		</td>
233 233
             		<td>
234 234
             		<?php 
235
-            		if ($birth_dates=$person->getAllBirthDates()) {
235
+            		if ($birth_dates = $person->getAllBirthDates()) {
236 236
 			            foreach ($birth_dates as $num=>$birth_date) {
237 237
     					   if ($num) { ?><br/><?php } ?>
238 238
     						<?php  echo $birth_date->display(true);
239 239
 			            }
240 240
             		} else {
241
-            		    $birth_date=$person->getEstimatedBirthDate();
241
+            		    $birth_date = $person->getEstimatedBirthDate();
242 242
             		    if ($person->getTree()->getPreference('SHOW_EST_LIST_DATES')) {
243 243
             		        $birth_date->display(true);
244 244
             		    } else {
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
             		}
249 249
             		?>
250 250
             		</td>
251
-            		<td><?php echo $birth_date->julianDay();?></td>
251
+            		<td><?php echo $birth_date->julianDay(); ?></td>
252 252
         			<td>
253 253
         			<?php foreach ($person->getAllBirthPlaces() as $n => $birth_place) {
254 254
 				        $tmp = new \Fisharebest\Webtrees\Place($birth_place, $person->getTree());
@@ -343,10 +343,10 @@  discard block
 block discarded – undo
343 343
 							<?php echo I18N::translate('Number of Sosa ancestors: %1$s known / %2$s theoretical (%3$s)',
344 344
 							    I18N::number($this->data->get('sosa_count')),
345 345
 							    I18N::number($this->data->get('sosa_theo')), 
346
-							    I18N::percentage($this->data->get('sosa_ratio'),2)
346
+							    I18N::percentage($this->data->get('sosa_ratio'), 2)
347 347
 							    ); ?>
348
-							<?php if($this->data->get('sosa_hidden') > 0) {
349
-							    echo '['. I18N::translate('%s hidden', I18N::number($this->data->get('sosa_hidden'))).']';
348
+							<?php if ($this->data->get('sosa_hidden') > 0) {
349
+							    echo '['.I18N::translate('%s hidden', I18N::number($this->data->get('sosa_hidden'))).']';
350 350
 							} ?>
351 351
 						</div>
352 352
 					</th>
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 								<button type="button" class="ui-state-default btn-toggle-parents">
359 359
 									<?php echo I18N::translate('Show parents') ?>
360 360
 								</button>
361
-								<button id="btn-toggle-statistics-<?php echo $table_id ;?>" type="button" class="ui-state-default btn-toggle-statistics">
361
+								<button id="btn-toggle-statistics-<?php echo $table_id; ?>" type="button" class="ui-state-default btn-toggle-statistics">
362 362
 									<?php echo I18N::translate('Show statistics charts') ?>
363 363
 								</button>
364 364
 							</div>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaStatsView.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         <div id="maj-sosa-stats-page">
29 29
 			<h2><?php echo $this->data->get('title'); ?></h2>
30 30
 			
31
-			<?php  if($this->data->get('is_setup')) {  
31
+			<?php  if ($this->data->get('is_setup')) {  
32 32
 			    $general_stats = $this->data->get('general_stats'); ?>
33 33
 			<h3><?php echo I18N::translate('General statistics'); ?></h3>
34 34
 			<div class="maj-table">
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 				</div>
51 51
 				<div class="maj-row">
52 52
 					<div class="label"><?php echo I18N::translate('Mean generation time'); ?></div>
53
-					<div class="value"><?php echo I18N::plural('%s year', '%s years', $general_stats['mean_gen_time'],  I18N::number($general_stats['mean_gen_time'], 1)); ?></div>
53
+					<div class="value"><?php echo I18N::plural('%s year', '%s years', $general_stats['mean_gen_time'], I18N::number($general_stats['mean_gen_time'], 1)); ?></div>
54 54
 				</div>
55 55
 			</div>
56 56
 			
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 					</tr>
91 91
 				</thead>
92 92
 				<tbody>
93
-					<?php foreach($this->data->get('generation_stats') as $gen => $row) { ?>
93
+					<?php foreach ($this->data->get('generation_stats') as $gen => $row) { ?>
94 94
 					<tr class="maj-row">
95 95
 						<td class="label"><?php echo I18N::translate('<strong>G%d</strong>', $gen); ?></td>
96 96
 						<td class="label"><?php echo I18N::translate('%1$s <> %2$s', $row['gen_min_birth'], $row['gen_max_birth']); ?></td>
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 						<td class="value"><?php echo I18N::number($row['different']); ?></td>
105 105
 						<td class="value left percent_container">
106 106
 							<div class="percent_frame">
107
-								<div class="percent_cell" style="width:<?php echo 100*$row['perc_different'] ?>%;">
107
+								<div class="percent_cell" style="width:<?php echo 100 * $row['perc_different'] ?>%;">
108 108
 									&nbsp;<?php echo I18N::percentage($row['perc_different']); ?>&nbsp;
109 109
 								</div>
110 110
 							</div>
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 				<tfoot>
118 118
 					<tr class="maj-row">
119 119
 						<td class="label" colspan="13">
120
-							<?php echo I18N::translate('Generation-equivalent: %s generations', I18N::number($this->data->get('equivalent_gen'),2)); ?>
120
+							<?php echo I18N::translate('Generation-equivalent: %s generations', I18N::number($this->data->get('equivalent_gen'), 2)); ?>
121 121
 						</td>
122 122
 					</tr>
123 123
 				</tfoot>
@@ -126,8 +126,8 @@  discard block
 block discarded – undo
126 126
 			
127 127
 			<h3><?php echo I18N::translate('Known Sosa ancestors\' family dispersion'); ?></h3>
128 128
 			<div class="center">
129
-				<?php echo $this->data->get('chart_img_g2') ?: '' ; ?>
130
-				<?php echo $this->data->get('chart_img_g3') ?: '' ; ?>				
129
+				<?php echo $this->data->get('chart_img_g2') ?: ''; ?>
130
+				<?php echo $this->data->get('chart_img_g3') ?: ''; ?>				
131 131
 				<!--  <canvas id="chart_ancestors_g2" width="300" height="300"></canvas>  -->
132 132
 			</div>
133 133
 			
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListFamView.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 */
35 35
     protected function renderContent() { 
36 36
         
37
-        if($this->data->get('has_sosa', false)) {
37
+        if ($this->data->get('has_sosa', false)) {
38 38
             $table_id = $this->data->get('table_id');            
39 39
         ?>   
40 40
         
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 										class="ui-state-default"
53 53
 										title="<?php echo I18N::translate('Show individuals who are alive or couples where both partners are alive.'); ?>"
54 54
 									>
55
-									<?php echo I18N::translate('Both alive');?>
55
+									<?php echo I18N::translate('Both alive'); ?>
56 56
 									</button>
57 57
 									<button
58 58
 										type="button"
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 										class="ui-state-default"
62 62
 										title="<?php echo I18N::translate('Show couples where only the female partner is deceased.'); ?>"
63 63
 									>
64
-									<?php echo I18N::translate('Widower');?>
64
+									<?php echo I18N::translate('Widower'); ?>
65 65
 									</button>
66 66
 									<button
67 67
 										type="button"
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 				</thead>
187 187
 				<tbody>
188 188
 			
189
-			<?php foreach($this->data->get('sosa_list') as $sosa => $family) {
189
+			<?php foreach ($this->data->get('sosa_list') as $sosa => $family) {
190 190
 			    /** @var \Fisharebest\Webtrees\Family $person */
191 191
 
192 192
 			    //PERSO Create decorator for Family
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 			    }
204 204
 			    $dwife = new \MyArtJaub\Webtrees\Individual($wife);
205 205
 			    
206
-			    $mdate=$family->getMarriageDate();
206
+			    $mdate = $family->getMarriageDate();
207 207
 			    
208 208
 			    if ($family->isPendingAddtion()) {
209 209
 			        $class = ' class="new"';
@@ -219,18 +219,18 @@  discard block
 block discarded – undo
219 219
         			<!--  HUSBAND -->
220 220
         			<td colspan="2">
221 221
         			<?php foreach ($husb->getAllNames() as $num=>$name) {
222
-        				if ($name['type']=='NAME') {
223
-        					$title='';
222
+        				if ($name['type'] == 'NAME') {
223
+        					$title = '';
224 224
         				} else {
225
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $husb)).'"';
225
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $husb)).'"';
226 226
         				}
227
-        				if ($num==$husb->getPrimaryName()) {
228
-        					$class=' class="name2"';
229
-        					$sex_image=$husb->getSexImage();
230
-        					list($surn, $givn)=explode(',', $name['sort']);
227
+        				if ($num == $husb->getPrimaryName()) {
228
+        					$class = ' class="name2"';
229
+        					$sex_image = $husb->getSexImage();
230
+        					list($surn, $givn) = explode(',', $name['sort']);
231 231
         				} else {
232
-        					$class='';
233
-        					$sex_image='';
232
+        					$class = '';
233
+        					$sex_image = '';
234 234
         				} ?>
235 235
         				<a <?php echo $title.' '.$class; ?> href="<?php echo $husb->getHtmlUrl(); ?>">
236 236
         					<?php echo \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']); ?>
@@ -244,29 +244,29 @@  discard block
 block discarded – undo
244 244
             		<!-- Dummy column to match colspan in header -->
245 245
             		<td style="display:none;"></td>
246 246
             		<td>
247
-            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)) . 'AAAA' . Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
247
+            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)).'AAAA'.Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
248 248
             		</td>
249 249
             		<td>
250
-            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)) . 'AAAA' . Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
250
+            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)).'AAAA'.Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
251 251
             		</td>
252
-            		<?php $hdate=$husb->getBirthDate(); ?>
252
+            		<?php $hdate = $husb->getBirthDate(); ?>
253 253
             		<td><?php  Date::getAge($hdate, $mdate, 2); ?></td>
254 254
             		<td><?php  Date::getAge($hdate, $mdate, 1); ?></td>
255 255
             		<!--  WIFE -->
256 256
         			<td colspan="2">
257 257
         			<?php foreach ($wife->getAllNames() as $num=>$name) {
258
-        				if ($name['type']=='NAME') {
259
-        					$title='';
258
+        				if ($name['type'] == 'NAME') {
259
+        					$title = '';
260 260
         				} else {
261
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $wife)).'"';
261
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $wife)).'"';
262 262
         				}
263
-        				if ($num==$wife->getPrimaryName()) {
264
-        					$class=' class="name2"';
265
-        					$sex_image=$wife->getSexImage();
266
-        					list($surn, $givn)=explode(',', $name['sort']);
263
+        				if ($num == $wife->getPrimaryName()) {
264
+        					$class = ' class="name2"';
265
+        					$sex_image = $wife->getSexImage();
266
+        					list($surn, $givn) = explode(',', $name['sort']);
267 267
         				} else {
268
-        					$class='';
269
-        					$sex_image='';
268
+        					$class = '';
269
+        					$sex_image = '';
270 270
         				} ?>
271 271
         				<a <?php echo $title.' '.$class; ?> href="<?php echo $wife->getHtmlUrl(); ?>">
272 272
         					<?php echo \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']); ?>
@@ -280,12 +280,12 @@  discard block
 block discarded – undo
280 280
             		<!-- Dummy column to match colspan in header -->
281 281
             		<td style="display:none;"></td>
282 282
             		<td>
283
-            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)) . 'AAAA' . Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
283
+            			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)).'AAAA'.Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
284 284
             		</td>
285 285
             		<td>
286
-            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)) . 'AAAA' . Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
286
+            			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)).'AAAA'.Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
287 287
             		</td>
288
-            		<?php $wdate=$wife->getBirthDate(); ?>
288
+            		<?php $wdate = $wife->getBirthDate(); ?>
289 289
             		<td><?php  Date::getAge($wdate, $mdate, 2); ?></td>
290 290
             		<td><?php  Date::getAge($wdate, $mdate, 1); ?></td>
291 291
             		<td><?php 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             		    echo '&nbsp;';
303 303
             		} ?>
304 304
             		</td>
305
-            		<td><?php echo $marriage_dates ? $marriage_date->julianDay() : 0;  ?></td>
305
+            		<td><?php echo $marriage_dates ? $marriage_date->julianDay() : 0; ?></td>
306 306
             		<td><?php 
307 307
             		foreach ($family->getAllMarriagePlaces() as $n => $marriage_place) {
308 308
 				        $tmp = new Place($marriage_place, $family->getTree());
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 								<button type="button" class="ui-state-default btn-toggle-parents">
363 363
 									<?php echo I18N::translate('Show parents') ?>
364 364
 								</button>
365
-								<button id="btn-toggle-statistics-<?php echo $table_id ;?>" type="button" class="ui-state-default btn-toggle-statistics">
365
+								<button id="btn-toggle-statistics-<?php echo $table_id; ?>" type="button" class="ui-state-default btn-toggle-statistics">
366 366
 									<?php echo I18N::translate('Show statistics charts') ?>
367 367
 								</button>
368 368
 							</div>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaComputeResultView.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,14 +25,14 @@
 block discarded – undo
25 25
 	 */
26 26
     protected function renderContent() {        
27 27
         
28
-        if($this->data->get('is_success', false)) {
28
+        if ($this->data->get('is_success', false)) {
29 29
         ?>        
30 30
         	<i class="icon-maj-success" title="<?php echo I18N::translate('Success'); ?>"></i>&nbsp;
31 31
         	<?php echo I18N::translate('Success'); ?>
32 32
         <?php } else { ?>
33 33
 			<i class="icon-maj-error" title="<?php echo I18N::translate('Error'); ?>"></i>&nbsp;
34 34
 			<?php echo I18N::translate('Error'); ?>
35
-			<?php if($error = $this->data->get('error')) { echo '&nbsp;-&nbsp;' . $error; }
35
+			<?php if ($error = $this->data->get('error')) { echo '&nbsp;-&nbsp;'.$error; }
36 36
         }
37 37
     }
38 38
     
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListMissingView.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -36,15 +36,15 @@  discard block
 block discarded – undo
36 36
             <div id="maj-sosa-missing-page" class="center">
37 37
     			<h2><?php echo $this->data->get('title'); ?></h2>
38 38
     			
39
-    			<?php  if($this->data->get('is_setup')) { 
39
+    			<?php  if ($this->data->get('is_setup')) { 
40 40
     			    $selectedgen = $this->data->get('generation');
41 41
     			    $this->renderSosaHeader();
42
-    			    if($this->data->get('has_missing', false)) {
42
+    			    if ($this->data->get('has_missing', false)) {
43 43
     			        $missing_list = $this->data->get('missing_list');
44 44
     			        $table_id = $this->data->get('table_id');
45 45
     			        ?>
46 46
     			<div id="sosa-indi-missing" class="smissing-list">
47
-                	<table id="<?php echo $table_id;?>">
47
+                	<table id="<?php echo $table_id; ?>">
48 48
         				<thead>     
49 49
             				<tr>
50 50
     							<th colspan="16">
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         				</thead>
113 113
         			<tbody>
114 114
         			
115
-        			<?php foreach($this->data->get('missing_list') as $missing_tab) {
115
+        			<?php foreach ($this->data->get('missing_list') as $missing_tab) {
116 116
         			    $person = $missing_tab['indi'];
117 117
         			    
118 118
         			    /** @var \Fisharebest\Webtrees\Individual $person */
@@ -130,18 +130,18 @@  discard block
 block discarded – undo
130 130
                 			<td class="transparent"><?php echo $person->getXref(); ?></td>
131 131
                 			<td colspan="2">
132 132
                 			<?php foreach ($person->getAllNames() as $num=>$name) {
133
-                				if ($name['type']=='NAME') {
134
-                					$title='';
133
+                				if ($name['type'] == 'NAME') {
134
+                					$title = '';
135 135
                 				} else {
136
-                					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
136
+                					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
137 137
                 				}
138
-                				if ($num==$person->getPrimaryName()) {
139
-                					$class=' class="name2"';
140
-                					$sex_image=$person->getSexImage();
141
-                					list($surn, $givn)=explode(',', $name['sort']);
138
+                				if ($num == $person->getPrimaryName()) {
139
+                					$class = ' class="name2"';
140
+                					$sex_image = $person->getSexImage();
141
+                					list($surn, $givn) = explode(',', $name['sort']);
142 142
                 				} else {
143
-                					$class='';
144
-                					$sex_image='';
143
+                					$class = '';
144
+                					$sex_image = '';
145 145
                 				} ?>
146 146
                 				<a <?php echo $title.' '.$class; ?> href="<?php echo $person->getHtmlUrl(); ?>">
147 147
                 					<?php echo \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']); ?>
@@ -154,10 +154,10 @@  discard block
 block discarded – undo
154 154
                     		</td>
155 155
                     		<td style="display:none;"></td>
156 156
                     		<td>
157
-                    			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)) . 'AAAA' . Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
157
+                    			<?php echo Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)).'AAAA'.Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)); ?>
158 158
                     		</td>
159 159
                     		<td>
160
-                    			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)) . 'AAAA' . Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
160
+                    			<?php echo Filter::escapeHtml(str_replace('@N.N.', 'AAAA', $surn)).'AAAA'.Filter::escapeHtml(str_replace('@P.N.', 'AAAA', $givn)); ?>
161 161
                     		</td>                    		
162 162
                 			<?php if (ModuleManager::getInstance()->isOperational(Constants::MODULE_MAJ_ISSOURCED_NAME)) {
163 163
         				        $isISourced = $dperson->isSourced(); ?>
@@ -167,17 +167,17 @@  discard block
 block discarded – undo
167 167
         					<td>&nbsp;</td>
168 168
         					<td></td>
169 169
         					<?php } ?>
170
-        					<td><?php echo $missing_tab['has_father'] ? '&nbsp;' : 'X';?></td>
171
-        					<td><?php echo $missing_tab['has_mother'] ? '&nbsp;' : 'X';?></td>
170
+        					<td><?php echo $missing_tab['has_father'] ? '&nbsp;' : 'X'; ?></td>
171
+        					<td><?php echo $missing_tab['has_mother'] ? '&nbsp;' : 'X'; ?></td>
172 172
         					<td>
173 173
                     		<?php 
174
-                    		if ($birth_dates=$person->getAllBirthDates()) {
174
+                    		if ($birth_dates = $person->getAllBirthDates()) {
175 175
         			            foreach ($birth_dates as $num=>$birth_date) {
176 176
             					   if ($num) { ?><br/><?php } ?>
177 177
             						<?php  echo $birth_date->display(true);
178 178
         			            }
179 179
                     		} else {
180
-                    		    $birth_date=$person->getEstimatedBirthDate();
180
+                    		    $birth_date = $person->getEstimatedBirthDate();
181 181
                     		    if ($person->getTree()->getPreference('SHOW_EST_LIST_DATES')) {
182 182
                     		        $birth_date->display(true);
183 183
                     		    } else {
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
                     		}
188 188
                     		?>
189 189
                     		</td>
190
-                    		<td><?php echo $birth_date->julianDay();?></td>
190
+                    		<td><?php echo $birth_date->julianDay(); ?></td>
191 191
                 			<td>
192 192
                 			<?php foreach ($person->getAllBirthPlaces() as $n => $birth_place) {
193 193
         				        $tmp = new \Fisharebest\Webtrees\Place($birth_place, $person->getTree());
@@ -218,9 +218,9 @@  discard block
 block discarded – undo
218 218
 									$missing_hidden = $this->data->get('missing_hidden');
219 219
 									?>
220 220
 									<?php echo I18N::translate('Number of different missing ancestors: %s', I18N::number($this->data->get('missing_diff_count'))); ?>
221
-									<?php if($this->data->get('missing_hidden') > 0) echo ' ['. I18N::translate('%s hidden', I18N::number($this->data->get('missing_hidden'))).']'; ?>
222
-									<?php echo ' - ' . I18N::translate('Generation complete at %s', I18N::percentage($this->data->get('perc_sosa'), 2)); ?>
223
-									<?php echo ' [' . I18N::translate('Potential %s', I18N::percentage($this->data->get('perc_sosa_potential'),2)).']'; ?>
221
+									<?php if ($this->data->get('missing_hidden') > 0) echo ' ['.I18N::translate('%s hidden', I18N::number($this->data->get('missing_hidden'))).']'; ?>
222
+									<?php echo ' - '.I18N::translate('Generation complete at %s', I18N::percentage($this->data->get('perc_sosa'), 2)); ?>
223
+									<?php echo ' ['.I18N::translate('Potential %s', I18N::percentage($this->data->get('perc_sosa_potential'), 2)).']'; ?>
224 224
 								</div>
225 225
 							</td>
226 226
 						</tr>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/SosaStatsController.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         $view_bag->set('title', $controller->getPageTitle());
65 65
         $view_bag->set('is_setup', false);
66 66
         
67
-        if($this->sosa_provider->isSetup()) {
67
+        if ($this->sosa_provider->isSetup()) {
68 68
             $view_bag->set('is_setup', true);
69 69
             
70 70
             $sosaCount = $this->sosa_provider->getSosaCount();
@@ -82,23 +82,23 @@  discard block
 block discarded – undo
82 82
             $stats_gen = $this->sosa_provider->getStatisticsByGeneration();
83 83
             $view_bag->set('missinganc_url', 'module.php?mod='.$this->module->getName().'&mod_action=SosaList@missing&ged='.$WT_TREE->getNameUrl().'&gen=');
84 84
             
85
-            $gen_theoretical=1;
86
-            $total_theoretical=0;
87
-            $prev_diff=0;
88
-            $prev_known=0.5;
89
-            $gen_equiv=0;            
85
+            $gen_theoretical = 1;
86
+            $total_theoretical = 0;
87
+            $prev_diff = 0;
88
+            $prev_known = 0.5;
89
+            $gen_equiv = 0;            
90 90
             $generation_stats = array();
91 91
             
92
-            foreach($stats_gen as $gen => $tab){
93
-                $genY1= I18N::translate('-');
94
-                $genY2= I18N::translate('-');
95
-                if($tab['firstBirth']>0) $genY1=$tab['firstBirth'];
96
-                if($tab['lastBirth']>0) $genY2=$tab['lastBirth'];
92
+            foreach ($stats_gen as $gen => $tab) {
93
+                $genY1 = I18N::translate('-');
94
+                $genY2 = I18N::translate('-');
95
+                if ($tab['firstBirth'] > 0) $genY1 = $tab['firstBirth'];
96
+                if ($tab['lastBirth'] > 0) $genY2 = $tab['lastBirth'];
97 97
                 $total_theoretical += $gen_theoretical;
98 98
                 $perc_sosa_count_theor = Functions::safeDivision($tab['sosaCount'], $gen_theoretical);
99 99
                 $gen_equiv += $perc_sosa_count_theor;
100
-                $missing=2*$prev_known - $tab['sosaCount'];
101
-                $gen_diff=$tab['diffSosaTotalCount']-$prev_diff;
100
+                $missing = 2 * $prev_known - $tab['sosaCount'];
101
+                $gen_diff = $tab['diffSosaTotalCount'] - $prev_diff;
102 102
                 
103 103
                 $generation_stats[$gen] = array(
104 104
                     'gen_min_birth' => $genY1,
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
                     'known' => $tab['sosaCount'],
108 108
                     'perc_known' => $perc_sosa_count_theor,
109 109
                     'missing' => $missing,
110
-                    'perc_missing' => 1-Functions::safeDivision($tab['sosaCount'], 2*$prev_known),
110
+                    'perc_missing' => 1 - Functions::safeDivision($tab['sosaCount'], 2 * $prev_known),
111 111
                     'total_known' => $tab['sosaTotalCount'],
112 112
                     'perc_total_known' => Functions::safeDivision($tab['sosaTotalCount'], $total_theoretical),
113 113
                     'different' => $gen_diff,
@@ -117,8 +117,8 @@  discard block
 block discarded – undo
117 117
                 );
118 118
                 
119 119
                 $gen_theoretical = $gen_theoretical * 2;
120
-                $prev_known=$tab['sosaCount'];
121
-                $prev_diff=$tab['diffSosaTotalCount'];
120
+                $prev_known = $tab['sosaCount'];
121
+                $prev_diff = $tab['diffSosaTotalCount'];
122 122
             }
123 123
             
124 124
             $view_bag->set('generation_stats', $generation_stats);
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
      private function htmlAncestorDispersionG2()
140 140
     {
141 141
         $ancestorsDispGen2 = $this->sosa_provider->getAncestorDispersionForGen(2);
142
-        if(count($ancestorsDispGen2) == 0) return;
142
+        if (count($ancestorsDispGen2) == 0) return;
143 143
         
144 144
         $size = '600x300';
145 145
         $sizes = explode('x', $size);
@@ -150,21 +150,21 @@  discard block
 block discarded – undo
150 150
         
151 151
         $total = array_sum($ancestorsDispGen2);
152 152
         $father_count = isset($ancestorsDispGen2[1]) ? $ancestorsDispGen2[1] : 0;
153
-        $father = array (
153
+        $father = array(
154 154
             'color' => '84beff', 
155 155
             'count' => $father_count, 
156 156
             'perc' => Functions::safeDivision($father_count, $total), 
157 157
             'name' => \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('fat')            
158 158
         );
159 159
         $mother_count = isset($ancestorsDispGen2[2]) ? $ancestorsDispGen2[2] : 0;
160
-        $mother = array (
160
+        $mother = array(
161 161
             'color' => 'ffd1dc', 
162 162
             'count' => $mother_count, 
163 163
             'perc' => Functions::safeDivision($mother_count, $total),
164 164
             'name' => \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('mot')
165 165
         );
166 166
         $shared_count = isset($ancestorsDispGen2[-1]) ? $ancestorsDispGen2[-1] : 0;
167
-        $shared = array (
167
+        $shared = array(
168 168
             'color' => '777777', 
169 169
             'count' => $shared_count, 
170 170
             'perc' => Functions::safeDivision($shared_count, $total),
@@ -174,10 +174,10 @@  discard block
 block discarded – undo
174 174
         $chd = $this->arrayToExtendedEncoding(array(4095 * $father['perc'], 4095 * $shared['perc'], 4095 * $mother['perc']));
175 175
         $chart_title = I18N::translate('Known Sosa ancestors\' dispersion');
176 176
         $chl = 
177
-             $father['name'] . ' - ' . I18N::percentage($father['perc'], 1) . '|' .
178
-             $shared['name'] . ' - ' . I18N::percentage($shared['perc'], 1) . '|' .
179
-             $mother['name'] . ' - ' . I18N::percentage($mother['perc'], 1);
180
-        return "<img src=\"https://chart.googleapis.com/chart?cht=p&chp=1.5708&amp;chd=e:{$chd}&amp;chs={$size}&amp;chco={$father['color']},{$shared['color']},{$mother['color']}&amp;chf=bg,s,ffffff00&amp;chl={$chl}\" alt=\"" . $chart_title . "\" title=\"" . $chart_title . "\" />";
177
+             $father['name'].' - '.I18N::percentage($father['perc'], 1).'|'.
178
+             $shared['name'].' - '.I18N::percentage($shared['perc'], 1).'|'.
179
+             $mother['name'].' - '.I18N::percentage($mother['perc'], 1);
180
+        return "<img src=\"https://chart.googleapis.com/chart?cht=p&chp=1.5708&amp;chd=e:{$chd}&amp;chs={$size}&amp;chco={$father['color']},{$shared['color']},{$mother['color']}&amp;chf=bg,s,ffffff00&amp;chl={$chl}\" alt=\"".$chart_title."\" title=\"".$chart_title."\" />";
181 181
     }
182 182
     
183 183
     /**
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $total_motfat = $ancestorsDispGen2[4] ?: 0;
202 202
         $total_motmot = $ancestorsDispGen2[8] ?: 0;
203 203
         $total_sha = $ancestorsDispGen2[-1] ?: 0;
204
-        $total = $total_fatfat + $total_fatmot + $total_motfat+ $total_motmot + $total_sha;
204
+        $total = $total_fatfat + $total_fatmot + $total_motfat + $total_motmot + $total_sha;
205 205
     
206 206
         $chd = $this->arrayToExtendedEncoding(array(
207 207
             4095 * $total_fatfat / $total, 
@@ -212,12 +212,12 @@  discard block
 block discarded – undo
212 212
         ));
213 213
         $chart_title = I18N::translate('Known Sosa ancestors\' dispersion - G3');
214 214
         $chl =
215
-            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('fatfat') . ' - ' . I18N::percentage(Functions::safeDivision($total_fatfat, $total), 1) . '|' .
216
-            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('fatmot') . ' - ' . I18N::percentage(Functions::safeDivision($total_fatmot, $total), 1) . '|' .
217
-            I18N::translate('Shared') . ' - ' . I18N::percentage(Functions::safeDivision($total_sha, $total), 1) . '|' .
218
-            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('motfat') . ' - ' . I18N::percentage(Functions::safeDivision($total_motfat, $total), 1) . '|' .
219
-            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('motmot') . ' - ' . I18N::percentage(Functions::safeDivision($total_motmot, $total), 1);
220
-         return "<img src=\"https://chart.googleapis.com/chart?cht=p&chp=1.5708&amp;chd=e:{$chd}&amp;chs={$size}&amp;chco={$color_fatfat},{$color_fatmot},{$color_shared},{$color_motfat},{$color_motmot}&amp;chf=bg,s,ffffff00&amp;chl={$chl}\" alt=\"" . $chart_title . "\" title=\"" . $chart_title . "\" />";
215
+            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('fatfat').' - '.I18N::percentage(Functions::safeDivision($total_fatfat, $total), 1).'|'.
216
+            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('fatmot').' - '.I18N::percentage(Functions::safeDivision($total_fatmot, $total), 1).'|'.
217
+            I18N::translate('Shared').' - '.I18N::percentage(Functions::safeDivision($total_sha, $total), 1).'|'.
218
+            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('motfat').' - '.I18N::percentage(Functions::safeDivision($total_motfat, $total), 1).'|'.
219
+            \Fisharebest\Webtrees\Functions\Functions::getRelationshipNameFromPath('motmot').' - '.I18N::percentage(Functions::safeDivision($total_motmot, $total), 1);
220
+         return "<img src=\"https://chart.googleapis.com/chart?cht=p&chp=1.5708&amp;chd=e:{$chd}&amp;chs={$size}&amp;chco={$color_fatfat},{$color_fatmot},{$color_shared},{$color_motfat},{$color_motmot}&amp;chf=bg,s,ffffff00&amp;chl={$chl}\" alt=\"".$chart_title."\" title=\"".$chart_title."\" />";
221 221
     }
222 222
 
223 223
     /**
@@ -233,9 +233,9 @@  discard block
 block discarded – undo
233 233
             if ($value < 0) {
234 234
                 $value = 0;
235 235
             }
236
-            $first  = (int) ($value / 64);
236
+            $first  = (int)($value / 64);
237 237
             $second = $value % 64;
238
-            $encoding .= $xencoding[(int) $first] . $xencoding[(int) $second];
238
+            $encoding .= $xencoding[(int)$first].$xencoding[(int)$second];
239 239
         }
240 240
     
241 241
         return $encoding;
Please login to merge, or discard this patch.