MyArtJaub\Webtrees\Module\GeoDispersion\Http\RequestHandlers\MapAdapterAddAction::handle()

Complexity

Conditions	8
Paths	7

Size

Total Lines	60
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = Validator::attributes($request)->tree();

        if ($this->module === null) {
            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                'danger'
            );
            return redirect(route(AdminConfigPage::class, ['tree' => $tree->name()]));
        }

        $view_id = Validator::attributes($request)->integer('view_id', -1);
        $view = $this->geoview_data_service->find($tree, $view_id);

        $map = $this->map_definition_service->find(Validator::parsedBody($request)->string('map_adapter_map', ''));
        $mapping_property   = Validator::parsedBody($request)->string('map_adapter_property_selected', '');

        $mapper = null;

The assignment to $mapper is dead and can be removed.

        try {
            $mapper = app(Validator::parsedBody($request)->string('map_adapter_mapper', ''));
        } catch (BindingResolutionException $ex) {

Consider adding a comment why this CATCH block is empty.

        }

        if ($view === null || $map === null || $mapper === null || !($mapper instanceof PlaceMapperInterface)) {
            FlashMessages::addMessage(
                I18N::translate('The parameters for the map configuration are not valid.'),
                'danger'
            );
            return redirect(route(AdminConfigPage::class, ['tree' => $tree->name()]));
        }

        $new_adapter_id = $this->mapadapter_data_service->insertGetId(
            new GeoAnalysisMapAdapter(
                0,
                $view_id,
                $map,
                $mapper,
                new MapViewConfig($mapping_property, $mapper->config()->withConfigUpdate($request))
            )
        );
        if ($new_adapter_id > 0) {
            FlashMessages::addMessage(
                I18N::translate('The map configuration has been successfully added.'),
                'success'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addConfigurationLog('Module ' . $this->module->title() . ' : Map Adapter “' . $new_adapter_id . '” has been added.');
        } else {
            FlashMessages::addMessage(
                I18N::translate('An error occured while adding a new map configuration.'),
                'danger'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addConfigurationLog('Module ' . $this->module->title() . ' : Map Adapter could not be added. See error log.');
        }

        return redirect(route(GeoAnalysisViewEditPage::class, [
            'tree' => $tree->name(),
            'view_id' => $view_id
        ]));