Passed
Branch main (f9aaf7)
by Jonathan
14:43
created
app/Module/Hooks/Hooks/FamilyDatatablesExtenderCollector.php 1 patch
Indentation   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -25,45 +25,45 @@
 block discarded – undo
25 25
  * @extends AbstractHookCollector<FamilyDatatablesExtenderInterface>
26 26
  */
27 27
 class FamilyDatatablesExtenderCollector extends AbstractHookCollector implements
28
-    FamilyDatatablesExtenderInterface
28
+	FamilyDatatablesExtenderInterface
29 29
 {
30
-    /**
31
-     * {@inheritDoc}
32
-     * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::title()
33
-     */
34
-    public function title(): string
35
-    {
36
-        return I18N::translate('Columns extender for tables of families');
37
-    }
30
+	/**
31
+	 * {@inheritDoc}
32
+	 * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::title()
33
+	 */
34
+	public function title(): string
35
+	{
36
+		return I18N::translate('Columns extender for tables of families');
37
+	}
38 38
 
39
-    /**
40
-     * {@inheritDoc}
41
-     * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::description()
42
-     */
43
-    public function description(): string
44
-    {
45
-        return I18N::translate('Add additional columns to tables of families');
46
-    }
39
+	/**
40
+	 * {@inheritDoc}
41
+	 * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::description()
42
+	 */
43
+	public function description(): string
44
+	{
45
+		return I18N::translate('Add additional columns to tables of families');
46
+	}
47 47
 
48
-    /**
49
-     * {@inheritDoc}
50
-     * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::hookInterface()
51
-     */
52
-    public function hookInterface(): string
53
-    {
54
-        return FamilyDatatablesExtenderInterface::class;
55
-    }
48
+	/**
49
+	 * {@inheritDoc}
50
+	 * @see \MyArtJaub\Webtrees\Common\Hooks\AbstractHookCollector::hookInterface()
51
+	 */
52
+	public function hookInterface(): string
53
+	{
54
+		return FamilyDatatablesExtenderInterface::class;
55
+	}
56 56
 
57
-    /**
58
-     * {@inheritDoc}
59
-     * @see \MyArtJaub\Webtrees\Contracts\Hooks\FamilyDatatablesExtenderInterface::familyColumns()
60
-     */
61
-    public function familyColumns(iterable $records): array
62
-    {
63
-        $result = [];
64
-        foreach ($this->hooks() as $hook) {
65
-            $result = array_merge($result, $hook->familyColumns($records));
66
-        }
67
-        return $result;
68
-    }
57
+	/**
58
+	 * {@inheritDoc}
59
+	 * @see \MyArtJaub\Webtrees\Contracts\Hooks\FamilyDatatablesExtenderInterface::familyColumns()
60
+	 */
61
+	public function familyColumns(iterable $records): array
62
+	{
63
+		$result = [];
64
+		foreach ($this->hooks() as $hook) {
65
+			$result = array_merge($result, $hook->familyColumns($records));
66
+		}
67
+		return $result;
68
+	}
69 69
 }
Please login to merge, or discard this patch.
app/Module/Hooks/Http/RequestHandlers/ModulesHooksAction.php 2 patches
Indentation   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -29,61 +29,61 @@
 block discarded – undo
29 29
  */
30 30
 class ModulesHooksAction extends AbstractModuleComponentAction
31 31
 {
32
-    protected HookService $hook_service;
32
+	protected HookService $hook_service;
33 33
 
34
-    /**
35
-     * Constructor for ModulesHooksAction Request Handler
36
-     *
37
-     * @param ModuleService $module_service
38
-     * @param TreeService $tree_service
39
-     * @param HookService $hook_service
40
-     */
41
-    public function __construct(ModuleService $module_service, TreeService $tree_service, HookService $hook_service)
42
-    {
43
-        parent::__construct($module_service, $tree_service);
44
-        $this->hook_service = $hook_service;
45
-    }
34
+	/**
35
+	 * Constructor for ModulesHooksAction Request Handler
36
+	 *
37
+	 * @param ModuleService $module_service
38
+	 * @param TreeService $tree_service
39
+	 * @param HookService $hook_service
40
+	 */
41
+	public function __construct(ModuleService $module_service, TreeService $tree_service, HookService $hook_service)
42
+	{
43
+		parent::__construct($module_service, $tree_service);
44
+		$this->hook_service = $hook_service;
45
+	}
46 46
 
47
-    /**
48
-     * {@inheritDoc}
49
-     * @see \Psr\Http\Server\RequestHandlerInterface::handle()
50
-     */
51
-    public function handle(ServerRequestInterface $request): ResponseInterface
52
-    {
53
-        $hook_name = $request->getAttribute('hook_name');
54
-        $hook_collector = $this->hook_service->find($hook_name, true);
55
-        if ($hook_collector === null) {
56
-            FlashMessages::addMessage(I18N::translate('The hook with name “%s” does not exist.', $hook_name), 'danger');
57
-            return redirect(AdminConfigPage::class);
58
-        }
47
+	/**
48
+	 * {@inheritDoc}
49
+	 * @see \Psr\Http\Server\RequestHandlerInterface::handle()
50
+	 */
51
+	public function handle(ServerRequestInterface $request): ResponseInterface
52
+	{
53
+		$hook_name = $request->getAttribute('hook_name');
54
+		$hook_collector = $this->hook_service->find($hook_name, true);
55
+		if ($hook_collector === null) {
56
+			FlashMessages::addMessage(I18N::translate('The hook with name “%s” does not exist.', $hook_name), 'danger');
57
+			return redirect(AdminConfigPage::class);
58
+		}
59 59
 
60
-        foreach ($hook_collector->hooks() as $hook) {
61
-            $this->updateStatus(get_class($hook->module()), $request);
62
-        }
60
+		foreach ($hook_collector->hooks() as $hook) {
61
+			$this->updateStatus(get_class($hook->module()), $request);
62
+		}
63 63
 
64
-        $this->updateHookOrder($hook_collector, $request);
64
+		$this->updateHookOrder($hook_collector, $request);
65 65
 
66
-        FlashMessages::addMessage(I18N::translate('The hook preferences have been updated.'), 'success');
66
+		FlashMessages::addMessage(I18N::translate('The hook preferences have been updated.'), 'success');
67 67
 
68
-        return redirect(route(ModulesHooksPage::class, ['hook_name' => $hook_name]));
69
-    }
68
+		return redirect(route(ModulesHooksPage::class, ['hook_name' => $hook_name]));
69
+	}
70 70
 
71
-    /**
72
-     * Update the order of modules for a hook interface.
73
-     *
74
-     * @template THook of \MyArtJaub\Webtrees\Contracts\Hooks\HookInterface
75
-     * @param HookCollectorInterface<THook> $hook_collector
76
-     * @param ServerRequestInterface $request
77
-     */
78
-    protected function updateHookOrder(HookCollectorInterface $hook_collector, ServerRequestInterface $request): void
79
-    {
80
-        $params = (array) $request->getParsedBody();
71
+	/**
72
+	 * Update the order of modules for a hook interface.
73
+	 *
74
+	 * @template THook of \MyArtJaub\Webtrees\Contracts\Hooks\HookInterface
75
+	 * @param HookCollectorInterface<THook> $hook_collector
76
+	 * @param ServerRequestInterface $request
77
+	 */
78
+	protected function updateHookOrder(HookCollectorInterface $hook_collector, ServerRequestInterface $request): void
79
+	{
80
+		$params = (array) $request->getParsedBody();
81 81
 
82
-        $order = (array) ($params['order'] ?? []);
83
-        $order = array_flip($order);
82
+		$order = (array) ($params['order'] ?? []);
83
+		$order = array_flip($order);
84 84
 
85
-        foreach ($hook_collector->hooks() as $hook) {
86
-            $this->hook_service->updateOrder($hook_collector, $hook->module(), $order[$hook->module()->name()] ?? 0);
87
-        }
88
-    }
85
+		foreach ($hook_collector->hooks() as $hook) {
86
+			$this->hook_service->updateOrder($hook_collector, $hook->module(), $order[$hook->module()->name()] ?? 0);
87
+		}
88
+	}
89 89
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,9 +77,9 @@
 block discarded – undo
77 77
      */
78 78
     protected function updateHookOrder(HookCollectorInterface $hook_collector, ServerRequestInterface $request): void
79 79
     {
80
-        $params = (array) $request->getParsedBody();
80
+        $params = (array)$request->getParsedBody();
81 81
 
82
-        $order = (array) ($params['order'] ?? []);
82
+        $order = (array)($params['order'] ?? []);
83 83
         $order = array_flip($order);
84 84
 
85 85
         foreach ($hook_collector->hooks() as $hook) {
Please login to merge, or discard this patch.
app/Module/Hooks/Http/RequestHandlers/ModulesHooksPage.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -28,44 +28,44 @@
 block discarded – undo
28 28
  */
29 29
 class ModulesHooksPage implements RequestHandlerInterface
30 30
 {
31
-    use ViewResponseTrait;
31
+	use ViewResponseTrait;
32 32
 
33
-    protected HookService $hook_service;
33
+	protected HookService $hook_service;
34 34
 
35
-    /**
36
-     * Constructor for ModulesHooksPage request handler
37
-     *
38
-     * @param HookService $hook_service
39
-     */
40
-    public function __construct(HookService $hook_service)
41
-    {
42
-        $this->hook_service = $hook_service;
43
-    }
35
+	/**
36
+	 * Constructor for ModulesHooksPage request handler
37
+	 *
38
+	 * @param HookService $hook_service
39
+	 */
40
+	public function __construct(HookService $hook_service)
41
+	{
42
+		$this->hook_service = $hook_service;
43
+	}
44 44
 
45
-    /**
46
-     * {@inheritDoc}
47
-     * @see \Psr\Http\Server\RequestHandlerInterface::handle()
48
-     */
49
-    public function handle(ServerRequestInterface $request): ResponseInterface
50
-    {
51
-        $this->layout = 'layouts/administration';
45
+	/**
46
+	 * {@inheritDoc}
47
+	 * @see \Psr\Http\Server\RequestHandlerInterface::handle()
48
+	 */
49
+	public function handle(ServerRequestInterface $request): ResponseInterface
50
+	{
51
+		$this->layout = 'layouts/administration';
52 52
 
53
-        $hook_name = $request->getAttribute('hook_name');
54
-        $hook = $this->hook_service->find($hook_name, true);
55
-        if ($hook === null) {
56
-            throw new HttpNotFoundException(I18N::translate('The hook with name “%s” does not exist.', $hook_name));
57
-        }
53
+		$hook_name = $request->getAttribute('hook_name');
54
+		$hook = $this->hook_service->find($hook_name, true);
55
+		if ($hook === null) {
56
+			throw new HttpNotFoundException(I18N::translate('The hook with name “%s” does not exist.', $hook_name));
57
+		}
58 58
 
59
-        $modules = $hook->hooks()
60
-            ->sortKeys()
61
-            ->mapWithKeys(fn(HookInterface $hook) => [$hook->module()->name() => $hook->module()]);
59
+		$modules = $hook->hooks()
60
+			->sortKeys()
61
+			->mapWithKeys(fn(HookInterface $hook) => [$hook->module()->name() => $hook->module()]);
62 62
 
63
-        return $this->viewResponse('admin/components', [
64
-            'description'    => $hook->description(),
65
-            'modules'        => $modules,
66
-            'title'          => $hook->title(),
67
-            'uses_access'    => false,
68
-            'uses_sorting'   => true
69
-        ]);
70
-    }
63
+		return $this->viewResponse('admin/components', [
64
+			'description'    => $hook->description(),
65
+			'modules'        => $modules,
66
+			'title'          => $hook->title(),
67
+			'uses_access'    => false,
68
+			'uses_sorting'   => true
69
+		]);
70
+	}
71 71
 }
Please login to merge, or discard this patch.
app/Module/Hooks/Http/RequestHandlers/AdminConfigPage.php 2 patches
Indentation   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -29,38 +29,38 @@
 block discarded – undo
29 29
  */
30 30
 class AdminConfigPage implements RequestHandlerInterface
31 31
 {
32
-    use ViewResponseTrait;
32
+	use ViewResponseTrait;
33 33
 
34
-    private ?HooksModule $module;
35
-    private HookService $hook_service;
34
+	private ?HooksModule $module;
35
+	private HookService $hook_service;
36 36
 
37
-    /**
38
-     * Constructor for AdminConfigPage Request Handler
39
-     *
40
-     * @param ModuleService $module_service
41
-     * @param HookService $hook_service
42
-     */
43
-    public function __construct(ModuleService $module_service, HookService $hook_service)
44
-    {
45
-        $this->module = $module_service->findByInterface(HooksModule::class)->first();
46
-        $this->hook_service = $hook_service;
47
-    }
37
+	/**
38
+	 * Constructor for AdminConfigPage Request Handler
39
+	 *
40
+	 * @param ModuleService $module_service
41
+	 * @param HookService $hook_service
42
+	 */
43
+	public function __construct(ModuleService $module_service, HookService $hook_service)
44
+	{
45
+		$this->module = $module_service->findByInterface(HooksModule::class)->first();
46
+		$this->hook_service = $hook_service;
47
+	}
48 48
 
49
-    /**
50
-     * {@inheritDoc}
51
-     * @see \Psr\Http\Server\RequestHandlerInterface::handle()
52
-     */
53
-    public function handle(ServerRequestInterface $request): ResponseInterface
54
-    {
55
-        $this->layout = 'layouts/administration';
49
+	/**
50
+	 * {@inheritDoc}
51
+	 * @see \Psr\Http\Server\RequestHandlerInterface::handle()
52
+	 */
53
+	public function handle(ServerRequestInterface $request): ResponseInterface
54
+	{
55
+		$this->layout = 'layouts/administration';
56 56
 
57
-        if ($this->module === null) {
58
-            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
59
-        }
57
+		if ($this->module === null) {
58
+			throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
59
+		}
60 60
 
61
-        return $this->viewResponse($this->module->name() . '::admin/config', [
62
-            'title'                 =>  $this->module->title(),
63
-            'hook_interfaces_list'  =>  $this->hook_service->all(true)
64
-        ]);
65
-    }
61
+		return $this->viewResponse($this->module->name() . '::admin/config', [
62
+			'title'                 =>  $this->module->title(),
63
+			'hook_interfaces_list'  =>  $this->hook_service->all(true)
64
+		]);
65
+	}
66 66
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
             throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
59 59
         }
60 60
 
61
-        return $this->viewResponse($this->module->name() . '::admin/config', [
61
+        return $this->viewResponse($this->module->name().'::admin/config', [
62 62
             'title'                 =>  $this->module->title(),
63 63
             'hook_interfaces_list'  =>  $this->hook_service->all(true)
64 64
         ]);
Please login to merge, or discard this patch.
app/Module/Hooks/Schema/Migration1.php 2 patches
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -24,22 +24,22 @@
 block discarded – undo
24 24
 class Migration1 implements MigrationInterface
25 25
 {
26 26
 
27
-    /**
28
-     * {@inheritDoc}
29
-     * @see \Fisharebest\Webtrees\Schema\MigrationInterface::upgrade()
30
-     */
31
-    public function upgrade(): void
32
-    {
33
-        if (DB::schema()->hasTable('maj_hooks')) {
34
-            DB::schema()->drop('maj_hooks');
35
-        }
36
-
37
-        DB::schema()->create('maj_hook_order', static function (Blueprint $table): void {
38
-            $table->string('majho_module_name', 32);
39
-            $table->string('majho_hook_name', 64);
40
-            $table->integer('majho_hook_order')->nullable();
41
-
42
-            $table->primary(['majho_module_name', 'majho_hook_name']);
43
-        });
44
-    }
27
+	/**
28
+	 * {@inheritDoc}
29
+	 * @see \Fisharebest\Webtrees\Schema\MigrationInterface::upgrade()
30
+	 */
31
+	public function upgrade(): void
32
+	{
33
+		if (DB::schema()->hasTable('maj_hooks')) {
34
+			DB::schema()->drop('maj_hooks');
35
+		}
36
+
37
+		DB::schema()->create('maj_hook_order', static function (Blueprint $table): void {
38
+			$table->string('majho_module_name', 32);
39
+			$table->string('majho_hook_name', 64);
40
+			$table->integer('majho_hook_order')->nullable();
41
+
42
+			$table->primary(['majho_module_name', 'majho_hook_name']);
43
+		});
44
+	}
45 45
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
             DB::schema()->drop('maj_hooks');
35 35
         }
36 36
 
37
-        DB::schema()->create('maj_hook_order', static function (Blueprint $table): void {
37
+        DB::schema()->create('maj_hook_order', static function(Blueprint $table): void {
38 38
             $table->string('majho_module_name', 32);
39 39
             $table->string('majho_hook_name', 64);
40 40
             $table->integer('majho_hook_order')->nullable();
Please login to merge, or discard this patch.
app/Module/Hooks/Schema/Migration0.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@
 block discarded – undo
22 22
 class Migration0 implements MigrationInterface
23 23
 {
24 24
 
25
-    /**
26
-     * {@inheritDoc}
27
-     * @see \Fisharebest\Webtrees\Schema\MigrationInterface::upgrade()
28
-     */
29
-    public function upgrade(): void
30
-    {
25
+	/**
26
+	 * {@inheritDoc}
27
+	 * @see \Fisharebest\Webtrees\Schema\MigrationInterface::upgrade()
28
+	 */
29
+	public function upgrade(): void
30
+	{
31 31
 
32
-        // This migration has been superseded by migration 1.
33
-    }
32
+		// This migration has been superseded by migration 1.
33
+	}
34 34
 }
Please login to merge, or discard this patch.
app/Module/Hooks/Services/HookService.php 2 patches
Indentation   +91 added lines, -91 removed lines patch added patch discarded remove patch
@@ -30,104 +30,104 @@
 block discarded – undo
30 30
  */
31 31
 class HookService implements HookServiceInterface
32 32
 {
33
-    private ModuleService $module_service;
33
+	private ModuleService $module_service;
34 34
 
35
-    /**
36
-     * Constructor for HookService
37
-     *
38
-     * @param ModuleService $module_service
39
-     */
40
-    public function __construct(ModuleService $module_service)
41
-    {
42
-        $this->module_service = $module_service;
43
-    }
35
+	/**
36
+	 * Constructor for HookService
37
+	 *
38
+	 * @param ModuleService $module_service
39
+	 */
40
+	public function __construct(ModuleService $module_service)
41
+	{
42
+		$this->module_service = $module_service;
43
+	}
44 44
 
45
-    /**
46
-     * {@inheritDoc}
47
-     * @see \MyArtJaub\Webtrees\Contracts\Hooks\HookServiceInterface::use()
48
-     */
49
-    public function use(string $hook_interface): ?HookCollectorInterface
50
-    {
51
-        return $this->all()->get($hook_interface);
52
-    }
45
+	/**
46
+	 * {@inheritDoc}
47
+	 * @see \MyArtJaub\Webtrees\Contracts\Hooks\HookServiceInterface::use()
48
+	 */
49
+	public function use(string $hook_interface): ?HookCollectorInterface
50
+	{
51
+		return $this->all()->get($hook_interface);
52
+	}
53 53
 
54 54
 
55
-    /**
56
-     * Find a hook collector by its name, with or without the disabled ones.
57
-     *
58
-     * @template THook of HookInterface
59
-     * @param string $hook_name
60
-     * @return HookCollectorInterface<THook>|null
61
-     */
62
-    public function find(string $hook_name, bool $include_disabled = false): ?HookCollectorInterface
63
-    {
64
-        return $this->all($include_disabled)
65
-            ->first(fn(HookCollectorInterface $hook_collector) => $hook_collector->name() === $hook_name);
66
-    }
55
+	/**
56
+	 * Find a hook collector by its name, with or without the disabled ones.
57
+	 *
58
+	 * @template THook of HookInterface
59
+	 * @param string $hook_name
60
+	 * @return HookCollectorInterface<THook>|null
61
+	 */
62
+	public function find(string $hook_name, bool $include_disabled = false): ?HookCollectorInterface
63
+	{
64
+		return $this->all($include_disabled)
65
+			->first(fn(HookCollectorInterface $hook_collector) => $hook_collector->name() === $hook_name);
66
+	}
67 67
 
68
-    /**
69
-     * Get all hook collectors subscribed by modules, with hooks ordered, with or without the disabled ones.
70
-     *
71
-     * @template THook of HookInterface
72
-     * @param bool $include_disabled
73
-     * @return Collection<string, HookCollectorInterface<THook>>
74
-     */
75
-    public function all(bool $include_disabled = false): Collection
76
-    {
77
-        return Registry::cache()->array()->remember('all-hooks', function () use ($include_disabled): Collection {
78
-            $hooks_info = DB::table('maj_hook_order')
79
-                ->get()
80
-                ->groupBy(['majho_hook_name', 'majho_module_name']);
68
+	/**
69
+	 * Get all hook collectors subscribed by modules, with hooks ordered, with or without the disabled ones.
70
+	 *
71
+	 * @template THook of HookInterface
72
+	 * @param bool $include_disabled
73
+	 * @return Collection<string, HookCollectorInterface<THook>>
74
+	 */
75
+	public function all(bool $include_disabled = false): Collection
76
+	{
77
+		return Registry::cache()->array()->remember('all-hooks', function () use ($include_disabled): Collection {
78
+			$hooks_info = DB::table('maj_hook_order')
79
+				->get()
80
+				->groupBy(['majho_hook_name', 'majho_module_name']);
81 81
 
82
-            $hooks = $this->module_service
83
-                ->findByInterface(ModuleHookSubscriberInterface::class, $include_disabled)
84
-                ->flatMap(fn(ModuleHookSubscriberInterface $module) => $module->listSubscribedHooks());
82
+			$hooks = $this->module_service
83
+				->findByInterface(ModuleHookSubscriberInterface::class, $include_disabled)
84
+				->flatMap(fn(ModuleHookSubscriberInterface $module) => $module->listSubscribedHooks());
85 85
 
86
-            $hook_collectors = collect();
87
-            $hook_instances = collect();
88
-            foreach ($hooks as $hook) {
89
-                if (!($hook instanceof HookInterface)) {
90
-                    continue;
91
-                }
92
-                if ($hook instanceof HookCollectorInterface) {
93
-                    $hook_collectors->put($hook->hookInterface(), $hook);
94
-                } else {
95
-                    $hook_instances->add($hook);
96
-                }
97
-            }
86
+			$hook_collectors = collect();
87
+			$hook_instances = collect();
88
+			foreach ($hooks as $hook) {
89
+				if (!($hook instanceof HookInterface)) {
90
+					continue;
91
+				}
92
+				if ($hook instanceof HookCollectorInterface) {
93
+					$hook_collectors->put($hook->hookInterface(), $hook);
94
+				} else {
95
+					$hook_instances->add($hook);
96
+				}
97
+			}
98 98
 
99
-            foreach ($hook_collectors as $hook_interface => $hook_collector) {
100
-                $hook_info = $hooks_info->get($hook_collector->name()) ?? collect();
101
-                foreach (
102
-                    $hook_instances->filter(
103
-                        fn(HookInterface $hook): bool => $hook instanceof $hook_interface
104
-                    ) as $hook_instance
105
-                ) {
106
-                    $hook_module_info = $hook_info->get($hook_instance->module()->name(), collect())->first();
107
-                    $hook_order = $hook_module_info instanceof stdClass ? (int) $hook_module_info->majho_hook_order : 0;
108
-                    $hook_collector->register($hook_instance, $hook_order);
109
-                }
110
-            }
111
-            return $hook_collectors;
112
-        });
113
-    }
99
+			foreach ($hook_collectors as $hook_interface => $hook_collector) {
100
+				$hook_info = $hooks_info->get($hook_collector->name()) ?? collect();
101
+				foreach (
102
+					$hook_instances->filter(
103
+						fn(HookInterface $hook): bool => $hook instanceof $hook_interface
104
+					) as $hook_instance
105
+				) {
106
+					$hook_module_info = $hook_info->get($hook_instance->module()->name(), collect())->first();
107
+					$hook_order = $hook_module_info instanceof stdClass ? (int) $hook_module_info->majho_hook_order : 0;
108
+					$hook_collector->register($hook_instance, $hook_order);
109
+				}
110
+			}
111
+			return $hook_collectors;
112
+		});
113
+	}
114 114
 
115
-    /**
116
-     * Update the order of the modules implementing a hook in the database.
117
-     *
118
-     * @template THook of HookInterface
119
-     * @param HookCollectorInterface<THook> $hook_collector
120
-     * @param ModuleInterface $module
121
-     * @param int $order
122
-     * @return int
123
-     */
124
-    public function updateOrder(HookCollectorInterface $hook_collector, ModuleInterface $module, int $order): int
125
-    {
126
-        return DB::table('maj_hook_order')
127
-            ->upsert([
128
-                'majho_module_name' =>  $module->name(),
129
-                'majho_hook_name'   =>  $hook_collector->name(),
130
-                'majho_hook_order'  =>  $order
131
-            ], ['majho_module_name', 'majho_hook_name'], ['majho_hook_order']);
132
-    }
115
+	/**
116
+	 * Update the order of the modules implementing a hook in the database.
117
+	 *
118
+	 * @template THook of HookInterface
119
+	 * @param HookCollectorInterface<THook> $hook_collector
120
+	 * @param ModuleInterface $module
121
+	 * @param int $order
122
+	 * @return int
123
+	 */
124
+	public function updateOrder(HookCollectorInterface $hook_collector, ModuleInterface $module, int $order): int
125
+	{
126
+		return DB::table('maj_hook_order')
127
+			->upsert([
128
+				'majho_module_name' =>  $module->name(),
129
+				'majho_hook_name'   =>  $hook_collector->name(),
130
+				'majho_hook_order'  =>  $order
131
+			], ['majho_module_name', 'majho_hook_name'], ['majho_hook_order']);
132
+	}
133 133
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function all(bool $include_disabled = false): Collection
76 76
     {
77
-        return Registry::cache()->array()->remember('all-hooks', function () use ($include_disabled): Collection {
77
+        return Registry::cache()->array()->remember('all-hooks', function() use ($include_disabled): Collection {
78 78
             $hooks_info = DB::table('maj_hook_order')
79 79
                 ->get()
80 80
                 ->groupBy(['majho_hook_name', 'majho_module_name']);
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
                     ) as $hook_instance
105 105
                 ) {
106 106
                     $hook_module_info = $hook_info->get($hook_instance->module()->name(), collect())->first();
107
-                    $hook_order = $hook_module_info instanceof stdClass ? (int) $hook_module_info->majho_hook_order : 0;
107
+                    $hook_order = $hook_module_info instanceof stdClass ? (int)$hook_module_info->majho_hook_order : 0;
108 108
                     $hook_collector->register($hook_instance, $hook_order);
109 109
                 }
110 110
             }
Please login to merge, or discard this patch.
app/Module/MiscExtensions/Hooks/TitlesCardHook.php 2 patches
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -25,68 +25,68 @@
 block discarded – undo
25 25
  */
26 26
 class TitlesCardHook implements NameAccordionExtenderInterface
27 27
 {
28
-    private ModuleInterface $module;
28
+	private ModuleInterface $module;
29 29
 
30
-    /**
31
-     * Constructor for TitlesCardHook
32
-     *
33
-     * @param ModuleInterface $module
34
-     */
35
-    public function __construct(ModuleInterface $module)
36
-    {
37
-        $this->module = $module;
38
-    }
30
+	/**
31
+	 * Constructor for TitlesCardHook
32
+	 *
33
+	 * @param ModuleInterface $module
34
+	 */
35
+	public function __construct(ModuleInterface $module)
36
+	{
37
+		$this->module = $module;
38
+	}
39 39
 
40
-    /**
41
-     * {@inheritDoc}
42
-     * @see \MyArtJaub\Webtrees\Contracts\Hooks\HookInterface::module()
43
-     */
44
-    public function module(): ModuleInterface
45
-    {
46
-        return $this->module;
47
-    }
40
+	/**
41
+	 * {@inheritDoc}
42
+	 * @see \MyArtJaub\Webtrees\Contracts\Hooks\HookInterface::module()
43
+	 */
44
+	public function module(): ModuleInterface
45
+	{
46
+		return $this->module;
47
+	}
48 48
 
49
-    /**
50
-     * {@inheritDoc}
51
-     * @see \MyArtJaub\Webtrees\Contracts\Hooks\NameAccordionExtenderInterface::accordionCard()
52
-     */
53
-    public function accordionCard(Individual $individual): string
54
-    {
55
-        $title_separator = $this->module->getPreference('MAJ_TITLE_PREFIX');
56
-        if ($title_separator === '') {
57
-            return '';
58
-        }
49
+	/**
50
+	 * {@inheritDoc}
51
+	 * @see \MyArtJaub\Webtrees\Contracts\Hooks\NameAccordionExtenderInterface::accordionCard()
52
+	 */
53
+	public function accordionCard(Individual $individual): string
54
+	{
55
+		$title_separator = $this->module->getPreference('MAJ_TITLE_PREFIX');
56
+		if ($title_separator === '') {
57
+			return '';
58
+		}
59 59
 
60
-        $titles = $this->individualTitles($individual, '/(.*?) ((' . $title_separator .  ')(.*))/i');
60
+		$titles = $this->individualTitles($individual, '/(.*?) ((' . $title_separator .  ')(.*))/i');
61 61
 
62
-        return count($titles) === 0 ? '' :
63
-            view($this->module()->name() . '::components/card-titles', [ 'titles' => $titles ]);
64
-    }
62
+		return count($titles) === 0 ? '' :
63
+			view($this->module()->name() . '::components/card-titles', [ 'titles' => $titles ]);
64
+	}
65 65
 
66
-    /**
67
-     * Extract the individual titles from the TITL tags.
68
-     * Split the title based on a pattern to identify the title and the land it refers to.
69
-     *
70
-     * @param Individual $individual
71
-     * @param string $pattern
72
-     * @return array<string, string[]>
73
-     */
74
-    protected function individualTitles(Individual $individual, string $pattern): array
75
-    {
76
-        $titles_list = [];
77
-        /** @var \Illuminate\Support\Collection<string> $titles */
78
-        $titles = $individual->facts(['TITL'])
79
-            ->sortByDesc(fn(Fact $fact) => $fact->date()->julianDay())
80
-            ->map(fn(Fact $fact) => $fact->value());
66
+	/**
67
+	 * Extract the individual titles from the TITL tags.
68
+	 * Split the title based on a pattern to identify the title and the land it refers to.
69
+	 *
70
+	 * @param Individual $individual
71
+	 * @param string $pattern
72
+	 * @return array<string, string[]>
73
+	 */
74
+	protected function individualTitles(Individual $individual, string $pattern): array
75
+	{
76
+		$titles_list = [];
77
+		/** @var \Illuminate\Support\Collection<string> $titles */
78
+		$titles = $individual->facts(['TITL'])
79
+			->sortByDesc(fn(Fact $fact) => $fact->date()->julianDay())
80
+			->map(fn(Fact $fact) => $fact->value());
81 81
 
82
-        foreach ($titles as $title) {
83
-            if (preg_match($pattern, $title, $match) === 1) {
84
-                /** @var array<int, string> $match */
85
-                $titles_list[$match[1]][] = trim($match[2]);
86
-            } else {
87
-                $titles_list[$title][] = '';
88
-            }
89
-        }
90
-        return $titles_list;
91
-    }
82
+		foreach ($titles as $title) {
83
+			if (preg_match($pattern, $title, $match) === 1) {
84
+				/** @var array<int, string> $match */
85
+				$titles_list[$match[1]][] = trim($match[2]);
86
+			} else {
87
+				$titles_list[$title][] = '';
88
+			}
89
+		}
90
+		return $titles_list;
91
+	}
92 92
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,10 +57,9 @@
 block discarded – undo
57 57
             return '';
58 58
         }
59 59
 
60
-        $titles = $this->individualTitles($individual, '/(.*?) ((' . $title_separator .  ')(.*))/i');
60
+        $titles = $this->individualTitles($individual, '/(.*?) (('.$title_separator.')(.*))/i');
61 61
 
62
-        return count($titles) === 0 ? '' :
63
-            view($this->module()->name() . '::components/card-titles', [ 'titles' => $titles ]);
62
+        return count($titles) === 0 ? '' : view($this->module()->name().'::components/card-titles', ['titles' => $titles]);
64 63
     }
65 64
 
66 65
     /**
Please login to merge, or discard this patch.
app/Module/MiscExtensions/Http/RequestHandlers/AdminConfigAction.php 2 patches
Indentation   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -27,43 +27,43 @@
 block discarded – undo
27 27
  */
28 28
 class AdminConfigAction implements RequestHandlerInterface
29 29
 {
30
-    private ?MiscExtensionsModule $module;
30
+	private ?MiscExtensionsModule $module;
31 31
 
32
-    /**
33
-     * Constructor for AdminConfigPage Request Handler
34
-     *
35
-     * @param ModuleService $module_service
36
-     */
37
-    public function __construct(ModuleService $module_service)
38
-    {
39
-        $this->module = $module_service->findByInterface(MiscExtensionsModule::class)->first();
40
-    }
32
+	/**
33
+	 * Constructor for AdminConfigPage Request Handler
34
+	 *
35
+	 * @param ModuleService $module_service
36
+	 */
37
+	public function __construct(ModuleService $module_service)
38
+	{
39
+		$this->module = $module_service->findByInterface(MiscExtensionsModule::class)->first();
40
+	}
41 41
 
42
-    /**
43
-     * {@inheritDoc}
44
-     * @see \Psr\Http\Server\RequestHandlerInterface::handle()
45
-     */
46
-    public function handle(ServerRequestInterface $request): ResponseInterface
47
-    {
48
-        if ($this->module === null) {
49
-            FlashMessages::addMessage(
50
-                I18N::translate('The attached module could not be found.'),
51
-                'danger'
52
-            );
53
-            return redirect(route(AdminConfigPage::class));
54
-        }
42
+	/**
43
+	 * {@inheritDoc}
44
+	 * @see \Psr\Http\Server\RequestHandlerInterface::handle()
45
+	 */
46
+	public function handle(ServerRequestInterface $request): ResponseInterface
47
+	{
48
+		if ($this->module === null) {
49
+			FlashMessages::addMessage(
50
+				I18N::translate('The attached module could not be found.'),
51
+				'danger'
52
+			);
53
+			return redirect(route(AdminConfigPage::class));
54
+		}
55 55
 
56
-        $params = (array) $request->getParsedBody();
56
+		$params = (array) $request->getParsedBody();
57 57
 
58
-        $this->module->setPreference('MAJ_TITLE_PREFIX', $params['MAJ_TITLE_PREFIX'] ?? '');
59
-        $this->module->setPreference('MAJ_DISPLAY_CNIL', $params['MAJ_DISPLAY_CNIL'] ?? '');
60
-        $this->module->setPreference('MAJ_CNIL_REFERENCE', $params['MAJ_CNIL_REFERENCE' ?? '']);
58
+		$this->module->setPreference('MAJ_TITLE_PREFIX', $params['MAJ_TITLE_PREFIX'] ?? '');
59
+		$this->module->setPreference('MAJ_DISPLAY_CNIL', $params['MAJ_DISPLAY_CNIL'] ?? '');
60
+		$this->module->setPreference('MAJ_CNIL_REFERENCE', $params['MAJ_CNIL_REFERENCE' ?? '']);
61 61
 
62
-        FlashMessages::addMessage(
63
-            I18N::translate('The preferences for the module “%s” have been updated.', $this->module->title()),
64
-            'success'
65
-        );
62
+		FlashMessages::addMessage(
63
+			I18N::translate('The preferences for the module “%s” have been updated.', $this->module->title()),
64
+			'success'
65
+		);
66 66
 
67
-        return redirect(route(AdminConfigPage::class));
68
-    }
67
+		return redirect(route(AdminConfigPage::class));
68
+	}
69 69
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
             return redirect(route(AdminConfigPage::class));
54 54
         }
55 55
 
56
-        $params = (array) $request->getParsedBody();
56
+        $params = (array)$request->getParsedBody();
57 57
 
58 58
         $this->module->setPreference('MAJ_TITLE_PREFIX', $params['MAJ_TITLE_PREFIX'] ?? '');
59 59
         $this->module->setPreference('MAJ_DISPLAY_CNIL', $params['MAJ_DISPLAY_CNIL'] ?? '');
Please login to merge, or discard this patch.