Completed
Push — feature/code-analysis ( 820b23...92a398 )
by Jonathan
04:40 queued 01:48
created
src/Webtrees/Module/Hooks/AdminConfigController.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -34,26 +34,26 @@  discard block
 block discarded – undo
34 34
      * Manage updates sent from the AdminConfig@index form.
35 35
      */
36 36
     protected function update() {
37
-        if(Auth::isAdmin()){
37
+        if (Auth::isAdmin()) {
38 38
             $ihooks = HookProvider::getInstance()->getInstalledHooks();
39 39
             	
40
-            $module_names= Database::prepare(
40
+            $module_names = Database::prepare(
41 41
                 "SELECT module_name FROM `##module` WHERE status='disabled'"
42 42
             )->fetchOneColumn();
43 43
             	
44
-            if($ihooks !== null){
44
+            if ($ihooks !== null) {
45 45
                 foreach ($ihooks as $ihook => $params) {
46
-                    if(Filter::post('hook-' . $params['id']) === 'yes') {                    
46
+                    if (Filter::post('hook-'.$params['id']) === 'yes') {                    
47 47
                         $array_hook = explode('#', $ihook);
48 48
                         //Update status
49
-                        $new_status= Filter::postBool('status-' . $params['id']);
50
-                        if(in_array($array_hook[0], $module_names)) $new_status = false;
49
+                        $new_status = Filter::postBool('status-'.$params['id']);
50
+                        if (in_array($array_hook[0], $module_names)) $new_status = false;
51 51
                         $previous_status = $params['status'];
52 52
                         if ($new_status !== null) {
53
-                            $new_status= $new_status ? 'enabled' : 'disabled';
54
-                            if($new_status != $previous_status){
53
+                            $new_status = $new_status ? 'enabled' : 'disabled';
54
+                            if ($new_status != $previous_status) {
55 55
                                 $chook = new Hook($array_hook[1], $array_hook[2]);
56
-                                switch($new_status){
56
+                                switch ($new_status) {
57 57
                                     case 'enabled':
58 58
                                         $chook->enable($array_hook[0]);
59 59
                                         break;
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
                         $new_priority = Filter::postInteger("moduleorder-{$params['id']}");
71 71
                         $previous_priority = $params['priority'];
72 72
                         if ($new_priority !== null) {
73
-                            if($new_priority != $previous_priority){
73
+                            if ($new_priority != $previous_priority) {
74 74
                                 $chook = new Hook($array_hook[1], $array_hook[2]);
75 75
                                 $chook->setPriority($array_hook[0], $new_priority);
76 76
                             }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         HookProvider::getInstance()->updateHooks();
93 93
         
94 94
         $action = Filter::post('action');        
95
-        if($action == 'update' && Filter::checkCsrf()) $this->update();
95
+        if ($action == 'update' && Filter::checkCsrf()) $this->update();
96 96
         
97 97
         Theme::theme(new AdministrationTheme)->init(Globals::getTree());        
98 98
         $ctrl = new PageController();
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             ->restrictAccess(Auth::isAdmin())
101 101
             ->setPageTitle($this->module->getTitle());
102 102
         
103
-        $table_id = 'table-installedhooks-' . Uuid::uuid4();
103
+        $table_id = 'table-installedhooks-'.Uuid::uuid4();
104 104
 
105 105
         $view_bag = new ViewBag();
106 106
         $view_bag->set('title', $ctrl->getPageTitle());
Please login to merge, or discard this patch.
src/Webtrees/Module/MiscExtensionsModule.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      * @see \Fisharebest\Webtrees\Module\ModuleConfigInterface::getConfigLink()
64 64
      */
65 65
     public function getConfigLink() {
66
-        return 'module.php?mod=' . $this->getName() . '&mod_action=AdminConfig';
66
+        return 'module.php?mod='.$this->getName().'&mod_action=AdminConfig';
67 67
     }
68 68
     
69 69
     /**
@@ -92,19 +92,19 @@  discard block
 block discarded – undo
92 92
 	    $res = '';
93 93
 	    $dindi = new Individual($ctrlIndi->getSignificantIndividual());
94 94
 	    $titles = $dindi->getTitles();
95
-	    if(count($titles)>0){
95
+	    if (count($titles) > 0) {
96 96
 	        $res = '
97 97
 	            <dl>
98 98
 	               <dt class="label">'.I18N::translate('Titles').'</dt>';
99
-            foreach($titles as $title=>$props){
99
+            foreach ($titles as $title=>$props) {
100 100
                 $res .= 
101
-                    '<dd class="field">' . $title. ' ' .
102
-                    FunctionsPrint::getListFromArray($props) .
101
+                    '<dd class="field">'.$title.' '.
102
+                    FunctionsPrint::getListFromArray($props).
103 103
                     '</dd>';
104 104
             }
105
-            $res .=  '</dl>';
105
+            $res .= '</dl>';
106 106
         }
107
-	    return array( 'indi-header-titles' , $res);	    
107
+	    return array('indi-header-titles', $res);	    
108 108
 	}
109 109
 	
110 110
 	/**
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
 	 */
120 120
 	public function hPrintHeader() {
121 121
 	    $html = '';
122
-	    if($this->getSetting('MAJ_ADD_HTML_HEADER', 0) == 1){
123
-	        if(Auth::accessLevel(Globals::getTree()) >= $this->getSetting('MAJ_SHOW_HTML_HEADER', Auth::PRIV_HIDE)  && !Filter::getBool('noheader')){
122
+	    if ($this->getSetting('MAJ_ADD_HTML_HEADER', 0) == 1) {
123
+	        if (Auth::accessLevel(Globals::getTree()) >= $this->getSetting('MAJ_SHOW_HTML_HEADER', Auth::PRIV_HIDE) && !Filter::getBool('noheader')) {
124 124
 	            $html .= $this->getSetting('MAJ_HTML_HEADER', '');
125 125
 	        }
126 126
 	    }	
@@ -134,11 +134,11 @@  discard block
 block discarded – undo
134 134
 	public function hPrintFooter() {
135 135
 	    $wt_tree = Globals::getTree();
136 136
 	    $html = '';
137
-	    if($this->getSetting('MAJ_DISPLAY_CNIL', 0) == 1){
137
+	    if ($this->getSetting('MAJ_DISPLAY_CNIL', 0) == 1) {
138 138
 	        $html .= '<br/>';
139 139
 	        $html .= '<div class="center">';
140 140
 	        $cnil_ref = $this->getSetting('MAJ_CNIL_REFERENCE', '');
141
-	        if($cnil_ref != ''){
141
+	        if ($cnil_ref != '') {
142 142
 	            $html .= I18N::translate('This site has been notified to the French National Commission for Data protection (CNIL) and registered under number %s. ', $cnil_ref);
143 143
 	        }
144 144
 	        $html .= I18N::translate('In accordance with the French Data protection Act (<em>Loi Informatique et Libertés</em>) of January 6th, 1978, you have the right to access, modify, rectify and delete personal information that pertains to you. To exercice this right, please contact %s, and provide your name, address and a proof of your identity.',
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
146 146
 	        $html .= '</div>';
147 147
 	    }
148 148
 	    
149
-	    if($this->getSetting('MAJ_ADD_HTML_FOOTER', 0) == 1){
150
-	        if(Auth::accessLevel($wt_tree) >= $this->getSetting('MAJ_SHOW_HTML_FOOTER', Auth::PRIV_HIDE)  && !Filter::getBool('nofooter')){
149
+	    if ($this->getSetting('MAJ_ADD_HTML_FOOTER', 0) == 1) {
150
+	        if (Auth::accessLevel($wt_tree) >= $this->getSetting('MAJ_SHOW_HTML_FOOTER', Auth::PRIV_HIDE) && !Filter::getBool('nofooter')) {
151 151
 	            $html .= $this->getSetting('MAJ_HTML_FOOTER', '');
152 152
 	        }
153 153
 	    }
Please login to merge, or discard this patch.
src/Webtrees/Module/GeoDispersionModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     public function getConfigLink() {
69 69
         Database::updateSchema(self::SCHEMA_MIGRATION_PREFIX, self::SCHEMA_SETTING_NAME, self::SCHEMA_TARGET_VERSION);
70 70
         
71
-        return 'module.php?mod=' . $this->getName() . '&amp;mod_action=AdminConfig';
71
+        return 'module.php?mod='.$this->getName().'&amp;mod_action=AdminConfig';
72 72
     }
73 73
     
74 74
     /**
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 * @return \MyArtJaub\Webtrees\Module\GeoDispersion\Model\GeoAnalysisProvider
92 92
 	 */
93 93
     public function getProvider() {
94
-        if(!$this->provider) {
94
+        if (!$this->provider) {
95 95
             $this->provider = new GeoAnalysisProvider(Globals::getTree());
96 96
         }
97 97
         return $this->provider;
Please login to merge, or discard this patch.
src/Webtrees/Functions/FunctionsPrint.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * @return string List of elements
33 33
 	 */
34 34
 	public static function getListFromArray(array $array) {
35
-		$n=count($array);
35
+		$n = count($array);
36 36
 		switch ($n) {
37 37
 			case 0:
38 38
 				return '';
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
 			default:
42 42
 				return implode(
43 43
 						/* I18N: list separator */ I18N::translate(', '), 
44
-						array_slice($array, 0, $n-1)
45
-					) .
46
-					/* I18N: last list separator, " and " in English, " et " in French  */ I18N::translate(' and ') . 
47
-					$array[$n-1];
44
+						array_slice($array, 0, $n - 1)
45
+					).
46
+					/* I18N: last list separator, " and " in English, " et " in French  */ I18N::translate(' and '). 
47
+					$array[$n - 1];
48 48
 		}
49 49
 	}
50 50
 
@@ -60,10 +60,10 @@  discard block
 block discarded – undo
60 60
 			\MyArtJaub\Webtrees\Map\MapProviderInterface $mapProvider
61 61
 	) {
62 62
 		$place = $fact->getPlace();
63
-		if(!$place->isEmpty()) {
64
-			$iconPlace= $mapProvider->getPlaceIcon($place);	
65
-			if($iconPlace && strlen($iconPlace) > 0){
66
-				return	'<div class="fact_flag">'. self::htmlPlaceIcon($place, $iconPlace, 50). '</div>';
63
+		if (!$place->isEmpty()) {
64
+			$iconPlace = $mapProvider->getPlaceIcon($place);	
65
+			if ($iconPlace && strlen($iconPlace) > 0) {
66
+				return	'<div class="fact_flag">'.self::htmlPlaceIcon($place, $iconPlace, 50).'</div>';
67 67
 			}
68 68
 		}
69 69
 		return '';
@@ -77,8 +77,8 @@  discard block
 block discarded – undo
77 77
 	 * @param number $size
78 78
 	 * @return string HTML code of the inserted flag
79 79
 	 */
80
-	public static function htmlPlaceIcon(\Fisharebest\Webtrees\Place $place, $icon_path , $size = 50) {
81
-	    return '<img class="flag_gm_h'. $size . '" src="' . $icon_path . '" title="' . $place->getGedcomName() . '" alt="' . $place->getGedcomName() . '" />';
80
+	public static function htmlPlaceIcon(\Fisharebest\Webtrees\Place $place, $icon_path, $size = 50) {
81
+	    return '<img class="flag_gm_h'.$size.'" src="'.$icon_path.'" title="'.$place->getGedcomName().'" alt="'.$place->getGedcomName().'" />';
82 82
 	}
83 83
 	
84 84
 	/**
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 		$minimum = PHP_INT_MAX;
97 97
 		$maximum = 1;
98 98
 		foreach ($list as $params) {
99
-			if(array_key_exists('count', $params)) {
99
+			if (array_key_exists('count', $params)) {
100 100
 				$maximum = max($maximum, $params['count']);
101 101
 				$minimum = min($minimum, $params['count']);
102 102
 			}
@@ -114,15 +114,15 @@  discard block
 block discarded – undo
114 114
 				$size = 75.0 + 125.0 * ($count - $minimum) / ($maximum - $minimum);
115 115
 			}
116 116
 			
117
-			$html .= '<a style="font-size:' . $size . '%" href="' . $url . '">';
117
+			$html .= '<a style="font-size:'.$size.'%" href="'.$url.'">';
118 118
 			if ($totals) {
119
-				$html .= I18N::translate('%1$s (%2$s)', '<span dir="auto">' . $text . '</span>', I18N::number($count));
119
+				$html .= I18N::translate('%1$s (%2$s)', '<span dir="auto">'.$text.'</span>', I18N::number($count));
120 120
 			} else {
121 121
 				$html .= $text;
122 122
 			}
123 123
 			$html .= '</a>';
124 124
 		}
125
-		return '<div class="tag_cloud">' . $html . '</div>';
125
+		return '<div class="tag_cloud">'.$html.'</div>';
126 126
 	}
127 127
 	
128 128
 
@@ -157,11 +157,11 @@  discard block
 block discarded – undo
157 157
 	 * @param bool $isStrong Bolden the name ?
158 158
 	 * @return string HTML Code for individual item
159 159
 	 */
160
-	public static function htmlIndividualForList(\Fisharebest\Webtrees\Individual $individual, $isStrong = true){
160
+	public static function htmlIndividualForList(\Fisharebest\Webtrees\Individual $individual, $isStrong = true) {
161 161
 		$html = '';
162 162
 		$tag = 'em';
163
-		if($isStrong) $tag = 'strong';
164
-		if($individual && $individual->canShow()){
163
+		if ($isStrong) $tag = 'strong';
164
+		if ($individual && $individual->canShow()) {
165 165
 			$dindi = new Individual($individual);
166 166
 			$html = $individual->getSexImage();
167 167
 			$html .= '<a class="list_item" href="'.
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 			$html .= '</a>';
177 177
 		}
178 178
 		else {
179
-			$html .= '<span class=\"list_item\"><'.$tag.'>' . I18N::translate('Private') . '</'.$tag.'></span>';
179
+			$html .= '<span class=\"list_item\"><'.$tag.'>'.I18N::translate('Private').'</'.$tag.'></span>';
180 180
 		}
181 181
 		return $html;
182 182
 	}
@@ -188,20 +188,20 @@  discard block
 block discarded – undo
188 188
 	 * @param boolean $anchor option to print a link to calendar
189 189
 	 * @return string HTML code for short date
190 190
 	 */
191
-	public static function formatFactDateShort(\Fisharebest\Webtrees\Fact $fact, $anchor=false) {
192
-		$html='';
191
+	public static function formatFactDateShort(\Fisharebest\Webtrees\Fact $fact, $anchor = false) {
192
+		$html = '';
193 193
 		$date = $fact->getDate();
194
-		if($date->isOK()){
195
-			$html.=' '.$date->Display($anchor && !Globals::isSearchSpider(), '%Y');
194
+		if ($date->isOK()) {
195
+			$html .= ' '.$date->Display($anchor && !Globals::isSearchSpider(), '%Y');
196 196
 		}
197
-		else{
197
+		else {
198 198
 			// 1 DEAT Y with no DATE => print YES
199 199
 			// 1 BIRT 2 SOUR @S1@ => print YES
200 200
 			// 1 DEAT N is not allowed
201 201
 			// It is not proper GEDCOM form to use a N(o) value with an event tag to infer that it did not happen.
202 202
 			$factdetail = explode(' ', trim($fact->getGedcom()));
203 203
 			if (isset($factdetail) && (count($factdetail) == 3 && strtoupper($factdetail[2]) == 'Y') || (count($factdetail) == 4 && $factdetail[2] == 'SOUR')) {
204
-				$html.=I18N::translate('yes');
204
+				$html .= I18N::translate('yes');
205 205
 			}
206 206
 		}
207 207
 		return $html;
@@ -215,12 +215,12 @@  discard block
 block discarded – undo
215 215
 	 * @param boolean $anchor option to print a link to placelist
216 216
 	 * @return string HTML code for short place
217 217
 	 */
218
-	public static function formatFactPlaceShort(\Fisharebest\Webtrees\Fact $fact, $format, $anchor=false){
219
-		$html='';
218
+	public static function formatFactPlaceShort(\Fisharebest\Webtrees\Fact $fact, $format, $anchor = false) {
219
+		$html = '';
220 220
 		
221 221
 		if ($fact === null) return $html;
222 222
 		$place = $fact->getPlace();
223
-		if($place){
223
+		if ($place) {
224 224
 			$dplace = new Place($place);
225 225
 			$html .= $dplace->htmlFormattedName($format, $anchor);
226 226
 		}
@@ -238,21 +238,21 @@  discard block
 block discarded – undo
238 238
 	 * @param string $size CSS size for the icon. A CSS style css_$size is required
239 239
 	 * @return string HTML code for the formatted Sosa numbers
240 240
 	 */
241
-	public static function formatSosaNumbers(array $sosatab, $format = 1, $size = 'small'){
241
+	public static function formatSosaNumbers(array $sosatab, $format = 1, $size = 'small') {
242 242
 		$html = '';
243
-		switch($format){
243
+		switch ($format) {
244 244
 			case 1:
245
-				if(count($sosatab)>0){
245
+				if (count($sosatab) > 0) {
246 246
 					$html = '<i class="icon-maj-sosa_'.$size.'" title="'.I18N::translate('Sosa').'"></i>';
247 247
 				}
248 248
 				break;
249 249
 			case 2:
250
-				if(count($sosatab)>0){
250
+				if (count($sosatab) > 0) {
251 251
 					ksort($sosatab);
252 252
 					$tmp_html = array();
253 253
 					foreach ($sosatab as $sosa => $gen) {
254 254
 						$tmp_html[] = sprintf(
255
-								'<i class="icon-maj-sosa_%1$s" title="'.I18N::translate('Sosa').'"></i>&nbsp;<strong>%2$d&nbsp;'.I18N::translate('(G%s)', $gen) .'</strong>',
255
+								'<i class="icon-maj-sosa_%1$s" title="'.I18N::translate('Sosa').'"></i>&nbsp;<strong>%2$d&nbsp;'.I18N::translate('(G%s)', $gen).'</strong>',
256 256
 								$size,
257 257
 								$sosa
258 258
 							);
@@ -278,15 +278,15 @@  discard block
 block discarded – undo
278 278
 	 * @param string $size CSS size for the icon. A CSS style css_$size is required
279 279
 	 * @return string HTML code for IsSourced icon
280 280
 	 */
281
-	public static function formatIsSourcedIcon($sourceType, $isSourced, $tag='EVEN', $format = 1, $size='normal'){
282
-		$html='';
283
-		$image=null;
284
-		$title=null;
285
-		switch($format){
281
+	public static function formatIsSourcedIcon($sourceType, $isSourced, $tag = 'EVEN', $format = 1, $size = 'normal') {
282
+		$html = '';
283
+		$image = null;
284
+		$title = null;
285
+		switch ($format) {
286 286
 			case 1:
287
-				switch($sourceType){
287
+				switch ($sourceType) {
288 288
 					case 'E':
289
-						switch($isSourced){
289
+						switch ($isSourced) {
290 290
 							case 0:
291 291
 								$image = 'event_unknown';
292 292
 								$title = I18N::translate('%s not found', GedcomTag::getLabel($tag));
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 						}
317 317
 						break;
318 318
 					case 'R':
319
-						switch($isSourced){
319
+						switch ($isSourced) {
320 320
 							case -1:
321 321
 								$image = 'record_notsourced';
322 322
 								$title = I18N::translate('%s not sourced', GedcomTag::getLabel($tag));
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 					default:
337 337
 						break;
338 338
 				}
339
-				if($image && $title) $html = '<i class="icon-maj-sourced-'.$size.'_'.$image.'" title="'.$title.'"></i>';
339
+				if ($image && $title) $html = '<i class="icon-maj-sourced-'.$size.'_'.$image.'" title="'.$title.'"></i>';
340 340
 				break;
341 341
 			default:
342 342
 				break;
Please login to merge, or discard this patch.
src/Webtrees/GedcomRecord.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -23,14 +23,14 @@  discard block
 block discarded – undo
23 23
 	protected $gedcomrecord;
24 24
 
25 25
 	/** @var bool Is the GedcomRecord sourced (cache) */ 
26
-	protected $_issourced=null;
26
+	protected $_issourced = null;
27 27
 
28 28
 	/**
29 29
 	 * Contructor for the decorator
30 30
 	 *
31 31
 	 * @param \Fisharebest\Webtrees\GedcomRecord $gedcomrecord_in The GedcomRecord to extend
32 32
 	 */
33
-	public function __construct(\Fisharebest\Webtrees\GedcomRecord $gedcomrecord_in){
33
+	public function __construct(\Fisharebest\Webtrees\GedcomRecord $gedcomrecord_in) {
34 34
 		$this->gedcomrecord = $gedcomrecord_in;
35 35
 	}
36 36
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	 *
40 40
 	 * @return \Fisharebest\Webtrees\GedcomRecord Embedded gedcom record
41 41
 	 */
42
-	public function getDerivedRecord(){
42
+	public function getDerivedRecord() {
43 43
 		return $this->gedcomrecord;
44 44
 	}
45 45
 	
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 			if (($fact->getDate() || $fact->getPlace()) && $fact->canShow()) {
71 71
 				switch ($style) {
72 72
 					case 10:
73
-					    return '<i>'.$fact->getLabel().' '. \MyArtJaub\Webtrees\Functions\FunctionsPrint::formatFactDateShort($fact) .'&nbsp;'. MyArtJaub\Webtrees\Functions\FunctionsPrint::formatFactPlaceShort($fact, '%1') .'</i>';
73
+					    return '<i>'.$fact->getLabel().' '.\MyArtJaub\Webtrees\Functions\FunctionsPrint::formatFactDateShort($fact).'&nbsp;'.MyArtJaub\Webtrees\Functions\FunctionsPrint::formatFactPlaceShort($fact, '%1').'</i>';
74 74
 					default:
75 75
 						return $this->gedcomrecord->formatFirstMajorFact($facts, $style);
76 76
 				}
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 	 * @param int $access_level
86 86
 	 * @return boolean
87 87
 	 */
88
-	public function canDisplayIsSourced($access_level = null){
89
-		if(!$this->gedcomrecord->canShow($access_level)) return false;
90
-		if($access_level === null )
88
+	public function canDisplayIsSourced($access_level = null) {
89
+		if (!$this->gedcomrecord->canShow($access_level)) return false;
90
+		if ($access_level === null)
91 91
 		    $access_level = \Fisharebest\Webtrees\Auth::accessLevel($this->gedcomrecord->getTree());
92 92
 
93 93
 		$global_facts = Globals::getGlobalFacts();
@@ -107,14 +107,14 @@  discard block
 block discarded – undo
107 107
 	 *
108 108
 	 * @return int Level of sources
109 109
 	 */
110
-	public function isSourced(){
111
-		if($this->_issourced !== null) return $this->_issourced;
112
-		$this->_issourced=-1;
110
+	public function isSourced() {
111
+		if ($this->_issourced !== null) return $this->_issourced;
112
+		$this->_issourced = -1;
113 113
 		$sourcesfacts = $this->gedcomrecord->getFacts('SOUR');
114
-		foreach($sourcesfacts as $sourcefact){
115
-			$this->_issourced=max($this->_issourced, 1);
116
-			if($sourcefact->getAttribute('_ACT')){
117
-				$this->_issourced=max($this->_issourced, 2);
114
+		foreach ($sourcesfacts as $sourcefact) {
115
+			$this->_issourced = max($this->_issourced, 1);
116
+			if ($sourcefact->getAttribute('_ACT')) {
117
+				$this->_issourced = max($this->_issourced, 2);
118 118
 			}
119 119
 		}
120 120
 		return $this->_issourced;
@@ -126,19 +126,19 @@  discard block
 block discarded – undo
126 126
 	 * @param string $eventslist
127 127
 	 * @return int Level of sources
128 128
 	 */
129
-	public function isFactSourced($eventslist){
130
-	    if(empty($eventslist)) return 0;
131
-		$isSourced=0;
129
+	public function isFactSourced($eventslist) {
130
+	    if (empty($eventslist)) return 0;
131
+		$isSourced = 0;
132 132
 		$facts = $this->gedcomrecord->getFacts($eventslist);
133
-		foreach($facts as $fact){
134
-			if($isSourced < Fact::MAX_IS_SOURCED_LEVEL){
133
+		foreach ($facts as $fact) {
134
+			if ($isSourced < Fact::MAX_IS_SOURCED_LEVEL) {
135 135
 				$dfact = new Fact($fact);
136 136
 				$tmpIsSourced = $dfact->isSourced();
137
-				if($tmpIsSourced != 0) {
138
-					if($isSourced==0) {
139
-						$isSourced =  $tmpIsSourced;
137
+				if ($tmpIsSourced != 0) {
138
+					if ($isSourced == 0) {
139
+						$isSourced = $tmpIsSourced;
140 140
 					}
141
-					else{
141
+					else {
142 142
 						$isSourced = max($isSourced, $tmpIsSourced);
143 143
 					}
144 144
 				}
Please login to merge, or discard this patch.