Completed
Push — feature/code-analysis ( 820b23...92a398 )
by Jonathan
04:40 queued 01:48
created
src/Webtrees/Module/IsSourcedModule.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * @see \MyArtJaub\Webtrees\Hook\HookInterfaces\IndividualHeaderExtenderInterface::hExtendIndiHeaderIcons()
64 64
 	 */
65 65
 	public function hExtendIndiHeaderIcons(IndividualController $ctrlIndi) {
66
-	    if($ctrlIndi){
66
+	    if ($ctrlIndi) {
67 67
 	        $dindi = new Individual($ctrlIndi->getSignificantIndividual());
68 68
 	        if ($dindi->canDisplayIsSourced()) 
69 69
 	            return FunctionsPrint::formatIsSourcedIcon('R', $dindi->isSourced(), 'INDI', 1, 'large');
@@ -87,19 +87,19 @@  discard block
 block discarded – undo
87 87
 	 * {@inheritDoc}
88 88
 	 * @see \MyArtJaub\Webtrees\Hook\HookInterfaces\RecordNameTextExtenderInterface::hRecordNamePrepend()
89 89
 	 */
90
-	public function hRecordNamePrepend(GedcomRecord $grec, $size){ }
90
+	public function hRecordNamePrepend(GedcomRecord $grec, $size) { }
91 91
 	
92 92
 	/**
93 93
 	 * {@inheritDoc}
94 94
 	 * @see \MyArtJaub\Webtrees\Hook\HookInterfaces\RecordNameTextExtenderInterface::hRecordNameAppend()
95 95
 	 */
96
-	public function hRecordNameAppend(GedcomRecord $grec, $size = 'small'){
96
+	public function hRecordNameAppend(GedcomRecord $grec, $size = 'small') {
97 97
 	    $html = '';
98
-	    if($grec instanceof \Fisharebest\Webtrees\Individual){
98
+	    if ($grec instanceof \Fisharebest\Webtrees\Individual) {
99 99
 	        $dindi = new Individual($grec);
100 100
 	        $html .= FunctionsPrint::formatIsSourcedIcon('R', $dindi->isSourced(), 'INDI', 1, $size);
101 101
 	        $html .= FunctionsPrint::formatIsSourcedIcon('E', $dindi->isBirthSourced(), 'BIRT', 1, $size);
102
-	        if($grec->isDead())
102
+	        if ($grec->isDead())
103 103
 	            $html .= FunctionsPrint::formatIsSourcedIcon('E', $dindi->isDeathSourced(), 'DEAT', 1, $size);
104 104
 	    }
105 105
 	    return $html;
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 	 * {@inheritDoc}
118 118
 	 * @see \Fisharebest\Webtrees\Module\ModuleSidebarInterface::hasSidebarContent()
119 119
 	 */
120
-	public function hasSidebarContent(){ 
120
+	public function hasSidebarContent() { 
121 121
 	    return true;
122 122
 	}
123 123
 	
@@ -147,24 +147,24 @@  discard block
 block discarded – undo
147 147
 	            echo '
148 148
 	                <table class="issourcedtable">
149 149
 	                   <tr>
150
-	                       <td class="slabel"> ' . GedcomTag::getLabel('INDI') . '</td>
150
+	                       <td class="slabel"> ' . GedcomTag::getLabel('INDI').'</td>
151 151
 	                       <td class="svalue">' . FunctionsPrint::formatIsSourcedIcon('R', $dindi->isSourced(), 'INDI', 1).'</td>
152 152
 	                   </tr>
153 153
 	                   <tr>
154
-	                       <td class="slabel">' . GedcomTag::getLabel('BIRT') . '</td>
154
+	                       <td class="slabel">' . GedcomTag::getLabel('BIRT').'</td>
155 155
 	                       <td class="svalue">' . FunctionsPrint::formatIsSourcedIcon('E', $dindi->isBirthSourced(), 'BIRT', 1).'</td>
156 156
 	                   </tr>';
157 157
 	            
158 158
 	            $fams = $root->getSpouseFamilies();
159
-	            ($ct = count($fams)) > 1 ? $nb=1 : $nb=' ';	            
160
-	            foreach($fams as $fam){
159
+	            ($ct = count($fams)) > 1 ? $nb = 1 : $nb = ' ';	            
160
+	            foreach ($fams as $fam) {
161 161
 	                $dfam = new Family($fam);
162 162
 	                echo '
163 163
 	                    <tr>
164 164
 	                       <td class="slabel right">
165
-	                           <a href="' . $fam->getHtmlUrl() . '"> '. GedcomTag::getLabel('MARR');
166
-	                if($ct > 1){
167
-	                    echo ' ',$nb;
165
+	                           <a href="' . $fam->getHtmlUrl().'"> '.GedcomTag::getLabel('MARR');
166
+	                if ($ct > 1) {
167
+	                    echo ' ', $nb;
168 168
 	                    $nb++;
169 169
 	                }
170 170
 	                echo '     </a>
@@ -173,10 +173,10 @@  discard block
 block discarded – undo
173 173
 	                   </tr>';
174 174
 	            }
175 175
 	            
176
-	            if( $root->isDead() )
176
+	            if ($root->isDead())
177 177
 	                echo '
178 178
 	                    <tr>
179
-	                       <td class="slabel">' . GedcomTag::getLabel('DEAT') . '</td>
179
+	                       <td class="slabel">' . GedcomTag::getLabel('DEAT').'</td>
180 180
 	                       <td class="svalue">' . FunctionsPrint::formatIsSourcedIcon('E', $dindi->isDeathSourced(), 'DEAT', 1).'</td>
181 181
 	                   </tr>';
182 182
 	            
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListFamView.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 */
35 35
     protected function renderContent() { 
36 36
         
37
-        if($this->data->get('has_sosa', false)) {
37
+        if ($this->data->get('has_sosa', false)) {
38 38
             $table_id = $this->data->get('table_id');            
39 39
         ?>   
40 40
         
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 										class="ui-state-default"
53 53
 										title="<?php echo I18N::translate('Show individuals who are alive or couples where both partners are alive.'); ?>"
54 54
 									>
55
-									<?php echo I18N::translate('Both alive');?>
55
+									<?php echo I18N::translate('Both alive'); ?>
56 56
 									</button>
57 57
 									<button
58 58
 										type="button"
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 										class="ui-state-default"
62 62
 										title="<?php echo I18N::translate('Show couples where only the female partner is dead.'); ?>"
63 63
 									>
64
-									<?php echo I18N::translate('Widower');?>
64
+									<?php echo I18N::translate('Widower'); ?>
65 65
 									</button>
66 66
 									<button
67 67
 										type="button"
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 				</thead>
176 176
 				<tbody>
177 177
 			
178
-			<?php foreach($this->data->get('sosa_list') as $sosa => $family) {
178
+			<?php foreach ($this->data->get('sosa_list') as $sosa => $family) {
179 179
 			    /** @var \Fisharebest\Webtrees\Family $person */
180 180
 
181 181
 			    //PERSO Create decorator for Family
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 			        $wife = new Individual('W', '0 @W@ INDI', null, $family->getTree());
191 191
 			    }
192 192
 			    
193
-			    $mdate=$family->getMarriageDate();
193
+			    $mdate = $family->getMarriageDate();
194 194
 			    
195 195
 			    if ($family->isPendingAddtion()) {
196 196
 			        $class = ' class="new"';
@@ -206,17 +206,17 @@  discard block
 block discarded – undo
206 206
         			<?php list($surn_givn, $givn_surn) = FunctionsPrintLists::sortableNames($husb); ?>
207 207
         			<td colspan="2" data-sort="<?= Filter::escapeHtml($givn_surn) ?>">        			
208 208
         			<?php foreach ($husb->getAllNames() as $num=>$name) {
209
-        				if ($name['type']=='NAME') {
210
-        					$title='';
209
+        				if ($name['type'] == 'NAME') {
210
+        					$title = '';
211 211
         				} else {
212
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $husb)).'"';
212
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $husb)).'"';
213 213
         				}
214
-        				if ($num==$husb->getPrimaryName()) {
215
-        					$class=' class="name2"';
216
-        					$sex_image=$husb->getSexImage();
214
+        				if ($num == $husb->getPrimaryName()) {
215
+        					$class = ' class="name2"';
216
+        					$sex_image = $husb->getSexImage();
217 217
         				} else {
218
-        					$class='';
219
-        					$sex_image='';
218
+        					$class = '';
219
+        					$sex_image = '';
220 220
         				} ?>
221 221
         				<a <?php echo $title.' '.$class; ?> href="<?php echo $husb->getHtmlUrl(); ?>">
222 222
         					<?php echo \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']); ?>
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
         				echo implode('&nbsp;',
226 226
         				    \MyArtJaub\Webtrees\Hook\HookProvider::getInstance()
227 227
         				    ->get('hRecordNameAppend')
228
-        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME),  $husb, 'smaller')); 
228
+        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME), $husb, 'smaller')); 
229 229
         				?>
230 230
         				<br/>
231 231
             		<?php }
@@ -233,23 +233,23 @@  discard block
 block discarded – undo
233 233
             		?>
234 234
             		</td>
235 235
             		<td hidden data-sort="<?= Filter::escapeHtml($surn_givn) ?>"></td>
236
-            		<?php $hdate=$husb->getBirthDate(); ?>
236
+            		<?php $hdate = $husb->getBirthDate(); ?>
237 237
             		<td class="center" data-sort="<?= Date::getAge($hdate, $mdate, 1) ?>"><?= Date::getAge($hdate, $mdate, 2) ?></td>
238 238
             		<!--  WIFE -->            		
239 239
         			<?php list($surn_givn, $givn_surn) = FunctionsPrintLists::sortableNames($wife); ?>
240 240
         			<td colspan="2">
241 241
         			<?php foreach ($wife->getAllNames() as $num=>$name) {
242
-        				if ($name['type']=='NAME') {
243
-        					$title='';
242
+        				if ($name['type'] == 'NAME') {
243
+        					$title = '';
244 244
         				} else {
245
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $wife)).'"';
245
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $wife)).'"';
246 246
         				}
247
-        				if ($num==$wife->getPrimaryName()) {
248
-        					$class=' class="name2"';
249
-        					$sex_image=$wife->getSexImage();
247
+        				if ($num == $wife->getPrimaryName()) {
248
+        					$class = ' class="name2"';
249
+        					$sex_image = $wife->getSexImage();
250 250
         				} else {
251
-        					$class='';
252
-        					$sex_image='';
251
+        					$class = '';
252
+        					$sex_image = '';
253 253
         				} ?>
254 254
         				<a <?= $title.' '.$class ?> href="<?= $wife->getHtmlUrl() ?>">
255 255
         					<?= \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']) ?>
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
         				echo implode('&nbsp;',
259 259
         				    \MyArtJaub\Webtrees\Hook\HookProvider::getInstance()
260 260
         				    ->get('hRecordNameAppend')
261
-        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME),  $wife, 'smaller'));
261
+        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME), $wife, 'smaller'));
262 262
         				?>
263 263
         				<br/>
264 264
             		<?php }
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
             		?>
267 267
             		</td>
268 268
             		<td hidden data-sort="<?= Filter::escapeHtml($surn_givn) ?>"></td>
269
-            		<?php $wdate=$wife->getBirthDate(); ?>
269
+            		<?php $wdate = $wife->getBirthDate(); ?>
270 270
             		<td class="center" data-sort="<?= Date::getAge($wdate, $mdate, 1) ?>"><?= Date::getAge($wdate, $mdate, 2) ?></td>
271 271
             		<td data-sort="<?= $mdate->julianDay() ?>"><?php 
272 272
             		if ($marriage_dates = $family->getAllMarriageDates()) {
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListMissingView.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
             <div id="maj-sosa-missing-page" class="center">
36 36
     			<h2><?= $this->data->get('title') ?></h2>
37 37
     			
38
-    			<?php  if($this->data->get('is_setup')) { 
38
+    			<?php  if ($this->data->get('is_setup')) { 
39 39
     			    $this->renderSosaHeader();
40
-    			    if($this->data->get('has_missing', false)) {
40
+    			    if ($this->data->get('has_missing', false)) {
41 41
     			        $table_id = $this->data->get('table_id');
42 42
     			        ?>
43 43
     			<div id="sosa-indi-missing" class="smissing-list">
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         				</thead>
103 103
         			<tbody>
104 104
         			
105
-        			<?php foreach($this->data->get('missing_list') as $missing_tab) {
105
+        			<?php foreach ($this->data->get('missing_list') as $missing_tab) {
106 106
         			    $person = $missing_tab['indi'];
107 107
         			    
108 108
         			    /** @var \Fisharebest\Webtrees\Individual $person */
@@ -121,17 +121,17 @@  discard block
 block discarded – undo
121 121
                 			<td class="transparent"><?= $person->getXref() ?></td>
122 122
                 			<td colspan="2" data-sort="<?= Filter::escapeHtml($givn_surn) ?>">
123 123
                 			<?php foreach ($person->getAllNames() as $num=>$name) {
124
-                				if ($name['type']=='NAME') {
125
-                					$title='';
124
+                				if ($name['type'] == 'NAME') {
125
+                					$title = '';
126 126
                 				} else {
127
-                					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
127
+                					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
128 128
                 				}
129
-                				if ($num==$person->getPrimaryName()) {
130
-                					$class=' class="name2"';
131
-                					$sex_image=$person->getSexImage();
129
+                				if ($num == $person->getPrimaryName()) {
130
+                					$class = ' class="name2"';
131
+                					$sex_image = $person->getSexImage();
132 132
                 				} else {
133
-                					$class='';
134
-                					$sex_image='';
133
+                					$class = '';
134
+                					$sex_image = '';
135 135
                 				} ?>
136 136
                 				<a <?= $title.' '.$class ?> href="<?= $person->getHtmlUrl() ?>">
137 137
                 					<?= \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']) ?>
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
                 				echo implode('&nbsp;',
141 141
                 				    \MyArtJaub\Webtrees\Hook\HookProvider::getInstance()
142 142
                 				    ->get('hRecordNameAppend')
143
-                				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME),  $person, 'smaller'));  ?>
143
+                				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME), $person, 'smaller')); ?>
144 144
                 				<br/>
145 145
                     		<?php }
146 146
                     		echo $person->getPrimaryParentsNames('parents details1', 'none');
@@ -188,9 +188,9 @@  discard block
 block discarded – undo
188 188
 							<td class="ui-state-default" colspan="11">
189 189
 								<div class="center">
190 190
 									<?= I18N::translate('Number of different missing ancestors: %s', I18N::number($this->data->get('missing_diff_count'))) ?>
191
-									<?php if($this->data->get('missing_hidden') > 0) echo ' ['. I18N::translate('%s hidden', I18N::number($this->data->get('missing_hidden'))).']'; ?>
192
-									<?= ' - ' . I18N::translate('Generation complete at %s', I18N::percentage($this->data->get('perc_sosa'), 2)) ?>
193
-									<?= ' [' . I18N::translate('Potential %s', I18N::percentage($this->data->get('perc_sosa_potential'),2)).']' ?>
191
+									<?php if ($this->data->get('missing_hidden') > 0) echo ' ['.I18N::translate('%s hidden', I18N::number($this->data->get('missing_hidden'))).']'; ?>
192
+									<?= ' - '.I18N::translate('Generation complete at %s', I18N::percentage($this->data->get('perc_sosa'), 2)) ?>
193
+									<?= ' ['.I18N::translate('Potential %s', I18N::percentage($this->data->get('perc_sosa_potential'), 2)).']' ?>
194 194
 								</div>
195 195
 							</td>
196 196
 						</tr>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListIndiView.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 */
34 34
     protected function renderContent() { 
35 35
         
36
-        if($this->data->get('has_sosa', false)) {
36
+        if ($this->data->get('has_sosa', false)) {
37 37
             $table_id = $this->data->get('table_id');            
38 38
         ?>   
39 39
         
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 				</thead>
177 177
 			<tbody>
178 178
 			
179
-			<?php foreach($this->data->get('sosa_list') as $sosa => $person) {
179
+			<?php foreach ($this->data->get('sosa_list') as $sosa => $person) {
180 180
 			    /** @var \Fisharebest\Webtrees\Individual $person */
181 181
 			    if ($person->isPendingAddtion()) {
182 182
 			        $class = ' class="new"';
@@ -193,17 +193,17 @@  discard block
 block discarded – undo
193 193
         			<?php list($surn_givn, $givn_surn) = FunctionsPrintLists::sortableNames($person); ?>
194 194
         			<td colspan="2" data-sort="<?= Filter::escapeHtml($givn_surn) ?>">
195 195
         			<?php foreach ($person->getAllNames() as $num=>$name) {
196
-        				if ($name['type']=='NAME') {
197
-        					$title='';
196
+        				if ($name['type'] == 'NAME') {
197
+        					$title = '';
198 198
         				} else {
199
-        					$title='title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
199
+        					$title = 'title="'.strip_tags(GedcomTag::getLabel($name['type'], $person)).'"';
200 200
         				}
201
-        				if ($num==$person->getPrimaryName()) {
202
-        					$class=' class="name2"';
203
-        					$sex_image=$person->getSexImage();
201
+        				if ($num == $person->getPrimaryName()) {
202
+        					$class = ' class="name2"';
203
+        					$sex_image = $person->getSexImage();
204 204
         				} else {
205
-        					$class='';
206
-        					$sex_image='';
205
+        					$class = '';
206
+        					$sex_image = '';
207 207
         				} ?>
208 208
         				<a <?= $title.' '.$class; ?> href="<?= $person->getHtmlUrl() ?>">
209 209
         					<?= \Fisharebest\Webtrees\Functions\FunctionsPrint::highlightSearchHits($name['full']) ?>
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         				echo implode('&nbsp;',
213 213
         				    \MyArtJaub\Webtrees\Hook\HookProvider::getInstance()
214 214
         				    ->get('hRecordNameAppend')
215
-        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME),  $person, 'smaller')); 
215
+        				    ->executeOnlyFor(array(Constants::MODULE_MAJ_SOSA_NAME), $person, 'smaller')); 
216 216
         				?>
217 217
         				<br/>
218 218
             		<?php }
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
         			<?php } ?>
268 268
         			</td>
269 269
         			<?php if (ModuleManager::getInstance()->isOperational(Constants::MODULE_MAJ_ISSOURCED_NAME)) {
270
-        			    if($person->isDead()) {
270
+        			    if ($person->isDead()) {
271 271
         			        $isDSourced = $dperson->isDeathSourced(); ?>
272 272
 				   	<td data-sort=<?= $isDSourced ?>><?= FunctionsPrint::formatIsSourcedIcon('E', $isDSourced, 'DEAT', 1, 'medium') ?></td>
273 273
 					<?php } else { ?>
@@ -314,10 +314,10 @@  discard block
 block discarded – undo
314 314
 							<?= I18N::translate('Number of Sosa ancestors: %1$s known / %2$s theoretical (%3$s)',
315 315
 							    I18N::number($this->data->get('sosa_count')),
316 316
 							    I18N::number($this->data->get('sosa_theo')), 
317
-							    I18N::percentage($this->data->get('sosa_ratio'),2)
317
+							    I18N::percentage($this->data->get('sosa_ratio'), 2)
318 318
 							    ) ?>
319
-							<?php if($this->data->get('sosa_hidden') > 0) {
320
-							    echo '['. I18N::translate('%s hidden', I18N::number($this->data->get('sosa_hidden'))).']';
319
+							<?php if ($this->data->get('sosa_hidden') > 0) {
320
+							    echo '['.I18N::translate('%s hidden', I18N::number($this->data->get('sosa_hidden'))).']';
321 321
 							} ?>
322 322
 						</div>
323 323
 					</th>
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 								<button type="button" class="ui-state-default btn-toggle-parents">
330 330
 									<?= I18N::translate('Show parents') ?>
331 331
 								</button>
332
-								<button id="btn-toggle-statistics-<?= $table_id ;?>" type="button" class="ui-state-default btn-toggle-statistics">
332
+								<button id="btn-toggle-statistics-<?= $table_id; ?>" type="button" class="ui-state-default btn-toggle-statistics">
333 333
 									<?= I18N::translate('Show statistics charts') ?>
334 334
 								</button>
335 335
 							</div>
Please login to merge, or discard this patch.
src/Webtrees/Hook/Hook.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	 * @param string $hook_function_in Hook function to be subscribed or executed
32 32
 	 * @param string $hook_context_in Hook context to be subscribed or executed
33 33
 	 */
34
-	public function __construct($hook_function_in, $hook_context_in = 'all'){
34
+	public function __construct($hook_function_in, $hook_context_in = 'all') {
35 35
 		$this->hook_function = $hook_function_in;
36 36
 		$this->hook_context = $hook_context_in;
37 37
 	}
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	 *
48 48
 	 * @param string $hsubscriber Name of the subscriber module
49 49
 	 */
50
-	public function subscribe($hsubscriber){
51
-		if(HookProvider::getInstance()->isModuleOperational()){
50
+	public function subscribe($hsubscriber) {
51
+		if (HookProvider::getInstance()->isModuleOperational()) {
52 52
 			Database::prepare(
53 53
 					"INSERT IGNORE INTO `##maj_hooks` (majh_hook_function, majh_hook_context, majh_module_name)".
54 54
 					" VALUES (?, ?, ?)"
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
 	 * @param string $hsubscriber Name of the subscriber module
63 63
 	 * @param int $priority Priority of execution
64 64
 	 */
65
-	public function setPriority($hsubscriber, $priority){
66
-		if(HookProvider::getInstance()->isModuleOperational()){
65
+	public function setPriority($hsubscriber, $priority) {
66
+		if (HookProvider::getInstance()->isModuleOperational()) {
67 67
 			Database::prepare(
68 68
 			"UPDATE `##maj_hooks`".
69 69
 			" SET majh_module_priority=?".
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @param string $hsubscriber Name of the subscriber module
81 81
 	 */
82
-	public function enable($hsubscriber){
83
-		if(HookProvider::getInstance()->isModuleOperational()){
82
+	public function enable($hsubscriber) {
83
+		if (HookProvider::getInstance()->isModuleOperational()) {
84 84
 		Database::prepare(
85 85
 			"UPDATE `##maj_hooks`".
86 86
 			" SET majh_status='enabled'".
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
 	 *
97 97
 	 * @param string $hsubscriber Name of the subscriber module
98 98
 	 */
99
-	public function disable($hsubscriber){
100
-		if(HookProvider::getInstance()->isModuleOperational()){
99
+	public function disable($hsubscriber) {
100
+		if (HookProvider::getInstance()->isModuleOperational()) {
101 101
 		Database::prepare(
102 102
 			"UPDATE `##maj_hooks`".
103 103
 			" SET majh_status='disabled'".
@@ -113,8 +113,8 @@  discard block
 block discarded – undo
113 113
 	 *
114 114
 	 * @param string $hsubscriber Name of the subscriber module
115 115
 	 */
116
-	public function remove($hsubscriber){
117
-		if(HookProvider::getInstance()->isModuleOperational()){
116
+	public function remove($hsubscriber) {
117
+		if (HookProvider::getInstance()->isModuleOperational()) {
118 118
 		Database::prepare(
119 119
 			"DELETE FROM `##maj_hooks`".
120 120
 			" WHERE majh_hook_function=?".
@@ -138,11 +138,11 @@  discard block
 block discarded – undo
138 138
 	 */
139 139
 	public function executeOnlyFor(array $module_names) {
140 140
 	    $result = array();
141
-	    if(HookProvider::getInstance()->isModuleOperational()){
141
+	    if (HookProvider::getInstance()->isModuleOperational()) {
142 142
 	       $params = func_get_args();
143 143
 	       array_shift($params);
144 144
     	    foreach ($module_names as $module_name) {
145
-    	        if($module = Module::getModuleByName($module_name)) {
145
+    	        if ($module = Module::getModuleByName($module_name)) {
146 146
     	            $result[] = call_user_func_array(array($module, $this->hook_function), $params);
147 147
     	        }
148 148
     	    }
@@ -156,17 +156,17 @@  discard block
 block discarded – undo
156 156
 	 *
157 157
 	 * @return array Results of the hook executions
158 158
 	 */
159
-	public function execute(){
159
+	public function execute() {
160 160
 		$result = array();
161
-		if(HookProvider::getInstance()->isModuleOperational()){
161
+		if (HookProvider::getInstance()->isModuleOperational()) {
162 162
 			$params = func_get_args();
163 163
 			$sqlquery = '';
164 164
 			$sqlparams = array($this->hook_function);
165
-			if($this->hook_context != 'all') {
165
+			if ($this->hook_context != 'all') {
166 166
 				$sqlparams = array($this->hook_function, $this->hook_context);
167 167
 				$sqlquery = " OR majh_hook_context=?";
168 168
 			}
169
-			$module_names=Database::prepare(
169
+			$module_names = Database::prepare(
170 170
 					"SELECT majh_module_name AS module, majh_module_priority AS priority FROM `##maj_hooks`".
171 171
 					" WHERE majh_hook_function = ? AND (majh_hook_context='all'".$sqlquery.") AND majh_status='enabled'".
172 172
 					" ORDER BY majh_module_priority ASC, module ASC"
@@ -183,15 +183,15 @@  discard block
 block discarded – undo
183 183
 	 *
184 184
 	 * @return int Number of active modules
185 185
 	 */
186
-	public function getNumberActiveModules(){
187
-		if(HookProvider::getInstance()->isModuleOperational()){
186
+	public function getNumberActiveModules() {
187
+		if (HookProvider::getInstance()->isModuleOperational()) {
188 188
 			$sqlquery = '';
189 189
 			$sqlparams = array($this->hook_function);
190
-			if($this->hook_context != 'all') {
190
+			if ($this->hook_context != 'all') {
191 191
 				$sqlparams = array($this->hook_function, $this->hook_context);
192 192
 				$sqlquery = " OR majh_hook_context=?";
193 193
 			}
194
-			$module_names=Database::prepare(
194
+			$module_names = Database::prepare(
195 195
 					"SELECT majh_module_name AS modules FROM `##maj_hooks`".
196 196
 					" WHERE majh_hook_function = ? AND (majh_hook_context='all'".$sqlquery.") AND majh_status='enabled'"
197 197
 			)->execute($sqlparams)->fetchOneColumn();
@@ -205,8 +205,8 @@  discard block
 block discarded – undo
205 205
 	 *
206 206
 	 * @return bool True is active modules exist, false otherwise
207 207
 	 */
208
-	public function hasAnyActiveModule(){
209
-		return ($this->getNumberActiveModules()>0);
208
+	public function hasAnyActiveModule() {
209
+		return ($this->getNumberActiveModules() > 0);
210 210
 	}
211 211
 
212 212
 }
Please login to merge, or discard this patch.
src/Webtrees/Mvc/View/AbstractView.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     public function render() {
46 46
         global $controller;        
47 47
         
48
-        if(!$this->ctrl) throw new \Exception('Controller not initialised');
48
+        if (!$this->ctrl) throw new \Exception('Controller not initialised');
49 49
         
50 50
 		$controller = $this->ctrl;
51 51
         $this->ctrl->pageHeader();
Please login to merge, or discard this patch.
src/Webtrees/Module/AdminTasks/TaskController.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 		
70 70
 		$tasks = $this->provider->getTasksToRun($token == $token_submitted, $task_name);
71 71
 		
72
-		foreach($tasks as $task) {
72
+		foreach ($tasks as $task) {
73 73
 			$task->execute();		
74 74
 		}
75 75
 	}	
@@ -90,19 +90,19 @@  discard block
 block discarded – undo
90 90
         );
91 91
         
92 92
         $status = Filter::getBool('status');
93
-        $res = array('task' => $task->getName() , 'error' => null);
94
-        try{
93
+        $res = array('task' => $task->getName(), 'error' => null);
94
+        try {
95 95
             $this->provider->setTaskStatus($task, $status);
96 96
             $res['status'] = $status;
97
-			Log::addConfigurationLog('Module '.$this->module->getName().' : Admin Task "'.$task->getName().'" has been '. ($status ? 'enabled' : 'disabled') .'.');
97
+			Log::addConfigurationLog('Module '.$this->module->getName().' : Admin Task "'.$task->getName().'" has been '.($status ? 'enabled' : 'disabled').'.');
98 98
         }
99 99
         catch (\Exception $ex) {
100 100
             $res['error'] = $ex->getMessage();
101
-			Log::addErrorLog('Module '.$this->module->getName().' : Admin Task "'.$task->getName().'" could not be ' . ($status ? 'enabled' : 'disabled') .'. Error: '. $ex->getMessage());
101
+			Log::addErrorLog('Module '.$this->module->getName().' : Admin Task "'.$task->getName().'" could not be '.($status ? 'enabled' : 'disabled').'. Error: '.$ex->getMessage());
102 102
         }
103 103
         
104 104
         $controller->pageHeader();
105
-        if($res['error']) http_response_code(500);
105
+        if ($res['error']) http_response_code(500);
106 106
         
107 107
         $controller->encode($res);
108 108
     }
@@ -138,9 +138,9 @@  discard block
 block discarded – undo
138 138
         
139 139
         $data = new ViewBag();        
140 140
         $data->set('title', $controller->getPageTitle());
141
-		$data->set('admin_config_url', 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig&ged=' . $tree->getNameUrl());
141
+		$data->set('admin_config_url', 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig&ged='.$tree->getNameUrl());
142 142
         $data->set('module_title', $this->module->getTitle());
143
-		$data->set('save_url', 'module.php?mod=' . $this->module->getName() . '&mod_action=Task@save&ged=' . $tree->getNameUrl());
143
+		$data->set('save_url', 'module.php?mod='.$this->module->getName().'&mod_action=Task@save&ged='.$tree->getNameUrl());
144 144
 		$data->set('task', $task);
145 145
 		    
146 146
         ViewFactory::make('TaskEdit', $this, $controller, $data)->render();	
@@ -157,17 +157,17 @@  discard block
 block discarded – undo
157 157
             && Filter::checkCsrf()
158 158
          );
159 159
         
160
-		$task_name      = Filter::post('task');
161
-        $frequency    	= Filter::postInteger('frequency');
162
-        $is_limited  	= Filter::postInteger('is_limited', 0, 1);
163
-        $nb_occur       = Filter::postInteger('nb_occur');
160
+		$task_name = Filter::post('task');
161
+        $frequency = Filter::postInteger('frequency');
162
+        $is_limited = Filter::postInteger('is_limited', 0, 1);
163
+        $nb_occur = Filter::postInteger('nb_occur');
164 164
 				
165 165
 		$task = $this->provider->getTask($task_name, false);
166 166
         
167 167
         $success = false; 
168
-        if($task) {
168
+        if ($task) {
169 169
 			$task->setFrequency($frequency);
170
-			if($is_limited == 1) {
170
+			if ($is_limited == 1) {
171 171
 				$task->setRemainingOccurrences($nb_occur);
172 172
 			}
173 173
 			else {
@@ -176,34 +176,34 @@  discard block
 block discarded – undo
176 176
 			
177 177
 			$res = $task->save();
178 178
 						
179
-			if($res) {						
180
-				if($task instanceof MyArtJaub\Webtrees\Module\AdminTasks\Model\ConfigurableTaskInterface) {
179
+			if ($res) {						
180
+				if ($task instanceof MyArtJaub\Webtrees\Module\AdminTasks\Model\ConfigurableTaskInterface) {
181 181
 					$res = $task->saveConfig();
182 182
 					
183
-					if(!$res) {
183
+					if (!$res) {
184 184
 						FlashMessages::addMessage(I18N::translate('An error occured while updating the specific settings of administrative task “%s”', $task->getTitle()), 'danger');
185
-						Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'. $task->getName() .'” specific settings could not be updated. See error log.');
185
+						Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'.$task->getName().'” specific settings could not be updated. See error log.');
186 186
 					}
187 187
 				}
188 188
 			
189
-				if($res) {
189
+				if ($res) {
190 190
 					FlashMessages::addMessage(I18N::translate('The administrative task “%s” has been successfully updated', $task->getTitle()), 'success');
191
-					Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'.$task->getName() .'” has been updated.');
191
+					Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'.$task->getName().'” has been updated.');
192 192
 					$success = true;
193 193
 				}
194 194
 			}
195 195
 			else {
196 196
 				FlashMessages::addMessage(I18N::translate('An error occured while updating the administrative task “%s”', $task->getTitle()), 'danger');
197
-				Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'. $task->getName() .'” could not be updated. See error log.');
197
+				Log::addConfigurationLog('Module '.$this->module->getName().' : AdminTask “'.$task->getName().'” could not be updated. See error log.');
198 198
 			}
199 199
 			
200 200
         }
201 201
         
202
-        $redirection_url = 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig';
203
-        if(!$success) {
204
-			$redirection_url = 'module.php?mod=' . $this->module->getName() . '&mod_action=Task@edit&task='. $task->getName();
202
+        $redirection_url = 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig';
203
+        if (!$success) {
204
+			$redirection_url = 'module.php?mod='.$this->module->getName().'&mod_action=Task@edit&task='.$task->getName();
205 205
         }        
206
-        header('Location: ' . WT_BASE_URL . $redirection_url);
206
+        header('Location: '.WT_BASE_URL.$redirection_url);
207 207
 	}
208 208
      
209 209
 }
210 210
\ No newline at end of file
Please login to merge, or discard this patch.
src/Webtrees/Module/AdminTasks/AdminConfigController.php 1 patch
Spacing   +22 added lines, -25 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
             ->setPageTitle($this->module->getTitle());
69 69
 			
70 70
 		$token = $this->module->getSetting('MAJ_AT_FORCE_EXEC_TOKEN');
71
-		if(is_null($token)) {
71
+		if (is_null($token)) {
72 72
 			$token = Functions::generateRandomToken();
73 73
 			$this->module->setSetting('PAT_FORCE_EXEC_TOKEN', $token);
74 74
 		}
@@ -76,12 +76,12 @@  discard block
 block discarded – undo
76 76
         $data = new ViewBag();
77 77
         $data->set('title', $controller->getPageTitle());
78 78
         
79
-        $table_id = 'table-admintasks-' . Uuid::uuid4();
79
+        $table_id = 'table-admintasks-'.Uuid::uuid4();
80 80
         $data->set('table_id', $table_id);
81 81
 		
82 82
 		$data->set('trigger_url_root', WT_BASE_URL.'module.php?mod='.$this->module->getName().'&mod_action=Task@trigger');
83 83
 		$token = $this->module->getSetting('MAJ_AT_FORCE_EXEC_TOKEN');
84
-		if(is_null($token)) {
84
+		if (is_null($token)) {
85 85
 			$token = Functions::generateRandomToken();
86 86
 			$this->module->setSetting('MAJ_AT_FORCE_EXEC_TOKEN', $token);
87 87
 		}
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
                     processing: true,
107 107
                     serverSide : true,
108 108
 					ajax : {
109
-						url : "module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@jsonTasksList&ged='. $tree->getNameUrl().'",
109
+						url : "module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@jsonTasksList&ged='.$tree->getNameUrl().'",
110 110
                         type : "POST"
111 111
 					},
112 112
                     columns: [
@@ -143,14 +143,14 @@  discard block
 block discarded – undo
143 143
                             url: "module.php", 
144 144
                             type: "GET",
145 145
                             data: {
146
-                			    mod: "' . $this->module->getName() .'",
146
+                			    mod: "' . $this->module->getName().'",
147 147
                                 mod_action:  "Task@setStatus",
148 148
                 			    task: task,
149 149
                                 status: status
150 150
                             },
151 151
                             error: function(result, stat, error) {
152 152
                                 var err = typeof result.responseJSON === "undefined" ? error : result.responseJSON.error;
153
-                                alert("' . I18N::translate('An error occured while editing this task:') . '" + err);
153
+                                alert("' . I18N::translate('An error occured while editing this task:').'" + err);
154 154
                             },
155 155
                             complete: function(result, stat) {
156 156
                                 adminTasksTable.ajax.reload(null, false);
@@ -185,14 +185,14 @@  discard block
 block discarded – undo
185 185
     
186 186
         // Generate an AJAX/JSON response for datatables to load a block of rows
187 187
         $search = Filter::postArray('search');
188
-        if($search) $search = $search['value'];
188
+        if ($search) $search = $search['value'];
189 189
         $start  = Filter::postInteger('start');
190 190
         $length = Filter::postInteger('length');
191 191
         $order  = Filter::postArray('order');
192 192
     
193 193
 		$order_by_name = false;
194
-        foreach($order as $key => &$value) {
195
-            switch($value['column']) {
194
+        foreach ($order as $key => &$value) {
195
+            switch ($value['column']) {
196 196
                 case 3:
197 197
 					$order_by_name = true;
198 198
                     unset($order[$key]);
@@ -209,14 +209,14 @@  discard block
 block discarded – undo
209 209
         }
210 210
     
211 211
         $list = $this->provider->getFilteredTasksList($search, $order, $start, $length);
212
-		if($order_by_name) {
212
+		if ($order_by_name) {
213 213
 			usort($list, function(AbstractTask $a, AbstractTask $b) { return I18N::strcasecmp($a->getTitle(), $b->getTitle()); });
214 214
 		}
215 215
         $recordsFiltered = count($list);
216 216
         $recordsTotal = $this->provider->getTasksCount();
217 217
     
218 218
         $data = array();
219
-        foreach($list as $task) {    
219
+        foreach ($list as $task) {    
220 220
             $datum = array();
221 221
 			
222 222
             $datum[0] = '
@@ -227,37 +227,34 @@  discard block
 block discarded – undo
227 227
                     <ul class="dropdown-menu" role="menu">
228 228
                        <li>
229 229
                             <a href="#" onclick="return set_admintask_status(\''. $task->getName().'\', '.($task->isEnabled() ? 'false' : 'true').');">
230
-                                <i class="fa fa-fw '.($task->isEnabled() ? 'fa-times' : 'fa-check').'"></i> ' . ($task->isEnabled() ? I18N::translate('Disable') : I18N::translate('Enable')) . '
230
+                                <i class="fa fa-fw '.($task->isEnabled() ? 'fa-times' : 'fa-check').'"></i> '.($task->isEnabled() ? I18N::translate('Disable') : I18N::translate('Enable')).'
231 231
                             </a>
232 232
                        </li>
233 233
                         <li>
234
-                            <a href="module.php?mod='.$this->module->getName().'&mod_action=Task@edit&task='. $task->getName().'">
235
-                                <i class="fa fa-fw fa-pencil"></i> ' . I18N::translate('Edit') . '
234
+                            <a href="module.php?mod='.$this->module->getName().'&mod_action=Task@edit&task='.$task->getName().'">
235
+                                <i class="fa fa-fw fa-pencil"></i> ' . I18N::translate('Edit').'
236 236
                             </a>
237 237
                        </li>
238 238
                     </ul>
239 239
                 </div>';
240 240
             $datum[1] = $task->getName();
241 241
             $datum[2] = $task->isEnabled() ? 
242
-				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Enabled').'</span>' : 
243
-				'<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Disabled').'</span>';
242
+				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Enabled').'</span>' : '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Disabled').'</span>';
244 243
             $datum[3] = $task->getTitle();
245
-            $date_format = str_replace('%', '', I18N::dateFormat()) . ' H:i:s';
244
+            $date_format = str_replace('%', '', I18N::dateFormat()).' H:i:s';
246 245
 			$datum[4] = $task->getLastUpdated()->format($date_format);
247 246
             $datum[5] = $task->isLastRunSuccess() ? 
248
-				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Yes').'</span>' : 
249
-				'<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('No').'</span>';
247
+				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Yes').'</span>' : '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('No').'</span>';
250 248
             $dtF = new \DateTime('@0');
251
-            $dtT = new \DateTime('@' . ($task->getFrequency() * 60));            
249
+            $dtT = new \DateTime('@'.($task->getFrequency() * 60));            
252 250
             $datum[6] = $dtF->diff($dtT)->format(I18N::translate('%a d %h h %i m'));
253 251
 			$datum[7] = $task->getRemainingOccurrences() > 0 ? I18N::number($task->getRemainingOccurrences()) : I18N::translate('Unlimited');
254 252
 			$datum[8] = $task->isRunning() ? 
255
-				'<i class="fa fa-cog fa-spin fa-fw"></i><span class="sr-only">'.I18N::translate('Running').'</span>' : 
256
-				'<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Not running').'</span>';
257
-			if($task->isEnabled() && !$task->isRunning()) {
253
+				'<i class="fa fa-cog fa-spin fa-fw"></i><span class="sr-only">'.I18N::translate('Running').'</span>' : '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Not running').'</span>';
254
+			if ($task->isEnabled() && !$task->isRunning()) {
258 255
 			    $datum[9] = '
259
-    			    <button id="bt_runtask_'. $task->getName() .'" class="btn btn-primary" href="#" onclick="return run_admintask(\''. $task->getName() .'\')">
260
-    			         <div id="bt_runtasktext_'. $task->getName() .'"><i class="fa fa-cog fa-fw" ></i>' . I18N::translate('Run') . '</div>
256
+    			    <button id="bt_runtask_'. $task->getName().'" class="btn btn-primary" href="#" onclick="return run_admintask(\''.$task->getName().'\')">
257
+    			         <div id="bt_runtasktext_'. $task->getName().'"><i class="fa fa-cog fa-fw" ></i>'.I18N::translate('Run').'</div>
261 258
     			    </button>';
262 259
 			}
263 260
 			else {
Please login to merge, or discard this patch.
src/Webtrees/Module/GeoDispersion/AdminConfigController.php 1 patch
Spacing   +43 added lines, -45 removed lines patch added patch discarded remove patch
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
         $data->set('title', $controller->getPageTitle());
72 72
         $data->set('tree', $wt_tree);
73 73
         
74
-        $data->set('root_url', 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig');
74
+        $data->set('root_url', 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig');
75 75
                 
76
-        $table_id = 'table-geoanalysis-' . Uuid::uuid4();
76
+        $table_id = 'table-geoanalysis-'.Uuid::uuid4();
77 77
         $data->set('table_id', $table_id);
78 78
         
79 79
         $other_trees = array();
80 80
         foreach (Tree::getAll() as $tree) {
81
-            if($tree->getTreeId() != $wt_tree->getTreeId()) $other_trees[] = $tree;
81
+            if ($tree->getTreeId() != $wt_tree->getTreeId()) $other_trees[] = $tree;
82 82
         }      
83 83
         $data->set('other_trees', $other_trees);
84 84
         
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
                     processing: true,
102 102
                     serverSide : true,
103 103
 					ajax : {
104
-						url : "module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@jsonGeoAnalysisList&ged='. $wt_tree->getNameUrl().'",
104
+						url : "module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@jsonGeoAnalysisList&ged='.$wt_tree->getNameUrl().'",
105 105
                         type : "POST"
106 106
 					},
107 107
                     columns: [
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                             url: "module.php", 
126 126
                             type: "GET",
127 127
                             data: {
128
-                			    mod: "' . $this->module->getName() .'",
128
+                			    mod: "' . $this->module->getName().'",
129 129
                                 mod_action:  "GeoAnalysis@setStatus",
130 130
                 			    ga_id: ga_id,
131 131
                 			    ged: typeof gedcom === "undefined" ? WT_GEDCOM : gedcom,
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
                             },
134 134
                             error: function(result, stat, error) {
135 135
                                 var err = typeof result.responseJSON === "undefined" ? error : result.responseJSON.error;
136
-                                alert("' . I18N::translate('An error occured while editing this analysis:') . '" + err);
136
+                                alert("' . I18N::translate('An error occured while editing this analysis:').'" + err);
137 137
                             },
138 138
                             complete: function(result, stat) {
139 139
                                 geoAnalysisTable.ajax.reload(null, false);
@@ -146,14 +146,14 @@  discard block
 block discarded – undo
146 146
                             url: "module.php", 
147 147
                             type: "GET",
148 148
                             data: {
149
-                			    mod: "' . $this->module->getName() .'",
149
+                			    mod: "' . $this->module->getName().'",
150 150
                                 mod_action:  "GeoAnalysis@delete",
151 151
                 			    ga_id: ga_id,
152 152
                 			    ged: typeof gedcom === "undefined" ? WT_GEDCOM : gedcom
153 153
                             },
154 154
                             error: function(result, stat, error) {
155 155
                                 var err = typeof result.responseJSON === "undefined" ? error : result.responseJSON.error;
156
-                                alert("' . I18N::translate('An error occured while deleting this analysis:') . '" + err);
156
+                                alert("' . I18N::translate('An error occured while deleting this analysis:').'" + err);
157 157
                             },
158 158
                             complete: function(result, stat) {
159 159
                                 geoAnalysisTable.ajax.reload(null, false);
@@ -177,13 +177,13 @@  discard block
 block discarded – undo
177 177
         
178 178
         // Generate an AJAX/JSON response for datatables to load a block of rows
179 179
         $search = Filter::postArray('search');
180
-        if($search) $search = $search['value'];
180
+        if ($search) $search = $search['value'];
181 181
         $start  = Filter::postInteger('start');
182 182
         $length = Filter::postInteger('length');
183 183
         $order  = Filter::postArray('order');
184 184
         
185
-        foreach($order as $key => &$value) {
186
-            switch($value['column']) {
185
+        foreach ($order as $key => &$value) {
186
+            switch ($value['column']) {
187 187
                 case 3:
188 188
                     $value['column'] = 'majgd_descr';
189 189
                     break;
@@ -204,11 +204,11 @@  discard block
 block discarded – undo
204 204
         
205 205
         $data = array();
206 206
         $place_hierarchy = $this->provider->getPlacesHierarchy();
207
-        foreach($list as $ga) {
207
+        foreach ($list as $ga) {
208 208
             /** @var GeoAnalysis $ga */
209 209
             
210 210
             $datum = array();
211
-            $options= $ga->getOptions();
211
+            $options = $ga->getOptions();
212 212
             
213 213
             $datum[0] = '
214 214
                 <div class="btn-group">
@@ -218,50 +218,48 @@  discard block
 block discarded – undo
218 218
                     <ul class="dropdown-menu" role="menu">
219 219
                        <li>
220 220
                             <a href="#" onclick="return set_geoanalysis_status('. $ga->getId().', '.($ga->isEnabled() ? 'false' : 'true').', \''.Filter::escapeJs($wt_tree->getName()).'\');">
221
-                                <i class="fa fa-fw '.($ga->isEnabled() ? 'fa-times' : 'fa-check').'"></i> ' . ($ga->isEnabled() ? I18N::translate('Disable') : I18N::translate('Enable')) . '
221
+                                <i class="fa fa-fw '.($ga->isEnabled() ? 'fa-times' : 'fa-check').'"></i> '.($ga->isEnabled() ? I18N::translate('Disable') : I18N::translate('Enable')).'
222 222
                             </a>
223 223
                        </li>
224 224
                         <li>
225 225
                             <a href="module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@edit&ga_id='.$ga->getId().'&ged='.$wt_tree->getName().'">
226
-                                <i class="fa fa-fw fa-pencil"></i> ' . I18N::translate('Edit') . '
226
+                                <i class="fa fa-fw fa-pencil"></i> ' . I18N::translate('Edit').'
227 227
                             </a>
228 228
                        </li>
229 229
                        <li class="divider" />
230 230
                        <li>
231 231
                             <a href="#" onclick="return delete_geoanalysis('. $ga->getId().', \''.Filter::escapeJs($wt_tree->getName()).'\');">
232
-                                <i class="fa fa-fw fa-trash-o"></i> ' . I18N::translate('Delete') . '
232
+                                <i class="fa fa-fw fa-trash-o"></i> ' . I18N::translate('Delete').'
233 233
                             </a>
234 234
                        </li>
235 235
                     </ul>
236 236
                 </div>';
237 237
 		    $datum[1] = $ga->getId();
238 238
 		    $datum[2] = $ga->isEnabled() ? 
239
-				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Enabled').'</span>' : 
240
-				'<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Disabled').'</span>';
239
+				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Enabled').'</span>' : '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('Disabled').'</span>';
241 240
 		    $datum[3] = $ga->getTitle();
242 241
 		    $analysis_level = $ga->getAnalysisLevel();
243
-		    if($place_hierarchy['type'] == 'header') {
242
+		    if ($place_hierarchy['type'] == 'header') {
244 243
 		        $datum[4] = $place_hierarchy['hierarchy'][$analysis_level - 1];
245 244
 		    } else {
246
-		        $datum[4] = $analysis_level . '(' . $place_hierarchy['hierarchy'][$analysis_level - 1] . ')';
245
+		        $datum[4] = $analysis_level.'('.$place_hierarchy['hierarchy'][$analysis_level - 1].')';
247 246
 		    }
248 247
 		    $datum[5] = $ga->getAnalysisLevel();
249 248
 		    $datum[6] = '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('None').'</span>';
250 249
 		    $datum[7] = '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('None').'</span>';
251
-		    if($ga->hasMap()) {
250
+		    if ($ga->hasMap()) {
252 251
 		        $datum[6] = $options->getMap()->getDescription();
253
-		        $datum[7] = '<span data-toggle="tooltip" title="' . $options->getMap()->getTopLevelName() . '" />';
252
+		        $datum[7] = '<span data-toggle="tooltip" title="'.$options->getMap()->getTopLevelName().'" />';
254 253
 		        $top_level = $options->getMapLevel();
255
-		        if($place_hierarchy['type'] == 'header') {
254
+		        if ($place_hierarchy['type'] == 'header') {
256 255
 		            $datum[7] .= $place_hierarchy['hierarchy'][$top_level - 1];
257 256
 		        } else {
258
-		            $datum[7] .= $top_level . '(' . $place_hierarchy['hierarchy'][$top_level - 1] . ')';
257
+		            $datum[7] .= $top_level.'('.$place_hierarchy['hierarchy'][$top_level - 1].')';
259 258
 		        }
260 259
 		        $datum[7] .= '</span>';
261 260
 		    }
262 261
 		    $datum[8] = $options->isUsingFlags() ? 
263
-				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Yes').'</span>' : 
264
-				'<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('No').'</span>';
262
+				'<i class="fa fa-check"></i><span class="sr-only">'.I18N::translate('Yes').'</span>' : '<i class="fa fa-times"></i><span class="sr-only">'.I18N::translate('No').'</span>';
265 263
 		    $datum[9] = $options->getMaxDetailsInGen() > 0 ? $options->getMaxDetailsInGen() : I18N::translate('All');
266 264
 		    
267 265
 		    $data[] = $datum;
@@ -310,24 +308,24 @@  discard block
 block discarded – undo
310 308
         $description    = Filter::post('description');
311 309
         $analysislevel  = Filter::postInteger('analysislevel');
312 310
         $use_map        = Filter::postBool('use_map');
313
-        if($use_map) {
311
+        if ($use_map) {
314 312
             $map_file   = base64_decode(Filter::post('map_file'));
315
-            $map_top_level   = Filter::postInteger('map_top_level');
313
+            $map_top_level = Filter::postInteger('map_top_level');
316 314
         }
317 315
         $use_flags      = Filter::postBool('use_flags');
318 316
         $gen_details    = Filter::postInteger('gen_details');
319 317
         
320 318
         $success = false; 
321
-        if($ga_id) {
319
+        if ($ga_id) {
322 320
             $ga = $this->provider->getGeoAnalysis($ga_id, false);
323
-            if($ga) {
321
+            if ($ga) {
324 322
                 $ga->setTitle($description);
325 323
                 $ga->setAnalysisLevel($analysislevel + 1);
326 324
                 $options = $ga->getOptions();
327
-                if($options) {
325
+                if ($options) {
328 326
                     $options->setUsingFlags($use_flags);
329 327
                     $options->setMaxDetailsInGen($gen_details);
330
-                    if($use_map) {
328
+                    if ($use_map) {
331 329
                         $options->setMap(new OutlineMap($map_file));
332 330
                         $options->setMapLevel($map_top_level + 1);
333 331
                     }
@@ -337,7 +335,7 @@  discard block
 block discarded – undo
337 335
                 }
338 336
 				
339 337
 				$res = $this->provider->updateGeoAnalysis($ga);
340
-				if($res) {
338
+				if ($res) {
341 339
 					FlashMessages::addMessage(I18N::translate('The geographical dispersion analysis “%s” has been successfully updated', $res->getTitle()), 'success');
342 340
 					Log::addConfigurationLog('Module '.$this->module->getName().' : Geo Analysis ID “'.$res->getId().'” has been updated.');
343 341
 					$ga = $res;
@@ -345,7 +343,7 @@  discard block
 block discarded – undo
345 343
 				}
346 344
 				else {
347 345
 					FlashMessages::addMessage(I18N::translate('An error occured while updating the geographical dispersion analysis “%s”', $ga->getTitle()), 'danger');
348
-					Log::addConfigurationLog('Module '.$this->module->getName().' : Geo Analysis ID “'. $ga->getId() .'” could not be updated. See error log.');
346
+					Log::addConfigurationLog('Module '.$this->module->getName().' : Geo Analysis ID “'.$ga->getId().'” could not be updated. See error log.');
349 347
 				}
350 348
             }
351 349
         } else {
@@ -357,7 +355,7 @@  discard block
 block discarded – undo
357 355
 				$use_flags,
358 356
 				$gen_details
359 357
 			);
360
-			if($ga) {
358
+			if ($ga) {
361 359
 				FlashMessages::addMessage(I18N::translate('The geographical dispersion analysis “%s” has been successfully added.', $ga->getTitle()), 'success');
362 360
 				Log::addConfigurationLog('Module '.$this->module->getName().' : Geo Analysis ID “'.$ga->getId().'” has been added.');
363 361
 				$success = true;
@@ -368,16 +366,16 @@  discard block
 block discarded – undo
368 366
 			}
369 367
         }
370 368
         
371
-        $redirection_url = 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig&ged=' . $wt_tree->getNameUrl();
372
-        if(!$success) {			
373
-            if($ga) {
374
-                $redirection_url = 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig@edit&ga_id='. $ga->getId() .'&ged=' . $wt_tree->getNameUrl();
369
+        $redirection_url = 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig&ged='.$wt_tree->getNameUrl();
370
+        if (!$success) {			
371
+            if ($ga) {
372
+                $redirection_url = 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@edit&ga_id='.$ga->getId().'&ged='.$wt_tree->getNameUrl();
375 373
             }
376 374
             else {
377
-                $redirection_url = 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig@add&ged=' . $wt_tree->getNameUrl();
375
+                $redirection_url = 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@add&ged='.$wt_tree->getNameUrl();
378 376
             }
379 377
         }        
380
-        header('Location: ' . WT_BASE_URL . $redirection_url);
378
+        header('Location: '.WT_BASE_URL.$redirection_url);
381 379
         
382 380
     }
383 381
      
@@ -407,7 +405,7 @@  discard block
 block discarded – undo
407 405
             ');
408 406
         
409 407
         $data = new ViewBag();
410
-        if($ga) {
408
+        if ($ga) {
411 409
             $controller->setPageTitle(I18N::translate('Edit the geographical dispersion analysis'));
412 410
             $data->set('geo_analysis', $ga);
413 411
         } else {
@@ -415,9 +413,9 @@  discard block
 block discarded – undo
415 413
         }
416 414
         
417 415
         $data->set('title', $controller->getPageTitle());
418
-        $data->set('admin_config_url', 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig&ged=' . $wt_tree->getNameUrl());
416
+        $data->set('admin_config_url', 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig&ged='.$wt_tree->getNameUrl());
419 417
         $data->set('module_title', $this->module->getTitle());
420
-        $data->set('save_url', 'module.php?mod=' . $this->module->getName() . '&mod_action=AdminConfig@save&ged=' . $wt_tree->getNameUrl());
418
+        $data->set('save_url', 'module.php?mod='.$this->module->getName().'&mod_action=AdminConfig@save&ged='.$wt_tree->getNameUrl());
421 419
         $data->set('places_hierarchy', $this->provider->getPlacesHierarchy());
422 420
     
423 421
         $map_list = array_map(
@@ -430,7 +428,7 @@  discard block
 block discarded – undo
430 428
         $data->set('map_list', $map_list);
431 429
     
432 430
         $gen_details = array(0 => I18N::translate('All'));
433
-        for($i = 1; $i <= 10 ; $i++) $gen_details[$i] = $i;
431
+        for ($i = 1; $i <= 10; $i++) $gen_details[$i] = $i;
434 432
         $data->set('generation_details', $gen_details);
435 433
     
436 434
         ViewFactory::make('GeoAnalysisEdit', $this, $controller, $data)->render();
Please login to merge, or discard this patch.