jon48 / webtrees-lib

src/Webtrees/Module/Sosa/Services/SosaStatisticsService.php

Spacing +58 added lines, -59 removed lines

@@ -72,7 +72,7 @@ 
      */
     public function maxGeneration(): int
     {
-        return (int) DB::table('maj_sosa')
+        return (int)DB::table('maj_sosa')
             ->where('majs_gedcom_id', '=', $this->tree->id())
             ->where('majs_user_id', '=', $this->user->id())
             ->max('majs_gen');
@@ -149,8 +149,7 @@ 
             ->selectRaw('SUM(majs_gen * majs_gen) AS sum_x2')
             ->get()->first();
 
-        return $row->n == 0 ? 0 :
-            -($row->n * $row->sum_xy - $row->sum_x * $row->sum_y) / ($row->n * $row->sum_x2 - pow($row->sum_x, 2));
+        return $row->n == 0 ? 0 : -($row->n * $row->sum_xy - $row->sum_x * $row->sum_y) / ($row->n * $row->sum_x2 - pow($row->sum_x, 2));
     }
 
     /**
@@ -174,10 +173,10 @@ 
 
         $statistics_by_gen = [];
         foreach ($stats_by_gen as $gen => $stats_gen) {
-            $statistics_by_gen[(int) $stats_gen->gen] = array(
-                'sosaCount'             =>  (int) $stats_gen->total_sosa,
-                'sosaTotalCount'        =>  (int) $cumul_stats_by_gen[$gen]->total_cumul,
-                'diffSosaTotalCount'    =>  (int) $cumul_stats_by_gen[$gen]->total_distinct_cumul,
+            $statistics_by_gen[(int)$stats_gen->gen] = array(
+                'sosaCount'             =>  (int)$stats_gen->total_sosa,
+                'sosaTotalCount'        =>  (int)$cumul_stats_by_gen[$gen]->total_cumul,
+                'diffSosaTotalCount'    =>  (int)$cumul_stats_by_gen[$gen]->total_distinct_cumul,
                 'firstBirth'            =>  $stats_gen->first_year,
                 'firstEstimatedBirth'   =>  $stats_gen->first_est_year,
                 'lastBirth'             =>  $stats_gen->last_year,
@@ -221,7 +220,7 @@ 
             ->where('majs_user_id', '=', $this->user->id());
 
         return DB::table('maj_sosa')
-            ->joinSub($list_gen, 'list_gen', function (JoinClause $join): void {
+            ->joinSub($list_gen, 'list_gen', function(JoinClause $join): void {
                 $join->on('maj_sosa.majs_gen', '<=', 'list_gen.majs_gen')
                 ->where('majs_gedcom_id', '=', $this->tree->id())
                 ->where('majs_user_id', '=', $this->user->id());
@@ -258,37 +257,37 @@ 
             ->select(['list_gen.majs_gen AS gen', 'sosa.majs_gedcom_id', 'sosa.majs_user_id'])
             ->addSelect(['sosa.majs_i_id', 'sosa.majs_gen'])
             ->selectRaw(
-                '(CASE ' .
-                    ' WHEN ' . $table_prefix . 'sosa_fat.majs_i_id IS NULL' .
-                    ' THEN POWER(2, ' . $table_prefix . 'list_gen.majs_gen - ' . $table_prefix . 'sosa.majs_gen - 1)' .
-                    ' ELSE 0 ' .
-                ' END)' .
-                ' + (CASE ' .
-                    ' WHEN ' . $table_prefix . 'sosa_mot.majs_i_id IS NULL' .
-                    ' THEN POWER(2, ' . $table_prefix . 'list_gen.majs_gen - ' . $table_prefix . 'sosa.majs_gen - 1)' .
-                    ' ELSE 0 ' .
+                '(CASE '.
+                    ' WHEN '.$table_prefix.'sosa_fat.majs_i_id IS NULL'.
+                    ' THEN POWER(2, '.$table_prefix.'list_gen.majs_gen - '.$table_prefix.'sosa.majs_gen - 1)'.
+                    ' ELSE 0 '.
+                ' END)'.
+                ' + (CASE '.
+                    ' WHEN '.$table_prefix.'sosa_mot.majs_i_id IS NULL'.
+                    ' THEN POWER(2, '.$table_prefix.'list_gen.majs_gen - '.$table_prefix.'sosa.majs_gen - 1)'.
+                    ' ELSE 0 '.
                 ' END) contrib'
             )
-            ->joinSub($list_gen, 'list_gen', function (JoinClause $join): void {
+            ->joinSub($list_gen, 'list_gen', function(JoinClause $join): void {
                 $join->on('sosa.majs_gen', '<', 'list_gen.majs_gen')
                     ->where('majs_gedcom_id', '=', $this->tree->id())
                     ->where('majs_user_id', '=', $this->user->id());
             })
-            ->leftJoin('maj_sosa AS sosa_fat', function (JoinClause $join) use ($table_prefix): void {
+            ->leftJoin('maj_sosa AS sosa_fat', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's father
-                $join->whereRaw($table_prefix . 'sosa_fat.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa')
+                $join->whereRaw($table_prefix.'sosa_fat.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa')
                     ->where('sosa_fat.majs_gedcom_id', '=', $this->tree->id())
                     ->where('sosa_fat.majs_user_id', '=', $this->user->id());
             })
-            ->leftJoin('maj_sosa AS sosa_mot', function (JoinClause $join) use ($table_prefix): void {
+            ->leftJoin('maj_sosa AS sosa_mot', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's mother
-                $join->whereRaw($table_prefix . 'sosa_mot.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa + 1')
+                $join->whereRaw($table_prefix.'sosa_mot.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa + 1')
                     ->where('sosa_mot.majs_gedcom_id', '=', $this->tree->id())
                     ->where('sosa_mot.majs_user_id', '=', $this->user->id());
             })
             ->where('sosa.majs_gedcom_id', '=', $this->tree->id())
             ->where('sosa.majs_user_id', '=', $this->user->id())
-            ->where(function (Builder $query): void {
+            ->where(function(Builder $query): void {
                 $query->whereNull('sosa_fat.majs_i_id')
                 ->orWhereNull('sosa_mot.majs_i_id');
             });
@@ -298,24 +297,24 @@ 
          */
         $non_roots_ancestors = DB::table('maj_sosa AS sosa')
             ->select(['sosa.majs_gen', 'sosa.majs_gedcom_id', 'sosa.majs_user_id', 'sosa.majs_sosa'])
-            ->selectRaw('MAX(' . $table_prefix . 'sosa_anc.majs_sosa) - MIN(' . $table_prefix . 'sosa_anc.majs_sosa)' .
+            ->selectRaw('MAX('.$table_prefix.'sosa_anc.majs_sosa) - MIN('.$table_prefix.'sosa_anc.majs_sosa)'.
                 ' AS full_ancestors')
-            ->join('maj_sosa AS sosa_anc', function (JoinClause $join) use ($table_prefix): void {
+            ->join('maj_sosa AS sosa_anc', function(JoinClause $join) use ($table_prefix): void {
                 $join->on('sosa.majs_gen', '<', 'sosa_anc.majs_gen')
-                    ->whereRaw('FLOOR(' . $table_prefix . 'sosa_anc.majs_sosa / POWER(2, ' .
-                        $table_prefix . 'sosa_anc.majs_gen - ' . $table_prefix . 'sosa.majs_gen)) = ' .
-                        $table_prefix . 'sosa.majs_sosa')
+                    ->whereRaw('FLOOR('.$table_prefix.'sosa_anc.majs_sosa / POWER(2, '.
+                        $table_prefix.'sosa_anc.majs_gen - '.$table_prefix.'sosa.majs_gen)) = '.
+                        $table_prefix.'sosa.majs_sosa')
                     ->where('sosa_anc.majs_gedcom_id', '=', $this->tree->id())
                     ->where('sosa_anc.majs_user_id', '=', $this->user->id());
             })
             ->where('sosa.majs_gedcom_id', '=', $this->tree->id())
             ->where('sosa.majs_user_id', '=', $this->user->id())
-            ->whereIn('sosa_anc.majs_i_id', function (Builder $query) use ($table_prefix): void {
+            ->whereIn('sosa_anc.majs_i_id', function(Builder $query) use ($table_prefix): void {
                 $query->from('maj_sosa AS sosa_gen')
                 ->select('sosa_gen.majs_i_id')->distinct()
                 ->where('sosa_gen.majs_gedcom_id', '=', $this->tree->id())
                 ->where('sosa_gen.majs_user_id', '=', $this->user->id())
-                ->whereRaw($table_prefix . 'sosa_gen.majs_gen = ' . $table_prefix . 'sosa.majs_gen');
+                ->whereRaw($table_prefix.'sosa_gen.majs_gen = '.$table_prefix.'sosa.majs_gen');
             })
             ->groupBy(['sosa.majs_gen', 'sosa.majs_gedcom_id', 'sosa.majs_user_id',
                 'sosa.majs_sosa', 'sosa.majs_i_id']);
@@ -328,7 +327,7 @@ 
             ->select(['sosa.majs_gen AS gen', 'sosa.majs_gedcom_id', 'sosa.majs_user_id'])
             ->addSelect(['sosa.majs_i_id', 'sosa.majs_gen'])
             ->selectRaw('1 AS contrib')
-            ->leftJoinSub($non_roots_ancestors, 'nonroot', function (JoinClause $join): void {
+            ->leftJoinSub($non_roots_ancestors, 'nonroot', function(JoinClause $join): void {
                 $join->on('sosa.majs_gen', '=', 'nonroot.majs_gen')
                     ->on('sosa.majs_sosa', '=', 'nonroot.majs_sosa')
                     ->where('nonroot.full_ancestors', '>', 0)
@@ -346,9 +345,9 @@ 
             ->fromSub($root_ancestors_contributions->unionAll($known_ancestors_contributions), 'sosa_contribs')
             ->select(['sosa_contribs.gen', 'sosa_contribs.majs_gedcom_id', 'sosa_contribs.majs_user_id'])
             ->addSelect(['sosa_contribs.majs_i_id', 'sosa_contribs.contrib'])
-            ->selectRaw('COUNT(' . $table_prefix . 'sosa_contribs.majs_i_id) * ' .
-                $table_prefix . 'sosa_contribs.contrib AS totalContrib')
-            ->leftJoin('maj_sosa AS sosa_low', function (JoinClause $join): void {
+            ->selectRaw('COUNT('.$table_prefix.'sosa_contribs.majs_i_id) * '.
+                $table_prefix.'sosa_contribs.contrib AS totalContrib')
+            ->leftJoin('maj_sosa AS sosa_low', function(JoinClause $join): void {
                 $join->on('sosa_low.majs_gen', '<', 'sosa_contribs.majs_gen')
                     ->on('sosa_low.majs_i_id', '=', 'sosa_contribs.majs_i_id')
                     ->where('sosa_low.majs_gedcom_id', '=', $this->tree->id())
@@ -369,9 +368,9 @@ 
 
         $pedi_collapse_by_gen = [];
         foreach ($pedi_collapse_coll as $collapse_gen) {
-            $pedi_collapse_by_gen[(int) $collapse_gen->gen] = array(
-                'pedi_collapse_roots'   =>  (float) $collapse_gen->pedi_collapse_roots,
-                'pedi_collapse_xgen'   =>  (float) $collapse_gen->pedi_collapse_xgen
+            $pedi_collapse_by_gen[(int)$collapse_gen->gen] = array(
+                'pedi_collapse_roots'   =>  (float)$collapse_gen->pedi_collapse_roots,
+                'pedi_collapse_xgen'   =>  (float)$collapse_gen->pedi_collapse_xgen
             );
         }
         return $pedi_collapse_by_gen;
@@ -399,26 +398,26 @@ 
     {
         $table_prefix = DB::connection()->getTablePrefix();
         $missing_ancestors_by_gen = DB::table('maj_sosa AS sosa')
-            ->selectRaw($table_prefix . 'sosa.majs_gen - ? AS majs_gen_norm', [$gen])
-            ->selectRaw('FLOOR(((' . $table_prefix . 'sosa.majs_sosa / POW(2, ' . $table_prefix . 'sosa.majs_gen -1 )) - 1) * POWER(2, ? - 1)) + POWER(2, ? - 1) AS root_ancestor', [$gen, $gen])   //@phpcs:ignore Generic.Files.LineLength.TooLong
-            ->selectRaw('SUM(CASE WHEN ' . $table_prefix . 'sosa_fat.majs_i_id IS NULL AND ' . $table_prefix . 'sosa_mot.majs_i_id IS NULL THEN 1 ELSE 0 END) AS full_root_count')  //@phpcs:ignore Generic.Files.LineLength.TooLong
-            ->selectRaw('SUM(CASE WHEN ' . $table_prefix . 'sosa_fat.majs_i_id IS NULL AND ' . $table_prefix . 'sosa_mot.majs_i_id IS NULL THEN 0 ELSE 1 END) As semi_root_count')  //@phpcs:ignore Generic.Files.LineLength.TooLong
-            ->leftJoin('maj_sosa AS sosa_fat', function (JoinClause $join) use ($table_prefix): void {
+            ->selectRaw($table_prefix.'sosa.majs_gen - ? AS majs_gen_norm', [$gen])
+            ->selectRaw('FLOOR((('.$table_prefix.'sosa.majs_sosa / POW(2, '.$table_prefix.'sosa.majs_gen -1 )) - 1) * POWER(2, ? - 1)) + POWER(2, ? - 1) AS root_ancestor', [$gen, $gen])   //@phpcs:ignore Generic.Files.LineLength.TooLong
+            ->selectRaw('SUM(CASE WHEN '.$table_prefix.'sosa_fat.majs_i_id IS NULL AND '.$table_prefix.'sosa_mot.majs_i_id IS NULL THEN 1 ELSE 0 END) AS full_root_count')  //@phpcs:ignore Generic.Files.LineLength.TooLong
+            ->selectRaw('SUM(CASE WHEN '.$table_prefix.'sosa_fat.majs_i_id IS NULL AND '.$table_prefix.'sosa_mot.majs_i_id IS NULL THEN 0 ELSE 1 END) As semi_root_count')  //@phpcs:ignore Generic.Files.LineLength.TooLong
+            ->leftJoin('maj_sosa AS sosa_fat', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's father
-                $join->whereRaw($table_prefix . 'sosa_fat.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa')
+                $join->whereRaw($table_prefix.'sosa_fat.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa')
                 ->where('sosa_fat.majs_gedcom_id', '=', $this->tree->id())
                 ->where('sosa_fat.majs_user_id', '=', $this->user->id());
             })
-            ->leftJoin('maj_sosa AS sosa_mot', function (JoinClause $join) use ($table_prefix): void {
+            ->leftJoin('maj_sosa AS sosa_mot', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's mother
-                $join->whereRaw($table_prefix . 'sosa_mot.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa + 1')
+                $join->whereRaw($table_prefix.'sosa_mot.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa + 1')
                 ->where('sosa_mot.majs_gedcom_id', '=', $this->tree->id())
                 ->where('sosa_mot.majs_user_id', '=', $this->user->id());
             })
             ->where('sosa.majs_gedcom_id', '=', $this->tree->id())
             ->where('sosa.majs_user_id', '=', $this->user->id())
             ->where('sosa.majs_gen', '>=', $gen)
-            ->where(function (Builder $query): void {
+            ->where(function(Builder $query): void {
                 $query->whereNull('sosa_fat.majs_i_id')
                     ->orWhereNull('sosa_mot.majs_i_id');
             })
@@ -427,11 +426,11 @@ 
         return DB::table('maj_sosa AS sosa_list')
             ->select(['stats_by_gen.root_ancestor AS root_ancestor_sosa', 'sosa_list.majs_i_id as root_ancestor_id'])
             ->selectRaw('1 + SUM( (majs_gen_norm) * ( 2 * full_root_count + semi_root_count) /  (2 * POWER(2, majs_gen_norm))) AS mean_gen_depth')  //@phpcs:ignore Generic.Files.LineLength.TooLong
-            ->selectRaw(' SQRT(' .
-                '   SUM(POWER(majs_gen_norm, 2) * ( 2 * full_root_count + semi_root_count) /  (2 * POWER(2, majs_gen_norm)))' .     //@phpcs:ignore Generic.Files.LineLength.TooLong
-                '   - POWER( SUM( (majs_gen_norm) * ( 2 * full_root_count + semi_root_count) /  (2 * POWER(2, majs_gen_norm))), 2)' .       //@phpcs:ignore Generic.Files.LineLength.TooLong
+            ->selectRaw(' SQRT('.
+                '   SUM(POWER(majs_gen_norm, 2) * ( 2 * full_root_count + semi_root_count) /  (2 * POWER(2, majs_gen_norm)))'.//@phpcs:ignore Generic.Files.LineLength.TooLong
+                '   - POWER( SUM( (majs_gen_norm) * ( 2 * full_root_count + semi_root_count) /  (2 * POWER(2, majs_gen_norm))), 2)'.//@phpcs:ignore Generic.Files.LineLength.TooLong
                 ' ) AS stddev_gen_depth')
-            ->joinSub($missing_ancestors_by_gen, 'stats_by_gen', function (JoinClause $join): void {
+            ->joinSub($missing_ancestors_by_gen, 'stats_by_gen', function(JoinClause $join): void {
                 $join->on('sosa_list.majs_sosa', '=', 'stats_by_gen.root_ancestor')
                     ->where('sosa_list.majs_gedcom_id', '=', $this->tree->id())
                     ->where('sosa_list.majs_user_id', '=', $this->user->id());
@@ -460,16 +459,16 @@ 
         $table_prefix = DB::connection()->getTablePrefix();
         $multiple_ancestors = DB::table('maj_sosa AS sosa')
             ->select('sosa.majs_i_id AS sosa_i_id')
-            ->selectRaw('COUNT(' . $table_prefix . 'sosa.majs_sosa) AS sosa_count')
-            ->leftJoin('maj_sosa AS sosa_fat', function (JoinClause $join) use ($table_prefix): void {
+            ->selectRaw('COUNT('.$table_prefix.'sosa.majs_sosa) AS sosa_count')
+            ->leftJoin('maj_sosa AS sosa_fat', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's father
-                $join->whereRaw($table_prefix . 'sosa_fat.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa')
+                $join->whereRaw($table_prefix.'sosa_fat.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa')
                     ->where('sosa_fat.majs_gedcom_id', '=', $this->tree->id())
                     ->where('sosa_fat.majs_user_id', '=', $this->user->id());
             })
-            ->leftJoin('maj_sosa AS sosa_mot', function (JoinClause $join) use ($table_prefix): void {
+            ->leftJoin('maj_sosa AS sosa_mot', function(JoinClause $join) use ($table_prefix): void {
                 // Link to sosa's mother
-                $join->whereRaw($table_prefix . 'sosa_mot.majs_sosa = 2 * ' . $table_prefix . 'sosa.majs_sosa + 1')
+                $join->whereRaw($table_prefix.'sosa_mot.majs_sosa = 2 * '.$table_prefix.'sosa.majs_sosa + 1')
                 ->where('sosa_mot.majs_gedcom_id', '=', $this->tree->id())
                 ->where('sosa_mot.majs_user_id', '=', $this->user->id());
             })
@@ -478,15 +477,15 @@ 
             ->whereNull('sosa_fat.majs_sosa')   // We keep only root individuals, i.e. those with no father or mother
             ->whereNull('sosa_mot.majs_sosa')
             ->groupBy('sosa.majs_i_id')
-            ->havingRaw('COUNT(' . $table_prefix . 'sosa.majs_sosa) > 1')    // Limit to the duplicate sosas.
-            ->orderByRaw('COUNT(' . $table_prefix . 'sosa.majs_sosa) DESC, MIN(' . $table_prefix . 'sosa.majs_sosa) ASC')   //@phpcs:ignore Generic.Files.LineLength.TooLong
+            ->havingRaw('COUNT('.$table_prefix.'sosa.majs_sosa) > 1')    // Limit to the duplicate sosas.
+            ->orderByRaw('COUNT('.$table_prefix.'sosa.majs_sosa) DESC, MIN('.$table_prefix.'sosa.majs_sosa) ASC')   //@phpcs:ignore Generic.Files.LineLength.TooLong
             ->limit($limit + 1)     // We want to select one more than required, for ties
             ->get();
 
         if ($multiple_ancestors->count() > $limit) {
             $last_count = $multiple_ancestors->last()->sosa_count;
-            $multiple_ancestors = $multiple_ancestors->reject(function (stdClass $element) use ($last_count): bool {
-                return $element->sosa_count ==  $last_count;
+            $multiple_ancestors = $multiple_ancestors->reject(function(stdClass $element) use ($last_count): bool {
+                return $element->sosa_count == $last_count;
             });
         }
         return $multiple_ancestors;

src/Webtrees/Module/Sosa/SosaModule.php

Spacing +12 added lines, -12 removed lines

@@ -70,7 +70,7 @@ 
     // How to update the database schema for this module
     private const SCHEMA_TARGET_VERSION   = 3;
     private const SCHEMA_SETTING_NAME     = 'MAJ_SOSA_SCHEMA_VERSION';
-    private const SCHEMA_MIGRATION_PREFIX = __NAMESPACE__ . '\Schema';
+    private const SCHEMA_MIGRATION_PREFIX = __NAMESPACE__.'\Schema';
 /**
      * {@inheritDoc}
      * @see \Fisharebest\Webtrees\Module\AbstractModule::title()
@@ -110,25 +110,25 @@ 
      */
     public function loadRoutes(Map $router): void
     {
-        $router->attach('', '', static function (Map $router): void {
+        $router->attach('', '', static function(Map $router): void {
 
-            $router->attach('', '/module-maj/sosa', static function (Map $router): void {
+            $router->attach('', '/module-maj/sosa', static function(Map $router): void {
 
-                $router->attach('', '/list', static function (Map $router): void {
+                $router->attach('', '/list', static function(Map $router): void {
 
                     $router->get(AncestorsList::class, '/ancestors/{tree}{/gen}', AncestorsList::class);
-                    $router->get(AncestorsListIndividual::class, '/ancestors/{tree}/{gen}/tab/individuals', AncestorsListIndividual::class);    //phpcs:ignore Generic.Files.LineLength.TooLong
-                    $router->get(AncestorsListFamily::class, '/ancestors/{tree}/{gen}/tab/families', AncestorsListFamily::class);   //phpcs:ignore Generic.Files.LineLength.TooLong
+                    $router->get(AncestorsListIndividual::class, '/ancestors/{tree}/{gen}/tab/individuals', AncestorsListIndividual::class); //phpcs:ignore Generic.Files.LineLength.TooLong
+                    $router->get(AncestorsListFamily::class, '/ancestors/{tree}/{gen}/tab/families', AncestorsListFamily::class); //phpcs:ignore Generic.Files.LineLength.TooLong
                     $router->get(MissingAncestorsList::class, '/missing/{tree}{/gen}', MissingAncestorsList::class);
                 });
 
-                $router->attach('', '/statistics/{tree}', static function (Map $router): void {
+                $router->attach('', '/statistics/{tree}', static function(Map $router): void {
 
                     $router->get(SosaStatistics::class, '', SosaStatistics::class);
                     $router->get(PedigreeCollapseData::class, '/pedigreecollapse', PedigreeCollapseData::class);
                 });
 
-                $router->attach('', '/config/{tree}', static function (Map $router): void {
+                $router->attach('', '/config/{tree}', static function(Map $router): void {
 
                     $router->get(SosaConfig::class, '', SosaConfig::class);
                     $router->post(SosaConfigAction::class, '', SosaConfigAction::class);
@@ -227,7 +227,7 @@ 
      */
     public function headContent(): string
     {
-        return '<link rel="stylesheet" href="' . e($this->moduleCssUrl()) . '">';
+        return '<link rel="stylesheet" href="'.e($this->moduleCssUrl()).'">';
     }
 
     /**
@@ -236,7 +236,7 @@ 
      */
     public function bodyContent(): string
     {
-        return '<script src="' . $this->assetUrl('js/sosa.min.js') . '"></script>';
+        return '<script src="'.$this->assetUrl('js/sosa.min.js').'"></script>';
     }
 
     /**
@@ -252,7 +252,7 @@ 
 
         $individual = Registry::individualFactory()->make($xref, $tree);
 
-        return view($this->name() . '::sidebar/title', [
+        return view($this->name().'::sidebar/title', [
             'module_name'   =>  $this->name(),
             'sosa_numbers'  =>  app(SosaRecordsService::class)->sosaNumbers($tree, $user, $individual)
         ]);
@@ -268,7 +268,7 @@ 
         $sosa_root = Registry::individualFactory()->make($sosa_root_xref, $individual->tree());
         $user = Auth::check() ? Auth::user() : new DefaultUser();
 
-        return view($this->name() . '::sidebar/content', [
+        return view($this->name().'::sidebar/content', [
             'sosa_ancestor' =>  $individual,
             'sosa_root'     =>  $sosa_root,
             'sosa_numbers'  =>  app(SosaRecordsService::class)->sosaNumbers($individual->tree(), $user, $individual)

src/Webtrees/Common/GeoDispersion/GeoAnalysis/GeoAnalysisResult.php

Spacing +7 added lines, -7 removed lines

@@ -78,7 +78,7 @@ 
      */
     public function addPlace(GeoAnalysisPlace $place): void
     {
-        if($place->isKnown()) {
+        if ($place->isKnown()) {
             /** @var GeoAnalysisResultItem $item */
             $item = $this->places->get($place->key(), new GeoAnalysisResultItem($place));
             $this->places->put($item->key(), $item->increment());
@@ -96,7 +96,7 @@ 
     {
         /** @var GeoAnalysisResultItem|null $item */
         $item = $this->places->get($place->key());
-        if($item !== null) {
+        if ($item !== null) {
             $item->place()->exclude();
         }
     }
@@ -134,7 +134,7 @@ 
     public function merge(GeoAnalysisResult $other): self
     {
         $this->places->each(function(GeoAnalysisResultItem $item) use ($other) : void {
-            if($other->places->has($item->key())) {
+            if ($other->places->has($item->key())) {
                 $item->place()->exclude(
                     $item->place()->isExcluded() 
                     && $other->places->get($item->key())->place()->isExcluded()
@@ -143,7 +143,7 @@ 
         });
         
         $other->places->each(function(GeoAnalysisResultItem $item): void {
-            if(!$this->places->has($item->key())) {
+            if (!$this->places->has($item->key())) {
                 $this->addPlace($item->place());
             }
         });
@@ -213,7 +213,7 @@ 
      */
     public function knownPlaces(bool $exclude_other = false): Collection
     {
-        if($exclude_other) {
+        if ($exclude_other) {
             return $this->places->reject(fn(GeoAnalysisResultItem $item): bool => $item->place()->isExcluded());
         }
         return $this->places;
@@ -229,8 +229,8 @@ 
     public function sortedKnownPlaces(bool $exclude_other = false): Collection
     {
         return $this->knownPlaces($exclude_other)->sortBy([
-            fn (GeoAnalysisResultItem $a, GeoAnalysisResultItem $b): int => $b->count() <=> $a->count(),
-            fn (GeoAnalysisResultItem $a, GeoAnalysisResultItem $b): int => 
+            fn(GeoAnalysisResultItem $a, GeoAnalysisResultItem $b): int => $b->count() <=> $a->count(),
+            fn(GeoAnalysisResultItem $a, GeoAnalysisResultItem $b): int => 
                 I18N::comparator()($a->place()->place()->gedcomName(), $b->place()->place()->gedcomName())
         ]);
     }

src/Webtrees/Common/GeoDispersion/GeoAnalysis/GeoAnalysisResults.php

Spacing +3 added lines, -3 removed lines

@@ -89,7 +89,7 @@ 
      */
     public function addCategory(string $description, int $order): void
     {
-        if(!$this->detailed->has($description)) {
+        if (!$this->detailed->has($description)) {
             $this->detailed->put($description, new GeoAnalysisResult($description, $order));
         }
     }
@@ -102,7 +102,7 @@ 
      */
     public function addPlaceInCreatedCategory(string $category_name, GeoAnalysisPlace $place): void
     {
-        if($this->detailed->has($category_name)) {
+        if ($this->detailed->has($category_name)) {
             $this->detailed->get($category_name)->addPlace($place);
         }
     }
@@ -115,7 +115,7 @@ 
      */
     public function addPlaceInCategory(string $category_name, int $category_order, GeoAnalysisPlace $place): void
     {
-        if(!$this->detailed->has($category_name)) {
+        if (!$this->detailed->has($category_name)) {
             $this->addCategory($category_name, $category_order);
         }
         $this->addPlaceInCreatedCategory($category_name, $place);

src/Webtrees/Common/GeoDispersion/GeoAnalysis/GeoAnalysisPlace.php

Spacing +3 added lines, -3 removed lines

@@ -64,10 +64,10 @@
      */
     private function extractPlace(?Place $place, int $depth, bool $strict_depth): ?Place
     {
-        if($place === null) return null;
-        if(mb_strlen($place->gedcomName()) === 0) return null;
+        if ($place === null) return null;
+        if (mb_strlen($place->gedcomName()) === 0) return null;
         $parts = $place->lastParts($depth);
-        if($strict_depth && $parts->count() !== $depth) return new Place(self::INVALID_PLACE, $place->tree());
+        if ($strict_depth && $parts->count() !== $depth) return new Place(self::INVALID_PLACE, $place->tree());
         return new Place($parts->implode(', '), $place->tree());
     }
     

src/Webtrees/Common/GeoDispersion/Maps/SimpleFilesystemMap.php

Spacing +2 added lines, -2 removed lines

@@ -74,11 +74,11 @@
         $reader = new GeoJSONReader();
         try {
             $feature_collection = $reader->read($this->filesystem->read($this->path));
-            if($feature_collection instanceof FeatureCollection) {
+            if ($feature_collection instanceof FeatureCollection) {
                 return $feature_collection->getFeatures();
             }
         }
-        catch(Throwable $ex) { }
+        catch (Throwable $ex) { }
         return [];
     }
     

src/Webtrees/Common/GeoDispersion/Config/GenericPlaceMapperConfig.php

Spacing +2 added lines, -2 removed lines

@@ -91,10 +91,10 @@
      */
     public function jsonDeserialize($config): self
     {
-        if(is_string($config)) {
+        if (is_string($config)) {
             return $this->jsonDeserialize(json_decode($config));
         }
-        if(is_array($config)) {
+        if (is_array($config)) {
             return $this->setConfig($config);
         }
         return $this;

src/Webtrees/Common/GeoDispersion/Config/MapColorsConfig.php

Spacing +4 added lines, -4 removed lines

@@ -64,10 +64,10 @@
     public function jsonSerialize()
     {
         return [
-            'default'   => (string) $this->defaultColor()->toHex(),
-            'stroke'    => (string) $this->strokeColor()->toHex(),
-            'maxvalue'  => (string) $this->maxValueColor()->toHex(),
-            'hover'     => (string) $this->hoverColor()->toHex(),
+            'default'   => (string)$this->defaultColor()->toHex(),
+            'stroke'    => (string)$this->strokeColor()->toHex(),
+            'maxvalue'  => (string)$this->maxValueColor()->toHex(),
+            'hover'     => (string)$this->hoverColor()->toHex(),
         ];
     }