Passed
Push — master ( b2ca54...1f995c )
by Jonathan
04:01
created
src/Webtrees/Functions/FunctionsPrintLists.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,8 +35,8 @@
 block discarded – undo
35 35
         $surn = str_replace('@N.N.', 'AAAA', $surn);
36 36
 
37 37
         return array(
38
-            $surn . 'AAAA' . $givn,
39
-            $givn . 'AAAA' . $surn,
38
+            $surn.'AAAA'.$givn,
39
+            $givn.'AAAA'.$surn,
40 40
         );
41 41
     }
42 42
 
Please login to merge, or discard this patch.
src/Webtrees/Module/Certificates/Views/CertificatesListView.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,13 +39,13 @@  discard block
 block discarded – undo
39 39
     			<input type="hidden" name="ged" value="<?= $this->data->get('url_ged') ?>">
40 40
     			<select name="city">
41 41
     			<?php foreach ($cities as $city) { ?>
42
-    				<option value="<?= Functions::encryptToSafeBase64($city) ?>" <?php if(trim($city) == trim($selected_city)) echo 'selected="selected"'?> ><?= $city ?></option>
42
+    				<option value="<?= Functions::encryptToSafeBase64($city) ?>" <?php if (trim($city) == trim($selected_city)) echo 'selected="selected"'?> ><?= $city ?></option>
43 43
     			<?php } ?>
44 44
     			</select>
45 45
     			<input type="submit" value="<?= I18N::translate('Show') ?>" />
46 46
     		</form>
47 47
     		
48
-    		<?php if($this->data->get('has_list', false)) { ?>
48
+    		<?php if ($this->data->get('has_list', false)) { ?>
49 49
     		<div class="loading-image">&nbsp;</div>
50 50
     		<div class="certificate-list">
51 51
     			<table id="<?= $this->data->get('table_id') ?>">
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     				    ?>
63 63
     					<tr>
64 64
     						<!-- Certificate date -->
65
-    						<?php if($date = $certificate->getCertificateDate()) { ?>
65
+    						<?php if ($date = $certificate->getCertificateDate()) { ?>
66 66
     						<td data-sort="<?= $date->julianDay() ?>"><?= $date->display() ?></td>
67 67
     						<?php } else { ?>
68 68
     						<td data-sort="0">&nbsp;</td>
@@ -73,8 +73,8 @@  discard block
 block discarded – undo
73 73
     						<?php 
74 74
     						$name = $certificate->getCertificateDetails() ?: '';
75 75
     						$sortname = "";
76
-    						$ct_names=preg_match("/([A-Z]{2,})/", $name, $match);
77
-    						if($ct_names > 0) $sortname = $match[1].'_';
76
+    						$ct_names = preg_match("/([A-Z]{2,})/", $name, $match);
77
+    						if ($ct_names > 0) $sortname = $match[1].'_';
78 78
     						$sortname .= $name;
79 79
     						?>
80 80
     						<td data-sort="<?= Filter::escapeHtml($sortname) ?>">
Please login to merge, or discard this patch.
src/Webtrees/Module/WelcomeBlockModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
             return $wb_controller->config($block_id);
92 92
         }
93 93
         catch (MvcException $ex) {
94
-            if($ex->getHttpCode() != 200) throw $ex;
94
+            if ($ex->getHttpCode() != 200) throw $ex;
95 95
             return;
96 96
         }     
97 97
     }
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Model/SosaCalculator.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         $this->tree = $tree;
59 59
         $this->user = $user;
60 60
         
61
-        $this->sosa_provider = new SosaProvider($this->tree, $this->user);;
61
+        $this->sosa_provider = new SosaProvider($this->tree, $this->user); ;
62 62
     }
63 63
     
64 64
     /**
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     public function computeAll() {
69 69
         $root_id = $this->tree->getUserPreference($this->user, 'MAJ_SOSA_ROOT_ID');        
70 70
         $indi = Individual::getInstance($root_id, $this->tree);
71
-        if($indi){
71
+        if ($indi) {
72 72
             $this->sosa_provider->deleteAll();
73 73
             $this->addNode($indi, 1);
74 74
             $this->flushTmpSosaTable(true);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     public function computeFromIndividual(Individual $indi) {
86 86
         $dindi = new \MyArtJaub\Webtrees\Individual($indi);
87 87
         $current_sosas = $dindi->getSosaNumbers();
88
-        foreach($current_sosas as $current_sosa => $gen) {
88
+        foreach ($current_sosas as $current_sosa => $gen) {
89 89
             $this->sosa_provider->deleteAncestors($current_sosa);
90 90
             $this->addNode($indi, $current_sosa);
91 91
         }
@@ -111,9 +111,9 @@  discard block
 block discarded – undo
111 111
         
112 112
         $this->flushTmpSosaTable();
113 113
         
114
-        if($fam = $indi->getPrimaryChildFamily()) {
115
-            if($husb = $fam->getHusband()) $this->addNode($husb, 2 * $sosa);
116
-            if($wife = $fam->getWife()) $this->addNode($wife, 2 * $sosa + 1);
114
+        if ($fam = $indi->getPrimaryChildFamily()) {
115
+            if ($husb = $fam->getHusband()) $this->addNode($husb, 2 * $sosa);
116
+            if ($wife = $fam->getWife()) $this->addNode($wife, 2 * $sosa + 1);
117 117
         }
118 118
     }
119 119
     
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
123 123
      * @param bool $force Should the flush be forced
124 124
      */
125 125
     protected function flushTmpSosaTable($force = false) {
126
-        if( count($this->tmp_sosa_table)> 0 && 
127
-            ($force ||  count($this->tmp_sosa_table) >= self::TMP_SOSA_TABLE_LIMIT)){            
126
+        if (count($this->tmp_sosa_table) > 0 && 
127
+            ($force || count($this->tmp_sosa_table) >= self::TMP_SOSA_TABLE_LIMIT)) {            
128 128
                 $this->sosa_provider->insertOrUpdate($this->tmp_sosa_table);
129 129
                 $this->tmp_sosa_table = array();
130 130
         }
Please login to merge, or discard this patch.
src/Webtrees/Module/HooksModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
     public function getConfigLink() {
58 58
         Database::updateSchema(self::SCHEMA_MIGRATION_PREFIX, self::SCHEMA_SETTING_NAME, self::SCHEMA_TARGET_VERSION);
59 59
         
60
-        return 'module.php?mod=' . $this->getName() . '&amp;mod_action=AdminConfig';
60
+        return 'module.php?mod='.$this->getName().'&amp;mod_action=AdminConfig';
61 61
     }
62 62
     
63 63
     /**
Please login to merge, or discard this patch.
src/Webtrees/Fact.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 	*
39 39
 	* @param \Fisharebest\Webtrees\Fact $fact_in The Fact to extend
40 40
 	*/
41
-	public function __construct(\Fisharebest\Webtrees\Fact $fact_in){
41
+	public function __construct(\Fisharebest\Webtrees\Fact $fact_in) {
42 42
 		$this->fact = $fact_in;
43 43
 	}
44 44
 	
@@ -54,22 +54,22 @@  discard block
 block discarded – undo
54 54
 	*
55 55
 	* @return int Level of sources
56 56
 	*/
57
-	public function isSourced(){
58
-		$isSourced=0;
57
+	public function isSourced() {
58
+		$isSourced = 0;
59 59
 		$date = $this->fact->getDate();
60
-		if($date->isOK()) {
61
-			$isSourced=-1;
62
-			if($date->qual1=='' && $date->minimumJulianDay() == $date->maximumJulianDay()){
63
-				$isSourced=-2;
60
+		if ($date->isOK()) {
61
+			$isSourced = -1;
62
+			if ($date->qual1 == '' && $date->minimumJulianDay() == $date->maximumJulianDay()) {
63
+				$isSourced = -2;
64 64
 				$citations = $this->fact->getCitations();
65
-				foreach($citations as $citation){
66
-					$isSourced=max($isSourced, 1);
67
-					if(preg_match('/3 _ACT (.*)/', $citation) ){
68
- 						$isSourced=max($isSourced, 2);
65
+				foreach ($citations as $citation) {
66
+					$isSourced = max($isSourced, 1);
67
+					if (preg_match('/3 _ACT (.*)/', $citation)) {
68
+ 						$isSourced = max($isSourced, 2);
69 69
  						preg_match_all("/4 DATE (.*)/", $citation, $datessource, PREG_SET_ORDER);
70
- 						foreach($datessource as $daterec){
70
+ 						foreach ($datessource as $daterec) {
71 71
  							$datesource = new Date($daterec[1]);
72
- 							if(abs($datesource->julianDay() - $date->julianDay()) < self::DATE_PRECISION_MARGIN){
72
+ 							if (abs($datesource->julianDay() - $date->julianDay()) < self::DATE_PRECISION_MARGIN) {
73 73
  								$isSourced = max($isSourced, 3); //If this level increases, do not forget to change the constant MAX_IS_SOURCED_LEVEL
74 74
  							}
75 75
  						}
Please login to merge, or discard this patch.
src/Webtrees/Module/WelcomeBlock/WelcomeBlockController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     public function index(PageController $parent_controller, Tree $tree, $block_id, $template) {        
46 46
         $view_bag = new ViewBag();
47 47
         
48
-        if($parent_controller && $tree) {
48
+        if ($parent_controller && $tree) {
49 49
         
50 50
             $view_bag->set('tree', $tree);
51 51
             $view_bag->set('indi', $parent_controller->getSignificantIndividual());
@@ -64,22 +64,22 @@  discard block
 block discarded – undo
64 64
     			');
65 65
     
66 66
             if (Auth::isAdmin()) {
67
-                $title='<a class="icon-admin" title="'.I18N::translate('Preferences').'" href="block_edit.php?block_id='.$block_id.'&amp;ged=' . $tree->getNameHtml() . '&amp;ctype=gedcom"></a>';
67
+                $title = '<a class="icon-admin" title="'.I18N::translate('Preferences').'" href="block_edit.php?block_id='.$block_id.'&amp;ged='.$tree->getNameHtml().'&amp;ctype=gedcom"></a>';
68 68
             } else {
69
-                $title='';
69
+                $title = '';
70 70
             }
71
-            $title .='<span dir="auto">'.$tree->getTitleHtml().'</span>';
71
+            $title .= '<span dir="auto">'.$tree->getTitleHtml().'</span>';
72 72
     
73 73
             $piwik_enabled = $this->module->getBlockSetting($block_id, 'piwik_enabled', false);
74 74
             $view_bag->set('piwik_enabled', $piwik_enabled);
75
-            if($piwik_enabled) {
75
+            if ($piwik_enabled) {
76 76
                 $parent_controller->addInlineJavascript(
77 77
                     '$("#piwik_stats")
78 78
                         .load("module.php?mod='.$this->module->getName().'&mod_action=Piwik&block_id='.$block_id.'");'
79 79
                 );
80 80
             }
81 81
     
82
-            $content = ViewFactory::make('WelcomeBlock', $this,  new BaseController(), $view_bag)->getHtmlPartial();   
82
+            $content = ViewFactory::make('WelcomeBlock', $this, new BaseController(), $view_bag)->getHtmlPartial();   
83 83
             
84 84
             if ($template) {
85 85
                 return Theme::theme()->formatBlock($id, $title, $class, $content);
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
      */
99 99
     public function config($block_id = null) {
100 100
         
101
-        if(empty($block_id)) throw new MvcException(404);
101
+        if (empty($block_id)) throw new MvcException(404);
102 102
 
103 103
         if (Filter::postBool('save') && Filter::checkCsrf()) {
104 104
             $this->module->setBlockSetting($block_id, 'piwik_enabled', Filter::postBool('piwik_enabled'));
Please login to merge, or discard this patch.
src/Webtrees/Module/WelcomeBlock/Views/WelcomeBlockView.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -36,20 +36,20 @@  discard block
 block discarded – undo
36 36
             '<table>
37 37
                 <tr>
38 38
                     <td>
39
-                        <a href="pedigree.php?rootid=' . $indi->getXref() . '&amp;ged=' . $tree->getNameUrl() . '">
40
-                            <i class="icon-pedigree"></i><br>' . I18N::translate('Default chart') . '
39
+                        <a href="pedigree.php?rootid=' . $indi->getXref().'&amp;ged='.$tree->getNameUrl().'">
40
+                            <i class="icon-pedigree"></i><br>' . I18N::translate('Default chart').'
41 41
                         </a>
42 42
                     </td>
43 43
                     <td>
44
-                        <a href="individual.php?pid=' . $indi->getXref() . '&amp;ged=' . $tree->getNameUrl() . '">
45
-                            <i class="icon-indis"></i><br>' . I18N::translate('Default individual') . '
44
+                        <a href="individual.php?pid=' . $indi->getXref().'&amp;ged='.$tree->getNameUrl().'">
45
+                            <i class="icon-indis"></i><br>' . I18N::translate('Default individual').'
46 46
                         </a>
47 47
                     </td>';
48 48
         
49 49
         if (Site::getPreference('USE_REGISTRATION_MODULE') && !Auth::check()) {
50 50
             $content .= '
51 51
                     <td>
52
-                        <a href="' . WT_LOGIN_URL . '?action=register">
52
+                        <a href="' . WT_LOGIN_URL.'?action=register">
53 53
                             <i class="icon-user_add"></i><br>'.I18N::translate('Request a new user account').'
54 54
                         </a>
55 55
                     </td>';
@@ -59,16 +59,16 @@  discard block
 block discarded – undo
59 59
             </table>';
60 60
         
61 61
         // Piwik Statistics        
62
-        if ($this->data->get('piwik_enabled', false)){
62
+        if ($this->data->get('piwik_enabled', false)) {
63 63
             $content .= '
64 64
                 <div class="center">
65 65
                     <div id="piwik_stats">
66
-                        <i class="icon-loading-small"></i>&nbsp;' . I18N::translate('Retrieving Piwik statistics...') . '
66
+                        <i class="icon-loading-small"></i>&nbsp;' . I18N::translate('Retrieving Piwik statistics...').'
67 67
                     </div>
68 68
                 </div>';
69 69
         }
70 70
         
71
-        $content .=  '<hr />';
71
+        $content .= '<hr />';
72 72
         
73 73
         // Login section - based on login_block
74 74
         if (Auth::check()) {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             <div class="center">
77 77
                 <form method="post" action="logout.php" name="logoutform" onsubmit="return true;">
78 78
                     <br>' . 
79
-                    I18N::translate('You are signed in as %s.', '<a href="edituser.php" class="name2">' . Auth::user()->getRealNameHtml() . '</a>') .
79
+                    I18N::translate('You are signed in as %s.', '<a href="edituser.php" class="name2">'.Auth::user()->getRealNameHtml().'</a>').
80 80
                     '<br><br>
81 81
                     <input type="submit" value="'.I18N::translate('sign out').'">
82 82
                     <br><br>
@@ -98,34 +98,34 @@  discard block
 block discarded – undo
98 98
 						</label>
99 99
 					</div>
100 100
 					<div>
101
-						<input type="submit" value="'. I18N::translate('sign in'). '">
101
+						<input type="submit" value="'. I18N::translate('sign in').'">
102 102
 					</div>
103 103
 					<div>
104 104
 						<a href="#" id="maj-passwd_click">'. I18N::translate('Request a new password').'</a>
105 105
 					</div>';
106 106
             if (Site::getPreference('USE_REGISTRATION_MODULE')) {
107
-                $content.= '
107
+                $content .= '
108 108
                     <div>
109
-                        <a href="'.WT_LOGIN_URL.'?action=register">'. I18N::translate('Request a new user account').'</a>
109
+                        <a href="'.WT_LOGIN_URL.'?action=register">'.I18N::translate('Request a new user account').'</a>
110 110
                     </div>';
111 111
             }
112
-            $content.= '
112
+            $content .= '
113 113
                 </form>'; // close "login-form"
114 114
              
115 115
             // hidden New Password block
116
-            $content.= '
116
+            $content .= '
117 117
                 <div id="maj-new_passwd">
118 118
                     <form id="maj-new_passwd_form" name="new_passwd_form" action="'.WT_LOGIN_URL.'" method="post">
119 119
                         <input type="hidden" name="time" value="">
120 120
                         <input type="hidden" name="action" value="requestpw">
121 121
                         <h4>'. I18N::translate('Lost password request').'</h4>
122 122
                         <div>
123
-                            <label for="maj-new_passwd_username">'. I18N::translate('Username or email address') . '
123
+                            <label for="maj-new_passwd_username">'. I18N::translate('Username or email address').'
124 124
                                 <input type="text" id="maj-new_passwd_username" name="new_passwd_username" value="">
125 125
                             </label>
126 126
         				</div>
127 127
         				<div>
128
-                            <input type="submit" value="'. I18N::translate('Continue'). '">
128
+                            <input type="submit" value="'. I18N::translate('Continue').'">
129 129
                         </div>
130 130
                     </form>
131 131
                 </div>
Please login to merge, or discard this patch.
src/Webtrees/Module/WelcomeBlock/PiwikController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
      * @param string $period
31 31
      * @param (null|int) Number of visits
32 32
      */
33
-    private function getNumberOfVisitsPiwik($block_id, $period='year'){
33
+    private function getNumberOfVisitsPiwik($block_id, $period = 'year') {
34 34
     
35 35
         $piwik_url = $this->module->getBlockSetting($block_id, 'piwik_url');
36 36
         $piwik_siteid = $this->module->getBlockSetting($block_id, 'piwik_siteid');
37 37
         $piwik_token = $this->module->getBlockSetting($block_id, 'piwik_token');
38 38
     
39
-        if($piwik_url && strlen($piwik_url) > 0 &&
40
-            $piwik_siteid  && strlen($piwik_siteid) > 0 &&
39
+        if ($piwik_url && strlen($piwik_url) > 0 &&
40
+            $piwik_siteid && strlen($piwik_siteid) > 0 &&
41 41
             $piwik_token && strlen($piwik_token)            
42 42
             ) 
43 43
         {        
@@ -48,9 +48,9 @@  discard block
 block discarded – undo
48 48
             $url .= '&format=PHP';
49 49
             $url .= '&token_auth='.$piwik_token;
50 50
         
51
-            if($fetched = File::fetchUrl($url)) {
51
+            if ($fetched = File::fetchUrl($url)) {
52 52
                 $content = @unserialize($fetched);
53
-                if(is_numeric($content)) return $content;
53
+                if (is_numeric($content)) return $content;
54 54
             }
55 55
         }
56 56
     
@@ -72,20 +72,20 @@  discard block
 block discarded – undo
72 72
         $data->set('has_stats', false);
73 73
         
74 74
         $block_id = Filter::get('block_id');        
75
-        if($block_id){
75
+        if ($block_id) {
76 76
             $cached_item = Cache::get('piwikCountYear', $this->module);
77 77
             $visitCountYear = $cached_item->get();
78
-            if(!$cached_item->isHit()) {
78
+            if (!$cached_item->isHit()) {
79 79
                 $visitCountYear = $this->getNumberOfVisitsPiwik($block_id);
80
-                if(!is_null($visitCountYear)) {
81
-                    $cached_item->expiresAt(new \DateTime('tomorrow'));  // Expires the next day at midnight
80
+                if (!is_null($visitCountYear)) {
81
+                    $cached_item->expiresAt(new \DateTime('tomorrow')); // Expires the next day at midnight
82 82
                     Cache::save($cached_item, $visitCountYear);
83 83
                 }
84 84
             }
85 85
             
86
-            if($visitCountYear){
86
+            if ($visitCountYear) {
87 87
                 $visitCountToday = max(0, $this->getNumberOfVisitsPiwik($block_id, 'day'));
88
-                $visitCountYear = max( 0, $visitCountYear);
88
+                $visitCountYear = max(0, $visitCountYear);
89 89
                 
90 90
                 $data->set('has_stats', true);
91 91
                 $data->set('visits_today', $visitCountToday);
Please login to merge, or discard this patch.