MyArtJaub\Webtrees\Module\GeoDispersion\Http\RequestHandlers\MapAdapterEditAction::handle()

Complexity

Conditions	8
Paths	7

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = $request->getAttribute('tree');
        assert($tree instanceof Tree);

        if ($this->module === null) {
            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                'danger'
            );
            return redirect(route(AdminConfigPage::class, ['tree' => $tree]));
        }

        $adapter_id = (int) $request->getAttribute('adapter_id');
        $map_adapter = $this->mapadapter_data_service->find($adapter_id);

        $params = (array) $request->getParsedBody();

        $map = $this->map_definition_service->find($params['map_adapter_map'] ?? '');
        $mapping_property   = $params['map_adapter_property_selected'] ?? '';

        $mapper = null;

The assignment to $mapper is dead and can be removed.

        try {
            $mapper = app($params['map_adapter_mapper'] ?? '');
        } catch (BindingResolutionException $ex) {

Consider adding a comment why this CATCH block is empty.

        }

        if ($map_adapter === null || $map === null || $mapper === null || !($mapper instanceof PlaceMapperInterface)) {
            FlashMessages::addMessage(
                I18N::translate('The parameters for the map configuration are not valid.'),
                'danger'
            );
            return redirect(route(AdminConfigPage::class, ['tree' => $tree]));
        }

        $mapper->setConfig($mapper->config()->withConfigUpdate($request));
        $new_map_adapter = $map_adapter->with($map, $mapper, $mapping_property);
        if ($this->mapadapter_data_service->update($new_map_adapter) > 0) {
            FlashMessages::addMessage(
                I18N::translate('The map configuration has been successfully updated'),
                'success'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addConfigurationLog('Module ' . $this->module->title() . ' : Map Adapter “' . $map_adapter->id() . '” has been updated.');
        } else {
            FlashMessages::addMessage(
                I18N::translate('An error occured while updating the map configuration'),
                'danger'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addConfigurationLog('Module ' . $this->module->title() . ' : Map Adapter “' . $map_adapter->id() . '” could not be updated. See error log.');
        }

        return redirect(route(GeoAnalysisViewEditPage::class, [
            'tree' => $tree->name(),
            'view_id' => $map_adapter->geoAnalysisViewId()
        ]));