jon48 /
webtrees-lib
| Conditions | 9 |
| Paths | 7 |
| Total Lines | 64 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 56 | { |
||
| 57 | $tree = $request->getAttribute('tree'); |
||
| 58 | assert($tree instanceof Tree); |
||
| 59 | |||
| 60 | $admin_config_route = route(AdminConfigPage::class, ['tree' => $tree->name()]); |
||
| 61 | |||
| 62 | if ($this->module === null) { |
||
| 63 | FlashMessages::addMessage( |
||
| 64 | I18N::translate('The attached module could not be found.'), |
||
| 65 | 'danger' |
||
| 66 | ); |
||
| 67 | return redirect($admin_config_route); |
||
| 68 | } |
||
| 69 | |||
| 70 | |||
| 71 | $view_id = (int) $request->getAttribute('view_id'); |
||
| 72 | $view = $this->geoview_data_service->find($tree, $view_id, true); |
||
| 73 | |||
| 74 | $params = (array) $request->getParsedBody(); |
||
| 75 | |||
| 76 | $description = $params['view_description'] ?? ''; |
||
| 77 | $place_depth = (int) ($params['view_depth'] ?? 1); |
||
| 78 | $top_places = (int) ($params['view_top_places'] ?? 0); |
||
| 79 | |||
| 80 | $analysis = null; |
||
|
Unused Code
introduced
by
|
|||
| 81 | try { |
||
| 82 | $analysis = app($params['view_analysis'] ?? ''); |
||
| 83 | } catch (BindingResolutionException $ex) { |
||
| 84 | } |
||
| 85 | |||
| 86 | if ( |
||
| 87 | $view === null |
||
| 88 | || $analysis === null || !($analysis instanceof GeoAnalysisInterface) |
||
| 89 | || $place_depth <= 0 && $top_places < 0 |
||
| 90 | ) { |
||
| 91 | FlashMessages::addMessage( |
||
| 92 | I18N::translate('The parameters for view with ID “%d” are not valid.', I18N::number($view_id)), |
||
| 93 | 'danger' |
||
| 94 | ); |
||
| 95 | return redirect($admin_config_route); |
||
| 96 | } |
||
| 97 | |||
| 98 | $new_view = $view |
||
| 99 | ->with($view->isEnabled(), $description, $analysis, $place_depth, $top_places) |
||
| 100 | ->withGlobalSettingsUpdate($request); |
||
| 101 | |||
| 102 | if ($this->geoview_data_service->update($new_view) > 0) { |
||
| 103 | FlashMessages::addMessage( |
||
| 104 | I18N::translate('The geographical dispersion analysis view has been successfully updated'), |
||
| 105 | 'success' |
||
| 106 | ); |
||
| 107 | //phpcs:ignore Generic.Files.LineLength.TooLong |
||
| 108 | Log::addConfigurationLog('Module ' . $this->module->title() . ' : View “' . $view->id() . '” has been updated.'); |
||
| 109 | } else { |
||
| 110 | FlashMessages::addMessage( |
||
| 111 | I18N::translate('An error occured while updating the geographical dispersion analysis view'), |
||
| 112 | 'danger' |
||
| 113 | ); |
||
| 114 | //phpcs:ignore Generic.Files.LineLength.TooLong |
||
| 115 | Log::addConfigurationLog('Module ' . $this->module->title() . ' : View “' . $view->id() . '” could not be updated. See error log.'); |
||
| 116 | } |
||
| 117 | |||
| 118 | return redirect($admin_config_route); |
||
| 119 | } |
||
| 121 |
Loading history...