Passed
Branch feature/2.0 (2da243)
by Jonathan
05:05
created
src/Webtrees/Constants.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	 * @return string $WT_RAPHAEL_JS_URL
62 62
 	 */
63 63
 	public static function WT_RAPHAEL_JS_URL() {
64
-	    return WT_STATIC_URL . 'packages/raphael-2.1.4/raphael-min.js';
64
+	    return WT_STATIC_URL.'packages/raphael-2.1.4/raphael-min.js';
65 65
 	}
66 66
 		
67 67
 }
68 68
\ No newline at end of file
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Schema/Migration0.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@
 block discarded – undo
22 22
 	public function upgrade() {
23 23
 
24 24
 		Database::exec(
25
-		    'CREATE TABLE IF NOT EXISTS `##maj_sosa` (' .
26
-	        ' majs_gedcom_id      INTEGER 	        NOT NULL,' .
27
-		    ' majs_user_id        INTEGER           NOT NULL DEFAULT -1,' . 
28
-		    ' majs_sosa           BIGINT UNSIGNED 	NOT NULL,' . // Allow to calculate sosa on 64 generations
29
-            ' majs_i_id           VARCHAR(20)	    NOT NULL,' .	
30
-            ' majs_gen            TINYINT			NULL,' .
31
-            ' majs_birth_year	  SMALLINT			NULL,' .
32
-            ' majs_death_year	  SMALLINT			NULL,' .
33
-            ' PRIMARY KEY (majs_gedcom_id, majs_user_id, majs_sosa),' .
34
-		    ' FOREIGN KEY `##gedcom_id_fk1` (majs_gedcom_id) REFERENCES `##gedcom` (gedcom_id) ON DELETE CASCADE,' .
35
-		    ' FOREIGN KEY `##user_id_fk1` (majs_user_id) REFERENCES `##user` (user_id) ON DELETE CASCADE' .			
25
+		    'CREATE TABLE IF NOT EXISTS `##maj_sosa` ('.
26
+	        ' majs_gedcom_id      INTEGER 	        NOT NULL,'.
27
+		    ' majs_user_id        INTEGER           NOT NULL DEFAULT -1,'. 
28
+		    ' majs_sosa           BIGINT UNSIGNED 	NOT NULL,'.// Allow to calculate sosa on 64 generations
29
+            ' majs_i_id           VARCHAR(20)	    NOT NULL,'.	
30
+            ' majs_gen            TINYINT			NULL,'.
31
+            ' majs_birth_year	  SMALLINT			NULL,'.
32
+            ' majs_death_year	  SMALLINT			NULL,'.
33
+            ' PRIMARY KEY (majs_gedcom_id, majs_user_id, majs_sosa),'.
34
+		    ' FOREIGN KEY `##gedcom_id_fk1` (majs_gedcom_id) REFERENCES `##gedcom` (gedcom_id) ON DELETE CASCADE,'.
35
+		    ' FOREIGN KEY `##user_id_fk1` (majs_user_id) REFERENCES `##user` (user_id) ON DELETE CASCADE'.			
36 36
 		    ') COLLATE utf8_unicode_ci ENGINE=InnoDB'
37 37
 		);
38 38
 	}
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaListView.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
         <div id="maj-sosa-list-page" class="center">
29 29
 			<h2><?php echo $this->data->get('title'); ?></h2>
30 30
 			
31
-			<?php  if($this->data->get('is_setup')) { 
31
+			<?php  if ($this->data->get('is_setup')) { 
32 32
 			    $selectedgen = $this->data->get('generation');
33 33
 			    $this->renderSosaHeader();
34
-			    if($this->data->get('has_sosa') ) {
35
-			         if($selectedgen > 0) {
34
+			    if ($this->data->get('has_sosa')) {
35
+			         if ($selectedgen > 0) {
36 36
 			        ?>
37 37
 			<div id="sosalist-tabs">
38 38
 				<ul>
@@ -75,9 +75,9 @@  discard block
 block discarded – undo
75 75
         ?>
76 76
         
77 77
     	<form method="get" name="setgen" action="module.php">
78
-			<input type="hidden" name="mod" value="<?php echo $this->data->get('url_module');?>">
79
-			<input type="hidden" name="mod_action" value="<?php echo $this->data->get('url_action');?>">
80
-			<input type="hidden" name="ged" value="<?php echo $this->data->get('url_ged');?>">
78
+			<input type="hidden" name="mod" value="<?php echo $this->data->get('url_module'); ?>">
79
+			<input type="hidden" name="mod_action" value="<?php echo $this->data->get('url_action'); ?>">
80
+			<input type="hidden" name="ged" value="<?php echo $this->data->get('url_ged'); ?>">
81 81
 			<div class="maj-table">
82 82
 				<div class="maj-row">
83 83
 					<div class="label"><?php echo I18N::translate('Choose generation') ?></div>
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 				<div class="maj-row">
86 86
 					<div class="value">
87 87
 						<select name="gen">							
88
-						<?php for($i=$this->data->get('min_gen'); $i <= $max_gen;$i++) {?>
88
+						<?php for ($i = $this->data->get('min_gen'); $i <= $max_gen; $i++) {?>
89 89
 							<option value="<?php echo $i; ?>"
90
-							<?php if($selectedgen && $selectedgen==$i) { ?> selected="true" <?php } ?>
90
+							<?php if ($selectedgen && $selectedgen == $i) { ?> selected="true" <?php } ?>
91 91
                 			><?php echo I18N::translate('Generation %d', $i); ?>
92 92
                 			</option>
93 93
                 		<?php } ?>
@@ -95,21 +95,21 @@  discard block
 block discarded – undo
95 95
                 	</div>
96 96
                 </div>
97 97
       		</div>
98
-      		<input type="submit" value="<?php echo I18N::translate('Show');?>" />
98
+      		<input type="submit" value="<?php echo I18N::translate('Show'); ?>" />
99 99
       		<br />
100 100
       	</form>
101
-      	<?php if($selectedgen > 0) { ?>
101
+      	<?php if ($selectedgen > 0) { ?>
102 102
 		<h4>
103
-			<?php if($selectedgen > $this->data->get('min_gen')) { ?>
104
-			<a href="module.php?mod=<?php echo $this->data->get('url_module');?>&mod_action=<?php echo $this->data->get('url_action');?>&ged=<?php echo $this->data->get('url_ged');?>&gen=<?php echo $selectedgen-1; ?>">
103
+			<?php if ($selectedgen > $this->data->get('min_gen')) { ?>
104
+			<a href="module.php?mod=<?php echo $this->data->get('url_module'); ?>&mod_action=<?php echo $this->data->get('url_action'); ?>&ged=<?php echo $this->data->get('url_ged'); ?>&gen=<?php echo $selectedgen - 1; ?>">
105 105
 				<i class="icon-ldarrow" title="<?php echo I18N::translate('Previous generation'); ?>" ></i>
106 106
 			</a>
107 107
 			&nbsp;&nbsp;
108 108
 			<?php } ?>
109 109
 			<?php echo I18N::translate('Generation %d', $selectedgen); ?>
110
-			<?php if($selectedgen < $max_gen) { ?>
110
+			<?php if ($selectedgen < $max_gen) { ?>
111 111
 			&nbsp;&nbsp;
112
-			<a href="module.php?mod=<?php echo $this->data->get('url_module');?>&mod_action=<?php echo $this->data->get('url_action');?>&ged=<?php echo $this->data->get('url_ged');?>&gen=<?php echo $selectedgen+1; ?>">
112
+			<a href="module.php?mod=<?php echo $this->data->get('url_module'); ?>&mod_action=<?php echo $this->data->get('url_action'); ?>&ged=<?php echo $this->data->get('url_ged'); ?>&gen=<?php echo $selectedgen + 1; ?>">
113 113
 				<i class="icon-rdarrow" title="<?php echo I18N::translate('Next generation'); ?>" ></i>
114 114
 			</a>
115 115
 			<?php } ?>
Please login to merge, or discard this patch.
src/Webtrees/Module/Sosa/Views/SosaComputeResultView.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,14 +25,14 @@
 block discarded – undo
25 25
 	 */
26 26
     protected function renderContent() {        
27 27
         
28
-        if($this->data->get('is_success', false)) {
28
+        if ($this->data->get('is_success', false)) {
29 29
         ?>        
30 30
         	<i class="icon-maj-success" title="<?php echo I18N::translate('Success'); ?>"></i>&nbsp;
31 31
         	<?php echo I18N::translate('Success'); ?>
32 32
         <?php } else { ?>
33 33
 			<i class="icon-maj-error" title="<?php echo I18N::translate('Error'); ?>"></i>&nbsp;
34 34
 			<?php echo I18N::translate('Error'); ?>
35
-			<?php if($error = $this->data->get('error')) { echo '&nbsp;-&nbsp;' . $error; }
35
+			<?php if ($error = $this->data->get('error')) { echo '&nbsp;-&nbsp;'.$error; }
36 36
         }
37 37
     }
38 38
     
Please login to merge, or discard this patch.
src/Webtrees/Module/Hooks/Views/AdminConfigView.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -60,13 +60,13 @@
 block discarded – undo
60 60
 							?>
61 61
 							<tr>
62 62
 								<td>
63
-									<input type="hidden" name="hook-<?php echo $hook->id;?>" value="yes" >
64
-									<?php echo FunctionsEdit::twoStateCheckbox('status-'.($hook->id), ($hook->status)=='enabled'); ?>
63
+									<input type="hidden" name="hook-<?php echo $hook->id; ?>" value="yes" >
64
+									<?php echo FunctionsEdit::twoStateCheckbox('status-'.($hook->id), ($hook->status) == 'enabled'); ?>
65 65
 								</td>
66
-								<td><?php echo (($hook->status)=='enabled'); ?></td>
66
+								<td><?php echo (($hook->status) == 'enabled'); ?></td>
67 67
 								<td><?php echo $hook->hook; ?></td>
68 68
 								<td><?php echo $hook->context; ?></td>
69
-								<td><?php if($mod = Module::getModuleByName($hook->module)) echo $mod->getTitle(); ?></td>
69
+								<td><?php if ($mod = Module::getModuleByName($hook->module)) echo $mod->getTitle(); ?></td>
70 70
 								<td><input type="text" class="center" size="2" value="<?php echo $hook->priority; ?>" name="moduleorder-<?php echo $hook->id; ?>" /></td>
71 71
 								<td><?php echo $hook->priority; ?></td>
72 72
 							</tr>
Please login to merge, or discard this patch.
src/Webtrees/Module/ModuleManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -61,10 +61,10 @@
 block discarded – undo
61 61
      * @see \MyArtJaub\Webtrees\Module\ModuleManagerInterface::isOperational()
62 62
      */
63 63
     public function isOperational($moduleName) {
64
-    	if(!array_key_exists($moduleName, $this->modules_list)) {
65
-    		if($module = fw\Module::getModuleByName($moduleName)) {
66
-    			if($module instanceof DependentInterface) {
67
-    				if($module->validatePrerequisites()) {
64
+    	if (!array_key_exists($moduleName, $this->modules_list)) {
65
+    		if ($module = fw\Module::getModuleByName($moduleName)) {
66
+    			if ($module instanceof DependentInterface) {
67
+    				if ($module->validatePrerequisites()) {
68 68
     					$this->modules_list[$moduleName] = TRUE;
69 69
     					return true;
70 70
     				} else {
Please login to merge, or discard this patch.
src/Webtrees/Module/GeoDispersion/Model/GeoDisplayOptions.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 *
45 45
      * @return (OutlineMap|null)
46 46
      */
47
-    public function getMap(){
47
+    public function getMap() {
48 48
         return $this->map;
49 49
     }
50 50
     
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 	 *
65 65
 	 * @return int
66 66
 	 */
67
-    public function getMapLevel(){
67
+    public function getMapLevel() {
68 68
         return $this->map_level;
69 69
     }
70 70
     
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	 *
85 85
 	 * @return bool
86 86
 	 */
87
-    public function isUsingFlags(){
87
+    public function isUsingFlags() {
88 88
         return $this->use_flags;
89 89
     }
90 90
     
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	 *
105 105
 	 * @return int
106 106
 	 */
107
-    public function getMaxDetailsInGen(){
107
+    public function getMaxDetailsInGen() {
108 108
         return $this->max_details_in_gen;
109 109
     }
110 110
     
Please login to merge, or discard this patch.
src/Webtrees/Module/GeoDispersion/Views/GeoAnalysisView.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 			<h2><?php echo $this->data->get('title'); ?></h2>
31 31
 			
32 32
 			<?php
33
-			if($this->data->get('has_analysis', false)) { 
33
+			if ($this->data->get('has_analysis', false)) { 
34 34
 			    /** @var GeoAnalysis $ga  */
35 35
     		    $ga = $this->data->get('geoanalysis');
36 36
     		?>
Please login to merge, or discard this patch.
src/Webtrees/Module/GeoDispersion/Views/GeoAnalysisTabGenerationsView.php 1 patch
Spacing   +30 added lines, -31 removed lines patch added patch discarded remove patch
@@ -38,39 +38,38 @@  discard block
 block discarded – undo
38 38
         '<div id="geodispersion_gen">
39 39
         	<table id="geodispersion_gentable" class="center">';
40 40
             
41
-        foreach($results_by_gen as $gen => $genData){
41
+        foreach ($results_by_gen as $gen => $genData) {
42 42
             $html .= 
43 43
             '<tr>
44 44
                 <td class="descriptionbox">' .
45 45
                     I18N::translate("Generation %s", I18N::number($gen)).
46 46
                     ($display_all_places ? '<br />' : ' ').
47
-                    I18N::translate('(%s)', I18N::percentage(Functions::safeDivision($genData['sum'] + $genData['other'], $genData['sum'] + $genData['other'] + $genData['unknown']),1)) . 
47
+                    I18N::translate('(%s)', I18N::percentage(Functions::safeDivision($genData['sum'] + $genData['other'], $genData['sum'] + $genData['other'] + $genData['unknown']), 1)). 
48 48
                 '</td>
49 49
                  <td class="optionbox left">'.
50 50
                     ($display_all_places ? 
51
-                        $this->htmlGenerationAllPlacesRow($genData, $analysis_level) :
52
-                        $this->htmlGenerationTopPlacesRow($genData, $analysis_level)
53
-                     ) .
51
+                        $this->htmlGenerationAllPlacesRow($genData, $analysis_level) : $this->htmlGenerationTopPlacesRow($genData, $analysis_level)
52
+                     ).
54 53
                 '</ditdv>
55 54
             </tr>';
56 55
         }       
57 56
         
58
-        $html.= 
57
+        $html .= 
59 58
             '</table>
60 59
             <div class="left">
61
-                <strong>' . I18N::translate('Interpretation help:') . '</strong>
60
+                <strong>' . I18N::translate('Interpretation help:').'</strong>
62 61
                 <br />'.
63
-                I18N::translate('<strong>Generation X (yy %%)</strong>: The percentage indicates the number of found places compared to the total number of ancestors in this generation.') . 
62
+                I18N::translate('<strong>Generation X (yy %%)</strong>: The percentage indicates the number of found places compared to the total number of ancestors in this generation.'). 
64 63
                 '<br />';
65
-        if(!is_null($max_details_gen) && $max_details_gen == 0){
64
+        if (!is_null($max_details_gen) && $max_details_gen == 0) {
66 65
             $html .= I18N::translate('<strong><em>Place</em> or <em>Flag</em> aa (bb %%)</strong>: The first number indicates the total number of ancestors born in this place, the percentage relates this count to the total number of found places. No percentage means it is less than 10%%.').'<br />';
67 66
             $html .= I18N::translate('If any, the darker area indicates the number of unknown places within the generation or places outside the analysed area, and its percentage compared to the number of ancestors. No percentage means it is less than 10%%.');
68 67
         }
69
-        else{
68
+        else {
70 69
             $html .= I18N::translate('<strong><em>Place</em> [aa - bb %%]</strong>: The first number indicates the total number of ancestors born in this place, the percentage compares this count to the total number of found places.').'<br />';
71 70
             $html .= I18N::translate('Only the %d more frequent places for each generation are displayed.', $max_details_gen);
72 71
         }
73
-        $html.= 
72
+        $html .= 
74 73
             '</div>
75 74
         </div>';
76 75
         
@@ -92,25 +91,25 @@  discard block
 block discarded – undo
92 91
         
93 92
         $sum_gen = $data['sum'];
94 93
         $unknownother = $data['unknown'] + $data['other'];
95
-        foreach($data['places'] as $placename=> $dataplace){
96
-            $levels = array_map('trim',explode(',', $placename));
94
+        foreach ($data['places'] as $placename=> $dataplace) {
95
+            $levels = array_map('trim', explode(',', $placename));
97 96
             $content = '';
98
-            if(isset($dataplace['flag'])){
99
-                $content .= '<td class="geodispersion_flag">'. FunctionsPrint::htmlPlaceIcon($dataplace['place'], $dataplace['flag']) .'</td><td>';
97
+            if (isset($dataplace['flag'])) {
98
+                $content .= '<td class="geodispersion_flag">'.FunctionsPrint::htmlPlaceIcon($dataplace['place'], $dataplace['flag']).'</td><td>';
100 99
             }
101
-            else{
102
-                $content .= '<td><span title="'.implode(I18N::$list_separator, array_reverse($levels)).'">'.$levels[$analysis_level-1].'</span><br/>';
100
+            else {
101
+                $content .= '<td><span title="'.implode(I18N::$list_separator, array_reverse($levels)).'">'.$levels[$analysis_level - 1].'</span><br/>';
103 102
             }
104 103
             $count = $dataplace['count'];
105 104
             $content .= I18N::number($count);
106 105
             $perc = Functions::safeDivision($count, $sum_gen + $unknownother);
107
-            $perc2= Functions::safeDivision($count, $sum_gen);
108
-            if($perc2>=0.1) 
109
-                $content.= '<br/><span class="small">('.I18N::percentage($perc2, 1).')</span>';
106
+            $perc2 = Functions::safeDivision($count, $sum_gen);
107
+            if ($perc2 >= 0.1) 
108
+                $content .= '<br/><span class="small">('.I18N::percentage($perc2, 1).')</span>';
110 109
             $content .= '</td>';
111 110
                
112 111
             $html .= '
113
-                <td class="geodispersion_rowitem" width="'.max(round(100*$perc, 0),1).'%">
112
+                <td class="geodispersion_rowitem" width="'.max(round(100 * $perc, 0), 1).'%">
114 113
                     <table>
115 114
                         <tr>
116 115
                             <td>
@@ -123,11 +122,11 @@  discard block
 block discarded – undo
123 122
                 </td>';
124 123
         }
125 124
         
126
-        if($unknownother>0){
127
-            $perc= Functions::safeDivision($unknownother, $sum_gen + $unknownother);
128
-            $html .='<td class="geodispersion_unknownitem left" >'.I18N::number($unknownother);
129
-            if($perc>=0.1) $html.= '<br/><span class="small">('.I18N::percentage($perc, 1).')</span>';
130
-            $html .='</td>';
125
+        if ($unknownother > 0) {
126
+            $perc = Functions::safeDivision($unknownother, $sum_gen + $unknownother);
127
+            $html .= '<td class="geodispersion_unknownitem left" >'.I18N::number($unknownother);
128
+            if ($perc >= 0.1) $html .= '<br/><span class="small">('.I18N::percentage($perc, 1).')</span>';
129
+            $html .= '</td>';
131 130
         }
132 131
         
133 132
         $html .= 
@@ -148,12 +147,12 @@  discard block
 block discarded – undo
148 147
         $sum_gen = $data['sum'];
149 148
         $other = $data['other'];
150 149
         
151
-        foreach($data['places'] as $placename => $count) {
152
-            if($placename != 'other'){
153
-                $levels = array_map('trim',explode(',', $placename));
154
-                $placename = '<span title="'.implode(I18N::$list_separator, array_reverse($levels)).'">'.$levels[$analysis_level-1].'</span>';
150
+        foreach ($data['places'] as $placename => $count) {
151
+            if ($placename != 'other') {
152
+                $levels = array_map('trim', explode(',', $placename));
153
+                $placename = '<span title="'.implode(I18N::$list_separator, array_reverse($levels)).'">'.$levels[$analysis_level - 1].'</span>';
155 154
             }
156
-            else{
155
+            else {
157 156
                 $placename = I18N::translate('Other places');
158 157
             }
159 158
             $tmp_places[] = I18N::translate('<strong>%s</strong> [%d - %s]', $placename, $count, I18N::percentage(Functions::safeDivision($count, $sum_gen + $other), 1));         	
Please login to merge, or discard this patch.