MyArtJaub\Webtrees\Module\GeoDispersion\Http\RequestHandlers\GeoAnalysisViewEditAction::handle()

Complexity

Conditions	9
Paths	11

Size

Total Lines	62
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = Validator::attributes($request)->tree();

        if ($this->module === null) {
            FlashMessages::addMessage(
                I18N::translate('The attached module could not be found.'),
                'danger'
            );
            return Registry::responseFactory()->redirect(AdminConfigPage::class, ['tree' => $tree->name()]);
        }


        $view_id = Validator::attributes($request)->integer('view_id', -1);
        $view = $this->geoview_data_service->find($tree, $view_id, true);

        $description    = Validator::parsedBody($request)->string('view_description', '');
        $place_depth    = Validator::parsedBody($request)->integer('view_depth', 1);
        $top_places     = Validator::parsedBody($request)->integer('view_top_places', 0);

        $analysis = null;

The assignment to $analysis is dead and can be removed.

        try {
            $analysis = app(Validator::parsedBody($request)->string('view_analysis', ''));
        } catch (BindingResolutionException $ex) {

Consider adding a comment why this CATCH block is empty.

        }

        if (
            $view === null
            || $analysis === null || !($analysis instanceof GeoAnalysisInterface)
            || $place_depth <= 0 && $top_places < 0
        ) {
            FlashMessages::addMessage(
                I18N::translate('The parameters for view with ID “%s” are not valid.', I18N::number($view_id)),
                'danger'
            );
            return Registry::responseFactory()->redirect(AdminConfigPage::class, ['tree' => $tree->name()]);
        }

        $new_view = $view
            ->with($view->isEnabled(), $description, $analysis, $place_depth, $top_places)
            ->withGlobalSettingsUpdate($request);

        try {
            $this->geoview_data_service->update($new_view);
            FlashMessages::addMessage(
                I18N::translate('The geographical dispersion analysis view has been successfully updated.'),
                'success'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addConfigurationLog('Module ' . $this->module->title() . ' : View “' . $view->id() . '” has been updated.');
        } catch (Throwable $ex) {
            FlashMessages::addMessage(
                I18N::translate('An error occured while updating the geographical dispersion analysis view.'),
                'danger'
            );
            //phpcs:ignore Generic.Files.LineLength.TooLong
            Log::addErrorLog('Module ' . $this->module->title() . ' : Error when updating view “' . $view->id() . '”: ' . $ex->getMessage());
        }

        return Registry::responseFactory()->redirect(GeoAnalysisViewEditPage::class, [
            'tree' => $tree->name(),
            'view_id' => $view->id()
        ]);