Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 25 | class ParseContentExecutorFactoryTest extends TestCase |
||
| 26 | { |
||
| 27 | use ContainerAwareTrait; |
||
| 28 | |||
| 29 | private $factory; |
||
| 30 | |||
| 31 | protected function setUp() |
||
| 32 | { |
||
| 33 | $this->setConfigProviders([ModuleConfig::class, TestConfig::class]); |
||
| 34 | $this->setContainerConfigs([ |
||
| 35 | \Jolicht\MarkdownCms\ContainerConfig::class, |
||
| 36 | ExpressiveAuraConfig::class, |
||
| 37 | TestContainerConfig::class |
||
| 38 | ]); |
||
| 39 | $this->setUpContainer(); |
||
| 40 | |||
| 41 | $this->factory = new ParseContentExecutorFactory(); |
||
| 42 | } |
||
| 43 | |||
| 44 | public function testContainerHasService() |
||
| 45 | { |
||
| 46 | $this->assertTrue($this->getContainer()->has(ParseContentExecutor::class)); |
||
| 47 | } |
||
| 48 | |||
| 49 | public function testCreateService() |
||
| 50 | { |
||
| 51 | $container = $this->getContainer(); |
||
| 52 | // $contentParser = $this->getMockBuilder(ContentParser::class)->disableOriginalConstructor()->getMock(); |
||
| 53 | // $container->setAllowOverride(true); |
||
| 54 | // $container->setService(ContentParser::class, $contentParser); |
||
| 55 | // $container->setAllowOverride(false); |
||
| 56 | |||
| 57 | $executor = $container->get(ContentParser::class); |
||
| 58 | $executor = $this->factory->__invoke($container); |
||
| 59 | $this->assertInstanceOf(ParseContentExecutor::class, $executor); |
||
| 60 | $this->assertSame($container->get(ContentParser::class), $executor->getContentParser()); |
||
| 61 | $observers = $executor->getObservers(); |
||
| 62 | $this->assertCount(2, $observers); |
||
| 63 | $this->assertInstanceOf(SaveContentConfigObserver::class, $observers[0]); |
||
| 64 | $this->assertInstanceOf(SitemapObserver::class, $observers[1]); |
||
| 65 | } |
||
| 66 | } |