Scoring - Code Metrics - Inspection of "scrutinizer removed type of private variables" - joki20/dbwebb-mvc-proj - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7d2376...38002a )

by Johan

created 2021-05-21 21:59 UTC

Scoring C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	297
Duplicated Lines	39.06 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

8.64%

Importance

Changes

Metric	Value
wmc	57
lcom	1
cbo	1
dl	116
loc	297
ccs	14
cts	162
cp	0.0864
rs	5.04
c	0
b	0
f	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	setPointsSessions()	0	24	1
B	checkFullRow()	43	43	7
B	checkFullColumn()	40	40	7
A	sortHand()	0	37	4
B	scoreSameSuit()	0	27	7
A	checkValueOccurrence()	0	19	6
A	fourOfAKind()	11	11	3
A	fullHouse()	11	11	4
A	threeOfAKind()	11	11	4
B	twoPairsOrPair()	0	27	9
A	straightOrNothing()	0	18	4
A	setNotScoredYetBackToFalse()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Scoring often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Scoring, and based on these observations, apply Extract Interface, too.

<?php

declare(strict_types=1);

// Folder \Controllers containing classes
namespace Joki20\Http\Controllers;

// use Joki20\Http\Controllers\PokerSquares;
use Joki20\Http\Controllers\Setup;

/**
 * Class Scoring;
 */


class Scoring extends Setup
{
    private $currentSession = '';
    private $suitsRow = [];
    private $valuesRow = [];
    private $suitsColumn = [];
    private $valuesColumn = [];
    private $scoreSession = [];
    private $sortedValues = [];
    private $consecutiveArray = false;
    private $times;
    private $occurrencesValues = [];
    private $notScoredYet;

    public function setPointsSessions(): void
    {
        // row data (suits array and values array)
        session()->put('dataRow0', []);
        session()->put('dataRow1', []);
        session()->put('dataRow2', []);
        session()->put('dataRow3', []);
        session()->put('dataRow4', []);
        // column data (suits array and values array)
        session()->put('dataColumn0', []);
        session()->put('dataColumn1', []);
        session()->put('dataColumn2', []);
        session()->put('dataColumn3', []);
        session()->put('dataColumn4', []);
        // counting times of each result for highscore list
        // has to reset to 0 each time score is calculated, and not null according to database
        session()->put('count', [
            'nothing' => 0, 'pair' => 0,
            'twoPairs' => 0, 'threeofakind' => 0,
            'straight' => 0, 'flush' => 0,
            'fullhouse' => 0, 'fourofakind' => 0,
            'straightflush' => 0, 'royalstraightflush' => 0
        ]);
    }

    public function checkFullRow(): void

    {
        // LOOP FOR EACH ROW
        for ($row = 0; $row < 5; $row++) {
            for ($column = 0; $column < 5; $column++) {
                $this->notScoredYet = true;
                // initial length is 0, if not then session contians card
                // ROW SUITS AND VALUES
                // if a card is existing (form length has 235)
                $this->currentSession = session('grid.' . $row . $column);
                if (strlen($this->currentSession) != 235) {
                    // collect suit HDSC and value 02-14 for row
                    array_push($this->suitsRow, substr($this->currentSession, 23, 1));
                    array_push($this->valuesRow, substr($this->currentSession, 21, 2));
                }
                // ROW SAVE AND SCORE DATA
                // if five cards (five suits), push suits and values arrays
                if ($column == 4 && count($this->suitsRow) == 5) {
                    // session('dataRow00', [[H,D,C,S,D],[03,05,01,13,10]])
                    session()->push('dataRow' . $row, $this->suitsRow);
                    session()->push('dataRow' . $row, $this->valuesRow);
                    // send array of suits and values for row to score function
                    $this->sortHand('Row' . $row);
                    // when match is found, $this->notScoredYet = false and rest of functions will not proceed
                    $this->scoreSameSuit('Row' . $row);
                    $this->checkValueOccurrence('Row' . $row);

                    $this->fourOfaKind('Row' . $row);
                    $this->fullHouse('Row' . $row);
                    $this->threeOfAKind('Row' . $row);
                    $this->twoPairsOrPair('Row' . $row);
                    $this->straightOrNothing('Row' . $row);

                    // before next loop, reset to false
                    $this->setNotScoredYetBackToFalse();
                }
                // reset suits and values before next column
                if ($column == 4) {
                    $this->suitsRow = [];
                    $this->valuesRow = [];
                }
            }
        }
    }

    public function checkFullColumn(): void

    {
        // LOOP FOR EACH COLUMN
        for ($column = 0; $column < 5; $column++) {
            for ($row = 0; $row < 5; $row++) {
                $this->notScoredYet = true;
                // ROW SUITS AND VALUES
                // if a card is existing (form length has 233)
                $this->currentSession = session('grid.' . $row . $column);
                if (strlen($this->currentSession) != 235) {
                    // collect suit HDSC and value 02-14 for column
                    array_push($this->suitsColumn, substr($this->currentSession, 23, 1));
                    array_push($this->valuesColumn, substr($this->currentSession, 21, 2));
                }
                // COLUMN SAVE AND SCORE DATA
                if ($row == 4 && count($this->suitsColumn) == 5) {
                    session()->push('dataColumn' . $column, $this->suitsColumn);
                    session()->push('dataColumn' . $column, $this->valuesColumn);

                    //begin with sorting hand and set
                    $this->sortHand('Column' . $column);
                    // when match is found, $this->notScoredYet = false and rest of functions will not proceed
                    $this->scoreSameSuit('Column' . $column);
                    $this->checkValueOccurrence('Column' . $column);

                    $this->fourOfaKind('Column' . $column);
                    $this->fullHouse('Column' . $column);
                    $this->threeOfAKind('Column' . $column);
                    $this->twoPairsOrPair('Column' . $column);
                    $this->straightOrNothing('Column' . $column);
                    // before next loop, reset to false
                    $this->setNotScoredYetBackToFalse();
                }
                // reset suits and values before next column
                if ($row == 4) {
                    $this->suitsColumn = [];
                    $this->valuesColumn = [];
                }
            }
        }
    }

    public function sortHand($type)
    {
        // set initial value to 0, increment with ++ when a hand fulfills
        $this->countNothing = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countPair = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countTwopairs = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countThreeofakind = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countStraight = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countFlush = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countFullhouse = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countFourofakind = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->countStraightflush = 0;

        $this->countRoyalstraightflush = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->consecutiveArray = false;

       // type is string dataRowX/dataColumnX array with suits. Used with session()->put()
       // scoreSession[0] is suits, scoreSession[1] is values
        $this->scoreSession = session('data' . $type); // i e dataRow21

       // set consecutive to true
        $this->consecutiveArray = true;
        // CREATE COPY ARRAY AND SORT VALUES
        $this->sortedValues = $this->scoreSession[1];
        sort($this->sortedValues);
       // check if consecutive numbers
        for ($i = 0; $i < 4; $i++) {
            if (intval($this->sortedValues[$i + 1]) != intval($this->sortedValues[$i]) + 1) {
                $this->consecutiveArray = false;
            }
        }

        if ($this->sortedValues === ["14", "01", "02", "03", "04"]) {
            $this->consecutiveArray = true;
        }

        return $this->sortedValues;
       // END OF SORT
    }

    public function scoreSameSuit($type)
    {
        if ($this->notScoredYet == true) {

            // ///////////// SAME SUIT /////////////
            // how many different suits. 1 means all are same
            if (count(array_count_values($this->scoreSession[0])) == 1) {
                // if straight
                if ($this->consecutiveArray == true) {

                    // ROYAL STRAIGHT FLUSH 10-A
                    if ($this->sortedValues[0] == "10") {
                        session()->put('score' . $type, ['score' => 100, 'feedback' => 'ROYAL STRAIGHT FLUSH']);
                        session()->put('count.royalstraightflush', session('count.royalstraightflush') + 1);
                        $this->notScoredYet = false;
                    // STRAIGHT FLUSH
                    } elseif (($this->sortedValues[0] != "10")) {
                        session()->put('score' . $type, ['score' => 75, 'feedback' => 'STRAIGHT FLUSH']);
                        session()->put('count.straightflush', session('count.straightflush') + 1);
                        $this->notScoredYet = false;
                    } // FLUSH
                } elseif ($this->consecutiveArray == false) {

                    session()->put('score' . $type, ['score' => 20, 'feedback' => 'FLUSH']);
                    session()->put('count.flush', session('count.flush') + 1);
                    $this->notScoredYet = false;
                }
            }
        }
    }

    public function checkValueOccurrence(): void
    {
        if ($this->notScoredYet == true) {

            if (count(array_count_values($this->scoreSession[1])) > 1) {
                $this->occurrencesValues = [];
                // count occurrences of each value, insert into $occurrences array
                $this->times = 0;
                for ($val = 0; $val < 5; $val++) {
                    for ($match = 0; $match < 5; $match++) {
                        if ($this->scoreSession[1][$val] == $this->scoreSession[1][$match]) {
                            $this->times++;
                        }
                    }
                    array_push($this->occurrencesValues, $this->times);
                    $this->times = 0;
                }
            }
        }
    }

    public function fourOfAKind($type): void

    {
        if ($this->notScoredYet == true) {

            // 4 OF A KIND
            if (in_array(4, $this->occurrencesValues)) {
                session()->put('score' . $type, ['score' => 50, 'feedback' => 'FOUR OF A KIND']);
                session()->put('count.fourofakind', session('count.fourofakind') + 1);
                $this->notScoredYet = false;
            }
        }
    }
    public function fullHouse($type): void

    {
        if ($this->notScoredYet == true) {

            // FULL HOUSE
            if (in_array(3, $this->occurrencesValues) && in_array(2, $this->occurrencesValues)) {
                session()->put('score' . $type, ['score' => 25, 'feedback' => 'FULL HOUSE']);
                session()->put('count.fullhouse', session('count.fullhouse') + 1);
                $this->notScoredYet = false;
            }
        }
    }

    public function threeOfAKind($type): void

    {
        if ($this->notScoredYet == true) {

            // 3 OF A KIND
            if (in_array(3, $this->occurrencesValues) && in_array(1, $this->occurrencesValues)) {
                session()->put('score' . $type, ['score' => 10, 'feedback' => 'THREE OF A KIND']);
                session()->put('count.threeofakind', session('count.threeofakind') + 1);
                $this->notScoredYet = false;
            }
        }
    }

    public function twoPairsOrPair($type): void
    {
        if ($this->notScoredYet == true) {

            // 2 PAIRS OR 1 PAIR
            if (in_array(2, $this->occurrencesValues) && in_array(1, $this->occurrencesValues)) {
                // 2 PAIRS
                if (array_count_values($this->occurrencesValues)[2] == 4) {
                    session()->put('score' . $type, ['score' => 5, 'feedback' => 'TWO PAIRS']);
                    session()->put('count.twopairs', session('count.twopairs') + 1);
                    $this->notScoredYet = false;
                }
            }
        }

        // PAIR
        if ($this->notScoredYet == true) {

            // 2 PAIRS OR 1 PAIR
            if (in_array(2, $this->occurrencesValues) && in_array(1, $this->occurrencesValues)) {
                // 1 PAIR
                if (array_count_values($this->occurrencesValues)[2] == 2) {
                    session()->put('score' . $type, ['score' => 2, 'feedback' => 'PAIR']);
                    session()->put('count.pair', session('count.pair') + 1);
                    $this->notScoredYet = false;
                }
            }
        }
    }

    public function straightOrNothing($type): void
    {
        if ($this->notScoredYet == true) {

            // CHECK FOR STRAIGHT
            if ($this->consecutiveArray == true) {

                session()->put('score' . $type, ['score' => 15, 'feedback' => 'STRAIGHT']);
                session()->put('count.straight', session('count.straight') + 1);
                $this->notScoredYet = false;
            }
        }

        if ($this->notScoredYet == true) {

            // NO POINTS
            session()->put('score' . $type, ['score' => 0, 'feedback' => 'NOTHING']);
            session()->put('count.nothing', session('count.nothing') + 1);
            $this->notScoredYet = false;
        }
    }

    public function setNotScoredYetBackToFalse(): void
    {
        $this->notScoredYet = true;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		// Folder \Controllers containing classes
6		namespace Joki20\Http\Controllers;
7
8		// use Joki20\Http\Controllers\PokerSquares;
9		use Joki20\Http\Controllers\Setup;
10
11		/**
12		* Class Scoring;
13		*/
14
15
16		class Scoring extends Setup
17		{
18		private $currentSession = '';
19		private $suitsRow = [];
20		private $valuesRow = [];
21		private $suitsColumn = [];
22		private $valuesColumn = [];
23		private $scoreSession = [];
24		private $sortedValues = [];
25		private $consecutiveArray = false;
26		private $times;
27		private $occurrencesValues = [];
28		private $notScoredYet;
29
30	1	public function setPointsSessions(): void
31		{
32		// row data (suits array and values array)
33	1	session()->put('dataRow0', []);
34	1	session()->put('dataRow1', []);
35	1	session()->put('dataRow2', []);
36	1	session()->put('dataRow3', []);
37	1	session()->put('dataRow4', []);
38		// column data (suits array and values array)
39	1	session()->put('dataColumn0', []);
40	1	session()->put('dataColumn1', []);

joki20 / dbwebb-mvc-proj