InitMeeting::initCreateMeeting() - Code Metrics - Inspection of "convert class or trait into StudyCase" - joisarjignesh/bigbluebutton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 718eb8...2626a3 )

by Jignesh

created 2020-08-15 15:02 UTC

InitMeeting::initCreateMeeting() C

↳ Parent: InitMeeting

Complexity

Conditions	11
Paths	40

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
nc	40
nop	1
dl	0
loc	94
rs	5.9842
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace JoisarJignesh\Bigbluebutton\Services;

use BigBlueButton\Parameters\CreateMeetingParameters;
use BigBlueButton\Parameters\EndMeetingParameters;
use BigBlueButton\Parameters\GetMeetingInfoParameters;
use BigBlueButton\Parameters\IsMeetingRunningParameters;
use BigBlueButton\Parameters\JoinMeetingParameters;
use Illuminate\Support\Str;

trait InitMeeting
{
    /**
     * @param array $parameters
     *
     * required fields
     * meetingID
     * meetingName
     * optional fields
     * moderatorPW
     * attendeePW
     *
     * @return CreateMeetingParameters
     */
    public function initCreateMeeting(array $parameters)
    {
        $request = Fluent($parameters);
        $meetingParams = new CreateMeetingParameters($request->meetingID, $request->meetingName);
        $meetingParams->setModeratorPassword($request->get('moderatorPW', Str::random(config('bigbluebutton.create.passwordLength', 8))));
        $meetingParams->setAttendeePassword($request->get('attendeePW', Str::random(config('bigbluebutton.create.passwordLength', 8))));
        $meetingParams->setDuration($request->get('duration', config('bigbluebutton.create.duration', 0)));
        $meetingParams->setRecord($request->get('record', config('bigbluebutton.create.record', false)));
        $meetingParams->setMaxParticipants($request->get('maxParticipants', config('bigbluebutton.create.maxParticipants', 0)));
        $meetingParams->setLogoutUrl($request->get('logoutUrl', config('bigbluebutton.create.logoutUrl', null)));
        $meetingParams->setWelcomeMessage(
            $request->get('welcomeMessage', config('bigbluebutton.create.welcomeMessage', null))
        );
        $meetingParams->setDialNumber(
            $request->get('dialNumber', config('bigbluebutton.create.dialNumber', null))
        );
        $meetingParams->setBreakout(
            $request->get('isBreakout', config('bigbluebutton.create.isBreakout', false))
        );
        $meetingParams->setModeratorOnlyMessage(
            $request->get('moderatorOnlyMessage', config('bigbluebutton.create.moderatorOnlyMessage', null))
        );
        $meetingParams->setAutoStartRecording(
            $request->get('autoStartRecording', config('bigbluebutton.create.autoStartRecording', false))
        );
        $meetingParams->setAllowStartStopRecording(
            $request->get('allowStartStopRecording', config('bigbluebutton.create.allowStartStopRecording', true))
        );
        $meetingParams->setWebcamsOnlyForModerator(
            $request->get('webcamsOnlyForModerator', config('bigbluebutton.create.webcamsOnlyForModerator', false))
        );
        $meetingParams->setLogo(
            $request->get('logo', config('bigbluebutton.create.logo', null))
        );
        $meetingParams->setCopyright(
            $request->get('copyright', config('bigbluebutton.create.copyright', null))
        );
        $meetingParams->setMuteOnStart(
            $request->get('muteOnStart', config('bigbluebutton.create.muteOnStart', false))
        );

        $meetingParams->setLockSettingsDisableCam(
            $request->get('lockSettingsDisableCam', config('bigbluebutton.create.lockSettingsDisableCam', false))
        );
        $meetingParams->setLockSettingsDisableMic(
            $request->get('lockSettingsDisableMic', config('bigbluebutton.create.lockSettingsDisableMic', false))
        );
        $meetingParams->setLockSettingsDisablePrivateChat(
            $request->get('lockSettingsDisablePrivateChat', config('bigbluebutton.create.lockSettingsDisablePrivateChat', false))
        );
        $meetingParams->setLockSettingsDisablePublicChat(
            $request->get('lockSettingsDisablePublicChat', config('bigbluebutton.create.lockSettingsDisablePublicChat', false))
        );
        $meetingParams->setLockSettingsDisableNote(
            $request->get('lockSettingsDisableNote', config('bigbluebutton.create.lockSettingsDisableNote', false))
        );
        $meetingParams->setLockSettingsLockedLayout(
            $request->get('lockSettingsLockedLayout', config('bigbluebutton.create.lockSettingsLockedLayout', false))
        );
        $meetingParams->setLockSettingsLockOnJoin(
            $request->get('lockSettingsLockOnJoin', config('bigbluebutton.create.lockSettingsLockOnJoin', false))
        );
        $meetingParams->setLockSettingsLockOnJoinConfigurable(
            $request->get('lockSettingsLockOnJoinConfigurable', config('bigbluebutton.create.lockSettingsLockOnJoinConfigurable', false))
        );

        if (! is_null($request->get('endCallbackUrl', null))) {
            $meetingParams->setEndCallbackUrl($request->get('endCallbackUrl', null));
        }

        if (! is_null($request->get('bbb-recording-ready-url', null))) {
            $meetingParams->setRecordingReadyCallbackUrl($request->get('bbb-recording-ready-url', null));
        }

        $meetingParams->setFreeJoin($request->get('freeJoin', false));

        $presentation = (array) $request->get('presentation', null);
        foreach ($presentation as $item) {
            if (isset($item['fileName']) && ! empty($item['fileName'])) {
                if (isset($item['link']) && ! empty($item['link'])) {
                    $meetingParams->addPresentation(trim($item['link']), null, trim($item['fileName']));
                } elseif (isset($item['content']) && ! empty($item['content'])) {
                    $meetingParams->addPresentation(trim($item['fileName']), trim($item['content']), null);
                }
            }
        }

        $meta = (array) $request->get('meta', null);
        foreach ($meta as $key => $value) {
            $meetingParams->addMeta(trim($key), trim($value));
        }

        return $meetingParams;
    }

    /**
     * @param array $parameters
     *
     * required fields:
     * meetingID
     * moderatorPW close meeting must be there moderator password
     *
     * @return EndMeetingParameters
     */
    public function initCloseMeeting(array $parameters)
    {
        $request = Fluent($parameters);

        return new EndMeetingParameters($request->meetingID, $request->moderatorPW);
    }

    /**
     * @param array $parameters
     *
     *  required fields
     *
     *  meetingID
     *  userName join by name
     *  password which role want to join
     *
     * @return JoinMeetingParameters
     */
    public function initJoinMeeting(array $parameters)
    {
        $request = Fluent($parameters);
        $meetingParams = new JoinMeetingParameters($request->meetingID, $request->userName, $request->password);
        $meetingParams->setRedirect($request->get('redirect', config('bigbluebutton.join.redirect', true)));
        $meetingParams->setJoinViaHtml5($request->get('joinViaHtml5', config('bigbluebutton.join.joinViaHtml5', true)));
        $meetingParams->setUserId($request->get('userId', null));
        if ($request->createTime) {
            $meetingParams->setCreationTime($request->createTime);
        }
        if ($request->configToken) {
            $meetingParams->setConfigToken($request->configToken);
        }
        if ($request->webVoiceConf) {
            $meetingParams->setWebVoiceConf($request->webVoiceConf);
        }
        if ($request->avatarUrl) {
            $meetingParams->setAvatarURL($request->avatarUrl);
        }
        if ($request->clientUrl) {
            $meetingParams->setClientURL($request->clientUrl);
        }

        return $meetingParams;
    }

    /**
     * @param $parameters
     *
     * required fields
     * meetingID
     *
     * @return IsMeetingRunningParameters
     */
    public function initIsMeetingRunning($parameters)
    {
        $meetingID = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (is_array($parameters)) {
            $meetingID = Fluent($parameters)->get('meetingID');
        } else {
            $meetingID = $parameters;
        }

        return new IsMeetingRunningParameters($meetingID);
    }

    /**
     * @param $parameters
     *
     * required fields
     * meetingID
     * moderatorPW must be there moderator password
     *
     * @return GetMeetingInfoParameters
     */
    public function initGetMeetingInfo($parameters)
    {
        $request = Fluent($parameters);

        return new GetMeetingInfoParameters($request->meetingID, $request->moderatorPW);
    }

    private function makeJoinMeetingArray($object, $parameters)
    {
        $pass['meetingID'] = $object->get('meetingID');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $pass['password'] = $object->get('moderatorPW');
        if (isset($parameters['userName'])) {
            $pass['userName'] = $parameters['userName'];
        }
        $pass['meetingName'] = $object->get('meetingName');
        if (isset($parameters['redirect'])) {
            $pass['redirect'] = $parameters['redirect'];
        }

        return $pass;
    }

    /**
     * @param array $parameters
     *
     * required fields
     * meetingID
     * meetingName
     * userName
     * attendeePW
     * moderatorPW
     *
     * @return mixed
     */
    public function initStart(array $parameters)
    {
        if ($this->getMeetingInfo($parameters)->isEmpty()) {

            $object = $this->create($parameters);

            if (method_exists($object, 'isEmpty') && ! $object->isEmpty()) {
                return $this->join($this->makeJoinMeetingArray($object, $parameters));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        } else {
            if (isset($parameters['moderatorPW'])) {
                $parameters['password'] = trim($parameters['moderatorPW']);
            }

            return $this->join($parameters);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php
2
3			namespace JoisarJignesh\Bigbluebutton\Services;
4
5			use BigBlueButton\Parameters\CreateMeetingParameters;
6			use BigBlueButton\Parameters\EndMeetingParameters;
7			use BigBlueButton\Parameters\GetMeetingInfoParameters;
8			use BigBlueButton\Parameters\IsMeetingRunningParameters;
9			use BigBlueButton\Parameters\JoinMeetingParameters;
10			use Illuminate\Support\Str;
11
12			trait InitMeeting
13			{
14			/**
15			* @param array $parameters
16			*
17			* required fields
18			* meetingID
19			* meetingName
20			* optional fields
21			* moderatorPW
22			* attendeePW
23			*
24			* @return CreateMeetingParameters
25			*/
26			public function initCreateMeeting(array $parameters)
27			{
28			$request = Fluent($parameters);
29			$meetingParams = new CreateMeetingParameters($request->meetingID, $request->meetingName);
30			$meetingParams->setModeratorPassword($request->get('moderatorPW', Str::random(config('bigbluebutton.create.passwordLength', 8))));
31			$meetingParams->setAttendeePassword($request->get('attendeePW', Str::random(config('bigbluebutton.create.passwordLength', 8))));
32			$meetingParams->setDuration($request->get('duration', config('bigbluebutton.create.duration', 0)));
33			$meetingParams->setRecord($request->get('record', config('bigbluebutton.create.record', false)));
34			$meetingParams->setMaxParticipants($request->get('maxParticipants', config('bigbluebutton.create.maxParticipants', 0)));
35			$meetingParams->setLogoutUrl($request->get('logoutUrl', config('bigbluebutton.create.logoutUrl', null)));
36			$meetingParams->setWelcomeMessage(
37			$request->get('welcomeMessage', config('bigbluebutton.create.welcomeMessage', null))
38			);
39			$meetingParams->setDialNumber(
40			$request->get('dialNumber', config('bigbluebutton.create.dialNumber', null))
41			);
42			$meetingParams->setBreakout(
43			$request->get('isBreakout', config('bigbluebutton.create.isBreakout', false))
44			);
45			$meetingParams->setModeratorOnlyMessage(
46			$request->get('moderatorOnlyMessage', config('bigbluebutton.create.moderatorOnlyMessage', null))
47			);
48			$meetingParams->setAutoStartRecording(
49			$request->get('autoStartRecording', config('bigbluebutton.create.autoStartRecording', false))
50			);
51			$meetingParams->setAllowStartStopRecording(
52			$request->get('allowStartStopRecording', config('bigbluebutton.create.allowStartStopRecording', true))
53			);
54			$meetingParams->setWebcamsOnlyForModerator(
55			$request->get('webcamsOnlyForModerator', config('bigbluebutton.create.webcamsOnlyForModerator', false))
56			);
57			$meetingParams->setLogo(
58			$request->get('logo', config('bigbluebutton.create.logo', null))
59			);
60			$meetingParams->setCopyright(
61			$request->get('copyright', config('bigbluebutton.create.copyright', null))
62			);
63			$meetingParams->setMuteOnStart(
64			$request->get('muteOnStart', config('bigbluebutton.create.muteOnStart', false))
65			);
66
67			$meetingParams->setLockSettingsDisableCam(
68			$request->get('lockSettingsDisableCam', config('bigbluebutton.create.lockSettingsDisableCam', false))
69			);
70			$meetingParams->setLockSettingsDisableMic(
71			$request->get('lockSettingsDisableMic', config('bigbluebutton.create.lockSettingsDisableMic', false))
72			);
73			$meetingParams->setLockSettingsDisablePrivateChat(
74			$request->get('lockSettingsDisablePrivateChat', config('bigbluebutton.create.lockSettingsDisablePrivateChat', false))
75			);
76			$meetingParams->setLockSettingsDisablePublicChat(
77			$request->get('lockSettingsDisablePublicChat', config('bigbluebutton.create.lockSettingsDisablePublicChat', false))
78			);
79			$meetingParams->setLockSettingsDisableNote(
80			$request->get('lockSettingsDisableNote', config('bigbluebutton.create.lockSettingsDisableNote', false))
81			);
82			$meetingParams->setLockSettingsLockedLayout(
83			$request->get('lockSettingsLockedLayout', config('bigbluebutton.create.lockSettingsLockedLayout', false))
84			);
85			$meetingParams->setLockSettingsLockOnJoin(
86			$request->get('lockSettingsLockOnJoin', config('bigbluebutton.create.lockSettingsLockOnJoin', false))
87			);
88			$meetingParams->setLockSettingsLockOnJoinConfigurable(
89			$request->get('lockSettingsLockOnJoinConfigurable', config('bigbluebutton.create.lockSettingsLockOnJoinConfigurable', false))
90			);
91
92			if (! is_null($request->get('endCallbackUrl', null))) {
93			$meetingParams->setEndCallbackUrl($request->get('endCallbackUrl', null));
94			}
95
96			if (! is_null($request->get('bbb-recording-ready-url', null))) {
97			$meetingParams->setRecordingReadyCallbackUrl($request->get('bbb-recording-ready-url', null));
98			}
99
100			$meetingParams->setFreeJoin($request->get('freeJoin', false));
101
102			$presentation = (array) $request->get('presentation', null);
103			foreach ($presentation as $item) {
104			if (isset($item['fileName']) && ! empty($item['fileName'])) {
105			if (isset($item['link']) && ! empty($item['link'])) {
106			$meetingParams->addPresentation(trim($item['link']), null, trim($item['fileName']));
107			} elseif (isset($item['content']) && ! empty($item['content'])) {
108			$meetingParams->addPresentation(trim($item['fileName']), trim($item['content']), null);
109			}
110			}
111			}
112
113			$meta = (array) $request->get('meta', null);
114			foreach ($meta as $key => $value) {
115			$meetingParams->addMeta(trim($key), trim($value));
116			}
117
118			return $meetingParams;
119			}
120
121			/**
122			* @param array $parameters
123			*
124			* required fields:
125			* meetingID
126			* moderatorPW close meeting must be there moderator password
127			*
128			* @return EndMeetingParameters
129			*/
130			public function initCloseMeeting(array $parameters)
131			{
132			$request = Fluent($parameters);
133
134			return new EndMeetingParameters($request->meetingID, $request->moderatorPW);
135			}
136
137			/**
138			* @param array $parameters
139			*
140			* required fields
141			*
142			* meetingID
143			* userName join by name
144			* password which role want to join
145			*
146			* @return JoinMeetingParameters
147			*/
148			public function initJoinMeeting(array $parameters)
149			{
150			$request = Fluent($parameters);
151			$meetingParams = new JoinMeetingParameters($request->meetingID, $request->userName, $request->password);
152			$meetingParams->setRedirect($request->get('redirect', config('bigbluebutton.join.redirect', true)));
153			$meetingParams->setJoinViaHtml5($request->get('joinViaHtml5', config('bigbluebutton.join.joinViaHtml5', true)));
154			$meetingParams->setUserId($request->get('userId', null));
155			if ($request->createTime) {
156			$meetingParams->setCreationTime($request->createTime);
157			}
158			if ($request->configToken) {
159			$meetingParams->setConfigToken($request->configToken);
160			}
161			if ($request->webVoiceConf) {
162			$meetingParams->setWebVoiceConf($request->webVoiceConf);
163			}
164			if ($request->avatarUrl) {
165			$meetingParams->setAvatarURL($request->avatarUrl);
166			}
167			if ($request->clientUrl) {
168			$meetingParams->setClientURL($request->clientUrl);
169			}
170
171			return $meetingParams;
172			}
173
174			/**
175			* @param $parameters
176			*
177			* required fields
178			* meetingID
179			*
180			* @return IsMeetingRunningParameters
181			*/
182			public function initIsMeetingRunning($parameters)
183			{
184			$meetingID = '';
			0 ignored issues – show Unused Code introduced 2020-06-21 08:42 UTC by Report Bug Copy Issue Report `$meetingID` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
185			if (is_array($parameters)) {
186			$meetingID = Fluent($parameters)->get('meetingID');
187			} else {
188			$meetingID = $parameters;
189			}
190
191			return new IsMeetingRunningParameters($meetingID);
192			}
193
194			/**
195			* @param $parameters
196			*
197			* required fields
198			* meetingID
199			* moderatorPW must be there moderator password
200			*
201			* @return GetMeetingInfoParameters
202			*/
203			public function initGetMeetingInfo($parameters)
204			{
205			$request = Fluent($parameters);
206
207			return new GetMeetingInfoParameters($request->meetingID, $request->moderatorPW);
208			}
209
210			private function makeJoinMeetingArray($object, $parameters)
211			{
212			$pass['meetingID'] = $object->get('meetingID');
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-13 07:39 UTC by Report Bug Copy Issue Report `$pass` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$pass = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
213			$pass['password'] = $object->get('moderatorPW');
214			if (isset($parameters['userName'])) {
215			$pass['userName'] = $parameters['userName'];
216			}
217			$pass['meetingName'] = $object->get('meetingName');
218			if (isset($parameters['redirect'])) {
219			$pass['redirect'] = $parameters['redirect'];
220			}
221
222			return $pass;
223			}
224
225			/**
226			* @param array $parameters
227			*
228			* required fields
229			* meetingID
230			* meetingName
231			* userName
232			* attendeePW
233			* moderatorPW
234			*
235			* @return mixed
236			*/
237			public function initStart(array $parameters)
238			{
239			if ($this->getMeetingInfo($parameters)->isEmpty()) {
			0 ignored issues – show Bug introduced 2020-08-15 15:03 UTC by Report Bug Copy Issue Report The method `getMeetingInfo()` does not exist on `JoisarJignesh\Bigbluebutton\Services\InitMeeting`. Did you maybe mean `initGetMeetingInfo()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
240			$object = $this->create($parameters);
			0 ignored issues – show Bug introduced 2020-08-15 15:03 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `JoisarJignesh\Bigbluebutton\Services\InitMeeting`. Did you maybe mean `initCreateMeeting()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
241			if (method_exists($object, 'isEmpty') && ! $object->isEmpty()) {
242			return $this->join($this->makeJoinMeetingArray($object, $parameters));
			0 ignored issues – show Bug introduced 2020-04-13 07:39 UTC by Report Bug Copy Issue Report It seems like `join()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
243			}
244			} else {
245			if (isset($parameters['moderatorPW'])) {
246			$parameters['password'] = trim($parameters['moderatorPW']);
247			}
248
249			return $this->join($parameters);
			0 ignored issues – show Bug introduced 2020-04-12 12:52 UTC by Report Bug Copy Issue Report It seems like `join()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
250			}
251			}
252			}
253

joisarjignesh / bigbluebutton

Push — master ( 718eb8...2626a3 )

InitMeeting::initCreateMeeting() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like