| Conditions | 11 |
| Paths | 40 |
| Total Lines | 94 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | public function initCreateMeeting(array $parameters) |
||
| 27 | { |
||
| 28 | $request = Fluent($parameters); |
||
| 29 | $meetingParams = new CreateMeetingParameters($request->meetingID, $request->meetingName); |
||
| 30 | $meetingParams->setModeratorPassword($request->get('moderatorPW', Str::random(config('bigbluebutton.create.passwordLength', 8)))); |
||
| 31 | $meetingParams->setAttendeePassword($request->get('attendeePW', Str::random(config('bigbluebutton.create.passwordLength', 8)))); |
||
| 32 | $meetingParams->setDuration($request->get('duration', config('bigbluebutton.create.duration', 0))); |
||
| 33 | $meetingParams->setRecord($request->get('record', config('bigbluebutton.create.record', false))); |
||
| 34 | $meetingParams->setMaxParticipants($request->get('maxParticipants', config('bigbluebutton.create.maxParticipants', 0))); |
||
| 35 | $meetingParams->setLogoutUrl($request->get('logoutUrl', config('bigbluebutton.create.logoutUrl', null))); |
||
| 36 | $meetingParams->setWelcomeMessage( |
||
| 37 | $request->get('welcomeMessage', config('bigbluebutton.create.welcomeMessage', null)) |
||
| 38 | ); |
||
| 39 | $meetingParams->setDialNumber( |
||
| 40 | $request->get('dialNumber', config('bigbluebutton.create.dialNumber', null)) |
||
| 41 | ); |
||
| 42 | $meetingParams->setBreakout( |
||
| 43 | $request->get('isBreakout', config('bigbluebutton.create.isBreakout', false)) |
||
| 44 | ); |
||
| 45 | $meetingParams->setModeratorOnlyMessage( |
||
| 46 | $request->get('moderatorOnlyMessage', config('bigbluebutton.create.moderatorOnlyMessage', null)) |
||
| 47 | ); |
||
| 48 | $meetingParams->setAutoStartRecording( |
||
| 49 | $request->get('autoStartRecording', config('bigbluebutton.create.autoStartRecording', false)) |
||
| 50 | ); |
||
| 51 | $meetingParams->setAllowStartStopRecording( |
||
| 52 | $request->get('allowStartStopRecording', config('bigbluebutton.create.allowStartStopRecording', true)) |
||
| 53 | ); |
||
| 54 | $meetingParams->setWebcamsOnlyForModerator( |
||
| 55 | $request->get('webcamsOnlyForModerator', config('bigbluebutton.create.webcamsOnlyForModerator', false)) |
||
| 56 | ); |
||
| 57 | $meetingParams->setLogo( |
||
| 58 | $request->get('logo', config('bigbluebutton.create.logo', null)) |
||
| 59 | ); |
||
| 60 | $meetingParams->setCopyright( |
||
| 61 | $request->get('copyright', config('bigbluebutton.create.copyright', null)) |
||
| 62 | ); |
||
| 63 | $meetingParams->setMuteOnStart( |
||
| 64 | $request->get('muteOnStart', config('bigbluebutton.create.muteOnStart', false)) |
||
| 65 | ); |
||
| 66 | |||
| 67 | $meetingParams->setLockSettingsDisableCam( |
||
| 68 | $request->get('lockSettingsDisableCam', config('bigbluebutton.create.lockSettingsDisableCam', false)) |
||
| 69 | ); |
||
| 70 | $meetingParams->setLockSettingsDisableMic( |
||
| 71 | $request->get('lockSettingsDisableMic', config('bigbluebutton.create.lockSettingsDisableMic', false)) |
||
| 72 | ); |
||
| 73 | $meetingParams->setLockSettingsDisablePrivateChat( |
||
| 74 | $request->get('lockSettingsDisablePrivateChat', config('bigbluebutton.create.lockSettingsDisablePrivateChat', false)) |
||
| 75 | ); |
||
| 76 | $meetingParams->setLockSettingsDisablePublicChat( |
||
| 77 | $request->get('lockSettingsDisablePublicChat', config('bigbluebutton.create.lockSettingsDisablePublicChat', false)) |
||
| 78 | ); |
||
| 79 | $meetingParams->setLockSettingsDisableNote( |
||
| 80 | $request->get('lockSettingsDisableNote', config('bigbluebutton.create.lockSettingsDisableNote', false)) |
||
| 81 | ); |
||
| 82 | $meetingParams->setLockSettingsLockedLayout( |
||
| 83 | $request->get('lockSettingsLockedLayout', config('bigbluebutton.create.lockSettingsLockedLayout', false)) |
||
| 84 | ); |
||
| 85 | $meetingParams->setLockSettingsLockOnJoin( |
||
| 86 | $request->get('lockSettingsLockOnJoin', config('bigbluebutton.create.lockSettingsLockOnJoin', false)) |
||
| 87 | ); |
||
| 88 | $meetingParams->setLockSettingsLockOnJoinConfigurable( |
||
| 89 | $request->get('lockSettingsLockOnJoinConfigurable', config('bigbluebutton.create.lockSettingsLockOnJoinConfigurable', false)) |
||
| 90 | ); |
||
| 91 | |||
| 92 | if (! is_null($request->get('endCallbackUrl', null))) { |
||
| 93 | $meetingParams->setEndCallbackUrl($request->get('endCallbackUrl', null)); |
||
| 94 | } |
||
| 95 | |||
| 96 | if (! is_null($request->get('bbb-recording-ready-url', null))) { |
||
| 97 | $meetingParams->setRecordingReadyCallbackUrl($request->get('bbb-recording-ready-url', null)); |
||
| 98 | } |
||
| 99 | |||
| 100 | $meetingParams->setFreeJoin($request->get('freeJoin', false)); |
||
| 101 | |||
| 102 | $presentation = (array) $request->get('presentation', null); |
||
| 103 | foreach ($presentation as $item) { |
||
| 104 | if (isset($item['fileName']) && ! empty($item['fileName'])) { |
||
| 105 | if (isset($item['link']) && ! empty($item['link'])) { |
||
| 106 | $meetingParams->addPresentation(trim($item['link']), null, trim($item['fileName'])); |
||
| 107 | } elseif (isset($item['content']) && ! empty($item['content'])) { |
||
| 108 | $meetingParams->addPresentation(trim($item['fileName']), trim($item['content']), null); |
||
| 109 | } |
||
| 110 | } |
||
| 111 | } |
||
| 112 | |||
| 113 | $meta = (array) $request->get('meta', null); |
||
| 114 | foreach ($meta as $key => $value) { |
||
| 115 | $meetingParams->addMeta(trim($key), trim($value)); |
||
| 116 | } |
||
| 117 | |||
| 118 | return $meetingParams; |
||
| 119 | } |
||
| 120 | |||
| 258 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.