Completed
Pull Request — master (#22)
by Andreas
02:01
created
src/Parser/Lanyrd/EventUri.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -32,6 +32,10 @@
 block discarded – undo
32 32
 class Uri
33 33
 {
34 34
 
35
+    /**
36
+     * @param \DOMDocument $dom
37
+     * @param \DOMXPath $xpath
38
+     */
35 39
     public function parse($dom, $xpath)
36 40
     {
37 41
         $uri = $xpath->query(
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
     {
37 37
         $uriPath = $xpath->query("//a[contains(@title, 'visit their website')]");
38 38
 
39
-        if (! $uriPath || $uriPath->length == 0) {
39
+        if (!$uriPath || $uriPath->length == 0) {
40 40
             throw new \InvalidArgumentException('The CfP does not seem to have an EventUri');
41 41
         }
42 42
 
Please login to merge, or discard this patch.
src/Parser/Lanyrd/Entry.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -114,6 +114,9 @@  discard block
 block discarded – undo
114 114
         }
115 115
     }
116 116
 
117
+    /**
118
+     * @param string $location
119
+     */
117 120
     protected function getLatLonForLocation($location)
118 121
     {
119 122
         $result = $this->client->get(sprintf(
@@ -131,6 +134,9 @@  discard block
 block discarded – undo
131 134
         return [$location->lat, $location->lon];
132 135
     }
133 136
 
137
+    /**
138
+     * @param \DOMXPath $xpath
139
+     */
134 140
     public function getEventPage($xpath)
135 141
     {
136 142
         $confPath = $xpath->query("//h3/a[contains(@class, 'summary')]");
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
             $content = file_Get_contents($uri);
56 56
             $content = mb_convert_encoding($content, 'UTF-8');
57
-            $dom->loadHTML('<?xml version="1.0" charset="UTF-8" ?>' . $content);
57
+            $dom->loadHTML('<?xml version="1.0" charset="UTF-8" ?>'.$content);
58 58
             $dom->preserveWhiteSpace = false;
59 59
 
60 60
             $xpath = new \DOMXPath($dom);
@@ -135,15 +135,15 @@  discard block
 block discarded – undo
135 135
     {
136 136
         $confPath = $xpath->query("//h3/a[contains(@class, 'summary')]");
137 137
 
138
-        if (! $confPath || $confPath->length == 0) {
138
+        if (!$confPath || $confPath->length == 0) {
139 139
             throw new \InvalidArgumentException('We can\'t find an EventPage');
140 140
         }
141 141
 
142 142
         $dom = new \DOMDocument('1.0', 'UTF-8');
143 143
 
144
-        $content = file_get_contents('https://lanyrd.com' . $confPath->item(0)->attributes->getNamedItem('href')->textContent);
144
+        $content = file_get_contents('https://lanyrd.com'.$confPath->item(0)->attributes->getNamedItem('href')->textContent);
145 145
         $content = mb_convert_encoding($content, 'UTF-8');
146
-        $dom->loadHTML('<?xml version="1.0" charset="UTF-8" ?>' . $content);
146
+        $dom->loadHTML('<?xml version="1.0" charset="UTF-8" ?>'.$content);
147 147
         $dom->preserveWhiteSpace = false;
148 148
 
149 149
         return $dom;
Please login to merge, or discard this patch.
src/Parser/Lanyrd/OpeningDate.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -32,6 +32,10 @@
 block discarded – undo
32 32
 class Uri
33 33
 {
34 34
 
35
+    /**
36
+     * @param \DOMDocument $dom
37
+     * @param \DOMXPath $xpath
38
+     */
35 39
     public function parse($dom, $xpath)
36 40
     {
37 41
         $uri = $xpath->query(
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     public function parse($dom, $xpath)
36 36
     {
37 37
         $openingDate = $xpath->query("//span[text()='Openend on:']/following-sibling::strong");
38
-        if (! $openingDate || $openingDate->length == 0) {
38
+        if (!$openingDate || $openingDate->length == 0) {
39 39
             return new \DateTime();
40 40
         }
41 41
 
Please login to merge, or discard this patch.
src/Parser/JoindinCfpParser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
47 47
         $content = json_decode($content, true);
48 48
 
49 49
         foreach ($content['events'] as $event) {
50
-            if (! $event['cfp_url']) {
50
+            if (!$event['cfp_url']) {
51 51
                 continue;
52 52
             }
53 53
             $info = new Cfp();
54 54
             $info->conferenceName = $event['name'];
55 55
             $info->conferenceUri = $event['href'];
56 56
             if ($event['icon']) {
57
-                $info->iconUri = 'https://joind.in/inc/img/event_icons/' . $event['icon'];
57
+                $info->iconUri = 'https://joind.in/inc/img/event_icons/'.$event['icon'];
58 58
             }
59 59
             $info->eventEndDate = new \DateTimeImmutable($event['end_date']);
60 60
             $info->eventStartDate = new \DateTimeImmutable($event['start_date']);
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             $info->longitude = $event['longitude'];
67 67
             $info->tags = $event['tags'];
68 68
             $info->uri = $event['cfp_url'];
69
-            $info->timezone = $event['tz_continent'] . '/' . $event['tz_place'];
69
+            $info->timezone = $event['tz_continent'].'/'.$event['tz_place'];
70 70
 
71 71
             $writer->write($info, 'joind.in');
72 72
         }
Please login to merge, or discard this patch.
src/Service/WriterFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
 class WriterFactory
31 31
 {
32
-    public $configFile = __DIR__ . '/../../config/callingallpapers.ini';
32
+    public $configFile = __DIR__.'/../../config/callingallpapers.ini';
33 33
 
34 34
     public function getWriter()
35 35
     {
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             throw new UnknownWriterException('The requested writer could not be created');
43 43
         }
44 44
         
45
-        if (! $writer instanceof WriterInterface) {
45
+        if (!$writer instanceof WriterInterface) {
46 46
             throw new InvalidWriterException('The requested writer is not of the expected type');
47 47
         }
48 48
 
Please login to merge, or discard this patch.
src/Service/TimezoneService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 
64 64
         $values = json_decode($result->getBody()->getContents(), true);
65 65
 
66
-        if (! isset($values['status']) || $values['status'] !== 'OK') {
66
+        if (!isset($values['status']) || $values['status'] !== 'OK') {
67 67
             return 'UTC';
68 68
         }
69 69
 
Please login to merge, or discard this patch.
src/Notification/TwitterNotifier.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             $uri
51 51
         );
52 52
         $request = new Request('POST',
53
-            'statuses/update.json?' . $this->formUrlEncode([
53
+            'statuses/update.json?'.$this->formUrlEncode([
54 54
                 'status'              => $notificationString,
55 55
                 'lat'                 => $cfp->latitude,
56 56
                 'long'                => $cfp->longitude,
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         if (strlen($name) < 70) {
71 71
             return $name;
72 72
         }
73
-        return substr($name, 0, 69) . '…';
73
+        return substr($name, 0, 69).'…';
74 74
     }
75 75
 
76 76
     protected function shortenUri($uri)
Please login to merge, or discard this patch.
src/Reader/ApiCfpReader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             return $list;
93 93
         }
94 94
 
95
-        if (! $items) {
95
+        if (!$items) {
96 96
             return $list;
97 97
         }
98 98
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             $cfp->longitude      = $item['longitude'];
111 111
             $cfp->iconUri        = $item['iconUri'];
112 112
             $cfp->uri            = $item['uri'];
113
-            $cfp->tags           = array_filter($item['tags'], function ($item) {
113
+            $cfp->tags           = array_filter($item['tags'], function($item) {
114 114
                 return (bool) $item;
115 115
             });
116 116
             $cfp->timezone       = $item['timezone'];
Please login to merge, or discard this patch.
src/Command/NotifyClosingCfps.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -45,18 +45,18 @@
 block discarded – undo
45 45
     protected function configure()
46 46
     {
47 47
         $this->setName("notifyClosingCfps")
48
-             ->setDescription("Notify about CfPs that close within 24 hours")
49
-             ->setDefinition(array(
50
-                 new InputOption('start', 's', InputOption::VALUE_OPTIONAL, 'What should be the first date to be taken into account?', ''),
51
-             ))
52
-             ->setHelp(<<<EOT
48
+                ->setDescription("Notify about CfPs that close within 24 hours")
49
+                ->setDefinition(array(
50
+                    new InputOption('start', 's', InputOption::VALUE_OPTIONAL, 'What should be the first date to be taken into account?', ''),
51
+                ))
52
+                ->setHelp(<<<EOT
53 53
 Notify about CfPs that are closing within 24 hours
54 54
 
55 55
 Usage:
56 56
 
57 57
 <info>callingallpapers notifyClosingCfp</info>
58 58
 EOT
59
-             );
59
+                );
60 60
     }
61 61
 
62 62
     protected function execute(InputInterface $input, OutputInterface $output)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,11 +67,11 @@
 block discarded – undo
67 67
 
68 68
         $start = new \DateTime($input->getOption('start'));
69 69
 
70
-        if (! $start instanceof \DateTime) {
70
+        if (!$start instanceof \DateTime) {
71 71
             throw new \InvalidArgumentException('The given date could not be parsed');
72 72
         }
73 73
 
74
-        $config = parse_ini_file(__DIR__ . '/../../config/callingallpapers.ini');
74
+        $config = parse_ini_file(__DIR__.'/../../config/callingallpapers.ini');
75 75
         $writer = new ApiCfpWriter($config['event_api_url'], $config['event_api_token']);
76 76
         $writer->setOutput($output);
77 77
 
Please login to merge, or discard this patch.