NotificationList::notify() - Code Metrics - Inspection of "Merge pull request #17 from heiglandreas/hotfix/st..." - joindin/callingallpapers-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e2689e...3cb732 )

by Andreas

created 2016-11-07 17:17 UTC

NotificationList::notify() A

↳ Parent: NotificationList

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	3
nop	1

<?php
/**
 * Copyright (c) Andreas Heigl<[email protected]>
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @author    Andreas Heigl<[email protected]>
 * @copyright Andreas Heigl
 * @license   http://www.opensource.org/licenses/mit-license.php MIT-License
 * @since     22.09.2016
 * @link      http://github.com/heiglandreas/callingallpapers
 */

namespace Callingallpapers\Notification;

use Callingallpapers\Entity\CfpList;

class NotificationList extends \ArrayObject
{
    /**
     * @param mixed $item
     *
     * @deprecated
     * @throws \Exception
     * @return void
     */
    public function append($item)
    {
        throw new \Exception(sprintf(
            'Use %s::add() instead',
            self::class
        ));
    }

    public function add(NotificationInterface $notification)
    {
        parent::append($notification);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public function notify(CfpList $cfps)
    {
        foreach ($cfps as $cfp) {
            foreach ($this as $notifier) {
                $notifier->notify($cfp);
            }
        }
    }
}


1			<?php
2			/**
3			* Copyright (c) Andreas Heigl<[email protected]>
4			* Permission is hereby granted, free of charge, to any person obtaining a copy
5			* of this software and associated documentation files (the "Software"), to deal
6			* in the Software without restriction, including without limitation the rights
7			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
8			* copies of the Software, and to permit persons to whom the Software is
9			* furnished to do so, subject to the following conditions:
10			* The above copyright notice and this permission notice shall be included in
11			* all copies or substantial portions of the Software.
12			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
13			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
14			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
15			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
16			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
17			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
18			* THE SOFTWARE.
19			*
20			* @author Andreas Heigl<[email protected]>
21			* @copyright Andreas Heigl
22			* @license http://www.opensource.org/licenses/mit-license.php MIT-License
23			* @since 22.09.2016
24			* @link http://github.com/heiglandreas/callingallpapers
25			*/
26
27			namespace Callingallpapers\Notification;
28
29			use Callingallpapers\Entity\CfpList;
30
31			class NotificationList extends \ArrayObject
32			{
33			/**
34			* @param mixed $item
35			*
36			* @deprecated
37			* @throws \Exception
38			* @return void
39			*/
40			public function append($item)
41			{
42			throw new \Exception(sprintf(
43			'Use %s::add() instead',
44			self::class
45			));
46			}
47
48			public function add(NotificationInterface $notification)
49			{
50			parent::append($notification);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-23 08:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`append()` instead of `add()`). Are you sure this is correct? If so, you might want to change this to `$this->append()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
51			}
52
53			public function notify(CfpList $cfps)
54			{
55			foreach ($cfps as $cfp) {
56			foreach ($this as $notifier) {
57			$notifier->notify($cfp);
58			}
59			}
60			}
61			}
62

joindin / callingallpapers-cli

Push — master ( e2689e...3cb732 )

NotificationList::notify() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like