ClosingDate::__construct() - Code Metrics - Inspection of "WIP Feature/add paper call io parser" - joindin/callingallpapers-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

by Andreas

created 2017-08-18 06:26 UTC

ClosingDate::__construct() A

↳ Parent: ClosingDate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php
/**
 * Copyright (c) 2015-2015 Andreas Heigl<[email protected]>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @author    Andreas Heigl<[email protected]>
 * @copyright 2015-2015 Andreas Heigl/callingallpapers.com
 * @license   http://www.opensource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     06.03.2012
 * @link      http://github.com/joindin/callingallpapers
 */
namespace Callingallpapers\Parser\PapercallIo;

use Callingallpapers\Entity\Cfp;
use Callingallpapers\Parser\EventDetailParserInterface;
use DateTimeImmutable;
use DOMDocument;
use DOMNode;
use DOMXPath;
use InvalidArgumentException;

class ClosingDate implements EventDetailParserInterface
{
    protected $timezone;

    public function __construct($timezone = 'UTC')
    {
        $this->timezone = new \DateTimezone($timezone);
    }

    public function parse(DOMDocument $dom, DOMNode $node, Cfp $cfp) : Cfp
    {
        $xpath = new DOMXPath($node->ownerDocument);
        $closingDate = $xpath->query(".//time/@datetime", $node);
        if (! $closingDate || $closingDate->length == 0) {
            throw new InvalidArgumentException('The CfP does not seem to have a closing date');
        }

        $closingDate = $closingDate->item(0)->textContent;

        $cfp->dateEnd = new DateTimeImmutable($closingDate);
        $cfp->dateEnd = $cfp->dateEnd->setTimezone($this->timezone);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $cfp;
    }
}


1			<?php
2			/**
3			* Copyright (c) 2015-2015 Andreas Heigl<[email protected]>
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy
6			* of this software and associated documentation files (the "Software"), to deal
7			* in the Software without restriction, including without limitation the rights
8			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9			* copies of the Software, and to permit persons to whom the Software is
10			* furnished to do so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in
13			* all copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21			* THE SOFTWARE.
22			*
23			* @author Andreas Heigl<[email protected]>
24			* @copyright 2015-2015 Andreas Heigl/callingallpapers.com
25			* @license http://www.opensource.org/licenses/mit-license.php MIT-License
26			* @version 0.0
27			* @since 06.03.2012
28			* @link http://github.com/joindin/callingallpapers
29			*/
30			namespace Callingallpapers\Parser\PapercallIo;
31
32			use Callingallpapers\Entity\Cfp;
33			use Callingallpapers\Parser\EventDetailParserInterface;
34			use DateTimeImmutable;
35			use DOMDocument;
36			use DOMNode;
37			use DOMXPath;
38			use InvalidArgumentException;
39
40			class ClosingDate implements EventDetailParserInterface
41			{
42			protected $timezone;
43
44			public function __construct($timezone = 'UTC')
45			{
46			$this->timezone = new \DateTimezone($timezone);
47			}
48
49			public function parse(DOMDocument $dom, DOMNode $node, Cfp $cfp) : Cfp
50			{
51			$xpath = new DOMXPath($node->ownerDocument);
52			$closingDate = $xpath->query(".//time/@datetime", $node);
53			if (! $closingDate \|\| $closingDate->length == 0) {
54			throw new InvalidArgumentException('The CfP does not seem to have a closing date');
55			}
56
57			$closingDate = $closingDate->item(0)->textContent;
58
59			$cfp->dateEnd = new DateTimeImmutable($closingDate);
60			$cfp->dateEnd = $cfp->dateEnd->setTimezone($this->timezone);
			0 ignored issues – show Documentation Bug introduced 2017-08-18 06:28 UTC by Report Bug Copy Issue Report It seems like `$cfp->dateEnd->setTimezone($this->timezone)` can also be of type `false`. However, the property `$dateEnd` is declared as type `object<DateTimeInterface>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
61
62			return $cfp;
63			}
64			}
65

joindin / callingallpapers-cli

Pull Request — master (#28)

ClosingDate::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like