ResultKeeper::add() - Code Metrics - Inspection of "Add confs tech" - joindin/callingallpapers-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Andreas

created 2018-08-27 05:53 UTC

ResultKeeper::add() A

↳ Parent: ResultKeeper

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.3554
c	0
b	0
f	0
cc	5
nc	5
nop	1

<?php

/*
 * Copyright (c) Andreas Heigl<[email protected]
 *
 * Licensed under the MIT License. See LICENSE.md file in the project root
 * for full license information.
 */

namespace Callingallpapers\ResultKeeper;

use Symfony\Component\Console\Output\OutputInterface;

class ResultKeeper
{
    private $errors = [];

    private $failures = [];

    private $updated = [];

    private $created = [];

    public function add(Result $result)
    {
        switch (get_class($result)) {
            case Error::class:
                $this->addError($result);

                break;
            case Failure::class:
                $this->addFailure($result);

                break;
            case Created::class:
                $this->addCreated($result);

                break;
            case Updated::class:
                $this->addUpdated($result);

                break;
            default:
        }
    }

    public function addError(Error $error) : void
    {
        $this->errors[] = $error;
    }

    public function addFailure(Failure $failure) : void
    {
        $this->failures[] = $failure;
    }

    public function addCreated(Created $created) : void
    {
        $this->created[] = $created;
    }
    public function addUpdated(Updated $updated) : void
    {
        $this->updated[] = $updated;
    }

    /**
     * @return \Callingallpapers\ResultKeeper\Created[]
     */
    public function getCreated() : array
    {
        return $this->created;
    }

    /**
     * @return \Callingallpapers\ResultKeeper\Updated[]
     */
    public function getUpdated() : array
    {
        return $this->updated;
    }

    /**
     * @return \Callingallpapers\ResultKeeper\Failure[]
     */
    public function getFailed() : array
    {
        return $this->failures;
    }

    /**
     * @return \Callingallpapers\ResultKeeper\Error[]
     */
    public function getErrored() : array
    {
        return $this->errors;
    }
}


1			<?php
2
3			/*
4			* Copyright (c) Andreas Heigl<[email protected]
5			*
6			* Licensed under the MIT License. See LICENSE.md file in the project root
7			* for full license information.
8			*/
9
10			namespace Callingallpapers\ResultKeeper;
11
12			use Symfony\Component\Console\Output\OutputInterface;
13
14			class ResultKeeper
15			{
16			private $errors = [];
17
18			private $failures = [];
19
20			private $updated = [];
21
22			private $created = [];
23
24			public function add(Result $result)
25			{
26			switch (get_class($result)) {
27			case Error::class:
28			$this->addError($result);
			0 ignored issues – show Compatibility introduced 2018-08-27 05:58 UTC by Report Bug Copy Issue Report `$result` of type `object<Callingallpapers\ResultKeeper\Result>` is not a sub-type of `object<Callingallpapers\ResultKeeper\Error>`. It seems like you assume a concrete implementation of the interface `Callingallpapers\ResultKeeper\Result` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
29			break;
30			case Failure::class:
31			$this->addFailure($result);
			0 ignored issues – show Compatibility introduced 2018-08-27 05:58 UTC by Report Bug Copy Issue Report `$result` of type `object<Callingallpapers\ResultKeeper\Result>` is not a sub-type of `object<Callingallpapers\ResultKeeper\Failure>`. It seems like you assume a concrete implementation of the interface `Callingallpapers\ResultKeeper\Result` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
32			break;
33			case Created::class:
34			$this->addCreated($result);
			0 ignored issues – show Compatibility introduced 2018-08-27 05:58 UTC by Report Bug Copy Issue Report `$result` of type `object<Callingallpapers\ResultKeeper\Result>` is not a sub-type of `object<Callingallpapers\ResultKeeper\Created>`. It seems like you assume a concrete implementation of the interface `Callingallpapers\ResultKeeper\Result` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
35			break;
36			case Updated::class:
37			$this->addUpdated($result);
			0 ignored issues – show Compatibility introduced 2018-08-27 05:58 UTC by Report Bug Copy Issue Report `$result` of type `object<Callingallpapers\ResultKeeper\Result>` is not a sub-type of `object<Callingallpapers\ResultKeeper\Updated>`. It seems like you assume a concrete implementation of the interface `Callingallpapers\ResultKeeper\Result` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
38			break;
39			default:
40			}
41			}
42
43			public function addError(Error $error) : void
44			{
45			$this->errors[] = $error;
46			}
47
48			public function addFailure(Failure $failure) : void
49			{
50			$this->failures[] = $failure;
51			}
52
53			public function addCreated(Created $created) : void
54			{
55			$this->created[] = $created;
56			}
57			public function addUpdated(Updated $updated) : void
58			{
59			$this->updated[] = $updated;
60			}
61
62			/**
63			* @return \Callingallpapers\ResultKeeper\Created[]
64			*/
65			public function getCreated() : array
66			{
67			return $this->created;
68			}
69
70			/**
71			* @return \Callingallpapers\ResultKeeper\Updated[]
72			*/
73			public function getUpdated() : array
74			{
75			return $this->updated;
76			}
77
78			/**
79			* @return \Callingallpapers\ResultKeeper\Failure[]
80			*/
81			public function getFailed() : array
82			{
83			return $this->failures;
84			}
85
86			/**
87			* @return \Callingallpapers\ResultKeeper\Error[]
88			*/
89			public function getErrored() : array
90			{
91			return $this->errors;
92			}
93			}
94

joindin / callingallpapers-cli

Pull Request — master (#35)

ResultKeeper::add() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like