GusApi\Util\DataSearchDecoder::decode()

Complexity

Conditions	4
Paths	4

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	3	Features	0

<?php
    public static function decode(SearchResponseRaw $searchResponseRaw): SearchDataResponse
    {
        if ('' === $searchResponseRaw->getDaneSzukajPodmiotyResult()) {
            return new SearchDataResponse();
        }

        try {
            $xmlElementsResponse = new SimpleXMLElement($searchResponseRaw->getDaneSzukajPodmiotyResult());
        } catch (\Exception $e) {
            throw new InvalidServerResponseException('Invalid server response', 0, $e);
        }

        $elements = [];

        foreach ($xmlElementsResponse->dane as $resultData) {
            $elements[] = self::decodeSingleResult($resultData);

It seems like $resultData can also be of type null; however, parameter $element of GusApi\Util\DataSearchDecoder::decodeSingleResult() does only seem to accept SimpleXMLElement, maybe add an additional type check?

        }

        return new SearchDataResponse($elements);
    }