GeoPhone::lookupNumber() - Code Metrics - Inspection of "update geophone example to match new codebase post..." - johnvandeweghe/LunixREST - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba0dc9...449151 )

by John

created 2016-12-10 19:28 UTC

GeoPhone::lookupNumber() A

↳ Parent: GeoPhone

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	3
nop	1

<?php
namespace GeoPhone\Models;

/**
 * Class GeoPhone
 * @package GeoPhone\Models
 */
class GeoPhone {
    /**
     * @var resource
     */
    protected $fileHandle;

    /**
     * @param string $filename
     */
    public function __construct($filename = 'data.csv'){
        $this->fileHandle = fopen($filename, 'r');
    }

    /**
     * @param String $phoneNumber A phone number in any format
     * @return LookupResponse
     * City and state are empty when not found.
     */
    public function lookupNumber($phoneNumber): LookupResponse{
        $phoneNumber = preg_replace('/[^0-9]/s', '', $phoneNumber);
        $areaCode = substr($phoneNumber, 0, 3);
        $nextThree = substr($phoneNumber, 3, 3);

        while (($data = fgetcsv($this->fileHandle)) !== FALSE) {
            if($areaCode == $data[0] && $nextThree == $data[1]){
                return new LookupResponse($data[2], $data[3]);
            }
        }

        return new LookupResponse('', '');
    }
}


1			<?php
2			namespace GeoPhone\Models;
3
4			/**
5			* Class GeoPhone
6			* @package GeoPhone\Models
7			*/
8			class GeoPhone {
9			/**
10			* @var resource
11			*/
12			protected $fileHandle;
13
14			/**
15			* @param string $filename
16			*/
17			public function __construct($filename = 'data.csv'){
18			$this->fileHandle = fopen($filename, 'r');
19			}
20
21			/**
22			* @param String $phoneNumber A phone number in any format
23			* @return LookupResponse
24			* City and state are empty when not found.
25			*/
26			public function lookupNumber($phoneNumber): LookupResponse{
27			$phoneNumber = preg_replace('/[^0-9]/s', '', $phoneNumber);
28			$areaCode = substr($phoneNumber, 0, 3);
29			$nextThree = substr($phoneNumber, 3, 3);
30
31			while (($data = fgetcsv($this->fileHandle)) !== FALSE) {
32			if($areaCode == $data[0] && $nextThree == $data[1]){
33			return new LookupResponse($data[2], $data[3]);
34			}
35			}
36
37			return new LookupResponse('', '');
38			}
39			}
40

johnvandeweghe / LunixREST

Push — master ( ba0dc9...449151 )

GeoPhone::lookupNumber() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like