EndpointFactory::getEndpoint() - Code Metrics - Inspection of "update geophone example to match new codebase post..." - johnvandeweghe/LunixREST - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba0dc9...449151 )

by John

created 2016-12-10 19:28 UTC

EndpointFactory::getEndpoint() A

↳ Parent: EndpointFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	12
nc	3
nop	2

<?php
namespace GeoPhone\EndpointFactory;

use GeoPhone\Endpoints\v1\PhoneNumbers;
use GeoPhone\Models\GeoPhone;
use LunixREST\Endpoint\Endpoint;
use LunixREST\Endpoint\Exceptions\UnknownEndpointException;

class EndpointFactory implements \LunixREST\Endpoint\EndpointFactory {

    protected $geoPhone;

    public function __construct(GeoPhone $geoPhone) {
        $this->geoPhone = $geoPhone;
    }

    /**
     * @param string $name
     * @param string $version
     * @return Endpoint
     * @throws UnknownEndpointException
     */
    public function getEndpoint(string $name, string $version): Endpoint {
        switch($version) {
            case "1":
                switch (strtolower($name)) {
                    case "phonenumbers":
                        return new PhoneNumbers($this->geoPhone);
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                    default:
                        throw new UnknownEndpointException("Endpoint: $name not supported");
                }
                break;
            default:
                throw new UnknownEndpointException("Version: $version not support");
        }
    }

    /**
     * @param string $version
     * @return string[]
     */
    public function getSupportedEndpoints(string $version): array {
        return ["phonenumbers"];
    }
}


1			<?php
2			namespace GeoPhone\EndpointFactory;
3
4			use GeoPhone\Endpoints\v1\PhoneNumbers;
5			use GeoPhone\Models\GeoPhone;
6			use LunixREST\Endpoint\Endpoint;
7			use LunixREST\Endpoint\Exceptions\UnknownEndpointException;
8
9			class EndpointFactory implements \LunixREST\Endpoint\EndpointFactory {
10
11			protected $geoPhone;
12
13			public function __construct(GeoPhone $geoPhone) {
14			$this->geoPhone = $geoPhone;
15			}
16
17			/**
18			* @param string $name
19			* @param string $version
20			* @return Endpoint
21			* @throws UnknownEndpointException
22			*/
23			public function getEndpoint(string $name, string $version): Endpoint {
24			switch($version) {
25			case "1":
26			switch (strtolower($name)) {
27			case "phonenumbers":
28			return new PhoneNumbers($this->geoPhone);
29			break;
			0 ignored issues – show Unused Code introduced 2016-12-10 19:29 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
30			default:
31			throw new UnknownEndpointException("Endpoint: $name not supported");
32			}
33			break;
34			default:
35			throw new UnknownEndpointException("Version: $version not support");
36			}
37			}
38
39			/**
40			* @param string $version
41			* @return string[]
42			*/
43			public function getSupportedEndpoints(string $version): array {
44			return ["phonenumbers"];
45			}
46			}
47

johnvandeweghe / LunixREST

Push — master ( ba0dc9...449151 )

EndpointFactory::getEndpoint() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like