ResourceAPIResponseDataFactory::multipleToAPIResponseData() - Code Metrics - Inspection of "Resource abstraction" - johnvandeweghe/LunixREST - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#41)

by John

created 2017-05-29 22:46 UTC

multipleToAPIResponseData() A

↳ Parent: ResourceAPIResponseDataFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php
namespace LunixREST\Server\Router\Endpoint\ResourceEndpoint;

use LunixREST\Server\APIResponse\APIResponseData;
use LunixREST\Server\Router\Endpoint\ResourceEndpoint\Exceptions\UnableToCreateAPIResponseDataException;

/**
 * abstract class ResourceAPIResponseDataFactory
 * @package LunixREST\Server\Router\Endpoint\ResourceEndpoint
 */
abstract class ResourceAPIResponseDataFactory {

    /**
     * @param null|Resource $resource
     * @return APIResponseData
     * @throws UnableToCreateAPIResponseDataException
     */
    abstract public function toAPIResponseData(?Resource $resource): APIResponseData;

    /**
     * Uses above method for each resource, extracting the data into an array, creating a new APIResponseData from that array.
     * @param null|Resource[] $resources
     * @return APIResponseData
     * @throws UnableToCreateAPIResponseDataException
     */
    public function multipleToAPIResponseData(?array $resources): APIResponseData
    {
        if(is_null($resources)) {
            return $this->toAPIResponseData(null);
        }

        return new APIResponseData(array_map(function(Resource $resource) {
            return $this->toAPIResponseData($resource)->getData();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }, $resources));
    }
}


1		<?php
2		namespace LunixREST\Server\Router\Endpoint\ResourceEndpoint;
3
4		use LunixREST\Server\APIResponse\APIResponseData;
5		use LunixREST\Server\Router\Endpoint\ResourceEndpoint\Exceptions\UnableToCreateAPIResponseDataException;
6
7		/**
8		* abstract class ResourceAPIResponseDataFactory
9		* @package LunixREST\Server\Router\Endpoint\ResourceEndpoint
10		*/
11		abstract class ResourceAPIResponseDataFactory {
12
13		/**
14		* @param null\|Resource $resource
15		* @return APIResponseData
16		* @throws UnableToCreateAPIResponseDataException
17		*/
18		abstract public function toAPIResponseData(?Resource $resource): APIResponseData;
19
20		/**
21		* Uses above method for each resource, extracting the data into an array, creating a new APIResponseData from that array.
22		* @param null\|Resource[] $resources
23		* @return APIResponseData
24		* @throws UnableToCreateAPIResponseDataException
25		*/
26	10	public function multipleToAPIResponseData(?array $resources): APIResponseData
27		{
28	10	if(is_null($resources)) {
29	2	return $this->toAPIResponseData(null);
30		}
31
32	8	return new APIResponseData(array_map(function(Resource $resource) {
33	7	return $this->toAPIResponseData($resource)->getData();
		1 ignored issue – show Documentation introduced 2017-05-29 22:48 UTC by Report Bug Copy Issue Report `$resource` is of type `object<LunixREST\Server\...ourceEndpoint\Resource>`, but the function expects a `null\|resource`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34	8	}, $resources));
35		}
36		}
37

johnvandeweghe / LunixREST

Pull Request — master (#41)

multipleToAPIResponseData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like