HTTPServer - Code Metrics - Inspection of "split router into a server router pair. Add an htt..." - johnvandeweghe/LunixREST - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 73f336...7e2fc0 )

by John

created 2016-12-12 06:33 UTC

HTTPServer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	3
dl	0
loc	48
c	0
b	0
f	0
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
D	handleSAPIRequest()	0	27	9

<?php
namespace LunixREST\Server;

use LunixREST\Endpoint\Exceptions\UnknownEndpointException;
use LunixREST\Exceptions\AccessDeniedException;
use LunixREST\Exceptions\InvalidAPIKeyException;
use LunixREST\Exceptions\ThrottleLimitExceededException;
use LunixREST\Request\RequestFactory\RequestFactory;
use LunixREST\Request\URLParser\Exceptions\InvalidRequestURLException;
use LunixREST\Response\Exceptions\UnknownResponseTypeException;

class HTTPServer {
    /**
     * @var Server
     */
    protected $server;
    /**
     * @var RequestFactory
     */
    private $requestFactory;

    /**
     * HTTPServer constructor.
     * @param Server $server
     * @param RequestFactory $requestFactory
     */
    public function __construct(Server $server, RequestFactory $requestFactory) {
        $this->server = $server;
        $this->requestFactory = $requestFactory;
    }

    public function handleSAPIRequest() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        try {
            $request = $this->requestFactory->create($_SERVER['REQUEST_METHOD'], getallheaders(),
                file_get_contents("php://input"), $_SERVER['REMOTE_ADDR'], $_SERVER['REQUEST_URI']);

            try {
                $response = $this->server->handleRequest($request);
                echo $response->getAsString();
            } catch(InvalidAPIKeyException $e){
                header('400 Bad Request', true, 400);
            } catch(UnknownEndpointException $e){
                header('404 Not Found', true, 404);
            } catch(UnknownResponseTypeException $e){
                header('404 Not Found', true, 404);
            } catch(AccessDeniedException $e){
                header('403 Access Denied', true, 403);
            } catch(ThrottleLimitExceededException $e){
                header('429 Too Many Requests', true, 429);
            } catch (\Exception $e) {
                header('500 Internal Server Error', true, 500);
            }
        } catch(InvalidRequestURLException $e){
            header('400 Bad Request', true, 400);
        } catch(\Exception $e){
            header('500 Internal Server Error', true, 500);
        }
    }
}


1			<?php
2			namespace LunixREST\Server;
3
4			use LunixREST\Endpoint\Exceptions\UnknownEndpointException;
5			use LunixREST\Exceptions\AccessDeniedException;
6			use LunixREST\Exceptions\InvalidAPIKeyException;
7			use LunixREST\Exceptions\ThrottleLimitExceededException;
8			use LunixREST\Request\RequestFactory\RequestFactory;
9			use LunixREST\Request\URLParser\Exceptions\InvalidRequestURLException;
10			use LunixREST\Response\Exceptions\UnknownResponseTypeException;
11
12			class HTTPServer {
13			/**
14			* @var Server
15			*/
16			protected $server;
17			/**
18			* @var RequestFactory
19			*/
20			private $requestFactory;
21
22			/**
23			* HTTPServer constructor.
24			* @param Server $server
25			* @param RequestFactory $requestFactory
26			*/
27			public function __construct(Server $server, RequestFactory $requestFactory) {
28			$this->server = $server;
29			$this->requestFactory = $requestFactory;
30			}
31
32			public function handleSAPIRequest() {
			1 ignored issue – show Coding Style introduced 2016-12-12 06:35 UTC by Report Bug Copy Issue Report `handleSAPIRequest` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33			try {
34			$request = $this->requestFactory->create($_SERVER['REQUEST_METHOD'], getallheaders(),
35			file_get_contents("php://input"), $_SERVER['REMOTE_ADDR'], $_SERVER['REQUEST_URI']);
36
37			try {
38			$response = $this->server->handleRequest($request);
39			echo $response->getAsString();
40			} catch(InvalidAPIKeyException $e){
41			header('400 Bad Request', true, 400);
42			} catch(UnknownEndpointException $e){
43			header('404 Not Found', true, 404);
44			} catch(UnknownResponseTypeException $e){
45			header('404 Not Found', true, 404);
46			} catch(AccessDeniedException $e){
47			header('403 Access Denied', true, 403);
48			} catch(ThrottleLimitExceededException $e){
49			header('429 Too Many Requests', true, 429);
50			} catch (\Exception $e) {
51			header('500 Internal Server Error', true, 500);
52			}
53			} catch(InvalidRequestURLException $e){
54			header('400 Bad Request', true, 400);
55			} catch(\Exception $e){
56			header('500 Internal Server Error', true, 500);
57			}
58			}
59			}
60

johnvandeweghe / LunixREST

Push — master ( 73f336...7e2fc0 )

HTTPServer A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like