LunixRESTBasics\Endpoint\EntityManagedEndpointFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getLoggingEndpoint()	0	6	1
	getEntityManagedEndpoint()	0	1	?

<?php
namespace LunixRESTBasics\Endpoint;

use Doctrine\ORM\EntityManager;
use LunixREST\Endpoint\LoggingEndpoint;
use LunixREST\Endpoint\LoggingEndpointFactory;
use Psr\Log\LoggerInterface;

abstract class EntityManagedEndpointFactory extends LoggingEndpointFactory
{
    /**
     * @var EntityManager
     */
    protected $entityManager;

    public function __construct(EntityManager $entityManager, LoggerInterface $logger)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
        parent::__construct($logger);
    }

    protected function getLoggingEndpoint(string $name, string $version): LoggingEndpoint
    {
        $endpoint = $this->getEntityManagedEndpoint($name, $version);
        $endpoint->setEntityManager($this->entityManager);
        return $endpoint;
    }

    protected abstract function getEntityManagedEndpoint(string $name, string $version): EntityManagedEndpoint;

The abstract declaration must precede the visibility declaration

}