Alternation::parse() - Code Metrics - Inspection of "Added the Alternation Trigger" - johnnymast/rivescript-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 53b14c...3240e8 )

by Johnny

created 2022-01-19 01:53 UTC

Alternation::parse() B

↳ Parent: Alternation

Complexity

Conditions	8
Paths	4

Size

Total Lines	52
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	22
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	52
rs	8.4444

How to fix Long Method

<?php
/*
 * This file is part of Rivescript-php
 *
 * (c) Johnny Mast <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Axiom\Rivescript\Cortex\Triggers;

use Axiom\Rivescript\Cortex\Input;
use Axiom\Rivescript\Traits\Regex;

/**
 * Arrays class
 *
 * The Alternation class determines if a provided trigger
 * is an Alternation.
 *
 * PHP version 7.4 and higher.
 *
 * @category Core
 * @package  Cortext\Triggers
 * @author   Johnny Mast <[email protected]>
 * @license  https://opensource.org/licenses/MIT MIT
 * @link     https://github.com/axiom-labs/rivescript-php
 * @since    0.4.0
 */
class Alternation extends Trigger
{
    use Regex;

    /**
     * The Regex pattern to find sets
     * in the trigger.
     *
     * Note: This pattern ignores the set if a @ character
     * is inside to make sure we don't confuse them with arrays.
     *
     * @var string
     */
//    protected string $pattern = "/(\((?!\@)(.+?=*)\))|(\[(?!\@)(.+?=*)\])/ui";
    protected string $pattern = "/(\(|\[)(?!\@)(.+?=*)(\)|\])/ui";

    /**
     * Parse the trigger.
     *
     * @return bool|string
     */
    public function parse(string $trigger, Input $input): bool
    {
        if ($this->matchesPattern($this->pattern, $trigger) === true) {
            $triggerString = $trigger;
            $matches = $this->getMatchesFromPattern($this->pattern, $triggerString);
            $sets = [];

            /**
             * Replace every "set" in the trigger to their index number
             * found in the string.
             *
             * Example:
             *
             * "I (am|love) a robot. I like (my|style)"
             *
             * Will be replaced with:
             *
             * "I {0} a robot. I like {1}"
             */
            foreach ($matches as $index => $match) {

                $set = explode("|", $match[2]);

                if (count($set) > 0) {
                    $triggerString = str_replace($match[0], "{{$index}}", $triggerString);
                    $sets [] = $set;
                }
            }

            $combinations = $this->getCombinations(...$sets);

            if (count($combinations) > 0) {
                $sentences = [];

                foreach ($combinations as $combination) {
                    $tmp = $triggerString;
                    foreach ($combination as $index => $string) {
                        $tmp = str_replace("{{$index}}", $string, $tmp);
                    }

                    $sentences [] = $tmp;
                }

                $result = array_filter($sentences, static function (string $sentence) use ($input) {
                    return (strtolower($sentence) === strtolower($input->source()));
                });

                if (count($result) > 0) {
                    return $input->source();

                }
            }
        }
        return false;
    }

    /**
     * Create a set of possible combinations for given arrays.
     *
     * Note: This function is taken from stackoverflow.com
     * first posted by Guilhermo Luna and later edited by user Amlette.
     *
     * @see https://stackoverflow.com/questions/8567082/how-to-generate-in-php-all-combinations-of-items-in-multiple-arrays/33259643#33259643
     *
     * @param array ...$arrays A set of arrays to combine.
     *
     * @return array|array[]
     *
     */
    private function getCombinations(array ...$arrays): array
    {
        $result = [[]];
        foreach ($arrays as $property => $property_values) {
            $tmp = [];
            foreach ($result as $result_item) {
                foreach ($property_values as $property_value) {
                    $tmp[] = array_merge($result_item, [$property => $property_value]);
                }
            }
            $result = $tmp;
        }
        return $result;
    }
}


1			<?php
2			/*
3			* This file is part of Rivescript-php
4			*
5			* (c) Johnny Mast <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Axiom\Rivescript\Cortex\Triggers;
12
13			use Axiom\Rivescript\Cortex\Input;
14			use Axiom\Rivescript\Traits\Regex;
15
16			/**
17			* Arrays class
18			*
19			* The Alternation class determines if a provided trigger
20			* is an Alternation.
21			*
22			* PHP version 7.4 and higher.
23			*
24			* @category Core
25			* @package Cortext\Triggers
26			* @author Johnny Mast <[email protected]>
27			* @license https://opensource.org/licenses/MIT MIT
28			* @link https://github.com/axiom-labs/rivescript-php
29			* @since 0.4.0
30			*/
31			class Alternation extends Trigger
32			{
33			use Regex;
34
35			/**
36			* The Regex pattern to find sets
37			* in the trigger.
38			*
39			* Note: This pattern ignores the set if a @ character
40			* is inside to make sure we don't confuse them with arrays.
41			*
42			* @var string
43			*/
44			// protected string $pattern = "/(\((?!\@)(.+?=)\))\|(\[(?!\@)(.+?=)\])/ui";
45			protected string $pattern = "/(\(\|\[)(?!\@)(.+?=*)(\)\|\])/ui";
46
47			/**
48			* Parse the trigger.
49			*
50			* @return bool\|string
51			*/
52			public function parse(string $trigger, Input $input): bool
53			{
54			if ($this->matchesPattern($this->pattern, $trigger) === true) {
55			$triggerString = $trigger;
56			$matches = $this->getMatchesFromPattern($this->pattern, $triggerString);
57			$sets = [];
58
59			/**
60			* Replace every "set" in the trigger to their index number
61			* found in the string.
62			*
63			* Example:
64			*
65			* "I (am\|love) a robot. I like (my\|style)"
66			*
67			* Will be replaced with:
68			*
69			* "I {0} a robot. I like {1}"
70			*/
71			foreach ($matches as $index => $match) {
			0 ignored issues – show Bug introduced 2022-01-19 01:55 UTC by Report Bug Copy Issue Report The expression `$matches` of type `false` is not traversable. Loading history...
72			$set = explode("\|", $match[2]);
73
74			if (count($set) > 0) {
75			$triggerString = str_replace($match[0], "{{$index}}", $triggerString);
76			$sets [] = $set;
77			}
78			}
79
80			$combinations = $this->getCombinations(...$sets);
81
82			if (count($combinations) > 0) {
83			$sentences = [];
84
85			foreach ($combinations as $combination) {
86			$tmp = $triggerString;
87			foreach ($combination as $index => $string) {
88			$tmp = str_replace("{{$index}}", $string, $tmp);
89			}
90
91			$sentences [] = $tmp;
92			}
93
94			$result = array_filter($sentences, static function (string $sentence) use ($input) {
95			return (strtolower($sentence) === strtolower($input->source()));
96			});
97
98			if (count($result) > 0) {
99			return $input->source();
			0 ignored issues – show Bug Best Practice introduced 2022-01-19 01:55 UTC by Report Bug Copy Issue Report The expression `return $input->source()` returns the type `string` which is incompatible with the type-hinted return `boolean`. Loading history...
100			}
101			}
102			}
103			return false;
104			}
105
106			/**
107			* Create a set of possible combinations for given arrays.
108			*
109			* Note: This function is taken from stackoverflow.com
110			* first posted by Guilhermo Luna and later edited by user Amlette.
111			*
112			* @see https://stackoverflow.com/questions/8567082/how-to-generate-in-php-all-combinations-of-items-in-multiple-arrays/33259643#33259643
113			*
114			* @param array ...$arrays A set of arrays to combine.
115			*
116			* @return array\|array[]
117			*
118			*/
119			private function getCombinations(array ...$arrays): array
120			{
121			$result = [[]];
122			foreach ($arrays as $property => $property_values) {
123			$tmp = [];
124			foreach ($result as $result_item) {
125			foreach ($property_values as $property_value) {
126			$tmp[] = array_merge($result_item, [$property => $property_value]);
127			}
128			}
129			$result = $tmp;
130			}
131			return $result;
132			}
133			}
134

johnnymast / rivescript-php

Push — develop ( 53b14c...3240e8 )

Alternation::parse() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like