Report::fromArray() - Code Metrics - Inspection of "Added the report tests" - johnnymast/redbox-scan - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — release/1.0 ( 82bfa1...74ea79 )

by Johnny

created 2015-12-25 20:46 UTC

Report::fromArray() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	18
ccs	0
cts	0
cp	0
rs	9.4286
cc	3
eloc	11
nc	3
nop	1
crap	12

<?php
namespace Redbox\Scan\Report;
use Redbox\Scan\Exception;

class Report extends AbstractReport
{
    /**
     * Return the report in array form.
     *
     * @return array
     */
    public function toArray() {
        return array(
            'name'  => $this->getName(),
            'date'  => $this->getDate(),
            'path'  => $this->getPath(),
            'items' => $this->getItems(),
        );
    }

    /**
     * Return an instance of Report by providing an array to the method.
     *
     * @param array $array
     * @return Report
     */
    static function fromArray($array = array()) {

        $required = array('name','date','path','items');
        $report = new Report();

        /**
         * Check if all required fields are being set.
         */
        foreach ($required as $req) {
            if (isset($array[$req]) == false) {

                throw new Exception\RuntimeException('Could not create a report from this array field ' . $req . ' was not set the following fields are required (' . implode(',', $required) . ')');
            }
        }
        $report->setName($array['name']);
        $report->setDate($array['date']);
        $report->setPath($array['path']);
        $report->setItems($array['items']);
        return $report;
    }

}

1		<?php
2		namespace Redbox\Scan\Report;
3		use Redbox\Scan\Exception;
4
5		class Report extends AbstractReport
6		{
7		/**
8		* Return the report in array form.
9		*
10		* @return array
11	4	*/
12		public function toArray() {
13		return array(
14	4	'name' => $this->getName(),
15	4	'date' => $this->getDate(),
16	4	'path' => $this->getPath(),
17	4	'items' => $this->getItems(),
18		);
19	2	}
20
21		/**
22		* Return an instance of Report by providing an array to the method.
23		*
24		* @param array $array
25		* @return Report
26		*/
27		static function fromArray($array = array()) {
		0 ignored issues – show Best Practice introduced 2015-12-26 05:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28		$required = array('name','date','path','items');
29		$report = new Report();
30
31		/**
32		* Check if all required fields are being set.
33		*/
34		foreach ($required as $req) {
35		if (isset($array[$req]) == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-26 05:19 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
36		throw new Exception\RuntimeException('Could not create a report from this array field ' . $req . ' was not set the following fields are required (' . implode(',', $required) . ')');
37		}
38		}
39		$report->setName($array['name']);
40		$report->setDate($array['date']);
41		$report->setPath($array['path']);
42		$report->setItems($array['items']);
43		return $report;
44		}
45
46		}

johnnymast / redbox-scan

Push — release/1.0 ( 82bfa1...74ea79 )

Report::fromArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like