Redbox\Hooks\Annotations\Filter::__construct()

Complexity

Conditions	6
Paths	18

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	6.0045

Importance

Changes

0

<?php
    public function __construct($options = [])
    {
        if (isset($options['value'])) {
            $options['propertyName'] = $options['value'];
            unset($options['value']);
        }

        $this->priority = 10;

        $default = [
            'priority' => 10,
        ];

        foreach ($default as $key => $value) {
            if (isset($options[$key]) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                $options[$key] = $value;
            }
        }

        foreach ($options as $key => $value) {
            if (!property_exists($this, $key)) {
                throw new \InvalidArgumentException(sprintf('Property "%s" does not exist', $key));
            }

            $this->$key = $value;
        }

        $this->options = $options;
    }