App\Link

Complexity

Total Complexity

6

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	generateUniqueHash()	0	10	2
A	user()	0	4	1
B	generate()	0	26	2
A	hits()	0	4	1

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;

class Link extends Model
{
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'url',
        'hash',
        'user_id',
    ];

    /**
     * Generate a link with a unique hash.
     *
     * @see      generateUniqueHash
     *
     * @param string    $url
     * @param User|null $user
     *
     * @return mixed
     *
     * @internal param int $user_id
     */
    public function generate($url = '', User $user = null)
    {
        $hash = $this->generateUniqueHash();
        $data = [
            'url'  => $url,
            'hash' => $hash,
        ];

        /*
         * If the user_id has been offered
         * add the user_id so we can build
         * a relationship between link and
         * user.
         */
        if ($user) {
            $data['user_id'] = $user->id;

The property id does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        }

        /**
         * Finally insert the link into
         * the database.
         */
        $link = self::create($data);

The method create() does not exist on App\Link. Did you maybe mean created()?

        return $link;
    }

    /**
     * Create a hash for this link to use.
     *
     * @return int
     */
    private function generateUniqueHash()
    {
        $number = str_random(config('myio.general.hash_length')); // better than rand()

        if (self::whereHash($number)->exists()) {
            return $this->generateUniqueHash();
        }

        return $number;
    }

    /**
     * Return the user for this link.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function user()
    {
        return $this->belongsTo(User::class);
    }

    /**
     * Return the hits for this link.
     *
     * @return \Illuminate\Database\Eloquent\Relations\HasMany
     */
    public function hits()
    {
        return $this->hasMany(Hit::class);
    }
}