SecureAdmin - Code Metrics - johnnymast/myio - Measure and Improve Code Quality continuously with Scrutinizer

SecureAdmin A
last analyzed 2017-04-13 21:26 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	4
c	4
b	0
f	0
lcom	1
cbo	1
dl	0
loc	32
ccs	0
cts	8
cp	0
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	9	3

<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Guard;

class SecureAdmin
{
    /**
     * The Guard implementation.
     *
     * @var Guard
     */
    protected $auth;

    public function __construct(Guard $auth)
    {
        $this->auth = $auth;
    }

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        // If the auth user is null, redirect to home page
        if (is_null($this->auth->user()) || (! $this->auth->user()->hasRole('Administrator'))) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            abort(404, 'Page not found');
        }

        return $next($request);
    }
}


1			<?php
2
3			namespace App\Http\Middleware;
4
5			use Closure;
6			use Illuminate\Contracts\Auth\Guard;
7
8			class SecureAdmin
9			{
10			/**
11			* The Guard implementation.
12			*
13			* @var Guard
14			*/
15			protected $auth;
16
17			public function __construct(Guard $auth)
18			{
19			$this->auth = $auth;
20			}
21
22			/**
23			* Handle an incoming request.
24			*
25			* @param \Illuminate\Http\Request $request
26			* @param \Closure $next
27			*
28			* @return mixed
29			*/
30			public function handle($request, Closure $next)
31			{
32			// If the auth user is null, redirect to home page
33			if (is_null($this->auth->user()) \|\| (! $this->auth->user()->hasRole('Administrator'))) {
			0 ignored issues – show Bug introduced 2017-04-13 21:26 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `hasRole()` does only exist in the following implementations of said interface: `App\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34			abort(404, 'Page not found');
35			}
36
37			return $next($request);
38			}
39			}
40

johnnymast / myio

SecureAdmin A last analyzed 2017-04-13 21:26 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

SecureAdmin A
last analyzed 2017-04-13 21:26 UTC