JM\Morsecode\Morsecode

Complexity

Total Complexity

9

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

88.89%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	encode()	0	14	4
A	decode()	0	15	4

<?php
namespace JM\Morsecode;

class Morsecode
{
    /**
     * @var array
     */
    private $translation = [
        '0' => '-----',
        '1' => '.----',
        '2' => '..---',
        '3' => '...--',
        '4' => '....-',
        '5' => '.....',
        '6' => '-....',
        '7' => '--...',
        '8' => '---..',
        '9' => '----.',
        'a' => '.-',
        'b' => '-...',
        'c' => '-.-.',
        'd' => '-..',
        'e' => '.',
        'f' => '..-.',
        'g' => '--.',
        'h' => '....',
        'i' => '..',
        'j' => '.---',
        'k' => '-.-',
        'l' => '.-..',
        'm' => '--',
        'n' => '-.',
        'o' => '---',
        'p' => '.--.',
        'q' => '--.-',
        'r' => '.-.',
        's' => '...',
        't' => '-',
        'u' => '..-',
        'v' => '...-',
        'w' => '.--',
        'x' => '-..-',
        'y' => '-.--',
        'z' => '--..',
        '.' => '.-.-.-',
        ',' => '--..--',
        '?' => '..--..',
        '!' => '-.-.--',
        '-' => '-....-',
        '/' => '-..-.',
        '@' => '.--.-.',
        '(' => '-.--.',
        ')' => '-.--.-',
        ' ' => '/',
    ];

    /**
     * The value the class constructed with.
     *
     * @var string
     */
    private $value = '';

    /**
     * Morsecode constructor.
     *
     * @param string $value
     */
    public function __construct(string $value = '')
    {
        $this->value = $value;
    }

    /**
     * @param string $str
     * @return string
     */
    public function encode(string $str = '', string $result = ''): string
    {
        if (empty($str) == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return $this->encode($this->value);
        }

        foreach (str_split($str) as $char) {
            if (isset($this->translation[$char])) {
                $result .= " ".$this->translation[$char];
            }
        }

        return trim($result);
    }

    /**
     * @param string $str
     * @return string
     */
    public function decode(string $str = '', string $result = ''): string
    {
        if (empty($str) == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return $this->decode($this->value);
        }

        $characters = array_flip($this->translation);
        foreach (explode(' ', $str) as $character) {
            if (isset($characters[$character])) {
                $result .= $characters[$character];
            }
        }

        return $result;
    }
}