WatchCommand::execute() - Code Metrics - Inspection of "v0.1" - johnkrovitch/SamBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Arnaud

created 2016-11-16 21:52 UTC

WatchCommand::execute() A

↳ Parent: WatchCommand

Complexity

Conditions	4
Paths	6

Size

Total Lines	57
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	9.0309
c	0
b	0
f	0
cc	4
eloc	36
nc	6
nop	2

How to fix Long Method

<?php

namespace JK\SamBundle\Command;

use Exception;
use JK\SamBundle\Watcher\Indexer\FileIndexer;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;

class WatchCommand extends AbstractAssetsCommand
{
    /**
     * Indicate if the watching loop should continue.
     *
     * @var bool
     */
    protected $shouldStop = false;

    /**
     *
     */
    protected function configure()
    {
        $this
            ->setName('jk:assets:watch')
            ->setDescription('Watch the assets according to your tasks configuration ("jk_assets")')
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|null|void
     * @throws Exception
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->io = new SymfonyStyle($input, $output);
        $this
            ->io
            ->title('Symfony PHP Assets Manager');
        $this
            ->io
            ->section('Watch assets changes');

        // get debug mode
        $this->debug = $this
            ->container
            ->getParameter('jk.assets.debug');

        if ($this->debug) {
            $this->io->note('Debug Mode...');
        }

        // on Ctrl+C, we must stop to watch files
        pcntl_signal(SIGTERM, [$this, 'stopWatch']);
        pcntl_signal(SIGINT, [$this, 'stopWatch']);

        $indexer = new FileIndexer();
        $sources = $this->collectSources($input);

        // start watching sources
        $this
            ->io
            ->text('Watching...');

        while (!$this->shouldStop) {
            $indexer->index($sources);

            if ($indexer->hasChangedEntries()) {
                $this
                    ->io
                    ->note('Sources has been modified...');

                $runCommand = new RunCommand();
                $runCommand->setContainer($this->container);
                $runCommand->run(new ArrayInput([]), $output);

                $this
                    ->io
                    ->text('Watching...');
            }

            pcntl_signal_dispatch();
            sleep(1);
        }

        // display end message
        $this->io->success('Assets watching end');

        return;
    }

    public function stopWatch()
    {
        $this->shouldStop = true;
        $this
            ->io
            ->note('Stop watching changes');
    }

    /**
     * @param InputInterface $input
     *
     * @return array
     */
    protected function collectSources(InputInterface $input)
    {
        $sources = [];
        $directories = [];
        $tasks = $this->buildTasks($input);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        foreach ($tasks as $task) {
            $sources = array_merge($sources, $task->getSources());
        }
        foreach ($sources as $source) {

            if (is_dir($source)) {
                $directory = $source;
            } else {
                $directory = dirname($source);
            }
            $this
                ->io
                ->text('Found new directory : '.$directory);
            $directories[] = $directory;
        }

        return $directories;
    }
}


1			<?php
2
3			namespace JK\SamBundle\Command;
4
5			use Exception;
6			use JK\SamBundle\Watcher\Indexer\FileIndexer;
7			use Symfony\Component\Console\Input\ArrayInput;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Output\OutputInterface;
10			use Symfony\Component\Console\Style\SymfonyStyle;
11
12			class WatchCommand extends AbstractAssetsCommand
13			{
14			/**
15			* Indicate if the watching loop should continue.
16			*
17			* @var bool
18			*/
19			protected $shouldStop = false;
20
21			/**
22			*
23			*/
24			protected function configure()
25			{
26			$this
27			->setName('jk:assets:watch')
28			->setDescription('Watch the assets according to your tasks configuration ("jk_assets")')
29			;
30			}
31
32			/**
33			* @param InputInterface $input
34			* @param OutputInterface $output
35			* @return int\|null\|void
36			* @throws Exception
37			*/
38			protected function execute(InputInterface $input, OutputInterface $output)
39			{
40			$this->io = new SymfonyStyle($input, $output);
41			$this
42			->io
43			->title('Symfony PHP Assets Manager');
44			$this
45			->io
46			->section('Watch assets changes');
47
48			// get debug mode
49			$this->debug = $this
50			->container
51			->getParameter('jk.assets.debug');
52
53			if ($this->debug) {
54			$this->io->note('Debug Mode...');
55			}
56
57			// on Ctrl+C, we must stop to watch files
58			pcntl_signal(SIGTERM, [$this, 'stopWatch']);
59			pcntl_signal(SIGINT, [$this, 'stopWatch']);
60
61			$indexer = new FileIndexer();
62			$sources = $this->collectSources($input);
63
64			// start watching sources
65			$this
66			->io
67			->text('Watching...');
68
69			while (!$this->shouldStop) {
70			$indexer->index($sources);
71
72			if ($indexer->hasChangedEntries()) {
73			$this
74			->io
75			->note('Sources has been modified...');
76
77			$runCommand = new RunCommand();
78			$runCommand->setContainer($this->container);
79			$runCommand->run(new ArrayInput([]), $output);
80
81			$this
82			->io
83			->text('Watching...');
84			}
85
86			pcntl_signal_dispatch();
87			sleep(1);
88			}
89
90			// display end message
91			$this->io->success('Assets watching end');
92
93			return;
94			}
95
96			public function stopWatch()
97			{
98			$this->shouldStop = true;
99			$this
100			->io
101			->note('Stop watching changes');
102			}
103
104			/**
105			* @param InputInterface $input
106			*
107			* @return array
108			*/
109			protected function collectSources(InputInterface $input)
110			{
111			$sources = [];
112			$directories = [];
113			$tasks = $this->buildTasks($input);
			0 ignored issues – show Documentation introduced 2016-11-16 21:55 UTC by Report Bug Copy Issue Report `$input` is of type `object<Symfony\Component...e\Input\InputInterface>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114
115			foreach ($tasks as $task) {
116			$sources = array_merge($sources, $task->getSources());
117			}
118			foreach ($sources as $source) {
119
120			if (is_dir($source)) {
121			$directory = $source;
122			} else {
123			$directory = dirname($source);
124			}
125			$this
126			->io
127			->text('Found new directory : '.$directory);
128			$directories[] = $directory;
129			}
130
131			return $directories;
132			}
133			}
134

johnkrovitch / SamBundle

Pull Request — master (#1)

WatchCommand::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like