| Total Complexity | 49 |
| Total Lines | 348 |
| Duplicated Lines | 12.64 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like br.ufrj.ppgi.greco.kettle.DataPropertyMappingStepMeta often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | package br.ufrj.ppgi.greco.kettle; |
||
| 36 | public class DataPropertyMappingStepMeta extends BaseStepMeta implements StepMetaInterface { |
||
| 37 | // Fields for serialization |
||
| 38 | public enum Field { |
||
| 39 | DATA_ROOT_NODE, VERSION, |
||
| 40 | |||
| 41 | // Aba 'Mapeamento' |
||
| 42 | RDF_TYPE_URIS, SUBJECT_URI_FIELD_NAME, MAP_TABLE, MAP_TABLE_PREDICATE_FIELD_NAME, MAP_TABLE_PREDICATE_URI, MAP_TABLE_OBJECT_FIELD_NAME, MAP_TABLE_TYPED_LITERAL, MAP_TABLE_LANGUAGE_TAG, MAP_TABLE_LANGTAG_FIELD_NAME, |
||
| 43 | |||
| 44 | // Aba 'Campos de saida' |
||
| 45 | SUBJECT_OUT_FIELD_NAME, PREDICATE_OUT_FIELD_NAME, OBJECT_OUT_FIELD_NAME, DATATYPE_OUT_FIELD_NAME, LANGTAG_OUT_FIELD_NAME, KEEP_INPUT_FIELDS, |
||
| 46 | |||
| 47 | // Aba 'Sparql Endpoint' - no futuro |
||
| 48 | ENDPOINT_URI, DEFAULT_GRAPH, PREFIX_TABLE, PREFIX_TABLE_PREFIX, PREFIX_TABLE_NAMESPACE |
||
| 49 | } |
||
| 50 | |||
| 51 | // Campos do step |
||
| 52 | private List<String> rdfTypeUris; |
||
| 53 | private String subjectUriFieldName; |
||
| 54 | private DataTable<String> mapTable; |
||
| 55 | |||
| 56 | private String subjectOutputFieldName; |
||
| 57 | private String predicateOutputFieldName; |
||
| 58 | private String objectOutputFieldName; |
||
| 59 | private String datatypeOutputFieldName; |
||
| 60 | private String langTagOutputFieldName; |
||
| 61 | private boolean keepInputFields; |
||
| 62 | |||
| 63 | // private String endpointUri; |
||
| 64 | // private String defaultGraph; |
||
| 65 | // private DataTable<String> prefixes; |
||
| 66 | |||
| 67 | public DataPropertyMappingStepMeta() { |
||
| 68 | setDefault(); |
||
| 69 | } |
||
| 70 | |||
| 71 | // TODO Validar todos os campos para dar feedback ao usuario! |
||
| 72 | @Override |
||
| 73 | public void check(List<CheckResultInterface> remarks, TransMeta transMeta, StepMeta stepMeta, RowMetaInterface prev, |
||
| 74 | String[] input, String[] output, RowMetaInterface info) { |
||
| 75 | CheckResultInterface ok = new CheckResult(CheckResult.TYPE_RESULT_OK, "", stepMeta); |
||
| 76 | remarks.add(ok); |
||
| 77 | } |
||
| 78 | |||
| 79 | public StepInterface getStep(StepMeta stepMeta, StepDataInterface stepDataInterface, int copyNr, |
||
| 80 | TransMeta transMeta, Trans trans) { |
||
| 81 | return new DataPropertyMappingStep(stepMeta, stepDataInterface, copyNr, transMeta, trans); |
||
| 82 | } |
||
| 83 | |||
| 84 | public StepDataInterface getStepData() { |
||
| 85 | return new DataPropertyMappingStepData(); |
||
| 86 | } |
||
| 87 | |||
| 88 | @Override |
||
| 89 | public String getDialogClassName() { |
||
| 90 | return DataPropertyMappingStepDialog.class.getName(); |
||
| 91 | } |
||
| 92 | |||
| 93 | @SuppressWarnings("unchecked") |
||
| 94 | @Override |
||
| 95 | public void loadXML(Node stepDomNode, List<DatabaseMeta> databases, Map<String, Counter> sequenceCounters) |
||
| 96 | throws KettleXMLException { |
||
| 97 | try { |
||
| 98 | XStream xs = new XStream(new DomDriver()); |
||
| 99 | xs.alias("DataTable", DataTable.class); |
||
| 100 | xs.registerConverter(new DataTableConverter()); |
||
| 101 | |||
| 102 | rdfTypeUris = (List<String>) xs.fromXML(XMLHandler.getTagValue(stepDomNode, Field.RDF_TYPE_URIS.name())); |
||
| 103 | subjectUriFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.SUBJECT_URI_FIELD_NAME.name()); |
||
| 104 | mapTable = (DataTable<String>) xs.fromXML(XMLHandler.getTagValue(stepDomNode, Field.MAP_TABLE.name())); |
||
| 105 | subjectOutputFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.SUBJECT_OUT_FIELD_NAME.name()); |
||
| 106 | predicateOutputFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.PREDICATE_OUT_FIELD_NAME.name()); |
||
| 107 | objectOutputFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.OBJECT_OUT_FIELD_NAME.name()); |
||
| 108 | datatypeOutputFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.DATATYPE_OUT_FIELD_NAME.name()); |
||
| 109 | langTagOutputFieldName = (String) XMLHandler.getTagValue(stepDomNode, Field.LANGTAG_OUT_FIELD_NAME.name()); |
||
| 110 | keepInputFields = Boolean.valueOf(XMLHandler.getTagValue(stepDomNode, Field.KEEP_INPUT_FIELDS.name())); |
||
| 111 | |||
| 112 | } catch (Throwable e) { |
||
| 113 | e.printStackTrace(); |
||
| 114 | } |
||
| 115 | } |
||
| 116 | |||
| 117 | @Override |
||
| 118 | public String getXML() throws KettleException { |
||
| 119 | XStream xs = new XStream(new DomDriver()); |
||
| 120 | xs.alias("DataTable", DataTable.class); |
||
| 121 | xs.registerConverter(new DataTableConverter()); |
||
| 122 | |||
| 123 | StringBuilder xml = new StringBuilder(); |
||
| 124 | |||
| 125 | xml.append(XMLHandler.addTagValue(Field.RDF_TYPE_URIS.name(), xs.toXML(rdfTypeUris))); |
||
| 126 | xml.append(XMLHandler.addTagValue(Field.SUBJECT_URI_FIELD_NAME.name(), subjectUriFieldName)); |
||
| 127 | xml.append(XMLHandler.addTagValue(Field.MAP_TABLE.name(), xs.toXML(mapTable))); |
||
| 128 | xml.append(XMLHandler.addTagValue(Field.SUBJECT_OUT_FIELD_NAME.name(), subjectOutputFieldName)); |
||
| 129 | xml.append(XMLHandler.addTagValue(Field.PREDICATE_OUT_FIELD_NAME.name(), predicateOutputFieldName)); |
||
| 130 | xml.append(XMLHandler.addTagValue(Field.OBJECT_OUT_FIELD_NAME.name(), objectOutputFieldName)); |
||
| 131 | xml.append(XMLHandler.addTagValue(Field.DATATYPE_OUT_FIELD_NAME.name(), datatypeOutputFieldName)); |
||
| 132 | xml.append(XMLHandler.addTagValue(Field.LANGTAG_OUT_FIELD_NAME.name(), langTagOutputFieldName)); |
||
| 133 | xml.append(XMLHandler.addTagValue(Field.KEEP_INPUT_FIELDS.name(), keepInputFields)); |
||
| 134 | |||
| 135 | return xml.toString(); |
||
| 136 | } |
||
| 137 | |||
| 138 | @Override |
||
| 139 | public void readRep(Repository repository, ObjectId stepIdInRepository, List<DatabaseMeta> databases, |
||
| 140 | Map<String, Counter> sequenceCounters) throws KettleException { |
||
| 141 | int version = (int) repository.getStepAttributeInteger(stepIdInRepository, Field.VERSION.name()); |
||
| 142 | |||
| 143 | switch (version) { |
||
| 144 | case 3: |
||
| 145 | langTagOutputFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 146 | Field.LANGTAG_OUT_FIELD_NAME.name()); |
||
| 147 | case 2: |
||
| 148 | datatypeOutputFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 149 | Field.DATATYPE_OUT_FIELD_NAME.name()); |
||
| 150 | case 1: |
||
| 151 | int nrRdfTypeUris = (int) repository.countNrStepAttributes(stepIdInRepository, Field.RDF_TYPE_URIS.name()); |
||
| 152 | rdfTypeUris = new ArrayList<String>(); |
||
| 153 | for (int i = 0; i < nrRdfTypeUris; i++) { |
||
| 154 | String item = repository.getStepAttributeString(stepIdInRepository, i, Field.RDF_TYPE_URIS.name()); |
||
| 155 | rdfTypeUris.add(item); |
||
| 156 | } |
||
| 157 | subjectUriFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 158 | Field.SUBJECT_URI_FIELD_NAME.name()); |
||
| 159 | int nrLines = (int) repository.getStepAttributeInteger(stepIdInRepository, "nr_lines"); |
||
| 160 | mapTable = new DataTable<String>(Field.MAP_TABLE.name(), Field.MAP_TABLE_PREDICATE_FIELD_NAME.name(), |
||
| 161 | Field.MAP_TABLE_PREDICATE_URI.name(), Field.MAP_TABLE_OBJECT_FIELD_NAME.name(), |
||
| 162 | Field.MAP_TABLE_TYPED_LITERAL.name(), Field.MAP_TABLE_LANGUAGE_TAG.name(), |
||
| 163 | Field.MAP_TABLE_LANGTAG_FIELD_NAME.name()); |
||
| 164 | String[] fields = mapTable.getHeader().toArray(new String[0]); |
||
| 165 | /* |
||
| 166 | * { Field.MAP_TABLE_PREDICATE_FIELD_NAME.name(), |
||
| 167 | * Field.MAP_TABLE_PREDICATE_URI.name(), |
||
| 168 | * Field.MAP_TABLE_OBJECT_FIELD_NAME.name(), |
||
| 169 | * Field.MAP_TABLE_TYPED_LITERAL.name(), |
||
| 170 | * Field.MAP_TABLE_LANGUAGE_TAG.name(), |
||
| 171 | * Field.MAP_TABLE_LANGTAG_FIELD_NAME.name() }; |
||
| 172 | */ |
||
| 173 | View Code Duplication | for (int i = 0; i < nrLines; i++) { |
|
|
|
|||
| 174 | int nrfields = fields.length; |
||
| 175 | String[] line = new String[nrfields]; |
||
| 176 | |||
| 177 | for (int f = 0; f < nrfields; f++) { |
||
| 178 | line[f] = repository.getStepAttributeString(stepIdInRepository, i, fields[f]); |
||
| 179 | } |
||
| 180 | mapTable.add(line); |
||
| 181 | } |
||
| 182 | subjectOutputFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 183 | Field.SUBJECT_OUT_FIELD_NAME.name()); |
||
| 184 | predicateOutputFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 185 | Field.PREDICATE_OUT_FIELD_NAME.name()); |
||
| 186 | objectOutputFieldName = repository.getStepAttributeString(stepIdInRepository, |
||
| 187 | Field.OBJECT_OUT_FIELD_NAME.name()); |
||
| 188 | keepInputFields = repository.getStepAttributeBoolean(stepIdInRepository, Field.KEEP_INPUT_FIELDS.name()); |
||
| 189 | break; |
||
| 190 | default: |
||
| 191 | setDefault(); |
||
| 192 | } |
||
| 193 | } |
||
| 194 | |||
| 195 | View Code Duplication | @Override |
|
| 196 | public void saveRep(Repository repository, ObjectId idOfTransformation, ObjectId idOfStep) throws KettleException { |
||
| 197 | try { |
||
| 198 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.VERSION.name(), 3); |
||
| 199 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.LANGTAG_OUT_FIELD_NAME.name(), |
||
| 200 | langTagOutputFieldName); |
||
| 201 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.DATATYPE_OUT_FIELD_NAME.name(), |
||
| 202 | datatypeOutputFieldName); |
||
| 203 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.SUBJECT_URI_FIELD_NAME.name(), |
||
| 204 | subjectUriFieldName); |
||
| 205 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.SUBJECT_OUT_FIELD_NAME.name(), |
||
| 206 | subjectOutputFieldName); |
||
| 207 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.PREDICATE_OUT_FIELD_NAME.name(), |
||
| 208 | predicateOutputFieldName); |
||
| 209 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.OBJECT_OUT_FIELD_NAME.name(), |
||
| 210 | objectOutputFieldName); |
||
| 211 | repository.saveStepAttribute(idOfTransformation, idOfStep, Field.KEEP_INPUT_FIELDS.name(), keepInputFields); |
||
| 212 | |||
| 213 | // Lista de RDF Type URIs |
||
| 214 | for (int i = 0; i < rdfTypeUris.size(); i++) { |
||
| 215 | repository.saveStepAttribute(idOfTransformation, idOfStep, i, Field.RDF_TYPE_URIS.name(), |
||
| 216 | rdfTypeUris.get(i)); |
||
| 217 | } |
||
| 218 | |||
| 219 | // Map Table |
||
| 220 | int linhas = (int) mapTable.size(); |
||
| 221 | int colunas = mapTable.getHeader().size(); |
||
| 222 | repository.saveStepAttribute(idOfTransformation, idOfStep, "nr_lines", linhas); |
||
| 223 | for (int i = 0; i < linhas; i++) { |
||
| 224 | for (int f = 0; f < colunas; f++) { |
||
| 225 | repository.saveStepAttribute(idOfTransformation, idOfStep, i, mapTable.getHeader().get(f), |
||
| 226 | mapTable.getValue(i, f)); |
||
| 227 | } |
||
| 228 | } |
||
| 229 | } catch (Exception e) { |
||
| 230 | throw new KettleException("Unable to save step information to the repository for id_step=" + idOfStep, e); |
||
| 231 | } |
||
| 232 | } |
||
| 233 | |||
| 234 | public void setDefault() { |
||
| 235 | rdfTypeUris = new ArrayList<String>(); |
||
| 236 | subjectUriFieldName = ""; |
||
| 237 | mapTable = new DataTable<String>(Field.MAP_TABLE.name(), Field.MAP_TABLE_PREDICATE_FIELD_NAME.name(), |
||
| 238 | Field.MAP_TABLE_PREDICATE_URI.name(), Field.MAP_TABLE_OBJECT_FIELD_NAME.name(), |
||
| 239 | Field.MAP_TABLE_TYPED_LITERAL.name(), Field.MAP_TABLE_LANGUAGE_TAG.name(), |
||
| 240 | Field.MAP_TABLE_LANGTAG_FIELD_NAME.name()); |
||
| 241 | |||
| 242 | subjectOutputFieldName = "subject"; |
||
| 243 | predicateOutputFieldName = "predicate"; |
||
| 244 | objectOutputFieldName = "object"; |
||
| 245 | datatypeOutputFieldName = "datatype"; |
||
| 246 | langTagOutputFieldName = "langtag"; |
||
| 247 | keepInputFields = false; |
||
| 248 | } |
||
| 249 | |||
| 250 | /** |
||
| 251 | * It describes what each output row is going to look like |
||
| 252 | */ |
||
| 253 | @Override |
||
| 254 | public void getFields(RowMetaInterface inputRowMeta, String name, RowMetaInterface[] info, StepMeta nextStep, |
||
| 255 | VariableSpace space) throws KettleStepException { |
||
| 256 | |||
| 257 | ValueMetaInterface field = null; |
||
| 258 | boolean sbjOutFieldSpecified = (subjectOutputFieldName != null) && !("".equals(subjectOutputFieldName)); |
||
| 259 | ValueMetaInterface inUriField = inputRowMeta.searchValueMeta(this.subjectUriFieldName); |
||
| 260 | |||
| 261 | if (!keepInputFields) { |
||
| 262 | inputRowMeta.clear(); |
||
| 263 | |||
| 264 | if (sbjOutFieldSpecified) {// [s p o] = S3 |
||
| 265 | // add out sbj |
||
| 266 | field = new ValueMetaString(subjectOutputFieldName); |
||
| 267 | field.setOrigin(name); |
||
| 268 | inputRowMeta.addValueMeta(field); |
||
| 269 | } else { // [uri p o] = S4 |
||
| 270 | // add in uri |
||
| 271 | inputRowMeta.addValueMeta(inUriField); |
||
| 272 | } |
||
| 273 | } else { |
||
| 274 | if (sbjOutFieldSpecified && !subjectOutputFieldName.equals(subjectUriFieldName)) { |
||
| 275 | // add out sbj == [uri A B C ... s p o] = S2 |
||
| 276 | field = new ValueMetaString(subjectOutputFieldName); |
||
| 277 | field.setOrigin(name); |
||
| 278 | inputRowMeta.addValueMeta(field); |
||
| 279 | } |
||
| 280 | // else = [uri A B C ... p o] = S1 |
||
| 281 | } |
||
| 282 | |||
| 283 | field = new ValueMetaString(predicateOutputFieldName); |
||
| 284 | field.setOrigin(name); |
||
| 285 | inputRowMeta.addValueMeta(field); |
||
| 286 | |||
| 287 | field = new ValueMetaString(objectOutputFieldName); |
||
| 288 | field.setOrigin(name); |
||
| 289 | inputRowMeta.addValueMeta(field); |
||
| 290 | |||
| 291 | field = new ValueMetaString(datatypeOutputFieldName); |
||
| 292 | field.setOrigin(name); |
||
| 293 | inputRowMeta.addValueMeta(field); |
||
| 294 | |||
| 295 | field = new ValueMetaString(langTagOutputFieldName); |
||
| 296 | field.setOrigin(name); |
||
| 297 | inputRowMeta.addValueMeta(field); |
||
| 298 | } |
||
| 299 | |||
| 300 | boolean isThereAdditionalSubjectOutputField() { |
||
| 301 | return (subjectOutputFieldName != null) && !("".equals(subjectOutputFieldName)) |
||
| 302 | && !subjectOutputFieldName.equals(subjectUriFieldName); |
||
| 303 | } |
||
| 304 | |||
| 305 | String getActualSubjectOutputFieldName() { |
||
| 306 | if ((subjectOutputFieldName != null) && !("".equals(subjectOutputFieldName))) { |
||
| 307 | return subjectOutputFieldName; |
||
| 308 | } else |
||
| 309 | return subjectUriFieldName; |
||
| 310 | } |
||
| 311 | |||
| 312 | // Getters & Setters |
||
| 313 | |||
| 314 | public List<String> getRdfTypeUris() { |
||
| 315 | return rdfTypeUris; |
||
| 316 | } |
||
| 317 | |||
| 318 | public void setRdfTypeUris(List<String> rdfTypeUris) { |
||
| 319 | this.rdfTypeUris = rdfTypeUris; |
||
| 320 | } |
||
| 321 | |||
| 322 | public String getSubjectUriFieldName() { |
||
| 323 | return subjectUriFieldName; |
||
| 324 | } |
||
| 325 | |||
| 326 | public void setSubjectUriFieldName(String subjectUriFieldName) { |
||
| 327 | this.subjectUriFieldName = subjectUriFieldName; |
||
| 328 | } |
||
| 329 | |||
| 330 | public DataTable<String> getMapTable() { |
||
| 331 | return mapTable; |
||
| 332 | } |
||
| 333 | |||
| 334 | public String getSubjectOutputFieldName() { |
||
| 335 | return subjectOutputFieldName; |
||
| 336 | } |
||
| 337 | |||
| 338 | public void setSubjectOutputFieldName(String subjectOutputFieldName) { |
||
| 339 | this.subjectOutputFieldName = subjectOutputFieldName; |
||
| 340 | } |
||
| 341 | |||
| 342 | public String getPredicateOutputFieldName() { |
||
| 343 | return predicateOutputFieldName; |
||
| 344 | } |
||
| 345 | |||
| 346 | public void setPredicateOutputFieldName(String predicateOutputFieldName) { |
||
| 347 | this.predicateOutputFieldName = predicateOutputFieldName; |
||
| 348 | } |
||
| 349 | |||
| 350 | public String getObjectOutputFieldName() { |
||
| 351 | return objectOutputFieldName; |
||
| 352 | } |
||
| 353 | |||
| 354 | public void setObjectOutputFieldName(String objectOutputFieldName) { |
||
| 355 | this.objectOutputFieldName = objectOutputFieldName; |
||
| 356 | } |
||
| 357 | |||
| 358 | public boolean isKeepInputFields() { |
||
| 359 | return keepInputFields; |
||
| 360 | } |
||
| 361 | |||
| 362 | public void setKeepInputFields(boolean keepInputFields) { |
||
| 363 | this.keepInputFields = keepInputFields; |
||
| 364 | } |
||
| 365 | |||
| 366 | public void setDatatypeOutputFieldName(String datatypeOutputFieldName) { |
||
| 367 | this.datatypeOutputFieldName = datatypeOutputFieldName; |
||
| 368 | } |
||
| 369 | |||
| 370 | public String getDatatypeOutputFieldName() { |
||
| 371 | return datatypeOutputFieldName; |
||
| 372 | } |
||
| 373 | |||
| 374 | public void setLangTagOutputFieldName(String langTagOutputFieldName) { |
||
| 375 | this.langTagOutputFieldName = langTagOutputFieldName; |
||
| 376 | } |
||
| 377 | |||
| 378 | public String getLangTagOutputFieldName() { |
||
| 379 | return langTagOutputFieldName; |
||
| 380 | } |
||
| 381 | |||
| 382 | public void setMapTable(DataTable<String> mapTable) { |
||
| 383 | this.mapTable = mapTable; |
||
| 384 | } |
||
| 386 |