Issues in TupleSet.php (master) - Issues in master - john-wilkinson/collections - Measure and Improve Code Quality continuously with Scrutinizer

Issues (66)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Set/TupleSet.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Jmw\Collection\Set;

use Jmw\Collection\Lists\Tuple;
use Jmw\Collection\Exception\InvalidTypeException;
use Jmw\Collection\Lists\ArrayList;
/**
 * A set of Tuple elements, which ensures that only Tuple elements
 * may be added to the set, and no Tuple element may be duplicated
 * @author john
 *
 */
class TupleSet extends SetAbstract
{
	protected $arrayList;
	
	/**
	 * Construct a TupleSet from an array
	 * Each key=>value pair will become a Tuple<key, value>
	 * @param unknown $array
	 */
	public function __construct($array)
	{
		$this->clear();
		foreach ($array as $value1=>$value2)
		{
			$this->add(new Tuple($value1, $value2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
	}
	
	/**
	 * Ensures that this collection contains the specified element (optional operation).
	 * @param multitype $element
	 * @return boolean
	 */
	public function add($element)
	{
		$changed = false;
		if($element instanceof Tuple)
		{
			if(!$this->contains($element))
			{
				$this->arrayList->add($element);
				$changed = true;
			}
		}
		else
		{
			throw new InvalidTypeException('Jmw\Collection\Lists\Tuple', gettype($element));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
		$changed;
	}
	
	/**
	 * Removes all of the elements from this collection (optional operation).
	*/
	public function clear()
	{
		$this->arrayList = new ArrayList();
	}
	
	/**
	 * Returns an iterator over the elements in this collection.
	 * @return IteratorInterface
	*/
	public function iterator()
	{
		return new SetIterator($this);
	}
	
	/**
	 * Removes a single instance of the specified element from this collection, if it is present (optional operation).
	 * @param boolean $changed
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	*/
	public function remove($tuple)
	{
		$iterator = $this->arrayList->iterator();
		
		while($iterator->hasNext())
		{
			$element = $iterator->next();
			if($element->equals($tuple))
			{
				$iterator->remove();
				return true;
			}
		}
		return false;
	}
	
	/**
	 * Returns the number of elements in this collection.
	*/
	public function size()
	{
		return $this->arrayList->size();
	}
	
	/**
	 * Returns an array containing all of the elements in this collection.
	*/
	public function toArray()
	{
		return $this->arrayList->toArray();
	}
}

1			<?php
2			namespace Jmw\Collection\Set;
3
4			use Jmw\Collection\Lists\Tuple;
5			use Jmw\Collection\Exception\InvalidTypeException;
6			use Jmw\Collection\Lists\ArrayList;
7			/**
8			* A set of Tuple elements, which ensures that only Tuple elements
9			* may be added to the set, and no Tuple element may be duplicated
10			* @author john
11			*
12			*/
13			class TupleSet extends SetAbstract
14			{
15			protected $arrayList;
16
17			/**
18			* Construct a TupleSet from an array
19			* Each key=>value pair will become a Tuple<key, value>
20			* @param unknown $array
21			*/
22			public function __construct($array)
23			{
24			$this->clear();
25			foreach ($array as $value1=>$value2)
26			{
27			$this->add(new Tuple($value1, $value2));
			0 ignored issues – show Documentation introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Jmw\Collection\Lists\Tuple($value1, $value2)` is of type `object<Jmw\Collection\Lists\Tuple>`, but the function expects a `object<Jmw\Collection\Set\multitype>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			}
29			}
30
31			/**
32			* Ensures that this collection contains the specified element (optional operation).
33			* @param multitype $element
34			* @return boolean
35			*/
36			public function add($element)
37			{
38			$changed = false;
39			if($element instanceof Tuple)
40			{
41			if(!$this->contains($element))
42			{
43			$this->arrayList->add($element);
44			$changed = true;
45			}
46			}
47			else
48			{
49			throw new InvalidTypeException('Jmw\Collection\Lists\Tuple', gettype($element));
			0 ignored issues – show Documentation introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'Jmw\\Collection\\Lists\\Tuple'` is of type `string`, but the function expects a `object<Jmw\Collection\Exception\multitype>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `gettype($element)` is of type `string`, but the function expects a `object<Jmw\Collection\Exception\multitype>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			}
51			$changed;
52			}
53
54			/**
55			* Removes all of the elements from this collection (optional operation).
56			*/
57			public function clear()
58			{
59			$this->arrayList = new ArrayList();
60			}
61
62			/**
63			* Returns an iterator over the elements in this collection.
64			* @return IteratorInterface
65			*/
66			public function iterator()
67			{
68			return new SetIterator($this);
69			}
70
71			/**
72			* Removes a single instance of the specified element from this collection, if it is present (optional operation).
73			* @param boolean $changed
			0 ignored issues – show Bug introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$changed`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
74			*/
75			public function remove($tuple)
76			{
77			$iterator = $this->arrayList->iterator();
78
79			while($iterator->hasNext())
80			{
81			$element = $iterator->next();
82			if($element->equals($tuple))
83			{
84			$iterator->remove();
85			return true;
86			}
87			}
88			return false;
89			}
90
91			/**
92			* Returns the number of elements in this collection.
93			*/
94			public function size()
95			{
96			return $this->arrayList->size();
97			}
98
99			/**
100			* Returns an array containing all of the elements in this collection.
101			*/
102			public function toArray()
103			{
104			return $this->arrayList->toArray();
105			}
106			}

john-wilkinson / collections

Issues (66)

Security Analysis no request data

src/Set/TupleSet.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like