Issues in SetIterator.php (master) - Issues in master - john-wilkinson/collections - Measure and Improve Code Quality continuously with Scrutinizer

Issues (66)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Set/SetIterator.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Jmw\Collection\Set;

use Jmw\Collection\IteratorInterface;
use Jmw\Collection\Exception\NoSuchElementException;
use Jmw\Collection\Exception\IllegalStateException;

/**
 * An iterator on a set. It uses an array to keep track
 * of the current location of iteration. Any modification to
 * the set during iteration except by using the iterator's 
 * remove method will put the iterator into an
 * undefined state.
 * @author john
 *
 */
class SetIterator implements IteratorInterface
{
	/**
	 * @var array
	 */
	protected $array;
	
	/**
	 * @var SetInterface
	 */
	protected $set;
	
	/**
	 * @var int
	 */
	protected $index;
	
	/**
	 * @var boolean
	 */
	protected $canRemove;
	
	/**
	 * Constructs a new SetIterator
	 * @param SetInterface $set
	 */
	public function __construct(SetInterface $set)
	{
		$this->array = $set->toArray();
		$this->index = -1;
		$this->set = $set;
		$this->canRemove = false;
	}
	
	/**
	 * Returns the next element in the iteration.
	 * @return multitype
	 */
	public function next()

	{
		if($this->hasNext())
		{
			$this->canRemove = true;
			return $this->array[++$this->index];
		}
		else
		{
			throw new NoSuchElementException();
		}
	}

	/**
	 * Returns true if the iteration has more elements. (In other words, returns
	 * true if next() would return an element rather than throwing an exception.)
	 * @return boolean
	 */
	public function hasNext()
	{
		return $this->index + 1 < $this->set->size();
	}
	
	/**
	 * Removes from the underlying collection the last
	 * element returned by this iterator (optional operation).
	 * This method can be called only once per call to next().
	 * The behavior of an iterator is unspecified if the underlying
	 * collection is modified while the iteration is in progress in any
	 * way other than by calling this method.
	 * @return boolean
	 */
	public function remove()
	{
		if($this->canRemove)
		{
			$removed = $this->set->remove($this->array[$this->index--]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			$this->array = $this->set->toArray();
			$this->canRemove = false;
		}
		else
		{
			throw new IllegalStateException();
		}
	}
}

1		<?php
2		namespace Jmw\Collection\Set;
3
4		use Jmw\Collection\IteratorInterface;
5		use Jmw\Collection\Exception\NoSuchElementException;
6		use Jmw\Collection\Exception\IllegalStateException;
7
8		/**
9		* An iterator on a set. It uses an array to keep track
10		* of the current location of iteration. Any modification to
11		* the set during iteration except by using the iterator's
12		* remove method will put the iterator into an
13		* undefined state.
14		* @author john
15		*
16		*/
17		class SetIterator implements IteratorInterface
18		{
19		/**
20		* @var array
21		*/
22		protected $array;
23
24		/**
25		* @var SetInterface
26		*/
27		protected $set;
28
29		/**
30		* @var int
31		*/
32		protected $index;
33
34		/**
35		* @var boolean
36		*/
37		protected $canRemove;
38
39		/**
40		* Constructs a new SetIterator
41		* @param SetInterface $set
42		*/
43		public function __construct(SetInterface $set)
44		{
45		$this->array = $set->toArray();
46		$this->index = -1;
47		$this->set = $set;
48		$this->canRemove = false;
49		}
50
51		/**
52		* Returns the next element in the iteration.
53		* @return multitype
54		*/
55	View Code Duplication	public function next()
		0 ignored issues – show Duplication introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		if($this->hasNext())
58		{
59		$this->canRemove = true;
60		return $this->array[++$this->index];
61		}
62		else
63		{
64		throw new NoSuchElementException();
65		}
66		}
67
68		/**
69		* Returns true if the iteration has more elements. (In other words, returns
70		* true if next() would return an element rather than throwing an exception.)
71		* @return boolean
72		*/
73		public function hasNext()
74		{
75		return $this->index + 1 < $this->set->size();
76		}
77
78		/**
79		* Removes from the underlying collection the last
80		* element returned by this iterator (optional operation).
81		* This method can be called only once per call to next().
82		* The behavior of an iterator is unspecified if the underlying
83		* collection is modified while the iteration is in progress in any
84		* way other than by calling this method.
85		* @return boolean
86		*/
87		public function remove()
88		{
89		if($this->canRemove)
90		{
91		$removed = $this->set->remove($this->array[$this->index--]);
		0 ignored issues – show Unused Code introduced 2016-04-16 03:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$removed` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
92		$this->array = $this->set->toArray();
93		$this->canRemove = false;
94		}
95		else
96		{
97		throw new IllegalStateException();
98		}
99		}
100		}

john-wilkinson / collections

Issues (66)

Security Analysis no request data

src/Set/SetIterator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like