OperationFailureFormatter::__construct() - Code Metrics - Inspection of "Add operation handler" - johmanx10/transaction - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#5)

by Jan-Marten

created 2020-03-19 15:32 UTC

OperationFailureFormatter::__construct() A

↳ Parent: OperationFailureFormatter

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

/**
 * Copyright MediaCT. All rights reserved.
 * https://www.mediact.nl
 */

namespace Johmanx10\Transaction\Formatter;

use Johmanx10\Transaction\OperationFailureInterface;

class OperationFailureFormatter implements OperationFailureFormatterInterface
{
    private OperationFormatterInterface $operationFormatter;

    private ExceptionFormatterInterface $exceptionFormatter;

    /**
     * Constructor.
     *
     * @param OperationFormatterInterface|null $operationFormatter
     * @param ExceptionFormatterInterface|null $exceptionFormatter
     */
    public function __construct(
        OperationFormatterInterface $operationFormatter = null,
        ExceptionFormatterInterface $exceptionFormatter = null
    ) {
        $this->operationFormatter = (
            $operationFormatter ?? new OperationFormatter()
        );
        $this->exceptionFormatter = (
            $exceptionFormatter ?? new ExceptionFormatter()
        );
    }

    /**
     * Format the operation failure into a readable string.
     *
     * @param OperationFailureInterface $failure
     *
     * @return string
     */
    public function format(OperationFailureInterface $failure): string
    {
        $exception  = $failure->getException();
        $operation  = $failure->getOperation();
        $identifier = str_pad(
            sprintf('(%d)', spl_object_id($operation)),
            8,
            ' ',
            STR_PAD_RIGHT
        );

        return $exception !== null
            ? sprintf(
                '%s ∴ %s',
                $identifier,
                $this->exceptionFormatter->format($exception)
            )
            : sprintf(
                '%s ✔ %s',
                $identifier,
                $this->operationFormatter->format($operation)
            );
    }
}


1		<?php
		0 ignored issues – show introduced 2020-03-19 15:20 UTC by Report Bug Copy Issue Report An error occurred during processing; checking has been aborted. The error message was: implode(): Passing glue string after array is deprecated. Swap the parameters in /home/scrutinizer/build/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php on line 468 Loading history...
2		/**
3		* Copyright MediaCT. All rights reserved.
4		* https://www.mediact.nl
5		*/
6
7		namespace Johmanx10\Transaction\Formatter;
8
9		use Johmanx10\Transaction\OperationFailureInterface;
10
11		class OperationFailureFormatter implements OperationFailureFormatterInterface
12		{
13		private OperationFormatterInterface $operationFormatter;
14
15		private ExceptionFormatterInterface $exceptionFormatter;
16
17		/**
18		* Constructor.
19		*
20		* @param OperationFormatterInterface\|null $operationFormatter
21		* @param ExceptionFormatterInterface\|null $exceptionFormatter
22		*/
23	4	public function __construct(
24		OperationFormatterInterface $operationFormatter = null,
25		ExceptionFormatterInterface $exceptionFormatter = null
26		) {
27	4	$this->operationFormatter = (
28	4	$operationFormatter ?? new OperationFormatter()
29		);
30	4	$this->exceptionFormatter = (
31	4	$exceptionFormatter ?? new ExceptionFormatter()
32		);
33	4	}
34
35		/**
36		* Format the operation failure into a readable string.
37		*
38		* @param OperationFailureInterface $failure
39		*
40		* @return string
41		*/
42	3	public function format(OperationFailureInterface $failure): string
43		{
44	3	$exception = $failure->getException();
45	3	$operation = $failure->getOperation();
46	3	$identifier = str_pad(
47	3	sprintf('(%d)', spl_object_id($operation)),
48	3	8,
49	3	' ',
50	3	STR_PAD_RIGHT
51		);
52
53	3	return $exception !== null
54		? sprintf(
55	2	'%s ∴ %s',
56		$identifier,
57	2	$this->exceptionFormatter->format($exception)
58		)
59		: sprintf(
60	1	'%s ✔ %s',
61		$identifier,
62	3	$this->operationFormatter->format($operation)
63		);
64		}
65		}
66

johmanx10 / transaction

Pull Request — master (#5)

OperationFailureFormatter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like