| Conditions | 20 |
| Paths | > 20000 |
| Total Lines | 55 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 37 | protected function private_core() |
||
| 38 | { |
||
| 39 | $this->share_extension(); |
||
| 40 | |||
| 41 | $this->grupo = new grupo_clientes(); |
||
| 42 | |||
| 43 | /// cargamos la configuración |
||
| 44 | $fsvar = new fs_var(); |
||
| 45 | $this->nuevocli_setup = $fsvar->array_get( |
||
| 46 | array( |
||
| 47 | 'nuevocli_cifnif_req' => 0, |
||
| 48 | 'nuevocli_direccion' => 1, |
||
| 49 | 'nuevocli_direccion_req' => 0, |
||
| 50 | 'nuevocli_codpostal' => 1, |
||
| 51 | 'nuevocli_codpostal_req' => 0, |
||
| 52 | 'nuevocli_pais' => 0, |
||
| 53 | 'nuevocli_pais_req' => 0, |
||
| 54 | 'nuevocli_provincia' => 1, |
||
| 55 | 'nuevocli_provincia_req' => 0, |
||
| 56 | 'nuevocli_ciudad' => 1, |
||
| 57 | 'nuevocli_ciudad_req' => 0, |
||
| 58 | 'nuevocli_telefono1' => 0, |
||
| 59 | 'nuevocli_telefono1_req' => 0, |
||
| 60 | 'nuevocli_telefono2' => 0, |
||
| 61 | 'nuevocli_telefono2_req' => 0, |
||
| 62 | 'nuevocli_email' => 0, |
||
| 63 | 'nuevocli_email_req' => 0, |
||
| 64 | 'nuevocli_codgrupo' => '', |
||
| 65 | ), FALSE |
||
| 66 | ); |
||
| 67 | |||
| 68 | if (isset($_POST['setup'])) { |
||
| 69 | $this->nuevocli_setup['nuevocli_cifnif_req'] = ( isset($_POST['nuevocli_cifnif_req']) ? 1 : 0 ); |
||
| 70 | $this->nuevocli_setup['nuevocli_direccion'] = ( isset($_POST['nuevocli_direccion']) ? 1 : 0 ); |
||
| 71 | $this->nuevocli_setup['nuevocli_direccion_req'] = ( isset($_POST['nuevocli_direccion_req']) ? 1 : 0 ); |
||
| 72 | $this->nuevocli_setup['nuevocli_codpostal'] = ( isset($_POST['nuevocli_codpostal']) ? 1 : 0 ); |
||
| 73 | $this->nuevocli_setup['nuevocli_codpostal_req'] = ( isset($_POST['nuevocli_codpostal_req']) ? 1 : 0 ); |
||
| 74 | $this->nuevocli_setup['nuevocli_pais'] = ( isset($_POST['nuevocli_pais']) ? 1 : 0 ); |
||
| 75 | $this->nuevocli_setup['nuevocli_pais_req'] = ( isset($_POST['nuevocli_pais_req']) ? 1 : 0 ); |
||
| 76 | $this->nuevocli_setup['nuevocli_provincia'] = ( isset($_POST['nuevocli_provincia']) ? 1 : 0 ); |
||
| 77 | $this->nuevocli_setup['nuevocli_provincia_req'] = ( isset($_POST['nuevocli_provincia_req']) ? 1 : 0 ); |
||
| 78 | $this->nuevocli_setup['nuevocli_ciudad'] = ( isset($_POST['nuevocli_ciudad']) ? 1 : 0 ); |
||
| 79 | $this->nuevocli_setup['nuevocli_ciudad_req'] = ( isset($_POST['nuevocli_ciudad_req']) ? 1 : 0 ); |
||
| 80 | $this->nuevocli_setup['nuevocli_telefono1'] = ( isset($_POST['nuevocli_telefono1']) ? 1 : 0 ); |
||
| 81 | $this->nuevocli_setup['nuevocli_telefono1_req'] = ( isset($_POST['nuevocli_telefono1_req']) ? 1 : 0 ); |
||
| 82 | $this->nuevocli_setup['nuevocli_telefono2'] = ( isset($_POST['nuevocli_telefono2']) ? 1 : 0 ); |
||
| 83 | $this->nuevocli_setup['nuevocli_telefono2_req'] = ( isset($_POST['nuevocli_telefono2_req']) ? 1 : 0 ); |
||
| 84 | $this->nuevocli_setup['nuevocli_email'] = ( isset($_POST['nuevocli_email']) ? 1 : 0 ); |
||
| 85 | $this->nuevocli_setup['nuevocli_email_req'] = ( isset($_POST['nuevocli_email_req']) ? 1 : 0 ); |
||
| 86 | $this->nuevocli_setup['nuevocli_codgrupo'] = $_POST['nuevocli_codgrupo']; |
||
| 87 | |||
| 88 | if ($fsvar->array_save($this->nuevocli_setup)) { |
||
| 89 | $this->new_message('Datos guardados correctamente.'); |
||
| 90 | } else |
||
| 91 | $this->new_error_msg('Error al guardar los datos.'); |
||
| 92 | } |
||
| 107 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths