joenilson / fsRepublicaDominicana

Controller/FiscalReports.php

Spacing +2 added lines, -2 removed lines

@@ -116,7 +116,7 @@ 
             $fileName = 'MyFiles/DGII_F_'.$reportCode.'_'.$this->empresa->cifnif.'_'.$year.'_'.$month.'.TXT';
             $commonFunctions->exportTXT($reportCode, $fileName, $this->empresa->cifnif, $year, $month, $whereReport);
             $this->response->headers->set('Content-type', 'text/plain');
-            $this->response->headers->set('Content-Disposition', 'attachment;filename=' . $fileName);
+            $this->response->headers->set('Content-Disposition', 'attachment;filename='.$fileName);
             $this->response->setContent(
                 file_get_contents(
                 \FS_FOLDER
@@ -223,7 +223,7 @@ 
         $periodStartDate = \date('Y-m-01');
         $periodEndDate = \date('Y-m-d');
         PeriodTools::applyPeriod('last-month', $periodStartDate, $periodEndDate);
-        if (in_array($this->request->request->get('filterfecha'), ['',null], true) === false) {
+        if (in_array($this->request->request->get('filterfecha'), ['', null], true) === false) {
             PeriodTools::applyPeriod($this->request->request->get('filterfecha'), $periodStartDate, $periodEndDate);
         } else {
             $periodStartDate = $this->request->request->get('filterstartfecha') ?? $periodStartDate;

Extension/Model/FacturaProveedor.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 
     public function saveBefore(): Closure
     {
-        return function () {
+        return function() {
             $ArrayTipoNCFCompras = ['11', '12', '16', '17'];
             $ncfrango = new NCFRango();
             $proveedor = new Proveedor();

Lib/CommonFunctionsDominicanRepublic.php

Spacing +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
             if (!$verificacion) {
                 echo json_encode(['success' => true], JSON_THROW_ON_ERROR);
             } else {
-                $message = "Factura: " . $verificacion[0]->idfactura . " Fecha: " . $verificacion[0]->fecha;
+                $message = "Factura: ".$verificacion[0]->idfactura." Fecha: ".$verificacion[0]->fecha;
                 echo json_encode(['error' => true, 'message' => $message], JSON_THROW_ON_ERROR);
             }
         }

Init.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
         $this->loadExtension(new Extension\Controller\EditFacturaProveedor());
         $this->loadExtension(new Extension\Controller\EditProducto());
         $this->loadExtension(new Extension\Controller\EditSettings());
-        AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+        AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
         SalesLineHTML::addMod(new Mod\SalesLineMod());
         SalesFooterHTML::addMod(new Mod\SalesFooterMod());
         PurchasesFooterHTML::addMod(new Mod\PurchasesFooterMod());

Mod/SalesLineMod.php

Spacing +7 added lines, -8 removed lines

@@ -26,15 +26,15 @@ 
 class SalesLineMod implements SalesLineModInterface
 {
 
-    public function apply(SalesDocument &$model, array &$lines, array $formData)
+    public function apply(SalesDocument & $model, array &$lines, array $formData)
     {
         // TODO: Implement apply() method.
     }
 
-    public function applyToLine(array $formData, SalesDocumentLine &$line, string $id)
+    public function applyToLine(array $formData, SalesDocumentLine & $line, string $id)
     {
-        $line->rdtaxisc = $formData['rdtaxisc_' . $id] ?? null;
-        $line->rdtaxcdt = $formData['rdtaxcdt_' . $id] ?? null;
+        $line->rdtaxisc = $formData['rdtaxisc_'.$id] ?? null;
+        $line->rdtaxcdt = $formData['rdtaxcdt_'.$id] ?? null;
     }
 
     public function assets(): void
@@ -80,8 +80,7 @@ 
     protected function rdTax($i18n, $idlinea, $line, $model, $field): string
     {
         $attributes = $model->editable ?
-            'name="'. $field .'_' . $idlinea . '"' :
-            'disabled=""';
+            'name="'.$field.'_'.$idlinea.'"' : 'disabled=""';
 
         $title = $this->rdTaxTitle($i18n, $field);
         $lineTax = $this->productoTaxValue($line->idproducto, $field);
@@ -90,14 +89,14 @@ 
 
         return '<div class="col-6">'
             . $title
-            . '<input type="number" ' . $attributes . ' value="' . $fieldValue. '" class="form-control" readonly=""/>'
+            . '<input type="number" '.$attributes.' value="'.$fieldValue.'" class="form-control" readonly=""/>'
             . '</div>'
             . '</div>';
     }
 
     protected function rdTaxTitle($i18n, $field): string
     {
-        return '<div class="mb-2">' . $i18n->trans($field);
+        return '<div class="mb-2">'.$i18n->trans($field);
     }
 
     protected function productoTaxValue($idproducto, $rdtaxid): ?ImpuestoProducto

Mod/SalesFooterMod.php

Spacing +20 added lines, -24 removed lines

@@ -28,21 +28,21 @@ 
 
 class SalesFooterMod implements SalesModInterface
 {
-    public function apply(SalesDocument &$model, array $formData, User $user)
+    public function apply(SalesDocument & $model, array $formData, User $user)
     {
         // TODO: Implement apply() method.
     }
 
-    public function applyBefore(SalesDocument &$model, array $formData, User $user)
+    public function applyBefore(SalesDocument & $model, array $formData, User $user)
     {
         // TODO: Implement applyBefore() method.
         if ($model->modelClassName() === 'FacturaCliente') {
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
         }
     }
 
@@ -103,7 +103,7 @@ 
         if (!$model->editable) {
             $invoiceTipoComprobante = $model->tipocomprobante;
         } elseif ($model->editable === true && ($cliente->tipocomprobante !== $model->tipocomprobante) && $model->tipocomprobante !== null) {
-            $invoiceTipoComprobante =  $model->tipocomprobante;
+            $invoiceTipoComprobante = $model->tipocomprobante;
         } elseif ($model->editable === true && ($cliente->tipocomprobante === $model->tipocomprobante) && $model->tipocomprobante !== null) {
             $invoiceTipoComprobante = $cliente->tipocomprobante;
         }
@@ -111,15 +111,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoComprobante as $row) {
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = ($model->editable || $model->numeroncf === '') ? 'id="tipocomprobante" name="tipocomprobante" required="" onChange="verificarCorrelativoNCF(this.value,\'Ventas\')"' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('tipocomprobante')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -143,15 +142,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoPago as $row) {
             $options[] = ($row->codigo === $invoiceTipoPago) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-payment-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -171,15 +169,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoMovimiento as $row) {
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-movement-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -197,15 +194,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoAnulacion as $row) {
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-cancellation-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -217,8 +213,8 @@ 
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
             : '';
         return '<div class="col-sm-2">'
-            . '<div class="form-group">' . $i18n->trans('due-date')
-            . '<input type="date" ' . $attributes . ' value="' . $ncfFechaVencimiento . '" class="form-control"/>'
+            . '<div class="form-group">'.$i18n->trans('due-date')
+            . '<input type="date" '.$attributes.' value="'.$ncfFechaVencimiento.'" class="form-control"/>'
             . '</div>'
             . '</div>';
     }
@@ -229,7 +225,7 @@ 
         return empty($model->codcliente) ? '' : '<div class="col-sm">'
             . '<div class="form-group">'
             . $i18n->trans('desc-numeroncf-sales')
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
             . '</div>'
             . '</div>';
     }

Mod/CalculatorMod.php

Spacing +4 added lines, -4 removed lines

@@ -26,13 +26,13 @@ 
 class CalculatorMod implements CalculatorModInterface
 {
 
-    public function apply(BusinessDocument &$doc, array &$lines): bool
+    public function apply(BusinessDocument & $doc, array &$lines): bool
     {
         //TODO: Implement apply() method.
         return true;
     }
 
-    public function calculate(BusinessDocument &$doc, array &$lines): bool
+    public function calculate(BusinessDocument & $doc, array &$lines): bool
     {
         // calculamos el total de impuestos
 //        $totalTaxes = 0.0;
@@ -44,13 +44,13 @@ 
         return true;
     }
 
-    public function calculateLine(BusinessDocument $doc, BusinessDocumentLine &$line): bool
+    public function calculateLine(BusinessDocument $doc, BusinessDocumentLine & $line): bool
     {
         // TODO: Implement calculateLine() method.
         return true;
     }
 
-    public function clear(BusinessDocument &$doc, array &$lines): bool
+    public function clear(BusinessDocument & $doc, array &$lines): bool
     {
         // TODO: Implement clear() method.
         return true;

Extension/Lib/PointOfSaleVoucher.php

Spacing +6 added lines, -6 removed lines

@@ -38,14 +38,14 @@ 
     {
         $this->printer->text($this->document->codigo, true, true);
         $this->printer->lineSeparator('-');
-        $this->printer->text('NCF: ' . $this->document->numeroncf, true, true);
+        $this->printer->text('NCF: '.$this->document->numeroncf, true, true);
         //$this->printer->text('TIPO: ' . $this->document->descripcionTipoComprobante(), true, true);
-        $this->printer->text('F. VENC. NCF: ' . $this->document->ncffechavencimiento, true, true);
+        $this->printer->text('F. VENC. NCF: '.$this->document->ncffechavencimiento, true, true);
         $this->printer->lineSeparator('-');
-        $fechacompleta = $this->document->fecha . ' ' . $this->document->hora;
+        $fechacompleta = $this->document->fecha.' '.$this->document->hora;
         $this->printer->text($fechacompleta, true, true);
 
-        $this->printer->text('CLIENTE: ' . $this->document->nombrecliente);
+        $this->printer->text('CLIENTE: '.$this->document->nombrecliente);
         $this->printer->lineSeparator('=');
 
         $this->printer->text('ARTICULO');
@@ -60,10 +60,10 @@ 
                 $this->printer->textColumns('IMPORTE', NumberTools::format($line->pvpsindto));
 
                 $descuento = $line->pvpsindto - ($line->pvpsindto * $line->getEUDiscount());
-                $this->printer->textColumns('Descuento:', '- ' . NumberTools::format($descuento));
+                $this->printer->textColumns('Descuento:', '- '.NumberTools::format($descuento));
 
                 $impuestoLinea = $line->pvptotal * $line->iva / 100;
-                $this->printer->textColumns("Impuesto $line->iva%:", '+ ' . NumberTools::format($impuestoLinea));
+                $this->printer->textColumns("Impuesto $line->iva%:", '+ '.NumberTools::format($impuestoLinea));
                 $this->printer->textColumns('Total linea:', NumberTools::format($line->pvptotal + $impuestoLinea));
             }
 

Extension/Model/FacturaCliente.php

Spacing +5 added lines, -5 removed lines

@@ -66,7 +66,7 @@ 
 
     public function saveBefore(): Closure
     {
-        return function () {
+        return function() {
             $ncfrango = new NCFRango();
             $cliente = new Cliente();
             $appSettins = new AppSettings;
@@ -95,7 +95,7 @@ 
                 $ncfRangoToUse->correlativo++;
                 $ncfRangoToUse->save();
                 //Verificamos si $this->tipoComprobante es una nota de crédito o debito
-                $arrayNCFTypes = ['03','04'];
+                $arrayNCFTypes = ['03', '04'];
                 if (in_array($this->tipocomprobante, $arrayNCFTypes) === true) {
                     $this->ncftipoanulacion = isset($_REQUEST['ncftipoanulacionr'])
                         ? $_REQUEST['ncftipoanulacionr']
@@ -112,11 +112,11 @@ 
 
     public function all(): Closure
     {
-        return function () {
+        return function() {
             $this->facturarectnumero2 = '';
             if ($this->idfacturarect !== '') {
                 $facturaRectificativa = $this->get($this->idfacturarect);
-                $this->loadFromData(['facturarectnumero2' => 'SI' ]);
+                $this->loadFromData(['facturarectnumero2' => 'SI']);
                 $this->facturarectnumero2 = $facturaRectificativa->numero2;
             } else {
                 $this->loadFromData(['facturarectnumero2' => 'NO HAY']);
@@ -127,7 +127,7 @@ 
 
     public function descripcionTipoComprobante(): Closure
     {
-        return function () {
+        return function() {
             $ncftipocomprobante = new NCFTipo();
             $ncftipocomprobante->loadFromCode($this->tipocomprobante);
             return $ncftipocomprobante->descripcion;