joenilson / fsRepublicaDominicana

Model/NCFRango.php

Spacing +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
                 . $idempresa
                 . ' AND tipocomprobante = '
                 . $dataBase->var2str($tipocomprobante)
-                . ' AND estado = ' . $dataBase->var2str(true)
+                . ' AND estado = '.$dataBase->var2str(true)
                 . ';';
         $data = $dataBase->select($sql);
         if (empty($data) === true || in_array($data[0], [null, ''], true)) {

Model/NCFTipo.php

Spacing +13 added lines, -13 removed lines

@@ -158,17 +158,17 @@ 
         parent::install();
         $sql = "INSERT INTO rd_ncftipo (".
             "tipocomprobante, descripcion, estado, clasemovimiento, ventas, compras, contribuyente".
-            " ) VALUES " .
-            "('01','FACTURA DE CREDITO FISCAL',true, 'suma','Y','Y','Y')," .
-            "('02','FACTURA DE CONSUMO',true, 'suma','Y','Y','Y')," .
-            "('03','NOTA DE DEBITO',true, 'suma','Y','Y','N')," .
-            "('04','NOTA DE CREDITO',true, 'resta','Y','Y','N')," .
-            "('11','COMPROBANTE DE COMPRAS',true, 'suma','N','Y','Y')," .
-            "('12','REGISTRO UNICO DE INGRESOS',true, 'suma','Y','N','N')," .
-            "('13','COMPROBANTE PARA GASTOS MENORES',true, 'suma','N','Y','N')," .
-            "('14','COMPROBANTE DE REGIMENES ESPECIALES',true, 'suma','Y','Y','Y')," .
-            "('15','COMPROBANTE GUBERNAMENTAL',true, 'suma','Y','Y','Y')," .
-            "('16','COMPROBANTE PARA EXPORTACIONES',true, 'suma','Y','N','Y')," .
+            " ) VALUES ".
+            "('01','FACTURA DE CREDITO FISCAL',true, 'suma','Y','Y','Y'),".
+            "('02','FACTURA DE CONSUMO',true, 'suma','Y','Y','Y'),".
+            "('03','NOTA DE DEBITO',true, 'suma','Y','Y','N'),".
+            "('04','NOTA DE CREDITO',true, 'resta','Y','Y','N'),".
+            "('11','COMPROBANTE DE COMPRAS',true, 'suma','N','Y','Y'),".
+            "('12','REGISTRO UNICO DE INGRESOS',true, 'suma','Y','N','N'),".
+            "('13','COMPROBANTE PARA GASTOS MENORES',true, 'suma','N','Y','N'),".
+            "('14','COMPROBANTE DE REGIMENES ESPECIALES',true, 'suma','Y','Y','Y'),".
+            "('15','COMPROBANTE GUBERNAMENTAL',true, 'suma','Y','Y','Y'),".
+            "('16','COMPROBANTE PARA EXPORTACIONES',true, 'suma','Y','N','Y'),".
             "('17','COMPROBANTE PARA PAGOS AL EXTERIOR',true, 'suma','N', 'Y','Y');";
         return($sql);
     }
@@ -176,7 +176,7 @@ 
     public function restoreData()
     {
         $dataBase = new DataBase();
-        $sqlClean = "DELETE FROM " . $this->tableName() . ";";
+        $sqlClean = "DELETE FROM ".$this->tableName().";";
         $dataBase->exec($sqlClean);
         foreach ($this->arrayComprobantes as $arrayItem) {
             $initialData = new NCFTipo($arrayItem);
@@ -187,7 +187,7 @@ 
 
     public function allFor($type = "ventas", $movimiento = "suma")
     {
-        $where = [new DataBaseWhere($type, 'Y'),new DataBaseWhere('clasemovimiento', $movimiento)];
+        $where = [new DataBaseWhere($type, 'Y'), new DataBaseWhere('clasemovimiento', $movimiento)];
         return $this->all($where, ['tipocomprobante' => 'ASC'], 0, 50);
     }
 

Model/Join/FiscalReport608.php

Spacing +10 added lines, -10 removed lines

@@ -39,14 +39,14 @@ 
             'idempresa' => static::MAIN_TABLE.'.idempresa',
             'codalmacen' => static::MAIN_TABLE.'.codalmacen',
             'ncf' => static::MAIN_TABLE.'.numeroncf',
-            'tipoanulacion' => 'CASE WHEN ' .
-                                static::ESTADOSDOC_TABLE . '.nombre = \'Anulada\' AND ' .
-                                static::MAIN_TABLE.'.ncftipoanulacion is null ' .
-                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE ' .
-                                'concat(' . static::MAIN_TABLE.'.ncftipoanulacion, \' - \', ' .
+            'tipoanulacion' => 'CASE WHEN '.
+                                static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\' AND '.
+                                static::MAIN_TABLE.'.ncftipoanulacion is null '.
+                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE '.
+                                'concat('.static::MAIN_TABLE.'.ncftipoanulacion, \' - \', '.
                                 static::NCFCANCELTYPE_TABLE.'.descripcion) END',
             'fecha' => $dateFormat.'('.static::MAIN_TABLE.'.fecha,\''.$dateFormatString.'\')',
-            'estado' => 'CASE WHEN ' . static::ESTADOSDOC_TABLE .
+            'estado' => 'CASE WHEN '.static::ESTADOSDOC_TABLE.
                         '.nombre = \'Emitida\' THEN \'Activo\' ELSE \'Anulado\' END',
         ];
         return $data;
@@ -59,10 +59,10 @@ 
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
-            . ' LEFT JOIN ' . static::NCFCANCELTYPE_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.ncftipoanulacion = ' . static::NCFCANCELTYPE_TABLE . '.codigo)';
+            . ' JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
+            . ' LEFT JOIN '.static::NCFCANCELTYPE_TABLE.' ON ('
+            . static::MAIN_TABLE.'.ncftipoanulacion = '.static::NCFCANCELTYPE_TABLE.'.codigo)';
     }
 
     /**

Model/Join/FiscalReport607.php

Spacing +4 added lines, -4 removed lines

@@ -92,10 +92,10 @@
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '
             . static::ESTADOSDOC_TABLE.'.nombre != \'Anulada\')';
     }
 

Lib/Export/DgiiExport.php

Spacing +2 added lines, -2 removed lines

@@ -81,10 +81,10 @@
     /**
      * @inheritDoc
      */
-    public function show(Response &$response)
+    public function show(Response & $response)
     {
         $response->headers->set('Content-Type', 'text/text; charset=utf-8');
-        $response->headers->set('Content-Disposition', 'attachment;filename=' . $this->getFileName() . '.TXT');
+        $response->headers->set('Content-Disposition', 'attachment;filename='.$this->getFileName().'.TXT');
         $response->setContent($this->getDoc());
     }
 }
\ No newline at end of file

Mod/PurchasesFooterMod.php

Spacing +23 added lines, -27 removed lines

@@ -29,21 +29,21 @@ 
 
 class PurchasesFooterMod implements PurchasesModInterface
 {
-    public function apply(PurchaseDocument &$model, array $formData, User $user)
+    public function apply(PurchaseDocument & $model, array $formData, User $user)
     {
         // TODO: Implement apply() method.
     }
 
-    public function applyBefore(PurchaseDocument &$model, array $formData, User $user)
+    public function applyBefore(PurchaseDocument & $model, array $formData, User $user)
     {
         // TODO: Implement applyBefore() method.
         if ($model->modelClassName() === 'FacturaProveedor') {
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
         }
     }
 
@@ -55,7 +55,7 @@ 
     public function newFields(): array
     {
         // TODO: Implement newFields() method.
-        return ['numeroncf','tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
+        return ['numeroncf', 'tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
     }
 
     public function renderField(Translator $i18n, PurchaseDocument $model, string $field): ?string
@@ -104,15 +104,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoComprobante as $row) {
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = ($model->editable || $model->numeroncf === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('tipocomprobante')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -136,15 +135,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoPago as $row) {
             $options[] = ($row->codigo === $invoiceTipoPago) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-payment-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -162,15 +160,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoMovimiento as $row) {
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-movement-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -188,15 +185,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoAnulacion as $row) {
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'name="ncftipoanulacion" readonly=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-cancellation-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -208,9 +204,9 @@ 
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
             : '';
         return '<div class="col-sm-2">'
-            . '<div class="form-group">' . $i18n->trans('due-date')
-            . '<input type="date" ' . $attributes . ' value="'
-            . $ncfFechaVencimiento . '" class="form-control"/>'
+            . '<div class="form-group">'.$i18n->trans('due-date')
+            . '<input type="date" '.$attributes.' value="'
+            . $ncfFechaVencimiento.'" class="form-control"/>'
             . '</div>'
             . '</div>';
     }
@@ -223,11 +219,11 @@ 
             . '<div class="form-group">'
             . $i18n->trans('desc-numeroncf-purchases')
             . '<div class="input-group">'
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
             . '<div class="input-group-append">'
-            . '<button class="btn ' . $btnColor .' btn-spin-action" id="btnVerifyNCF"'
+            . '<button class="btn '.$btnColor.' btn-spin-action" id="btnVerifyNCF"'
             . 'onclick="purchasesNCFVerify()" '
-            . 'title="'. $i18n->trans('verify-numproveedor')
+            . 'title="'.$i18n->trans('verify-numproveedor')
             .'" type="button">'
             . '<i id="iconBtnVerify" class="fas fa-search fa-fw"></i>'
             . '</button>'

Model/Join/FiscalReport606.php

Spacing +22 added lines, -22 removed lines

@@ -74,18 +74,18 @@ 
     protected function getGroupFields(): string
     {
         //return parent::getGroupFields(); // TODO: Change the autogenerated stub
-        return  static::MAIN_TABLE.'.idfactura, ' .
-                static::MAIN_TABLE.'.idempresa, ' .
-                static::MAIN_TABLE.'.codalmacen, ' .
-                static::MAIN_TABLE.'.cifnif, ' .
-                static::MAIN_TABLE.'.ncftipomovimiento, ' .
-                static::MAIN_TABLE.'.numeroncf, ' .
-                static::SECONDARY_TABLE_ALIAS.'.numeroncf, ' .
-                static::MAIN_TABLE.'.fecha, ' .
-                static::RECIBOSPROV_TABLE.'.fechapago, ' .
-                static::ESTADOSDOC_TABLE.'.nombre, ' .
-                static::MAIN_TABLE.'.neto, ' .
-                static::MAIN_TABLE.'.totaliva' .
+        return  static::MAIN_TABLE.'.idfactura, '.
+                static::MAIN_TABLE.'.idempresa, '.
+                static::MAIN_TABLE.'.codalmacen, '.
+                static::MAIN_TABLE.'.cifnif, '.
+                static::MAIN_TABLE.'.ncftipomovimiento, '.
+                static::MAIN_TABLE.'.numeroncf, '.
+                static::SECONDARY_TABLE_ALIAS.'.numeroncf, '.
+                static::MAIN_TABLE.'.fecha, '.
+                static::RECIBOSPROV_TABLE.'.fechapago, '.
+                static::ESTADOSDOC_TABLE.'.nombre, '.
+                static::MAIN_TABLE.'.neto, '.
+                static::MAIN_TABLE.'.totaliva'.
             ' ';
     }
 
@@ -96,16 +96,16 @@ 
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN '. static::RECIBOSPROV_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfactura = ' . static::RECIBOSPROV_TABLE . '.idfactura)'
-            . ' LEFT JOIN '. static::LINES_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
-            . ' LEFT JOIN '. static::PRODS_TABLE . ' ON ('
-            . static::LINES_TABLE . '.referencia = ' . static::PRODS_TABLE . '.referencia)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::RECIBOSPROV_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfactura = '.static::RECIBOSPROV_TABLE.'.idfactura)'
+            . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
+            . ' LEFT JOIN '.static::PRODS_TABLE.' ON ('
+            . static::LINES_TABLE.'.referencia = '.static::PRODS_TABLE.'.referencia)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
     }
 
     /**

Extension/Controller/EditCliente.php

Spacing +5 added lines, -5 removed lines

@@ -29,10 +29,10 @@ 
 {
     public function createViews(): Closure
     {
-        return function () {
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
+        return function() {
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
             $ncfTipo = new NCFTipo();
             $ncfTipos = $ncfTipo->allFor('ventas', 'suma');
             $customValues = [];
@@ -61,7 +61,7 @@ 
 
     public function execPreviousAction()
     {
-        return function ($action) {
+        return function($action) {
             switch ($action) {
                 case 'busca_rnc':
                     $this->setTemplate(false);

Extension/Controller/EditProveedor.php

Spacing +5 added lines, -5 removed lines

@@ -28,10 +28,10 @@ 
 
     public function createViews(): Closure
     {
-        return function () {
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
+        return function() {
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
             $ncfTipoPago = new NCFTipoPago();
             $ncfTiposPago = $ncfTipoPago->findAllByTipopago('02');
             $customValuesNTP = [];
@@ -48,7 +48,7 @@ 
 
     public function execPreviousAction()
     {
-        return function ($action) {
+        return function($action) {
             switch ($action) {
                 case 'busca_rnc':
                     $this->setTemplate(false);