joenilson / fsRepublicaDominicana

Extension/Controller/EditProveedor.php

Spacing +4 added lines, -4 removed lines

@@ -26,10 +26,10 @@
 
     public function createViews()
     {
-        return function () {
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
+        return function() {
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
             $ncfTipoPago = new NCFTipoPago();
             $ncfTiposPago = $ncfTipoPago->findAllByTipopago('02');
             $customValuesNTP = [];

Extension/Controller/EditCliente.php

Spacing +4 added lines, -4 removed lines

@@ -27,10 +27,10 @@
 {
     public function createViews()
     {
-        return function () {
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
+        return function() {
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
             $ncfTipo = new NCFTipo();
             $ncfTipos = $ncfTipo->allFor('ventas', 'suma');
             $customValues = [];

Extension/Model/Cliente.php

Indentation +6 added lines, -6 removed lines

@@ -21,13 +21,13 @@
 class Cliente
 {
     /**
-    * Payment type based on DGII table
-    * @var string
-    */
+     * Payment type based on DGII table
+     * @var string
+     */
     public $ncftipopago;
     /**
-    * Type of NCF to generate to the customer
-    * @var string
-    */
+     * Type of NCF to generate to the customer
+     * @var string
+     */
     public $tipocomprobante;
 }

Extension/Model/FacturaProveedor.php

Spacing +2 added lines, -2 removed lines

@@ -47,8 +47,8 @@
 
     public function saveInsert()
     {
-        return function () {
-            $ArrayTipoNCFCompras = ['11','12','16','17'];
+        return function() {
+            $ArrayTipoNCFCompras = ['11', '12', '16', '17'];
             $ncfrango = new NCFRango();
             $cliente = new Proveedor();
             $appSettings = new AppSettings;

Lib/PDF/PDFDocument.php

Spacing +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
     protected function insertBusinessDocHeader($model): void
     {
         $headerData = [
-            'title' => $this->i18n->trans($model->modelClassName() . '-min'),
+            'title' => $this->i18n->trans($model->modelClassName().'-min'),
             'subject' => $this->i18n->trans('customer'),
             'fieldName' => 'nombrecliente'
         ];
@@ -40,7 +40,7 @@ 
             $headerData['title'] = Utils::fixHtml($this->format->titulo);
         }
 
-        $this->pdf->ezText("\n" . $headerData['title'] . ': ' . $model->codigo . "\n", self::FONT_SIZE + 6);
+        $this->pdf->ezText("\n".$headerData['title'].': '.$model->codigo."\n", self::FONT_SIZE + 6);
         $this->newLine();
 
         $subject = $model->getSubject();

Model/Join/FiscalReport606.php

Spacing +19 added lines, -19 removed lines

@@ -69,17 +69,17 @@ 
     protected function getGroupFields(): string
     {
         //return parent::getGroupFields(); // TODO: Change the autogenerated stub
-        return  static::MAIN_TABLE.'.idfactura, ' .
-                static::MAIN_TABLE.'.idempresa, ' .
-                static::MAIN_TABLE.'.codalmacen, ' .
-                static::MAIN_TABLE.'.cifnif, ' .
-                static::MAIN_TABLE.'.ncftipomovimiento, ' .
-                static::MAIN_TABLE.'.numproveedor, ' .
-                static::SECONDARY_TABLE_ALIAS.'.numproveedor, ' .
-                static::MAIN_TABLE.'.fecha, ' .
-                static::ESTADOSDOC_TABLE.'.nombre, ' .
-                static::MAIN_TABLE.'.neto, ' .
-                static::MAIN_TABLE.'.totaliva' .
+        return  static::MAIN_TABLE.'.idfactura, '.
+                static::MAIN_TABLE.'.idempresa, '.
+                static::MAIN_TABLE.'.codalmacen, '.
+                static::MAIN_TABLE.'.cifnif, '.
+                static::MAIN_TABLE.'.ncftipomovimiento, '.
+                static::MAIN_TABLE.'.numproveedor, '.
+                static::SECONDARY_TABLE_ALIAS.'.numproveedor, '.
+                static::MAIN_TABLE.'.fecha, '.
+                static::ESTADOSDOC_TABLE.'.nombre, '.
+                static::MAIN_TABLE.'.neto, '.
+                static::MAIN_TABLE.'.totaliva'.
             ' ';
     }
 
@@ -90,14 +90,14 @@ 
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN '. static::LINES_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
-            . ' LEFT JOIN '. static::PRODS_TABLE . ' ON ('
-            . static::LINES_TABLE . '.referencia = ' . static::PRODS_TABLE . '.referencia)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
+            . ' LEFT JOIN '.static::PRODS_TABLE.' ON ('
+            . static::LINES_TABLE.'.referencia = '.static::PRODS_TABLE.'.referencia)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
     }
 
     /**

Model/RNCDGIIDB.php

Spacing +10 added lines, -10 removed lines

@@ -133,7 +133,7 @@ 
     private function slowParser()
     {
         $dataBase = new DataBase();
-        $sqlDelete = "DELETE FROM " . $this->tableName() . ";";
+        $sqlDelete = "DELETE FROM ".$this->tableName().";";
         $dataBase->exec($sqlDelete);
 
         [$handle, $totalLines] = $this->utf8FopenRead($this->fileNameTxt);
@@ -142,7 +142,7 @@ 
         while (($raw_string = fgets($handle)) !== false) {
             $totalLines--;
             if ($maxLine === 2000) {
-                $query = 'INSERT INTO ' . $this->tableName() .
+                $query = 'INSERT INTO '.$this->tableName().
                     ' (rnc, nombre, razonsocial, categoria, inicioactividad, estado, regimenpagos) VALUES ';
             }
             $linea = str_getcsv($raw_string, "|");
@@ -172,14 +172,14 @@ 
         $fecha = ($colArray[8] === '00/00/0000')
             ? "2000-01-01"
             : \date('Y-m-d', strtotime(str_replace("/", "-", $colArray[8])));
-        return "('" .
-            $colArray[0] . "','" .
-            str_replace('\\', '', str_replace('"', '', str_replace("'", "''", str_replace("  ", " ", $colArray[1])))) . "','" .
-            str_replace('\\', '', str_replace('"', '', str_replace("'", "''", str_replace("  ", " ", $colArray[2])))) . "','" .
-            $colArray[3] . "','" .
-            $fecha . "','" .
-            $colArray[9] . "','" .
-            $colArray[10] . "')" . $semiColon;
+        return "('".
+            $colArray[0]."','".
+            str_replace('\\', '', str_replace('"', '', str_replace("'", "''", str_replace("  ", " ", $colArray[1]))))."','".
+            str_replace('\\', '', str_replace('"', '', str_replace("'", "''", str_replace("  ", " ", $colArray[2]))))."','".
+            $colArray[3]."','".
+            $fecha."','".
+            $colArray[9]."','".
+            $colArray[10]."')".$semiColon;
     }
 
     private function utf8FopenRead($fileName)

Init.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
         $this->loadExtension(new Extension\Controller\EditProveedor());
         $this->loadExtension(new Extension\Controller\EditFacturaCliente());
         $this->loadExtension(new Extension\Controller\EditFacturaProveedor());
-        AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
+        AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
         SalesHeaderHTML::addMod(new Mod\SalesHeaderMod());
         SalesFooterHTML::addMod(new Mod\SalesFooterMod());
         PurchasesFooterHTML::addMod(new Mod\PurchasesFooterMod());

Mod/PurchasesFooterMod.php

Spacing +17 added lines, -21 removed lines

@@ -29,20 +29,20 @@ 
 
 class PurchasesFooterMod implements PurchasesModInterface
 {
-    public function apply(PurchaseDocument &$model, array $formData, User $user)
+    public function apply(PurchaseDocument & $model, array $formData, User $user)
     {
         // TODO: Implement apply() method.
     }
 
-    public function applyBefore(PurchaseDocument &$model, array $formData, User $user)
+    public function applyBefore(PurchaseDocument & $model, array $formData, User $user)
     {
         // TODO: Implement applyBefore() method.
         if ($model->modelClassName() === 'FacturaProveedor') {
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
         }
     }
 
@@ -101,15 +101,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoComprobante as $row) {
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = ($model->editable || $model->numproveedor === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('tipocomprobante')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -133,15 +132,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoPago as $row) {
             $options[] = ($row->codigo === $invoiceTipoPago) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-payment-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -159,15 +157,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoMovimiento as $row) {
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
         return '<div class="col-sm-3">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-movement-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -185,15 +182,14 @@ 
         $options = ['<option value="">------</option>'];
         foreach ($tipoAnulacion as $row) {
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
         }
 
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'disabled=""';
         return '<div class="col-sm-2">'
             . '<div class="form-group">'
             .  $i18n->trans('ncf-cancellation-type')
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
             . '</div>'
             . '</div>';
     }
@@ -202,8 +198,8 @@ 
     {
         $attributes = ($model->editable && $model->numproveedor === '') ? 'name="ncffechavencimiento"' : 'disabled=""';
         return '<div class="col-sm-2">'
-            . '<div class="form-group">' . $i18n->trans('due-date')
-            . '<input type="date" ' . $attributes . ' value="' . date('Y-m-d', strtotime($model->ncffechavencimiento)) . '" class="form-control"/>'
+            . '<div class="form-group">'.$i18n->trans('due-date')
+            . '<input type="date" '.$attributes.' value="'.date('Y-m-d', strtotime($model->ncffechavencimiento)).'" class="form-control"/>'
             . '</div>'
             . '</div>';
     }