EditFacturaProveedor.js ➔ businessDocViewSave - Code Metrics - Inspection of "- Added Lib for webservice DGII search" - joenilson/fsRepublicaDominicana - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 88ea97...aa75e3 )

by Joe Nilson

created 2022-03-11 01:03 UTC

EditFacturaProveedor.js ➔ businessDocViewSave F

↳ Parent: Assets/JS/EditFacturaProveedor.js

Complexity

Conditions

Size

Total Lines	74
Code Lines	58

Duplication

Lines	74
Ratio	100 %

Importance

Changes

Metric	Value
cc	14
eloc	58
c	0
b	0
f	0
dl	74
loc	74
rs	3.6

How to fix Long Method Complexity

/*
 * Copyright (C) 2021 Joe Nilson <[email protected]>
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
function businessDocViewSubjectChanged()

{
    var data = {};
    $.each($("#" + businessDocViewFormName).serializeArray(), function (key, value) {

        data[value.name] = value.value;
    });
    data.action = "subject-changed";
    logConsole(data, "subject-changed");

    $.ajax({
        type: "POST",
        url: businessDocViewUrl,

        dataType: "json",
        data: data,
        success: function (results) {
            $("#doc_codpago").val(results.codpago);
            $("#doc_codserie").val(results.codserie);
            $("#formEditFacturaProveedor select[name=ncftipopago]").val(results.ncftipopago);

            /**
             * Review the doc_codsubtipodoc existence,
             * if it exist we put the value from the customer data
             */
            if ($("#doc_codsubtipodoc").length !== 0) {
                $("#doc_codsubtipodoc").val(results.codsubtipodoc);
            }
            logConsole(results.codsubtipodoc,"codsubtipodoc");
            /**
             * Review the doc_codopersaciondoc existence,
             * if it exist we put the value from the customer data
             */
            if ($("#doc_codoperaciondoc").length !== 0) {
                $("#doc_codoperaciondoc").val(results.codoperaciondoc);
            }
            logConsole(results.codoperaciondoc,"codoperaciondoc");

            logConsole(results,"results");

            businessDocViewRecalculate();
        },
        error: function (xhr, status, error) {

            alert(xhr.responseText);

        }
    });
}

async function cargarInfoProveedor()
{
    return $.ajax({
        url: 'ListNCFTipo',
        async: true,
        data: {'action': 'busca_infoproveedor', 'codproveedor': $("#codproveedorAutocomplete").val()},
        type: 'POST',
        datatype: 'json',
        success: function (response) {
            let data = JSON.parse(response);
            return data;
        },
        error: function (xhr, status) {
            alert('Ha ocurrido algún tipo de error ' + status);

        }
    });
}

async function cargarTipoPago()
{
    return $.ajax({
        url: 'ListNCFTipoPago',
        async: true,
        data: {'action': 'busca_pago', 'tipopago': '02'},
        type: 'POST',
        datatype: 'json',
        success: function (response) {
            let data = JSON.parse(response);
            return data;
        },
        error: function (xhr, status) {
            alert('Ha ocurrido algún tipo de error ' + status);

        }
    });
}

async function cargarTipoMovimiento()
{
    return $.ajax({
        url: 'ListNCFTipoMovimiento',
        async: true,
        data: {'action': 'busca_movimiento', 'tipomovimiento': 'COM'},
        type: 'POST',
        datatype: 'json',
        success: function (response) {
            let data = JSON.parse(response);
            return data;
        },
        error: function (xhr, status) {
            alert('Ha ocurrido algún tipo de error ' + status);

        }
    });
}

async function businessDocViewSave()
{
    if ($("#codproveedorAutocomplete").val() === '') {
        executeModal('errorNoProveedorDetectado','No hay Proveedor','Debe seleccionar un proveedor primero!', 'warning', '');
    } else {
        $("#btn-document-save").prop("disabled", true);
        var infoProveedor = await cargarInfoProveedor();
        logConsole(infoProveedor, 'infoProveedor');
        var datosProveedor = JSON.parse(infoProveedor);

        var tipoPago = await cargarTipoPago();
        var datosPago = JSON.parse(tipoPago);

        var tipoNCFs = await cargarTipoNCF('Compras');
        logConsole(tipoNCFs, 'tipoNCFs');
        var datosTipoNCFs = JSON.parse(tipoNCFs);
        let selectTiposNCF = "";
        var descInfoProveedorTipoComprobante = '';
        var formTipoComprobante = $("#formEditFacturaProveedor select[name=tipocomprobante]").val();
        var formNumeroNCF = $("#formEditFacturaProveedor input[name=numproveedor]").val();
        var formNumProveedorType = formNumeroNCF.slice(-10, -8);
        var tipoComprobanteActivo = (formTipoComprobante !== '') ? formTipoComprobante : formNumProveedorType;
        var tipoComprobanteActivo = (tipoComprobanteActivo === '') ? '01' : tipoComprobanteActivo;

        var descDefault = datosTipoNCFs.tipocomprobantes[0].descripcion;
        $.each(datosTipoNCFs.tipocomprobantes, function (i, value) {
            let defaultSelected = (tipoComprobanteActivo === value.tipocomprobante) ? 'selected' : '';
            descInfoProveedorTipoComprobante = (formNumProveedorType === value.tipocomprobante)
                ? value.descripcion : descDefault;
            selectTiposNCF += '<option value="' + value.tipocomprobante + '"' + defaultSelected + '>' + value.descripcion + '</option>';
        });

        var ncfTipoPagoCliente = $("#formEditFacturaProveedor select[name=ncftipopago]").val();
        var readOnlySelects = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11');
        var descInfoProveedorTipoPago = '';
        let selectOptionsPagos = "";
        $.each(datosPago.pagos, function (i, value) {
            let defaultSelected = ((value.codigo === '04' && ncfTipoPagoCliente === '') || ncfTipoPagoCliente === value.codigo) ? 'selected' : '';
            let noSelected = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11' && defaultSelected !== 'selected') ? ' disabled' : '';
            descInfoProveedorTipoPago = (datosProveedor.infoproveedor.ncftipopago === value.codigo)
                ? value.descripcion : descInfoProveedorTipoPago;
            selectOptionsPagos += '<option value="' + value.codigo + '"' + defaultSelected + noSelected + '>' + value.descripcion + '</option>';
        });

        var tipoMovimiento = await cargarTipoMovimiento();
        var datosMovimiento = JSON.parse(tipoMovimiento);

        let selectOptionsMovimientos = "";
        $.each(datosMovimiento.movimientos, function (i, value) {
            let defaultSelected = (value.codigo === '09') ? 'selected' : '';
            let noSelected = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11' && defaultSelected !== 'selected') ? ' disabled' : '';
            selectOptionsMovimientos += '<option value="' + value.codigo + '"' + defaultSelected + noSelected + '>' + value.descripcion + '</option>';
        });

        let message = setBusinessDocViewModalSave(
            'Proveedor',
            readOnlySelects,
            descInfoProveedorTipoComprobante,
            descInfoProveedorTipoPago,
            selectTiposNCF,
            selectOptionsPagos,
            selectOptionsMovimientos
        );

        executeModal(
            'completeNCFData',
            'Complete la información faltante',
            message,
            'default',
            'saveBussinessDocument'
        );

        $("#btn-document-save").prop("disabled", false);
    }
}


1		/*
2		* Copyright (C) 2021 Joe Nilson <[email protected]>
3		*
4		* This program is free software: you can redistribute it and/or modify
5		* it under the terms of the GNU Lesser General Public License as
6		* published by the Free Software Foundation, either version 3 of the
7		* License, or (at your option) any later version.
8		*
9		* This program is distributed in the hope that it will be useful,
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12		* GNU Lesser General Public License for more details.
13		* You should have received a copy of the GNU Lesser General Public License
14		* along with this program. If not, see <http://www.gnu.org/licenses/>.
15		*/
16	View Code Duplication	function businessDocViewSubjectChanged()
		0 ignored issues – show Duplication introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
17		{
18		var data = {};
19		$.each($("#" + businessDocViewFormName).serializeArray(), function (key, value) {
		0 ignored issues – show Bug introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report The variable `businessDocViewFormName` seems to be never declared. If this is a global, consider adding a `/** global: businessDocViewFormName */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
20		data[value.name] = value.value;
21		});
22		data.action = "subject-changed";
23		logConsole(data, "subject-changed");
24
25		$.ajax({
26		type: "POST",
27		url: businessDocViewUrl,
		0 ignored issues – show Bug introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report The variable `businessDocViewUrl` seems to be never declared. If this is a global, consider adding a `/** global: businessDocViewUrl */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
28		dataType: "json",
29		data: data,
30		success: function (results) {
31		$("#doc_codpago").val(results.codpago);
32		$("#doc_codserie").val(results.codserie);
33		$("#formEditFacturaProveedor select[name=ncftipopago]").val(results.ncftipopago);
34
35		/**
36		* Review the doc_codsubtipodoc existence,
37		* if it exist we put the value from the customer data
38		*/
39		if ($("#doc_codsubtipodoc").length !== 0) {
40		$("#doc_codsubtipodoc").val(results.codsubtipodoc);
41		}
42		logConsole(results.codsubtipodoc,"codsubtipodoc");
43		/**
44		* Review the doc_codopersaciondoc existence,
45		* if it exist we put the value from the customer data
46		*/
47		if ($("#doc_codoperaciondoc").length !== 0) {
48		$("#doc_codoperaciondoc").val(results.codoperaciondoc);
49		}
50		logConsole(results.codoperaciondoc,"codoperaciondoc");
51
52		logConsole(results,"results");
53
54		businessDocViewRecalculate();
55		},
56		error: function (xhr, status, error) {
		0 ignored issues – show Unused Code introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report The parameter `status` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report The parameter `error` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
57		alert(xhr.responseText);
		0 ignored issues – show Debugging Code Best Practice introduced 2020-12-05 21:51 UTC by Report Bug Copy Issue Report The `alert` UI element is often considered obtrusive and is generally only used as a temporary measure. Consider replacing it with another UI element. Loading history...
58		}
59		});
60		}
61
62		async function cargarInfoProveedor()
63		{
64		return $.ajax({
65		url: 'ListNCFTipo',
66		async: true,
67		data: {'action': 'busca_infoproveedor', 'codproveedor': $("#codproveedorAutocomplete").val()},
68		type: 'POST',
69		datatype: 'json',
70		success: function (response) {
71		let data = JSON.parse(response);
72		return data;
73		},
74		error: function (xhr, status) {
75		alert('Ha ocurrido algún tipo de error ' + status);
		0 ignored issues – show Debugging Code Best Practice introduced 2021-07-26 00:19 UTC by Report Bug Copy Issue Report The `alert` UI element is often considered obtrusive and is generally only used as a temporary measure. Consider replacing it with another UI element. Loading history...
76		}
77		});
78		}
79
80		async function cargarTipoPago()
81		{
82		return $.ajax({
83		url: 'ListNCFTipoPago',
84		async: true,
85		data: {'action': 'busca_pago', 'tipopago': '02'},
86		type: 'POST',
87		datatype: 'json',
88		success: function (response) {
89		let data = JSON.parse(response);
90		return data;
91		},
92		error: function (xhr, status) {
93		alert('Ha ocurrido algún tipo de error ' + status);
		0 ignored issues – show Debugging Code Best Practice introduced 2021-07-26 00:19 UTC by Report Bug Copy Issue Report The `alert` UI element is often considered obtrusive and is generally only used as a temporary measure. Consider replacing it with another UI element. Loading history...
94		}
95		});
96		}
97
98		async function cargarTipoMovimiento()
99		{
100		return $.ajax({
101		url: 'ListNCFTipoMovimiento',
102		async: true,
103		data: {'action': 'busca_movimiento', 'tipomovimiento': 'COM'},
104		type: 'POST',
105		datatype: 'json',
106		success: function (response) {
107		let data = JSON.parse(response);
108		return data;
109		},
110		error: function (xhr, status) {
111		alert('Ha ocurrido algún tipo de error ' + status);
		0 ignored issues – show Debugging Code Best Practice introduced 2022-01-16 02:04 UTC by Report Bug Copy Issue Report The `alert` UI element is often considered obtrusive and is generally only used as a temporary measure. Consider replacing it with another UI element. Loading history...
112		}
113		});
114		}
115
116		async function businessDocViewSave()
117		{
118		if ($("#codproveedorAutocomplete").val() === '') {
119		executeModal('errorNoProveedorDetectado','No hay Proveedor','Debe seleccionar un proveedor primero!', 'warning', '');
120		} else {
121		$("#btn-document-save").prop("disabled", true);
122		var infoProveedor = await cargarInfoProveedor();
123		logConsole(infoProveedor, 'infoProveedor');
124		var datosProveedor = JSON.parse(infoProveedor);
125
126		var tipoPago = await cargarTipoPago();
127		var datosPago = JSON.parse(tipoPago);
128
129		var tipoNCFs = await cargarTipoNCF('Compras');
130		logConsole(tipoNCFs, 'tipoNCFs');
131		var datosTipoNCFs = JSON.parse(tipoNCFs);
132		let selectTiposNCF = "";
133		var descInfoProveedorTipoComprobante = '';
134		var formTipoComprobante = $("#formEditFacturaProveedor select[name=tipocomprobante]").val();
135		var formNumeroNCF = $("#formEditFacturaProveedor input[name=numproveedor]").val();
136		var formNumProveedorType = formNumeroNCF.slice(-10, -8);
137		var tipoComprobanteActivo = (formTipoComprobante !== '') ? formTipoComprobante : formNumProveedorType;
138		var tipoComprobanteActivo = (tipoComprobanteActivo === '') ? '01' : tipoComprobanteActivo;
		0 ignored issues – show Comprehensibility Naming Best Practice introduced 2022-01-16 02:04 UTC by Report Bug Copy Issue Report The variable `tipoComprobanteActivo` already seems to be declared on line `137`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
139		var descDefault = datosTipoNCFs.tipocomprobantes[0].descripcion;
140		$.each(datosTipoNCFs.tipocomprobantes, function (i, value) {
141		let defaultSelected = (tipoComprobanteActivo === value.tipocomprobante) ? 'selected' : '';
142		descInfoProveedorTipoComprobante = (formNumProveedorType === value.tipocomprobante)
143		? value.descripcion : descDefault;
144		selectTiposNCF += '<option value="' + value.tipocomprobante + '"' + defaultSelected + '>' + value.descripcion + '</option>';
145		});
146
147		var ncfTipoPagoCliente = $("#formEditFacturaProveedor select[name=ncftipopago]").val();
148		var readOnlySelects = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11');
149		var descInfoProveedorTipoPago = '';
150		let selectOptionsPagos = "";
151		$.each(datosPago.pagos, function (i, value) {
152		let defaultSelected = ((value.codigo === '04' && ncfTipoPagoCliente === '') \|\| ncfTipoPagoCliente === value.codigo) ? 'selected' : '';
153		let noSelected = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11' && defaultSelected !== 'selected') ? ' disabled' : '';
154		descInfoProveedorTipoPago = (datosProveedor.infoproveedor.ncftipopago === value.codigo)
155		? value.descripcion : descInfoProveedorTipoPago;
156		selectOptionsPagos += '<option value="' + value.codigo + '"' + defaultSelected + noSelected + '>' + value.descripcion + '</option>';
157		});
158
159		var tipoMovimiento = await cargarTipoMovimiento();
160		var datosMovimiento = JSON.parse(tipoMovimiento);
161
162		let selectOptionsMovimientos = "";
163		$.each(datosMovimiento.movimientos, function (i, value) {
164		let defaultSelected = (value.codigo === '09') ? 'selected' : '';
165		let noSelected = ($("#formPurchaseDocumentLine #doc_idestado").val() === '11' && defaultSelected !== 'selected') ? ' disabled' : '';
166		selectOptionsMovimientos += '<option value="' + value.codigo + '"' + defaultSelected + noSelected + '>' + value.descripcion + '</option>';
167		});
168
169		let message = setBusinessDocViewModalSave(
170		'Proveedor',
171		readOnlySelects,
172		descInfoProveedorTipoComprobante,
173		descInfoProveedorTipoPago,
174		selectTiposNCF,
175		selectOptionsPagos,
176		selectOptionsMovimientos
177		);
178
179		executeModal(
180		'completeNCFData',
181		'Complete la información faltante',
182		message,
183		'default',
184		'saveBussinessDocument'
185		);
186
187		$("#btn-document-save").prop("disabled", false);
188		}
189		}
190

joenilson / fsRepublicaDominicana

Push — master ( 88ea97...aa75e3 )

EditFacturaProveedor.js ➔ businessDocViewSave F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like