FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model\FacturaCliente

Complexity

Total Complexity

1

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	saveInsert()	0	14	1

<?php
/**
 * Copyright (C) 2020 joenilson.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 * MA 02110-1301  USA
 */

namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;

use FacturaScripts\Plugins\fsRepublicaDominicana\Model\NCFRango;
use FacturaScripts\Dinamic\Model\Cliente;

This use statement conflicts with another class in this namespace, FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model\Cliente. Consider defining an alias.

The type FacturaScripts\Dinamic\Model\Cliente was not found. Maybe you did not declare it correctly or list all dependencies?

use FacturaScripts\Core\App\AppSettings;

The type FacturaScripts\Core\App\AppSettings was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Description of FacturaCliente
 *
 * @author joenilson
 */
class FacturaCliente
{
    /**
     *
     * @var date

The type FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model\date was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public $ncffechavencimiento;
    /**
     * @var string
     */
    public $tipocomprobante;
    /**
     *
     * @var string
     */
    public $ncftipopago;
    /**
     *
     * @var string
     */
    public $ncftipoanulacion;
    
    public function saveInsert()
    {
        return function () {
            $ncfrango = new NCFRango();
            $cliente = new Cliente();
            $actualCliente = $cliente->get($this->codcliente);

The property codcliente does not exist on FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model\FacturaCliente. Did you maybe forget to declare it?

            $actualCliente->idempresa = AppSettings::get('default', 'idempresa');
            $ncfRangoToUse = $ncfrango->getByTipoComprobante($actualCliente->idempresa, $actualCliente->codsubtipodoc);
            $ncf = $ncfRangoToUse->generateNCF();
            $this->numero2 = $ncf;

The property numero2 does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->ncffechavencimiento = $ncfRangoToUse->fechavencimiento;
            $this->tipocomprobante = $ncfRangoToUse->tipocomprobante;
            $ncfRangoToUse->correlativo++;
            $ncfRangoToUse->save();
        };
    }
}