Passed
Push — master ( 48fa57...539c4e )
by Joe Nilson
01:55
created
Mod/PurchasesFooterMod.php 1 patch
Spacing   +23 added lines, -27 removed lines patch added patch discarded remove patch
@@ -29,21 +29,21 @@  discard block
 block discarded – undo
29 29
 
30 30
 class PurchasesFooterMod implements PurchasesModInterface
31 31
 {
32
-    public function apply(PurchaseDocument &$model, array $formData, User $user)
32
+    public function apply(PurchaseDocument & $model, array $formData, User $user)
33 33
     {
34 34
         // TODO: Implement apply() method.
35 35
     }
36 36
 
37
-    public function applyBefore(PurchaseDocument &$model, array $formData, User $user)
37
+    public function applyBefore(PurchaseDocument & $model, array $formData, User $user)
38 38
     {
39 39
         // TODO: Implement applyBefore() method.
40 40
         if ($model->modelClassName() === 'FacturaProveedor') {
41
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
42
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
43
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
45
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
41
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
42
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
43
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
45
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
47 47
         }
48 48
     }
49 49
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     public function newFields(): array
56 56
     {
57 57
         // TODO: Implement newFields() method.
58
-        return ['numeroncf','tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
58
+        return ['numeroncf', 'tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
59 59
     }
60 60
 
61 61
     public function renderField(Translator $i18n, PurchaseDocument $model, string $field): ?string
@@ -104,15 +104,14 @@  discard block
 block discarded – undo
104 104
         $options = ['<option value="">------</option>'];
105 105
         foreach ($tipoComprobante as $row) {
106 106
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
107
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
108
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
107
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
109 108
         }
110 109
 
111 110
         $attributes = ($model->editable || $model->numeroncf === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
112 111
         return '<div class="col-sm-3">'
113 112
             . '<div class="form-group">'
114 113
             .  $i18n->trans('tipocomprobante')
115
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
114
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
116 115
             . '</div>'
117 116
             . '</div>';
118 117
     }
@@ -136,15 +135,14 @@  discard block
 block discarded – undo
136 135
         $options = ['<option value="">------</option>'];
137 136
         foreach ($tipoPago as $row) {
138 137
             $options[] = ($row->codigo === $invoiceTipoPago) ?
139
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
140
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
138
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
141 139
         }
142 140
 
143 141
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
144 142
         return '<div class="col-sm-2">'
145 143
             . '<div class="form-group">'
146 144
             .  $i18n->trans('ncf-payment-type')
147
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
145
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
148 146
             . '</div>'
149 147
             . '</div>';
150 148
     }
@@ -162,15 +160,14 @@  discard block
 block discarded – undo
162 160
         $options = ['<option value="">------</option>'];
163 161
         foreach ($tipoMovimiento as $row) {
164 162
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
165
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
166
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
163
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
167 164
         }
168 165
 
169 166
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
170 167
         return '<div class="col-sm-3">'
171 168
             . '<div class="form-group">'
172 169
             .  $i18n->trans('ncf-movement-type')
173
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
170
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
174 171
             . '</div>'
175 172
             . '</div>';
176 173
     }
@@ -188,15 +185,14 @@  discard block
 block discarded – undo
188 185
         $options = ['<option value="">------</option>'];
189 186
         foreach ($tipoAnulacion as $row) {
190 187
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
191
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
192
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
188
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
193 189
         }
194 190
 
195 191
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'name="ncftipoanulacion" readonly=""';
196 192
         return '<div class="col-sm-2">'
197 193
             . '<div class="form-group">'
198 194
             .  $i18n->trans('ncf-cancellation-type')
199
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
195
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
200 196
             . '</div>'
201 197
             . '</div>';
202 198
     }
@@ -208,9 +204,9 @@  discard block
 block discarded – undo
208 204
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
209 205
             : '';
210 206
         return '<div class="col-sm-2">'
211
-            . '<div class="form-group">' . $i18n->trans('due-date')
212
-            . '<input type="date" ' . $attributes . ' value="'
213
-            . $ncfFechaVencimiento . '" class="form-control"/>'
207
+            . '<div class="form-group">'.$i18n->trans('due-date')
208
+            . '<input type="date" '.$attributes.' value="'
209
+            . $ncfFechaVencimiento.'" class="form-control"/>'
214 210
             . '</div>'
215 211
             . '</div>';
216 212
     }
@@ -223,11 +219,11 @@  discard block
 block discarded – undo
223 219
             . '<div class="form-group">'
224 220
             . $i18n->trans('desc-numeroncf-purchases')
225 221
             . '<div class="input-group">'
226
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
222
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
227 223
             . '<div class="input-group-append">'
228
-            . '<button class="btn ' . $btnColor .' btn-spin-action" id="btnVerifyNCF"'
224
+            . '<button class="btn '.$btnColor.' btn-spin-action" id="btnVerifyNCF"'
229 225
             . 'onclick="purchasesNCFVerify()" '
230
-            . 'title="'. $i18n->trans('verify-numproveedor')
226
+            . 'title="'.$i18n->trans('verify-numproveedor')
231 227
             .'" type="button">'
232 228
             . '<i id="iconBtnVerify" class="fas fa-search fa-fw"></i>'
233 229
             . '</button>'
Please login to merge, or discard this patch.
Model/Join/FiscalReport606.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -74,18 +74,18 @@  discard block
 block discarded – undo
74 74
     protected function getGroupFields(): string
75 75
     {
76 76
         //return parent::getGroupFields(); // TODO: Change the autogenerated stub
77
-        return  static::MAIN_TABLE.'.idfactura, ' .
78
-                static::MAIN_TABLE.'.idempresa, ' .
79
-                static::MAIN_TABLE.'.codalmacen, ' .
80
-                static::MAIN_TABLE.'.cifnif, ' .
81
-                static::MAIN_TABLE.'.ncftipomovimiento, ' .
82
-                static::MAIN_TABLE.'.numeroncf, ' .
83
-                static::SECONDARY_TABLE_ALIAS.'.numeroncf, ' .
84
-                static::MAIN_TABLE.'.fecha, ' .
85
-                static::RECIBOSPROV_TABLE.'.fechapago, ' .
86
-                static::ESTADOSDOC_TABLE.'.nombre, ' .
87
-                static::MAIN_TABLE.'.neto, ' .
88
-                static::MAIN_TABLE.'.totaliva' .
77
+        return  static::MAIN_TABLE.'.idfactura, '.
78
+                static::MAIN_TABLE.'.idempresa, '.
79
+                static::MAIN_TABLE.'.codalmacen, '.
80
+                static::MAIN_TABLE.'.cifnif, '.
81
+                static::MAIN_TABLE.'.ncftipomovimiento, '.
82
+                static::MAIN_TABLE.'.numeroncf, '.
83
+                static::SECONDARY_TABLE_ALIAS.'.numeroncf, '.
84
+                static::MAIN_TABLE.'.fecha, '.
85
+                static::RECIBOSPROV_TABLE.'.fechapago, '.
86
+                static::ESTADOSDOC_TABLE.'.nombre, '.
87
+                static::MAIN_TABLE.'.neto, '.
88
+                static::MAIN_TABLE.'.totaliva'.
89 89
             ' ';
90 90
     }
91 91
 
@@ -96,16 +96,16 @@  discard block
 block discarded – undo
96 96
     protected function getSQLFrom(): string
97 97
     {
98 98
         return static::MAIN_TABLE
99
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
100
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
101
-            . ' LEFT JOIN '. static::RECIBOSPROV_TABLE . ' ON ('
102
-            . static::MAIN_TABLE . '.idfactura = ' . static::RECIBOSPROV_TABLE . '.idfactura)'
103
-            . ' LEFT JOIN '. static::LINES_TABLE . ' ON ('
104
-            . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
105
-            . ' LEFT JOIN '. static::PRODS_TABLE . ' ON ('
106
-            . static::LINES_TABLE . '.referencia = ' . static::PRODS_TABLE . '.referencia)'
107
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
108
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
99
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
100
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
101
+            . ' LEFT JOIN '.static::RECIBOSPROV_TABLE.' ON ('
102
+            . static::MAIN_TABLE.'.idfactura = '.static::RECIBOSPROV_TABLE.'.idfactura)'
103
+            . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
104
+            . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
105
+            . ' LEFT JOIN '.static::PRODS_TABLE.' ON ('
106
+            . static::LINES_TABLE.'.referencia = '.static::PRODS_TABLE.'.referencia)'
107
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
108
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
109 109
     }
110 110
 
111 111
     /**
Please login to merge, or discard this patch.
Extension/Controller/EditCliente.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -29,10 +29,10 @@  discard block
 block discarded – undo
29 29
 {
30 30
     public function createViews(): Closure
31 31
     {
32
-        return function () {
33
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
34
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
35
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
32
+        return function() {
33
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
34
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
35
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
36 36
             $ncfTipo = new NCFTipo();
37 37
             $ncfTipos = $ncfTipo->allFor('ventas', 'suma');
38 38
             $customValues = [];
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 
62 62
     public function execPreviousAction()
63 63
     {
64
-        return function ($action) {
64
+        return function($action) {
65 65
             switch ($action) {
66 66
                 case 'busca_rnc':
67 67
                     $this->setTemplate(false);
Please login to merge, or discard this patch.
Extension/Controller/EditProveedor.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@  discard block
 block discarded – undo
28 28
 
29 29
     public function createViews(): Closure
30 30
     {
31
-        return function () {
32
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
33
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
34
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
31
+        return function() {
32
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
33
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
34
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/BusquedaRNCDGII.js');
35 35
             $ncfTipoPago = new NCFTipoPago();
36 36
             $ncfTiposPago = $ncfTipoPago->findAllByTipopago('02');
37 37
             $customValuesNTP = [];
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
     public function execPreviousAction()
50 50
     {
51
-        return function ($action) {
51
+        return function($action) {
52 52
             switch ($action) {
53 53
                 case 'busca_rnc':
54 54
                     $this->setTemplate(false);
Please login to merge, or discard this patch.
Controller/FiscalReports.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             $fileName = 'MyFiles/DGII_F_'.$reportCode.'_'.$this->empresa->cifnif.'_'.$year.'_'.$month.'.TXT';
117 117
             $commonFunctions->exportTXT($reportCode, $fileName, $this->empresa->cifnif, $year, $month, $whereReport);
118 118
             $this->response->headers->set('Content-type', 'text/plain');
119
-            $this->response->headers->set('Content-Disposition', 'attachment;filename=' . $fileName);
119
+            $this->response->headers->set('Content-Disposition', 'attachment;filename='.$fileName);
120 120
             $this->response->setContent(
121 121
                 file_get_contents(
122 122
                 \FS_FOLDER
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
         $periodStartDate = \date('Y-m-01');
224 224
         $periodEndDate = \date('Y-m-d');
225 225
         PeriodTools::applyPeriod('last-month', $periodStartDate, $periodEndDate);
226
-        if (in_array($this->request->request->get('filterfecha'), ['',null], true) === false) {
226
+        if (in_array($this->request->request->get('filterfecha'), ['', null], true) === false) {
227 227
             PeriodTools::applyPeriod($this->request->request->get('filterfecha'), $periodStartDate, $periodEndDate);
228 228
         } else {
229 229
             $periodStartDate = $this->request->request->get('filterstartfecha') ?? $periodStartDate;
Please login to merge, or discard this patch.
Extension/Controller/EditFacturaProveedor.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -30,16 +30,16 @@  discard block
 block discarded – undo
30 30
 {
31 31
     public function createViews(): Closure
32 32
     {
33
-        return function () {
33
+        return function() {
34 34
             parent::createViews();
35
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
36
-            AssetManager::add('js', \FS_ROUTE . '/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
35
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonModals.js');
36
+            AssetManager::add('js', \FS_ROUTE.'/Plugins/fsRepublicaDominicana/Assets/JS/CommonDomFunctions.js');
37 37
         };
38 38
     }
39 39
 
40 40
     public function execPreviousAction()
41 41
     {
42
-        return function ($action) {
42
+        return function($action) {
43 43
             switch ($action) {
44 44
                 case 'busca_tipo':
45 45
                     $this->setTemplate(false);
@@ -104,21 +104,21 @@  discard block
 block discarded – undo
104 104
         if (!$verificacion) {
105 105
             echo json_encode(['success' => true], JSON_THROW_ON_ERROR);
106 106
         } else {
107
-            $message = "Factura: " . $verificacion[0]->idfactura . " Fecha: " . $verificacion[0]->fecha;
107
+            $message = "Factura: ".$verificacion[0]->idfactura." Fecha: ".$verificacion[0]->fecha;
108 108
             echo json_encode(['error' => true, 'message' => $message], JSON_THROW_ON_ERROR);
109 109
         }
110 110
     }
111 111
 
112 112
     public function ncftipo()
113 113
     {
114
-        return function () {
114
+        return function() {
115 115
             return NCFTipo::allVentas();
116 116
         };
117 117
     }
118 118
 
119 119
     public function ncftipoanulacion()
120 120
     {
121
-        return function () {
121
+        return function() {
122 122
             $tiposAnulacion = new NCFTipoAnulacion();
123 123
             return $tiposAnulacion->all();
124 124
         };
Please login to merge, or discard this patch.