Passed
Push — master ( b8d623...b21d4a )
by Joe Nilson
01:59
created
Model/NCFTipoAnulacion.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -75,21 +75,21 @@
 block discarded – undo
75 75
     public function install()
76 76
     {
77 77
         parent::install();
78
-        return "INSERT INTO rd_ncftipoanulacion (codigo, descripcion, estado) VALUES " .
79
-            "('01','Deterioro de Factura Pre-Imprensa',true), " .
80
-             "('02','Errores de Impresión (Factura Pre-Impresa)',true), " .
81
-             "('03','Impresión defectuosa',true), " .
82
-             "('04','Duplicidad de Factura',true), " .
83
-             "('05','Corrección de la Información',true), " .
84
-             "('06','Cambio de Productos',true), " .
85
-             "('07','Devolución de Productos',true), " .
78
+        return "INSERT INTO rd_ncftipoanulacion (codigo, descripcion, estado) VALUES ".
79
+            "('01','Deterioro de Factura Pre-Imprensa',true), ".
80
+             "('02','Errores de Impresión (Factura Pre-Impresa)',true), ".
81
+             "('03','Impresión defectuosa',true), ".
82
+             "('04','Duplicidad de Factura',true), ".
83
+             "('05','Corrección de la Información',true), ".
84
+             "('06','Cambio de Productos',true), ".
85
+             "('07','Devolución de Productos',true), ".
86 86
              "('08','Omisión de Productos',true);";
87 87
     }
88 88
     
89 89
     public function restoreData()
90 90
     {
91 91
         $dataBase = new DataBase();
92
-        $sqlClean = "DELETE FROM " . $this->tableName() . ";";
92
+        $sqlClean = "DELETE FROM ".$this->tableName().";";
93 93
         $dataBase->exec($sqlClean);
94 94
         foreach ($this->arrayTipoAnulacion as $arrayItem) {
95 95
             $initialData = new NCFTipoAnulacion($arrayItem);
Please login to merge, or discard this patch.
Model/NCFRango.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
                 . $idempresa
185 185
                 . ' AND tipocomprobante = '
186 186
                 . $dataBase->var2str($tipocomprobante)
187
-                . ' AND estado = ' . $dataBase->var2str(true)
187
+                . ' AND estado = '.$dataBase->var2str(true)
188 188
                 . ';';
189 189
         $data = $dataBase->select($sql);
190 190
         if (empty($data) === true || in_array($data[0], [null, ''], true)) {
Please login to merge, or discard this patch.
Model/NCFTipo.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -158,17 +158,17 @@  discard block
 block discarded – undo
158 158
         parent::install();
159 159
         $sql = "INSERT INTO rd_ncftipo (".
160 160
             "tipocomprobante, descripcion, estado, clasemovimiento, ventas, compras, contribuyente".
161
-            " ) VALUES " .
162
-            "('01','FACTURA DE CREDITO FISCAL',true, 'suma','Y','Y','Y')," .
163
-            "('02','FACTURA DE CONSUMO',true, 'suma','Y','Y','Y')," .
164
-            "('03','NOTA DE DEBITO',true, 'suma','Y','Y','N')," .
165
-            "('04','NOTA DE CREDITO',true, 'resta','Y','Y','N')," .
166
-            "('11','COMPROBANTE DE COMPRAS',true, 'suma','N','Y','Y')," .
167
-            "('12','REGISTRO UNICO DE INGRESOS',true, 'suma','Y','N','N')," .
168
-            "('13','COMPROBANTE PARA GASTOS MENORES',true, 'suma','N','Y','N')," .
169
-            "('14','COMPROBANTE DE REGIMENES ESPECIALES',true, 'suma','Y','Y','Y')," .
170
-            "('15','COMPROBANTE GUBERNAMENTAL',true, 'suma','Y','Y','Y')," .
171
-            "('16','COMPROBANTE PARA EXPORTACIONES',true, 'suma','Y','N','Y')," .
161
+            " ) VALUES ".
162
+            "('01','FACTURA DE CREDITO FISCAL',true, 'suma','Y','Y','Y'),".
163
+            "('02','FACTURA DE CONSUMO',true, 'suma','Y','Y','Y'),".
164
+            "('03','NOTA DE DEBITO',true, 'suma','Y','Y','N'),".
165
+            "('04','NOTA DE CREDITO',true, 'resta','Y','Y','N'),".
166
+            "('11','COMPROBANTE DE COMPRAS',true, 'suma','N','Y','Y'),".
167
+            "('12','REGISTRO UNICO DE INGRESOS',true, 'suma','Y','N','N'),".
168
+            "('13','COMPROBANTE PARA GASTOS MENORES',true, 'suma','N','Y','N'),".
169
+            "('14','COMPROBANTE DE REGIMENES ESPECIALES',true, 'suma','Y','Y','Y'),".
170
+            "('15','COMPROBANTE GUBERNAMENTAL',true, 'suma','Y','Y','Y'),".
171
+            "('16','COMPROBANTE PARA EXPORTACIONES',true, 'suma','Y','N','Y'),".
172 172
             "('17','COMPROBANTE PARA PAGOS AL EXTERIOR',true, 'suma','N', 'Y','Y');";
173 173
         return($sql);
174 174
     }
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     public function restoreData()
177 177
     {
178 178
         $dataBase = new DataBase();
179
-        $sqlClean = "DELETE FROM " . $this->tableName() . ";";
179
+        $sqlClean = "DELETE FROM ".$this->tableName().";";
180 180
         $dataBase->exec($sqlClean);
181 181
         foreach ($this->arrayComprobantes as $arrayItem) {
182 182
             $initialData = new NCFTipo($arrayItem);
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 
188 188
     public function allFor($type = "ventas", $movimiento = "suma")
189 189
     {
190
-        $where = [new DataBaseWhere($type, 'Y'),new DataBaseWhere('clasemovimiento', $movimiento)];
190
+        $where = [new DataBaseWhere($type, 'Y'), new DataBaseWhere('clasemovimiento', $movimiento)];
191 191
         return $this->all($where, ['tipocomprobante' => 'ASC'], 0, 50);
192 192
     }
193 193
 
Please login to merge, or discard this patch.
Model/Join/FiscalReport608.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -39,14 +39,14 @@  discard block
 block discarded – undo
39 39
             'idempresa' => static::MAIN_TABLE.'.idempresa',
40 40
             'codalmacen' => static::MAIN_TABLE.'.codalmacen',
41 41
             'ncf' => static::MAIN_TABLE.'.numeroncf',
42
-            'tipoanulacion' => 'CASE WHEN ' .
43
-                                static::ESTADOSDOC_TABLE . '.nombre = \'Anulada\' AND ' .
44
-                                static::MAIN_TABLE.'.ncftipoanulacion is null ' .
45
-                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE ' .
46
-                                'concat(' . static::MAIN_TABLE.'.ncftipoanulacion, \' - \', ' .
42
+            'tipoanulacion' => 'CASE WHEN '.
43
+                                static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\' AND '.
44
+                                static::MAIN_TABLE.'.ncftipoanulacion is null '.
45
+                                'THEN CONCAT(\'05\',\' - \',\'Corrección de la Información\') ELSE '.
46
+                                'concat('.static::MAIN_TABLE.'.ncftipoanulacion, \' - \', '.
47 47
                                 static::NCFCANCELTYPE_TABLE.'.descripcion) END',
48 48
             'fecha' => $dateFormat.'('.static::MAIN_TABLE.'.fecha,\''.$dateFormatString.'\')',
49
-            'estado' => 'CASE WHEN ' . static::ESTADOSDOC_TABLE .
49
+            'estado' => 'CASE WHEN '.static::ESTADOSDOC_TABLE.
50 50
                         '.nombre = \'Emitida\' THEN \'Activo\' ELSE \'Anulado\' END',
51 51
         ];
52 52
         return $data;
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
     protected function getSQLFrom(): string
60 60
     {
61 61
         return static::MAIN_TABLE
62
-            . ' JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
63
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
64
-            . ' LEFT JOIN ' . static::NCFCANCELTYPE_TABLE . ' ON ('
65
-            . static::MAIN_TABLE . '.ncftipoanulacion = ' . static::NCFCANCELTYPE_TABLE . '.codigo)';
62
+            . ' JOIN '.static::ESTADOSDOC_TABLE.' ON ('
63
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '.static::ESTADOSDOC_TABLE.'.nombre = \'Anulada\')'
64
+            . ' LEFT JOIN '.static::NCFCANCELTYPE_TABLE.' ON ('
65
+            . static::MAIN_TABLE.'.ncftipoanulacion = '.static::NCFCANCELTYPE_TABLE.'.codigo)';
66 66
     }
67 67
 
68 68
     /**
Please login to merge, or discard this patch.
Model/Join/FiscalReport607.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -92,10 +92,10 @@
 block discarded – undo
92 92
     protected function getSQLFrom(): string
93 93
     {
94 94
         return static::MAIN_TABLE
95
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
96
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
97
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
98
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado AND '
95
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
96
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
97
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
98
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado AND '
99 99
             . static::ESTADOSDOC_TABLE.'.nombre != \'Anulada\')';
100 100
     }
101 101
 
Please login to merge, or discard this patch.
Extension/Model/FacturaCliente.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
     public function saveBefore(): Closure
67 67
     {
68
-        return function () {
68
+        return function() {
69 69
 
70 70
             $ncfrango = new NCFRango();
71 71
             $cliente = new Cliente();
@@ -103,11 +103,11 @@  discard block
 block discarded – undo
103 103
 
104 104
     public function all(): Closure
105 105
     {
106
-        return function () {
106
+        return function() {
107 107
             $this->facturarectnumero2 = '';
108 108
             if ($this->idfacturarect !== '') {
109 109
                 $facturaRectificativa = $this->get($this->idfacturarect);
110
-                $this->loadFromData(['facturarectnumero2' => 'SI' ]);
110
+                $this->loadFromData(['facturarectnumero2' => 'SI']);
111 111
                 $this->facturarectnumero2 = $facturaRectificativa->numero2;
112 112
             } else {
113 113
                 $this->loadFromData(['facturarectnumero2' => 'NO HAY']);
Please login to merge, or discard this patch.
Lib/Export/DgiiExport.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -81,10 +81,10 @@
 block discarded – undo
81 81
     /**
82 82
      * @inheritDoc
83 83
      */
84
-    public function show(Response &$response)
84
+    public function show(Response & $response)
85 85
     {
86 86
         $response->headers->set('Content-Type', 'text/text; charset=utf-8');
87
-        $response->headers->set('Content-Disposition', 'attachment;filename=' . $this->getFileName() . '.TXT');
87
+        $response->headers->set('Content-Disposition', 'attachment;filename='.$this->getFileName().'.TXT');
88 88
         $response->setContent($this->getDoc());
89 89
     }
90 90
 }
91 91
\ No newline at end of file
Please login to merge, or discard this patch.
Mod/SalesFooterMod.php 1 patch
Spacing   +20 added lines, -24 removed lines patch added patch discarded remove patch
@@ -28,21 +28,21 @@  discard block
 block discarded – undo
28 28
 
29 29
 class SalesFooterMod implements SalesModInterface
30 30
 {
31
-    public function apply(SalesDocument &$model, array $formData, User $user)
31
+    public function apply(SalesDocument & $model, array $formData, User $user)
32 32
     {
33 33
         // TODO: Implement apply() method.
34 34
     }
35 35
 
36
-    public function applyBefore(SalesDocument &$model, array $formData, User $user)
36
+    public function applyBefore(SalesDocument & $model, array $formData, User $user)
37 37
     {
38 38
         // TODO: Implement applyBefore() method.
39 39
         if ($model->modelClassName() === 'FacturaCliente') {
40
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
41
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
42
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
43
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
44
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
45
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
40
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
41
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
42
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
43
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
44
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
45
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
46 46
         }
47 47
     }
48 48
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         if (!$model->editable) {
106 106
             $invoiceTipoComprobante = $model->tipocomprobante;
107 107
         } elseif ($model->editable === true && ($cliente->tipocomprobante !== $model->tipocomprobante) && $model->tipocomprobante !== null) {
108
-            $invoiceTipoComprobante =  $model->tipocomprobante;
108
+            $invoiceTipoComprobante = $model->tipocomprobante;
109 109
         } elseif ($model->editable === true && ($cliente->tipocomprobante === $model->tipocomprobante) && $model->tipocomprobante !== null) {
110 110
             $invoiceTipoComprobante = $cliente->tipocomprobante;
111 111
         }
@@ -113,15 +113,14 @@  discard block
 block discarded – undo
113 113
         $options = ['<option value="">------</option>'];
114 114
         foreach ($tipoComprobante as $row) {
115 115
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
116
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
117
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
116
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
118 117
         }
119 118
 
120 119
         $attributes = ($model->editable || $model->numeroncf === '') ? 'id="tipocomprobante" name="tipocomprobante" required="" onChange="verificarCorrelativoNCF(this.value,\'Ventas\')"' : 'disabled=""';
121 120
         return '<div class="col-sm-3">'
122 121
             . '<div class="form-group">'
123 122
             .  $i18n->trans('tipocomprobante')
124
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
123
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
125 124
             . '</div>'
126 125
             . '</div>';
127 126
     }
@@ -145,15 +144,14 @@  discard block
 block discarded – undo
145 144
         $options = ['<option value="">------</option>'];
146 145
         foreach ($tipoPago as $row) {
147 146
             $options[] = ($row->codigo === $invoiceTipoPago) ?
148
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
149
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
147
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
150 148
         }
151 149
 
152 150
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
153 151
         return '<div class="col-sm-2">'
154 152
             . '<div class="form-group">'
155 153
             .  $i18n->trans('ncf-payment-type')
156
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
154
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
157 155
             . '</div>'
158 156
             . '</div>';
159 157
     }
@@ -173,15 +171,14 @@  discard block
 block discarded – undo
173 171
         $options = ['<option value="">------</option>'];
174 172
         foreach ($tipoMovimiento as $row) {
175 173
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
176
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
177
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
174
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
178 175
         }
179 176
 
180 177
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
181 178
         return '<div class="col-sm-3">'
182 179
             . '<div class="form-group">'
183 180
             .  $i18n->trans('ncf-movement-type')
184
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
181
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
185 182
             . '</div>'
186 183
             . '</div>';
187 184
     }
@@ -199,15 +196,14 @@  discard block
 block discarded – undo
199 196
         $options = ['<option value="">------</option>'];
200 197
         foreach ($tipoAnulacion as $row) {
201 198
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
202
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
203
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
199
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
204 200
         }
205 201
 
206 202
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'disabled=""';
207 203
         return '<div class="col-sm-2">'
208 204
             . '<div class="form-group">'
209 205
             .  $i18n->trans('ncf-cancellation-type')
210
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
206
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
211 207
             . '</div>'
212 208
             . '</div>';
213 209
     }
@@ -219,8 +215,8 @@  discard block
 block discarded – undo
219 215
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
220 216
             : '';
221 217
         return '<div class="col-sm-2">'
222
-            . '<div class="form-group">' . $i18n->trans('due-date')
223
-            . '<input type="date" ' . $attributes . ' value="' . $ncfFechaVencimiento . '" class="form-control"/>'
218
+            . '<div class="form-group">'.$i18n->trans('due-date')
219
+            . '<input type="date" '.$attributes.' value="'.$ncfFechaVencimiento.'" class="form-control"/>'
224 220
             . '</div>'
225 221
             . '</div>';
226 222
     }
@@ -239,7 +235,7 @@  discard block
 block discarded – undo
239 235
             . '<div class="form-group">'
240 236
             . $i18n->trans('desc-numeroncf-sales')
241 237
             //. '<div class="input-group">'
242
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
238
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
243 239
 //            . '<div class="input-group-append">'
244 240
 //            . '<button class="btn ' . $btnColor .' btn-spin-action" id="btnVerifyNCF"'
245 241
 //            . 'onclick="purchasesNCFVerify()" '
Please login to merge, or discard this patch.
Mod/PurchasesFooterMod.php 1 patch
Spacing   +23 added lines, -27 removed lines patch added patch discarded remove patch
@@ -29,21 +29,21 @@  discard block
 block discarded – undo
29 29
 
30 30
 class PurchasesFooterMod implements PurchasesModInterface
31 31
 {
32
-    public function apply(PurchaseDocument &$model, array $formData, User $user)
32
+    public function apply(PurchaseDocument & $model, array $formData, User $user)
33 33
     {
34 34
         // TODO: Implement apply() method.
35 35
     }
36 36
 
37
-    public function applyBefore(PurchaseDocument &$model, array $formData, User $user)
37
+    public function applyBefore(PurchaseDocument & $model, array $formData, User $user)
38 38
     {
39 39
         // TODO: Implement applyBefore() method.
40 40
         if ($model->modelClassName() === 'FacturaProveedor') {
41
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
42
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
43
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
45
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
41
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
42
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
43
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
45
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
47 47
         }
48 48
     }
49 49
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     public function newFields(): array
56 56
     {
57 57
         // TODO: Implement newFields() method.
58
-        return ['numeroncf','tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
58
+        return ['numeroncf', 'tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion'];
59 59
     }
60 60
 
61 61
     public function renderField(Translator $i18n, PurchaseDocument $model, string $field): ?string
@@ -104,15 +104,14 @@  discard block
 block discarded – undo
104 104
         $options = ['<option value="">------</option>'];
105 105
         foreach ($tipoComprobante as $row) {
106 106
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
107
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
108
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
107
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
109 108
         }
110 109
 
111 110
         $attributes = ($model->editable || $model->numeroncf === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
112 111
         return '<div class="col-sm-3">'
113 112
             . '<div class="form-group">'
114 113
             .  $i18n->trans('tipocomprobante')
115
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
114
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
116 115
             . '</div>'
117 116
             . '</div>';
118 117
     }
@@ -136,15 +135,14 @@  discard block
 block discarded – undo
136 135
         $options = ['<option value="">------</option>'];
137 136
         foreach ($tipoPago as $row) {
138 137
             $options[] = ($row->codigo === $invoiceTipoPago) ?
139
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
140
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
138
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
141 139
         }
142 140
 
143 141
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
144 142
         return '<div class="col-sm-2">'
145 143
             . '<div class="form-group">'
146 144
             .  $i18n->trans('ncf-payment-type')
147
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
145
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
148 146
             . '</div>'
149 147
             . '</div>';
150 148
     }
@@ -162,15 +160,14 @@  discard block
 block discarded – undo
162 160
         $options = ['<option value="">------</option>'];
163 161
         foreach ($tipoMovimiento as $row) {
164 162
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
165
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
166
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
163
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
167 164
         }
168 165
 
169 166
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
170 167
         return '<div class="col-sm-3">'
171 168
             . '<div class="form-group">'
172 169
             .  $i18n->trans('ncf-movement-type')
173
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
170
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
174 171
             . '</div>'
175 172
             . '</div>';
176 173
     }
@@ -188,15 +185,14 @@  discard block
 block discarded – undo
188 185
         $options = ['<option value="">------</option>'];
189 186
         foreach ($tipoAnulacion as $row) {
190 187
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
191
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
192
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
188
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
193 189
         }
194 190
 
195 191
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'name="ncftipoanulacion" readonly=""';
196 192
         return '<div class="col-sm-2">'
197 193
             . '<div class="form-group">'
198 194
             .  $i18n->trans('ncf-cancellation-type')
199
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
195
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
200 196
             . '</div>'
201 197
             . '</div>';
202 198
     }
@@ -208,9 +204,9 @@  discard block
 block discarded – undo
208 204
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
209 205
             : '';
210 206
         return '<div class="col-sm-2">'
211
-            . '<div class="form-group">' . $i18n->trans('due-date')
212
-            . '<input type="date" ' . $attributes . ' value="'
213
-            . $ncfFechaVencimiento . '" class="form-control"/>'
207
+            . '<div class="form-group">'.$i18n->trans('due-date')
208
+            . '<input type="date" '.$attributes.' value="'
209
+            . $ncfFechaVencimiento.'" class="form-control"/>'
214 210
             . '</div>'
215 211
             . '</div>';
216 212
     }
@@ -223,11 +219,11 @@  discard block
 block discarded – undo
223 219
             . '<div class="form-group">'
224 220
             . $i18n->trans('desc-numeroncf-purchases')
225 221
             . '<div class="input-group">'
226
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
222
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
227 223
             . '<div class="input-group-append">'
228
-            . '<button class="btn ' . $btnColor .' btn-spin-action" id="btnVerifyNCF"'
224
+            . '<button class="btn '.$btnColor.' btn-spin-action" id="btnVerifyNCF"'
229 225
             . 'onclick="purchasesNCFVerify()" '
230
-            . 'title="'. $i18n->trans('verify-numproveedor')
226
+            . 'title="'.$i18n->trans('verify-numproveedor')
231 227
             .'" type="button">'
232 228
             . '<i id="iconBtnVerify" class="fas fa-search fa-fw"></i>'
233 229
             . '</button>'
Please login to merge, or discard this patch.