FacturaCliente::saveBefore() - Code Metrics - Inspection of "- Fixed Return Invoice NCF missing value" - joenilson/fsRepublicaDominicana - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b8d623...b21d4a )

by Joe Nilson

created 2023-02-13 00:12 UTC

FacturaCliente::saveBefore() C

↳ Parent: FacturaCliente

Complexity

Conditions	12
Paths	1

Size

Total Lines	41
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	33
nc	1
nop	0
dl	0
loc	41
rs	6.9666
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Copyright (C) 2020 joenilson.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 * MA 02110-1301  USA
 */

namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;

use Closure;
use FacturaScripts\Core\Base\DataBase\DataBaseWhere;
filter:
    dependency_paths: ["lib/*"]
use FacturaScripts\Dinamic\Model\NCFRango;
filter:
    dependency_paths: ["lib/*"]
use FacturaScripts\Dinamic\Model\NCFTipoMovimiento;
filter:
    dependency_paths: ["lib/*"]
use FacturaScripts\Dinamic\Model\Cliente;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use FacturaScripts\Core\App\AppSettings;
filter:
    dependency_paths: ["lib/*"]

/**
 * Description of FacturaCliente
 *
 * @author joenilson
 */
class FacturaCliente
{
    /**
     * @var date
filter:
    dependency_paths: ["lib/*"]
     */
    public $ncffechavencimiento;
    /**
     * @var string
     */
    public $tipocomprobante;
    /**
     *
     * @var string
     */
    public $ncftipopago;
    /**
     *
     * @var string
     */
    public $ncftipomovimiento;
    /**
     *
     * @var string
     */
    public $ncftipoanulacion;

    /**
     * @var string
     */
    public $facturarectnumero2;

    public function saveBefore(): Closure
    {
        return function () {

            $ncfrango = new NCFRango();
            $cliente = new Cliente();
            $appSettins = new AppSettings;
            $actualCliente = $cliente->get($this->codcliente);

            $actualCliente->idempresa = $appSettins::get('default', 'idempresa');
            $this->tipocomprobante = $this->tipocomprobante ?? $actualCliente->tipocomprobante;
            $this->tipocomprobante = $_REQUEST['tipocomprobanter'] ?? $this->tipocomprobante;
            $this->numeroncf = (isset($_REQUEST['tipocomprobanter'])) ? '' : $this->numeroncf;

            if ($this->tipocomprobante !== '' && \in_array($this->numeroncf, ['', null], true)) {
                $tipocomprobante = "02";
                if (($this->tipocomprobante !== null) === true) {
                    $tipocomprobante = $this->tipocomprobante;
                } elseif (($this->tipocomprobante === null) === true) {
                    $tipocomprobante = $actualCliente->tipocomprobante;
                }

                $ncfRangoToUse = $ncfrango->getByTipoComprobante($actualCliente->idempresa, $tipocomprobante);
                if (!$ncfRangoToUse) {
                    $this->toolBox()->i18nLog()->error("no-ncf-range-for-$tipocomprobante");
                           toolBox()->i18nLog()->error("no-ncf-range-for-$tipocomprobante");
                    return false;
                }
                $ncf = $ncfRangoToUse->generateNCF();
                $this->numeroncf = $ncf;
                $this->ncffechavencimiento = $ncfRangoToUse->fechavencimiento;
                $this->tipocomprobante = $ncfRangoToUse->tipocomprobante;
                $ncfRangoToUse->correlativo++;
                $ncfRangoToUse->save();
                if (($this->tipocomprobante === '03' || $this->tipocomprobante === '04') === true) {
                    $this->ncftipoanulacion = isset($_REQUEST['ncftipoanulacionr'])
                        ? $_REQUEST['ncftipoanulacionr']
                        : $this->ncftipoanulacion;
                    $this->ncffechavencimiento = isset($_REQUEST['ncffechavencimientor'])
                        ? $_REQUEST['ncffechavencimientor']
                        : $this->ncffechavencimiento;
                }
            }
            $this->ncffechavencimiento = ($this->ncffechavencimiento == '') ? null : $this->ncffechavencimiento;

        };
    }

    public function all(): Closure
    {
        return function () {
            $this->facturarectnumero2 = '';
            if ($this->idfacturarect !== '') {

                $facturaRectificativa = $this->get($this->idfacturarect);
                $facturaRectificativa = $this->get($this->idfacturarect);
                $this->loadFromData(['facturarectnumero2' => 'SI' ]);
                       loadFromData(['facturarectnumero2' => 'SI' ]);
                $this->facturarectnumero2 = $facturaRectificativa->numero2;
            } else {
                $this->loadFromData(['facturarectnumero2' => 'NO HAY']);
            }
            return $this;
        };
    }
}


joenilson / fsRepublicaDominicana

Push — master ( b8d623...b21d4a )

FacturaCliente::saveBefore() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like