Passed
Push — master ( d29869...e61a0d )
by Joe Nilson
03:35
created

FacturaProveedor   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 56
Duplicated Lines 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
eloc 31
dl 0
loc 56
rs 10
c 1
b 0
f 0
wmc 6

1 Method

Rating   Name   Duplication   Size   Complexity  
B saveBefore() 0 28 6
1
<?php
2
/*
3
 * Copyright (C) 2021 Joe Nilson <[email protected]>
4
 *
5
 * This program is free software: you can redistribute it and/or modify
6
 * it under the terms of the GNU Lesser General Public License as
7
 * published by the Free Software Foundation, either version 3 of the
8
 * License, or (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
 * GNU Lesser General Public License for more details.
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
16
 */
17
18
namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;
19
20
use Closure;
21
use FacturaScripts\Dinamic\Model\NCFRango;
0 ignored issues
show
Bug introduced by
The type FacturaScripts\Dinamic\Model\NCFRango was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
22
use FacturaScripts\Dinamic\Model\NCFTipoMovimiento;
0 ignored issues
show
Bug introduced by
The type FacturaScripts\Dinamic\Model\NCFTipoMovimiento was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
23
use FacturaScripts\Dinamic\Model\Proveedor;
0 ignored issues
show
Bug introduced by
The type FacturaScripts\Dinamic\Model\Proveedor was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
Bug introduced by
This use statement conflicts with another class in this namespace, FacturaScripts\Plugins\f...tension\Model\Proveedor. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
24
use FacturaScripts\Core\App\AppSettings;
0 ignored issues
show
Bug introduced by
The type FacturaScripts\Core\App\AppSettings was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
25
26
class FacturaProveedor
27
{
28
    /**
29
     * @var date
0 ignored issues
show
Bug introduced by
The type FacturaScripts\Plugins\f...na\Extension\Model\date was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
30
     */
31
    public $ncffechavencimiento;
32
    /**
33
     * @var string
34
     */
35
    public $tipocomprobante;
36
    /**
37
     * @var string
38
     */
39
    public $ncftipopago;
40
    /**
41
     * @var string
42
     */
43
    public $ncftipomovimiento;
44
    /**
45
     * @var string
46
     */
47
    public $ncftipoanulacion;
48
49
    /**
50
     * @var string
51
     */
52
    public $numeroncf;
53
54
    public function saveBefore(): Closure
55
    {
56
        return function () {
57
            $ArrayTipoNCFCompras = ['11', '12', '16', '17'];
58
            $ncfrango = new NCFRango();
59
            $cliente = new Proveedor();
60
            $appSettings = new AppSettings;
61
            $actualProveedor = $cliente->get($this->codproveedor);
0 ignored issues
show
Bug Best Practice introduced by
The property codproveedor does not exist on FacturaScripts\Plugins\f...\Model\FacturaProveedor. Did you maybe forget to declare it?
Loading history...
62
            $actualProveedor->idempresa = $appSettings::get('default', 'idempresa');
63
            $this->tipocomprobante = $_REQUEST['tipocomprobanter'] ?? $this->tipocomprobante;
64
            $this->numeroncf = $_REQUEST['numeroncfr'] ?? $this->numeroncf;
65
            $tipocomprobante = $this->tipocomprobante;
66
            if ($tipocomprobante !== null && in_array($tipocomprobante, $ArrayTipoNCFCompras, true)) {
67
                $ncfRangoToUse = $ncfrango->getByTipoComprobante($actualProveedor->idempresa, $tipocomprobante);
68
                if (!$ncfRangoToUse) {
69
                    $this->toolBox()->i18nLog()->error("no-ncf-range-for-$tipocomprobante");
0 ignored issues
show
Bug introduced by
The method toolBox() does not exist on FacturaScripts\Plugins\f...\Model\FacturaProveedor. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

69
                    $this->/** @scrutinizer ignore-call */ 
70
                           toolBox()->i18nLog()->error("no-ncf-range-for-$tipocomprobante");

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
70
                    return false;
71
                }
72
                $ncf = $ncfRangoToUse->generateNCF();
73
                $this->numeroncf = $ncf;
74
                $this->ncffechavencimiento = $ncfRangoToUse->fechavencimiento;
75
                $this->tipocomprobante = $ncfRangoToUse->tipocomprobante;
76
                $ncfRangoToUse->correlativo++;
77
                $ncfRangoToUse->save();
78
            }
79
            if (($this->tipocomprobante === '03' || $this->tipocomprobante === '04') === true) {
80
                $this->ncftipoanulacion = $_REQUEST['ncftipoanulacionr'];
81
                $this->ncffechavencimiento = $_REQUEST['ncffechavencimientor'];
82
            }
83
        };
84
    }
85
}